summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move creation of 'open with' registry keys to installer. We should place ↵kuchhal@chromium.org2008-11-196-101/+36
| | | | | | | | | | nice and not create these keys on every Chrome start just in case user wants a customized open with list. So now we only create these keys at installation or when user choses to make Chrome default browser. Also we clean them up on uninstall. BUG=1190855 Review URL: http://codereview.chromium.org/11491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5726 0039d316-1c4b-4281-b951-d872f2087c98
* Port directory lister so test shell can view file directories.estade@chromium.org2008-11-1912-132/+182
| | | | | | Review URL: http://codereview.chromium.org/11437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5725 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when showing modal dialog from context menu. With thissky@google.com2008-11-195-43/+124
| | | | | | | | | | | | | | | | | | | | | sequence ContainerWin remains on the stack while the modal dialog is showing. Prior to this fix we would delete the ContainerWin, so that when the modal dialog closed control would return to a deleted object. The fix is to effectively delay deleting of the ConatinerWins used by menus. BUG=4580 TEST=This is the sequence that triggered the crash: open a folder on the bookmark bar, right child on a child folder that has more than 15 descendant URLs, click open all, a dialog should appear asking if you really want to open all, click cancel and make sure it doesn't crash. This is a subtle change to bookmark menus though, would be good to thoroughly exercise the menus in as many permutations as you can think of. Review URL: http://codereview.chromium.org/11289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this change: http://codereview.chromium.org/10967/showben@chromium.org2008-11-1919-71/+44
| | | | | | | | | Now with two improvements: - no longer create WebContentsViews as WS_VISIBLE, to prevent them from showing up in the taskbar - make sure overridden CreateView in NativeUIContents and StatusView have the correct signature. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5723 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup work I did while adding more Safari builders. It got to bempcomplete@chromium.org2008-11-195-54/+100
| | | | | | | | | | | | | | | extensive so I decided to just check it in. Changes: - Use Return() instead of Export() from SConscript.inputs to pass 'env' back. - Move some of the build vars around to fix builders that aren't in SConscript.browser. - Refactor SConscript.installers so that we now have DirBuilder, a generic builder that creates a directory tree (used to be FF-specific). This will be used for OSX bundles. Review URL: http://codereview.chromium.org/11261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5722 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux use the Windows tests lists for now.deanm@chromium.org2008-11-192-2/+1332
| | | | | | | | This means we can stop debugging failed tests that also fail on Windows. Review URL: http://codereview.chromium.org/11500 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5720 0039d316-1c4b-4281-b951-d872f2087c98
* sort chrome.sln. no functional changes, I just rantc@google.com2008-11-191-1713/+1713
| | | | | | | | | | the sort_sln.py script. TBR=brettw Review URL: http://codereview.chromium.org/11291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5719 0039d316-1c4b-4281-b951-d872f2087c98
* Make http_server.sh mutli-platform.mmoss@google.com2008-11-191-5/+15
| | | | | | | Review URL: http://codereview.chromium.org/11498 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5718 0039d316-1c4b-4281-b951-d872f2087c98
* Use the Ahem font for layout tests.evanm@google.com2008-11-191-17/+34
| | | | | | | Review URL: http://codereview.chromium.org/11499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5717 0039d316-1c4b-4281-b951-d872f2087c98
* Use /bin/cat for .asis files, this should make it work on both cygwin and ↵deanm@chromium.org2008-11-191-1/+1
| | | | | | | | Linux (and mac?). Review URL: http://codereview.chromium.org/11287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5716 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to pick up mac font metrics fix in r5714amanda@chromium.org2008-11-191-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5715 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply http://codereview.chromium.org/11225agl@chromium.org2008-11-192-3/+6
| | | | | | | | | This was lost by Brett's move this morning. Review URL: http://codereview.chromium.org/11605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5713 0039d316-1c4b-4281-b951-d872f2087c98
* Add url_request_unittest to mac build.ericroman@google.com2008-11-194-37/+57
| | | | | | Review URL: http://codereview.chromium.org/11224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5712 0039d316-1c4b-4281-b951-d872f2087c98
* Linux layout test fixagl@chromium.org2008-11-191-1/+1
| | | | | | | | | | | Append doesn't mutate so take the result of it. TBR=evan Review URL: http://codereview.chromium.org/11493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5711 0039d316-1c4b-4281-b951-d872f2087c98
* Support manual HTTP server "start/stop" on Linux.mmoss@google.com2008-11-192-4/+14
| | | | | | | | | | This makes the Layout Tests instructions work on Linux: http://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-tests Review URL: http://codereview.chromium.org/11490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5710 0039d316-1c4b-4281-b951-d872f2087c98
* Remove chrome\browser\frame_util.cc from the SCons build.sgk@google.com2008-11-191-1/+0
| | | | | | Review URL: http://codereview.chromium.org/11485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5709 0039d316-1c4b-4281-b951-d872f2087c98
* fix losing focus on arrow keys and tabtc@google.com2008-11-191-0/+10
| | | | | | | Review URL: http://codereview.chromium.org/11488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5707 0039d316-1c4b-4281-b951-d872f2087c98
* Committing on behalf of knorton@google.comjam@chromium.org2008-11-191-1/+1
| | | | | | | | | | | Fixes a threading issue in PluginInstance. PluginThreadAsyncCall is supposed to provide a thread safe way of enqueing a callback onto the plugin thread. Currently, it unsafely adds a reference to the PluginInstance when the callback is enqueued. This patch converts PluginInstance from RefCounted to RefCountedThreadSafe. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5706 0039d316-1c4b-4281-b951-d872f2087c98
* Send the chrome.dll base address in the UMA initial log. This will help us ↵deanm@chromium.org2008-11-191-0/+9
| | | | | | | | detect address space collisions where chrome.dll is needing to be rebased, and it will help us choose a better base address. Review URL: http://codereview.chromium.org/6540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5705 0039d316-1c4b-4281-b951-d872f2087c98
* Match Windows font metrics on Linux.agl@chromium.org2008-11-195-18/+98
| | | | | | | | | | | | | | | | | With this change, many layout tests involving text match render trees exactly. By turning off anti-aliasing we also almost match pixel exact. There are a couple of single-pixel differences between Win32 font rendering and FreeType however (see the bottom left pixel of an 'a' glyph for example), so we aren't quite pixel-for-pixel yet. Mike Reed expects to redo much of the font configuration code in Skia to cope with complex text and subpixel text so, for now, I'm not going to have anti-aliasing be a command line flag etc. Review URL: http://codereview.chromium.org/11284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5704 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the text on the toolbar.evanm@google.com2008-11-191-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/11477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5703 0039d316-1c4b-4281-b951-d872f2087c98
* Fallback to Windows expected results for Linux layout testsagl@chromium.org2008-11-194-0/+23
| | | | | | | | | | Otherwise we fall back to Mac results, which aren't what we are going to be aiming for. Review URL: http://codereview.chromium.org/11254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5702 0039d316-1c4b-4281-b951-d872f2087c98
* fix unitteststc@google.com2008-11-192-4/+5
| | | | | | | | | We need to trim whitespace off the URL and handle the tricky html case by using rfind. Review URL: http://codereview.chromium.org/11465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5701 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce httponly on cookies coming from the renderer. This prevents ↵deanm@chromium.org2008-11-195-37/+134
| | | | | | | | | javascript from setting a new httponly cookie, and more importantly from overwriting httponly cookies. Patch from Marius Schilder. Review URL: http://codereview.chromium.org/11275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5700 0039d316-1c4b-4281-b951-d872f2087c98
* Only have one constant for timeout time.erg@google.com2008-11-195-9/+10
| | | | | | | Review URL: http://codereview.chromium.org/11257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5698 0039d316-1c4b-4281-b951-d872f2087c98
* More Linux build fixes.agl@chromium.org2008-11-192-9/+44
| | | | | | | | | | Add the bitmap platform device file to the scons and revert a reversion introduced in the move. Review URL: http://codereview.chromium.org/11484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5697 0039d316-1c4b-4281-b951-d872f2087c98
* Remove platformCanvas_unittest from Liunx build since it doesn't compile ↵brettw@google.com2008-11-191-1/+3
| | | | | | | | properly. Review URL: http://codereview.chromium.org/11283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5695 0039d316-1c4b-4281-b951-d872f2087c98
* Mac changes for r5690mark@chromium.org2008-11-191-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5694 0039d316-1c4b-4281-b951-d872f2087c98
* Mac changes for r5690mark@chromium.org2008-11-194-26/+52
| | | | | | Review URL: http://codereview.chromium.org/11483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5693 0039d316-1c4b-4281-b951-d872f2087c98
* Minor Linux build fixupsagl@chromium.org2008-11-193-4/+4
| | | | | | | | | TBR=brett Review URL: http://codereview.chromium.org/11281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5692 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo for Linux build.brettw@google.com2008-11-191-1/+1
| | | | | | Review URL: http://codereview.chromium.org/11482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5691 0039d316-1c4b-4281-b951-d872f2087c98
* Move PlatformCanvas and PlatformDevice from base/gfx to webkit/port. I left ↵brettw@google.com2008-11-1951-3046/+3242
| | | | | | | | | | header files in the original locations that include the ones in the new location so I don't have to change all the includes in Chrome at once. These will be removed later. I kept the names, indenting, and the namespaces the same for now. I will also be cleaning this up in separate passes. Review URL: http://codereview.chromium.org/11244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5690 0039d316-1c4b-4281-b951-d872f2087c98
* Normalise layout test line endings to use UNIX style.agl@chromium.org2008-11-191-1/+1
| | | | | | | | | | | | | On Linux, the diffs against the Windows baselines fail if the baseline has \r\n line endings. The output from the test shell already appears to be normalised to \n endings, so it's not clear to me how Windows diff works in this case unless the Windows tools are automatically detecting and fixing the line endings. Review URL: http://codereview.chromium.org/11280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5689 0039d316-1c4b-4281-b951-d872f2087c98
* delete more unused codepinkerton@google.com2008-11-191-624/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5688 0039d316-1c4b-4281-b951-d872f2087c98
* Checkin of unmodified version of Mach IPC utility class.jeremy@chromium.org2008-11-192-0/+544
| | | | | | | | | This is the same version of the class present in the Gears tree, modifications are only the file & header guard names and the license. Review URL: http://codereview.chromium.org/11278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5687 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting for developer0420@gmail.comjoshia@google.com2008-11-192-7/+53
| | | | | | | | | | | | | | | | | | | | | The LPITEMIDLIST returned from SHBrowseForFolder might not get released if SHGetPathFromIDList fails Added in the comment changes Added GetDisplayNameOf for getting selection, using old way if STRRET Structure type does not equal STRRET_WSTR as I was unable to get complete code coverage. Added BrowseCallbackProc and listen to MSG so that we can highlight existing value Added in the comment changes ( changed to smart pointer for managing COM interface pointers.) Review URL: http://codereview.chromium.org/11481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5686 0039d316-1c4b-4281-b951-d872f2087c98
* Update expected results for LayoutTests/plugins/plugin-javascript-access.htmldarin@chromium.org2008-11-192-1/+19
| | | | | | | | | | The test was apparently expanded to test more features. Sadly we have to fork the expected results here to account for a difference in the plugin's filename. R=pamg Review URL: http://codereview.chromium.org/11266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5685 0039d316-1c4b-4281-b951-d872f2087c98
* Re-baseline hindi-spacing, using correct font settings this time.pamg@google.com2008-11-192-1/+1
| | | | | | | | | | TBR=ojan BUG=4391 TEST=covered by layout tests Review URL: http://codereview.chromium.org/11480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5684 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup TemporaryLinkStubs.cpp.darin@chromium.org2008-11-191-35/+39
| | | | | | | | R=ojan Review URL: http://codereview.chromium.org/11267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5683 0039d316-1c4b-4281-b951-d872f2087c98
* Remove nonexistent pending/ tests from tests_fixable, and leftover resultspamg@google.com2008-11-1950-841/+424
| | | | | | | | | | | | | from pending/ and chromium-win/pending/. Re-baseline tests that moved from pending/ to LayoutTests/. BUG=4391 TEST=covered by layout tests Review URL: http://codereview.chromium.org/11241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5682 0039d316-1c4b-4281-b951-d872f2087c98
* remove unused filepinkerton@google.com2008-11-191-264/+0
| | | | | | Review URL: http://codereview.chromium.org/11476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5681 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build.evanm@google.com2008-11-191-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5680 0039d316-1c4b-4281-b951-d872f2087c98
* Move more code to using FilePath.evanm@google.com2008-11-197-38/+42
| | | | | | | Review URL: http://codereview.chromium.org/11252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5679 0039d316-1c4b-4281-b951-d872f2087c98
* add chromium-mac expectations, they were missing previously.pinkerton@google.com2008-11-1921-0/+697
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5678 0039d316-1c4b-4281-b951-d872f2087c98
* More tweaks to fixable tests to get expected failures to zarro.pinkerton@google.com2008-11-191-27/+8
| | | | | | Review URL: http://codereview.chromium.org/11274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5677 0039d316-1c4b-4281-b951-d872f2087c98
* Don't build with exception support, we don't use exceptions.deanm@chromium.org2008-11-191-1/+1
| | | | | | | | This makes the output executable substantially smaller because it won't emit .eh_frame and .eh_frame_hdr header sections. These were previously ~1.2mb for an opt test_shell. Review URL: http://codereview.chromium.org/11265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5675 0039d316-1c4b-4281-b951-d872f2087c98
* Change by Alex Mendes da Costa <alexmdac@google.com>beng@google.com2008-11-193-4/+28
| | | | | | | | | | | | Use the most recently used download path when displaying a "save as" dialog. Reset the download path when the user clears the download history. BUG=293 (http://code.google.com/p/chromium/issues/detail?id=293) Review URL: http://codereview.chromium.org/10743 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5674 0039d316-1c4b-4281-b951-d872f2087c98
* Implement window closing.deanm@chromium.org2008-11-191-5/+5
| | | | | | Review URL: http://codereview.chromium.org/11263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5673 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GetRootWindowRect, for example, window.screenX.deanm@chromium.org2008-11-191-3/+13
| | | | | | Review URL: http://codereview.chromium.org/11262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5672 0039d316-1c4b-4281-b951-d872f2087c98
* Land this change again now I've fixed the crash.ben@chromium.org2008-11-1935-268/+196
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5669 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 12:33:33 +0000