summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix bug when accessing g_browser_process->broker_services() at shutdown.jam@chromium.org2009-11-236-22/+38
| | | | | | | BUG=28501 Review URL: http://codereview.chromium.org/435001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix recognizing FTP listings consisting of only one line.phajdan.jr@chromium.org2009-11-238-1/+66
| | | | | | | | | | | | | | It turns out we have to be a little more strict with that. Before this change both ls and VMS listing parsers would claim that they recognize the format. Also fallback to Mozilla code was broken in that case. TEST=Covered by net_unittests. BUG=28263 Review URL: http://codereview.chromium.org/421006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32831 0039d316-1c4b-4281-b951-d872f2087c98
* Roll GTM dep.thakis@chromium.org2009-11-231-1/+1
| | | | | | | | | | | Roll GTM dep to pick up http://code.google.com/p/google-toolbox-for-mac/source/detail?r=259 . BUG=28478 TEST=Install theme with light text on dark background; should look ok (see bug). Review URL: http://codereview.chromium.org/436005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32830 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing GCC 4.4 build fix (landing a patch for hbono)ian@chromium.org2009-11-231-1/+1
| | | | | | | | | | | | | | This patch was written by hbono, landing for him as he can't land this until tomorrow, and it's a patch to fix a build. Reviewed at http://codereview.chromium.org/414025 BUG=none TEST=GCC 4.4 compiles Review URL: http://codereview.chromium.org/436003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32829 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Set initial size for js alert.estade@chromium.org2009-11-232-0/+17
| | | | | | | | BUG=28058 Review URL: http://codereview.chromium.org/426008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32828 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't dereference stale ConstrainedWindow pointer.estade@chromium.org2009-11-231-2/+4
| | | | | | | | BUG=28587 Review URL: http://codereview.chromium.org/436004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32827 0039d316-1c4b-4281-b951-d872f2087c98
* Default browser checking on start-up was broken.jcampan@chromium.org2009-11-231-1/+3
| | | | | | | | | | | | ShellIntegration::IsDefaultBrowser() had been changed to return an enum instead of a bool. But the code in browser_init.cc calling it has not been updated. BUG=28429 TEST=Test that the default browser infobar is shown when Chrome is started and not the default browser. Review URL: http://codereview.chromium.org/426009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32825 0039d316-1c4b-4281-b951-d872f2087c98
* Adding some missing accelerators to Linux toolkit views.jcampan@chromium.org2009-11-231-1/+10
| | | | | | | | BUG=28416 TEST=Tests all the accelerators found in chrome/browser/views/accelerator_table_gtk.cc work and are consistent Chrome on Windows. Review URL: http://codereview.chromium.org/426006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32824 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one source of flakiness of FTP tests.phajdan.jr@chromium.org2009-11-233-2/+34
| | | | | | | | | | | | It turns out that similarly to RETR case, we can get two responses for LIST command, if the transfer finishes quickly enough. TEST=net_unittests BUG=25045 Review URL: http://codereview.chromium.org/436002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32823 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress reports under thread-safe gethostbyname2_r functiontimurrrr@chromium.org2009-11-231-0/+11
| | | | | | | | | | | Sample reports: http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20Tests%20(tsan%20ui)/builds/208/steps/valgrind%20test%3A%20ui_6/logs/stdio TEST=TSAN UI bot should become greener BUG=https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/59449 Review URL: http://codereview.chromium.org/435005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32822 0039d316-1c4b-4281-b951-d872f2087c98
* Notify race detectors (e.g. ThreadSanitizer) about the thread namestimurrrr@chromium.org2009-11-231-0/+2
| | | | | | | | | ThreadSanitizer will print the name of the threads in data race reports. ANNOTATE_THREAD_NAME is a no-op in Release non-valgrind build Review URL: http://codereview.chromium.org/434009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32821 0039d316-1c4b-4281-b951-d872f2087c98
* Add locale as a parameter to the extension link.mirandac@chromium.org2009-11-231-4/+5
| | | | | | | | | BUG= 28433 TEST= click on puzzle piece and promo line "extension" links; chrome UI language should be included as a parameter in the link. Review URL: http://codereview.chromium.org/434002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32820 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the position of the frame background image for ChromeOS to match gtk ↵oshima@chromium.org2009-11-231-3/+17
| | | | | | | | | | | | | | build. Gtk build is using non custom frame mode, which renders the frmae pixels 15 pixels above. I'll remove this hack once we migrate to views. BUG=28580 TEST=None Review URL: http://codereview.chromium.org/434011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32818 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "installer: clean up to use FilePath instead of std::wstring."kuchhal@chromium.org2009-11-2329-360/+395
| | | | | | | | | | | This reverts commit 9da05365beb211e3879e6049547e5e92c4c0a5a2 (r32811). TBR=thiago.farina@gmail.com BUG=32811 Review URL: http://codereview.chromium.org/437011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32817 0039d316-1c4b-4281-b951-d872f2087c98
* Some small comment fixes for HostResolver and DnsMaster.eroman@chromium.org2009-11-232-3/+4
| | | | | | | | | | | Original patch by cbentzel@google.com (see http://codereview.chromium.org/437005) r=me BUG=NONE Review URL: http://codereview.chromium.org/437009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32816 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at moving NTP CSS resources into the NTP resource cache.tony@chromium.org2009-11-2311-269/+301
| | | | | | | | | | | | | | | | | | Moving the HTML to the cache saved 8ms on New Tab Warm on Windows, maybe we can shave a few more ms off by moving the CSS. The last change had a regression on the mac new tab perf, so I suspect it's the extra round trip to the UI thread when trying to load the CSS (the UI thread is probably just busy at that time). Instead, I'm moving the generation of the CSS to the time the object is constructed, rather than when the resource is requested. This is like the code before, except sometimes we'll hit the cache. BUG=26228 Review URL: http://codereview.chromium.org/427003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32815 0039d316-1c4b-4281-b951-d872f2087c98
* Improve unit test robustness.mrossetti@chromium.org2009-11-231-1/+1
| | | | | | | | | BUG=28405 TEST=none Review URL: http://codereview.chromium.org/425007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32814 0039d316-1c4b-4281-b951-d872f2087c98
* Test continues to be flaky, but it's getting run anyway so mark it DISABLED ↵tim@chromium.org2009-11-231-6/+3
| | | | | | | | | | | to keep things green. TBR=levin BUG=28445 Review URL: http://codereview.chromium.org/437008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32813 0039d316-1c4b-4281-b951-d872f2087c98
* installer: clean up to use FilePath instead of std::wstring.kuchhal@chromium.org2009-11-2329-395/+360
| | | | | | | | | | BUG=24672 TEST=installer_util_unittests and setup_unittests Review URL: http://codereview.chromium.org/385129 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32811 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusts font sizes to be readable on Chrome OS.sky@chromium.org2009-11-232-9/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32810 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make the start up tests less flaky by switchingtony@chromium.org2009-11-231-4/+6
| | | | | | | | | | | from ApplyAccelerator (which uses RunCommandAsync) to using RunCommand. This shouldn't impact the timing any. BUG=28448 Review URL: http://codereview.chromium.org/427005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32809 0039d316-1c4b-4281-b951-d872f2087c98
* Call FNNotify on download complete; this should help apps watching the ↵avi@google.com2009-11-231-1/+8
| | | | | | | | | | | | downloads folder. BUG=none TEST=If Transmission is watching the Downloads folder, it should catch a completed download immediately. Review URL: http://codereview.chromium.org/437006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32808 0039d316-1c4b-4281-b951-d872f2087c98
* The async notification via OnReadComplete was still postingmbelshe@google.com2009-11-232-3/+9
| | | | | | | | | | | | | | | | | a callback through this message loop. This makes it difficult to write tests, as callbacks already scheduled will go in front of the OnReadComplete(). Treat the notifications through OnReadComplete as synchronous always. This doesn't effect existing tests, but makes my new tests possible. BUG=none TEST=this is the test! Review URL: http://codereview.chromium.org/414073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32807 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression expected leak in ProxyConfigServiceLinux.oshima@chromium.org2009-11-231-0/+11
| | | | | | | | | BUG=None TEST=OminiboxTest (and a couple of others) were reporting this in valgrind test. They should be gone with this patch. Review URL: http://codereview.chromium.org/414067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32805 0039d316-1c4b-4281-b951-d872f2087c98
* Allow reentrant tasks on window close in in-proc browser test framework. ↵kkania@chromium.org2009-11-232-0/+23
| | | | | | | | | | Disable tests that are failing on Mac. BUG=none TEST=none Review URL: http://codereview.chromium.org/425013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32804 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add UMA entry for inspect element action.pfeldman@chromium.org2009-11-232-2/+3
| | | | | | | | BUG=28563 Review URL: http://codereview.chromium.org/431009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32803 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more suppression for SafeBrowsing database for ThreadSanitizertimurrrr@chromium.org2009-11-231-1/+8
| | | | | | | | BUG=28559 TBR=dank Review URL: http://codereview.chromium.org/434007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32800 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress ThreadSanitizer reports in SafeBrowsingtimurrrr@chromium.org2009-11-231-0/+6
| | | | | | | | | BUG=28559 TBR=dank TEST=TSAN UI bot should become greener Review URL: http://codereview.chromium.org/437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32799 0039d316-1c4b-4281-b951-d872f2087c98
* Docs polish:aa@chromium.org2009-11-2343-1292/+1112
| | | | | | | | | | | | | | | | | * Fixed header alignment and spacing * Fixed top nav, removed useless/dead links, added sample link instead * Fixup requirements in samples and getting started page (beta no workie yet, mac and linux do -- at least enough to not be worth mentioning) * Make vertical separator bar green * Make default_icon required for page and browser actions * Fix incorrect description of how onclick works wrt isolated worlds * Make the page titles be <page title> - Google Chrome Extensions - Google Code * Add a warning about NPAPI BUG=28152,27875,28155,28182,27864,27432 Review URL: http://codereview.chromium.org/437001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32798 0039d316-1c4b-4281-b951-d872f2087c98
* Missed one more mac suppression.willchan@chromium.org2009-11-231-0/+24
| | | | | | | | BUG=28943 Review URL: http://codereview.chromium.org/429008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32797 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix toolbar sizing bug upon unloading extension/theme.viettrungluu@chromium.org2009-11-221-0/+7
| | | | | | | | | BUG=28476 TEST=Install any theme (e.g., "Classic"); click "undo" in infobar; toolbar layout shouldn't change (and the toolbar's contents should be sized correctly). Review URL: http://codereview.chromium.org/418048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32792 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Get rid of status bubble flicker.derat@chromium.org2009-11-222-2/+20
| | | | | | | | | | | | | | | | | | | | | The bubble was appearing in its default location when getting shown while the mouse was nearby; it would move to the correct location on the next motion event. I think that there's still a flicker in the wrong location when closing the download bar and then triggering the bubble, but the fix is non-obvious to me. It's possible that it's not noticeable on anything faster than the slow DSL line that I'm using to run Chrome remotely to test this. BUG=28494 TEST=repeated steps from bug and checked that download bar behavior doesn't appear to have regressed either Review URL: http://codereview.chromium.org/431007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32789 0039d316-1c4b-4281-b951-d872f2087c98
* Flip: last mac suppresion.willchan@chromium.org2009-11-221-0/+17
| | | | | | | | BUG=28493 Review URL: http://codereview.chromium.org/431006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32782 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: minor cleanup of constants in toolbar_controller.mm.viettrungluu@chromium.org2009-11-221-12/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/418049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32779 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 255.0 to 256.0chrome-bot@google.com2009-11-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32773 0039d316-1c4b-4281-b951-d872f2087c98
* build fix: missing includeevan@chromium.org2009-11-221-0/+1
| | | | | | Not exactly sure why this was compiling for some people before. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32772 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress mac flip leaks too.willchan@chromium.org2009-11-221-0/+53
| | | | | | | | BUG=28493 Review URL: http://codereview.chromium.org/431005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32771 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change that disallowed content scripts access toaa@chromium.org2009-11-2225-188/+188
| | | | | | | | | | | | | | | | | | file:// URLs. It turns out teams were already depending on this and we didn't want to break them. Instead, group file:// access with NPAPI in the extension install prompt. Note: this is a pure revert of r402029 and r402069 (sorry Finnur!) except the changes in extension_install_ui.cc, which are new. BUG=28456 Review URL: http://codereview.chromium.org/430003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32770 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress valgrind errors for flip leaks.willchan@chromium.org2009-11-221-0/+53
| | | | | | Review URL: http://codereview.chromium.org/418050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32769 0039d316-1c4b-4281-b951-d872f2087c98
* Put the --type switch back as the first for renderers, for easy identification.mdm@chromium.org2009-11-221-6/+6
| | | | | | | | | BUG=28421 TEST=run ps auxw, see that --type is the first switch to renderer processes Review URL: http://codereview.chromium.org/414071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32766 0039d316-1c4b-4281-b951-d872f2087c98
* Flip: Merge FlipStreamParser and FlipStream. Eliminate FlipDelegate.willchan@chromium.org2009-11-2212-834/+826
| | | | | | | | | | | | | | FlipStream now conceptually contains everything associated with a single Flip stream. This primarily consists of 2 things: (1) FlipStream as a consumer of network events from FlipSession (2) FlipStream as a network provider to consumers (such as FlipNetworkTransaction). Conceptually, FlipStream also should be agnostic of wire level protocol framing details, only dealing with HTTP style headers and responses. Anything wire level has been moved out of FlipStream into FlipSession. FlipStream is now reference counted since it is referenced by both the FlipSession and the consumer (only FlipNetworkTransaction currently). FlipNetworkTransaction can be cancelled prior to all network events finishing up, therefore the code needs to handle this gracefully. FlipStream supports a Cancel() function for this reason. FlipStream now communicates with consumers via CompletionCallbacks rather than using FlipDelegates. Review URL: http://codereview.chromium.org/410006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32765 0039d316-1c4b-4281-b951-d872f2087c98
* Add some diagnostics for dumping the headers that the clientmbelshe@google.com2009-11-211-0/+30
| | | | | | | | | | | sends to the server so that others can more easily debug. BUG=none TEST=none Review URL: http://codereview.chromium.org/414078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32764 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a test case for a basic server-push operation.mbelshe@google.com2009-11-211-0/+180
| | | | | | | | | BUG=none TEST=flip_network_transaction_unittest.cc Review URL: http://codereview.chromium.org/414032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32763 0039d316-1c4b-4281-b951-d872f2087c98
* When we had upload data, but it was a zero-length uploadmbelshe@chromium.org2009-11-211-1/+1
| | | | | | | | | | | | | | data, we would not set the FIN flag, which would stall the request upload. This fixes gmail. TEST=none BUG=none Review URL: http://codereview.chromium.org/414077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32762 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old bookmark sync promo from new tab page. mirandac@chromium.org2009-11-212-10/+1
| | | | | | | | | | | Part 2: to be merged into 249. BUG=28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/414076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32759 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old bookmark sync promo from new tab page. mirandac@chromium.org2009-11-211-6/+0
| | | | | | | | | | | part 1: string fix (not to be merged to 249) BUG=28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/431002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32758 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32754 - Remove old bookmark sync promo from new tab page.mirandac@chromium.org2009-11-213-1/+16
| | | | | | | | | | | | BUG= 28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/420004 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/414075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old bookmark sync promo from new tab page.mirandac@chromium.org2009-11-213-16/+1
| | | | | | | | | BUG= 28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/420004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32754 0039d316-1c4b-4281-b951-d872f2087c98
* testjam@chromium.org2009-11-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/430005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32751 0039d316-1c4b-4281-b951-d872f2087c98
* Launch all child processes asynchronously so as not to block the IO thread.jam@chromium.org2009-11-2117-387/+430
| | | | | | | BUG=6844, 27935 Review URL: http://codereview.chromium.org/402097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32750 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 01:59:06 +0000