| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
their own flags. Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise.--enable-local-storage and --enable-session-storage are the new flags. If you enable them and try to use DOM Storage, Chromium will crash.Originally Committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=21059 but then backed out due to include path issues.BUG=4360TEST=none
Review URL: http://codereview.chromium.org/159059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=NONE
BUG=NONE
TBR=paul
Review URL: http://codereview.chromium.org/155832
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17287
TEST=none
Review URL: http://codereview.chromium.org/159123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=scherkus
Review URL: http://codereview.chromium.org/159122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LinuxCertManagement
BUG=11507
Review URL: http://codereview.chromium.org/159115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
merge (is a new test).
Review URL: http://codereview.chromium.org/155833
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
startup latency.
This version handles 'free' atoms, which are produced by mp4box and other tools, but impact ffmpeg seeks on playback.
The code follows ffmpeg coding standards.
BUG=17304
TEST=instrument seeks or measure latency performance and play videos with and without qt-faststart applied to the data.
Review URL: http://codereview.chromium.org/149439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
differences in 2d sample.
Increasing the pixel diff threshold for texturesamplers and zsorting to its previous glory until we figure
out what the proper values are. Bumping up DEPS for assets to pick up new reference image for zsorting sample.
Review URL: http://codereview.chromium.org/159120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15864
Review URL: http://codereview.chromium.org/159119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TBR=paul
TEST=NONE
Review URL: http://codereview.chromium.org/159110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
pango detects strong RTL characters in the layout, it switches the text direction. For our uses of DrawStringInt, we've already handled the layout and don't want the direction switched. This matches the behavior of Windows.
BUG=16970
TEST=Open a browser in a RTL language. Navigate to google.com and notice that the tab title is right-aligned. Open up the history page and notice that the title (in Hebrew) is right-aligned as well.
Review URL: http://codereview.chromium.org/155829
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for development Chromium builds, to avoid conflicting with packaged Chromium.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that windows draws the tabstrip with a 1 pixel overlap on the toolbar, which we don't do. Instead (for now at least), just don't draw the bottom pixel of the tab. This makes the tabs 1 pixel shorter (matching windows).
BUG=13884
TEST=none
Review URL: http://codereview.chromium.org/155804
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16887
TEST=paste from intellij into chrome render view
Review URL: http://codereview.chromium.org/159107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't close info bubbles when they lose focus because then we can't use the select dropdown in the bookmark bubble. Thus we have to watch the active window. Since we are doing this, we no longer need the application level grab or the button press handler.
This also fixes the problem that a browser window showing an info bubble will paint inactive (assuming your WM supports active/inactive windows).
This maintains the desirable properties:
- info bubbles close when you click outside them but inside the parent window
- info bubbles close when the parent window closes
- info bubbles don't show up on alternate desktops (even if your WM doesn't support active/inactive windows)
- info bubbles can survive losing focus to a popup window
This breaks the desirable properties:
- clicking on something in the browser while the info bubble is showing both dismisses the info bubble and does the appropriate action in the browser
- the info bubble dismisses when the browser loses focus in a window manager that doesn't support active/inactive state
- on xmonad, if you have the cursor over the browser window but the focus is on the info bubble (this is hard to do, since focus is supposed to follow the mouse, but not impossible), then it requires two clicks to dismiss the info bubble. But I think that this is a problem with xmonad and is present before this patch as well.
So this is not the best of all possible worlds, but it is an improvement over our current state as well as an improvement over the state before r20977.
BUG=17223
TEST=browser doesn't crash when you open the select dropdown in the bookmark bubble
Review URL: http://codereview.chromium.org/155793
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11599
Review URL: http://codereview.chromium.org/155830
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These problems were caused by me addressing review comment and forgetting to compile before checkin.
Review URL: http://codereview.chromium.org/159114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17283
TRY=play multichannel audio (ie trek6.mp4) in media player and a crash occurs. This fix avoids the crash.
Review URL: http://codereview.chromium.org/159099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155826
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155797
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When there is no existing browser, this code will crash. It only works
because of the Linux splash screen.
Original review=http://codereview.chromium.org/155795
R=agl
TEST=none
Review URL: http://codereview.chromium.org/155822
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser.
BUG=17219
TEST=run chrome from a terminal in KDE and use the "set as default browser" feature when ~/.kde/share/config/profilerc is owned by root; chrome should not freeze
Review URL: http://codereview.chromium.org/155796
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
centers all of the buttons.
Also adds the ok/cancel buttons to the xib file. Infobars that do not
need the buttons can remove them from the view before displaying.
BUG=http://crbug.com/14462
BUG=http://crbug.com/17195
TEST=Infobars should have yellow background, look less ugly.
Review URL: http://codereview.chromium.org/155788
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This was showing up as a BAD_OVERRIDE in Coverity.
http://crbug.com/18296
Review URL: http://codereview.chromium.org/155810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/11817
TEST=Copy an URL somewhere and break it apart with newlines at random places. Copy/paste it into omnibox and the newlines should be gone. Try this one:
http://dev.chro
mium.org/develo
pers/how-tos/ge
t-the-code
Review URL: http://codereview.chromium.org/159018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switching two includes in common.gypi to msvs_system_include_dirs.
This will force them to the back of the include order (which matches
where the non-hermetic copies of these libraries would be).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/155812
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17129
TEST=Greener Mac valgind unit_test bot.
Review URL: http://codereview.chromium.org/155808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make thinner if possible.
Feelin luv 4 pink.
BUG=http://crbug.com/16942
TEST=2 main parts:
1)
Create bookmarks (click 'Star').
Make sure long titles get trimmed.
Make sure small titles have smaller buttons and text does NOT get trimmed.
Quit and launch with bookmark bar open.
Make sure things are still fine (icons load after bar first assembled).
2)
Quit Chromium.
Rename a LONG button title by editing ~/Library/Application Support/Chromium/Default/Bookmarks.
Relaunch Chromium.
Make sure the button is now smaller but is not "trimmed" (e.g. all the text is there).
Repeat for 5 buttons with different short (5-10 char) titles on each.
Make sure the buttons are smaller and the text is NOT trimmed.
Review URL: http://codereview.chromium.org/155712
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
theme mode.
Review URL: http://codereview.chromium.org/159103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/159102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/155813
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the IO thread be the second thread. The change is needed for plugins on mac.
Review URL: http://codereview.chromium.org/149558
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- forward declare more things
- move bits from header to implementation files to cut includes
- extract bookmark_model_observer.h out of bookmark_model.h to reduce includes
Review URL: http://codereview.chromium.org/159097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17297
TEST=Greener Mac valgrind unit_test bot
Review URL: http://codereview.chromium.org/155806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetWindowTitleForCurrentTab more accurately describes what this function really does.
TEST=none
http://crbug.com/16231
Review URL: http://codereview.chromium.org/155534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-maximized and non-fullscreen bounds. We still keep track of
whether the window is maximized or not, but this allows restoring
a maximized browser to go back to it's previous state.
This also fixes a bug where we would confuse window managers by
setting the initial window size to the full desktop would cause
WMs to disable resize/move.
BUG=16602
Review URL: http://codereview.chromium.org/155802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/17290
TEST=none
Review URL: http://codereview.chromium.org/155798
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://bugs.webkit.org/show_bug.cgi?id=26618, rolled into Chromium as of r21049.
BUG=http://crbug.com/10404,http://crbug.com/10309
TEST=See buildbots run. Run, buildbots, run.
Review URL: http://codereview.chromium.org/159032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=A few things.
Bookmark bar test (16063):
- open bookmark bar, then open popup. Popup should not have bmb.
- close bookmark bar, then open popup. Popup should not have bmb.
- In main window, toggle bmb a few times. Popup should not change.
Tab at bottom bug (16329):
- Open 'details' popup in gmail (next to 'last acct activity')
- make sure no tab strip at the bottom of the window
General (15727):
- Open a popup. Make sure no toolbar (back/fwd buttons et al)
Test: same as listed in
Review URL: http://codereview.chromium.org/155785
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
l10n support.
Cleanup some tabs/indents in chrome.gyp
BUG=16764
TEST=All UI still works
Review URL: http://codereview.chromium.org/155800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12117
TEST=none
Review URL: http://codereview.chromium.org/159085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It appears that this issue has been fixed amoungst the multiple
rewrites that this code has received in the mean time.
BUG=9757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
error if it ever gets out of sync with the plugin version in the future. We can't really update the deb package version automatically because packages ship with a changelog that needs to be updated by a human to describe changes in each new release. Hence it will now be necessary to update the Debian changelog when bumping the plugin version.
Review URL: http://codereview.chromium.org/155728
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149728
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21104 0039d316-1c4b-4281-b951-d872f2087c98
|