| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Widget ----
Now recognizes a supplied NativeWidget via InitParams. If this is specified then a default one is not created.
Is now created directly rather than using a factory. NativeWidget creation is not performed until Init() is called. This means some functions that rely on a NativeWidget must not be called until _AFTER_ Init() (explains some of the function call reordering in this CL, e.g. moving SetOpacity() until after Init()).
ResetLastMouseMovedFlag() moved to this API so that BaseTabStrip can call it in a cross-platform way.
Made last remaining unimplemented methods on Widget pass-thru to NativeWidget implementations.
* WidgetWin/WidgetGtk ----
The NativeWidget implementations now both require a NativeWidgetDelegate implementation upon construction. This is passed through the constructor by the static factory method NativeWidget::CreateNativeWidget and by subclasses such as WindowWin, BubbleWidgetWin, etc.
Some classes that are constructed directly (e.g. LockWindow, in ChromeOS) never have a Widget created for them, so they create the Widget themselves in their base class initializer.
Code in these classes (and their WindowWin/WindowGtk, BrowserFrameWin, BrowserFrameGtk subclasses) must now call GetWidget() etc to call Widget API methods since they are no longer subclasses.
static_casting to this (and derived) types must now be done on the Widget's native_widget().
GetWindow() is renamed to GetContainingWindow() to avoid naming conflicts.
* Window ----
Window is now a subclass of Widget.
Now recognizes a supplied NativeWindow via InitParams. If this is specified then a default one is not created.
Window::CloseWindow becomes an override of Widget::Close.
CloseAllSecondaryWindows() becomes CloseAllSecondaryWidgets() and moves to widget.h
IsAppWindow() is removed and replaced by set_is_secondary_widget on Widget.
* MenuHost ----
Subclasses Widget now.
* TabContentsViewViews ----
It looks like the Gtk-views code here was still using the old implementation of the Native version of this class - i.e. a class that subclassed TabContentsView AND WidgetGtk. A no-no. I had to write NativeTabContentsViewGtk, which is almost identical to NativeTabContentsViewWin with the Gtk bits of TabContentsViewGtk thrown in.
* BrowserFrame ----
Platform-specific functionality is now restricted to BrowserFrameWin/BrowserFrameGtk behind a NativeBrowserFrame interface. Construction is exposed via a static factory method on NativeBrowserFrame.
BrowserFrame becomes a concrete class that now subclasses Window.
As a result, it no longer needs a GetWindow() accessor method, so people with a BrowserFrame* can just call Window methods directly on it.
It is constructed directly, replacing the BrowserFrame::Create() method.
NativeBrowserFrameDelegate is no longer needed.
BrowserFrameChromeos is simpler as a couple of #ifdefs in BrowserFrame, so I got rid of that too.
* AutocompletePopupWin/Gtk ----
No longer required. AutocompletePopupContentsView now just uses a Widget directly.
* There is some lingering ugliness:
- If you set a native_window field on Window::InitParams you must also manually set widget_init_params.native_widget. I will make InitParams do more of this automatically later.
- It'd be nice for the ContentsView to be specified via InitParams. I'll get to this later.
- NativeBrowserFrame could probably disappear as an interface. It only exists to provide a couple of methods that may be implemented in other ways.
- delete_on_destroy should now be an ownership directionality enum. I will do this later.
- Secondary-widgetness should somehow be inferred from transience. Later.
- set_focus_on_creation for both the NativeWidgets should probably move to Widget if it is really needed.
- WidgetWin/Gtk::SetInitialFocus seems like it could move to Widget.
- I need to clean up function order in some cases.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7012006
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/7011038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not optimized yet - need to detect when the screen image is unchanged and avoid
passing it to the encoder (as in the Windows implementation).
BUG=None
TEST=Manual
To test:
Switch VT (Ctrl-Alt-F2) and run
startx -- :1 -extension DAMAGE
Run chromoting_simple_host from there, and connect to it. Verify that changing
screen resolution works. Also stress the X Server with
x11perf -time 99999 -osrect 500
and repeat the screen-resolution test.
Review URL: http://codereview.chromium.org/7012025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=81251
TEST=browser_tests
Review URL: http://codereview.chromium.org/6918001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
possible for an error page to be shown after another load, resulting
in cancelling the other load. Here's the sequence that can trigger it:
. load page that results in error page (eg http://cnn.co), in RVH1.
. trigger loading of error page
. load correct page (eg http://cnn.com) in RVH2. This triggers a stop
in RVH1.
. error page finishes loading. Navigation completes, notifies browser
and browser swaps back to RVH1.
BUG=79515
TEST=none
R=jamesr@chromium.org
Review URL: http://codereview.chromium.org/7004024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82167
TEST=none. Existing tests still pass.
Review URL: http://codereview.chromium.org/6969026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7012033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also change the animation to have a constant fade, instead of
pulsing it.
BUG=chromium-os:15279
TEST=None
Review URL: http://codereview.chromium.org/6973045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running as Chrome Frame, this new GPO will be consulted for the base location of the user data dirs. If not set, chrome.exe will use the command-line provided data dir rather than the Chrome-specific GPO.
BUG=80516
TEST=See repro steps in the bug report
R=pastarmovj@chromium.org
Review URL: http://codereview.chromium.org/6932019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82078
TEST=none
Review URL: http://codereview.chromium.org/6973057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6969046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ProfileIOData from content::ResourceClient.
Review URL: http://codereview.chromium.org/6973054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=82047
TEST=unit tests
Review URL: http://codereview.chromium.org/7005033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had a case where I was accidentally calling WatchFileDescriptor from another
thread, and it took me a while to debug why I was having problems.
This check would've immediately caught my error for me.
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/6410035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Widget ----
Now recognizes a supplied NativeWidget via InitParams. If this is specified then a default one is not created.
Is now created directly rather than using a factory. NativeWidget creation is not performed until Init() is called. This means some functions that rely on a NativeWidget must not be called until _AFTER_ Init() (explains some of the function call reordering in this CL, e.g. moving SetOpacity() until after Init()).
ResetLastMouseMovedFlag() moved to this API so that BaseTabStrip can call it in a cross-platform way.
Made last remaining unimplemented methods on Widget pass-thru to NativeWidget implementations.
* WidgetWin/WidgetGtk ----
The NativeWidget implementations now both require a NativeWidgetDelegate implementation upon construction. This is passed through the constructor by the static factory method NativeWidget::CreateNativeWidget and by subclasses such as WindowWin, BubbleWidgetWin, etc.
Some classes that are constructed directly (e.g. LockWindow, in ChromeOS) never have a Widget created for them, so they create the Widget themselves in their base class initializer.
Code in these classes (and their WindowWin/WindowGtk, BrowserFrameWin, BrowserFrameGtk subclasses) must now call GetWidget() etc to call Widget API methods since they are no longer subclasses.
static_casting to this (and derived) types must now be done on the Widget's native_widget().
GetWindow() is renamed to GetContainingWindow() to avoid naming conflicts.
* Window ----
Window is now a subclass of Widget.
Now recognizes a supplied NativeWindow via InitParams. If this is specified then a default one is not created.
Window::CloseWindow becomes an override of Widget::Close.
CloseAllSecondaryWindows() becomes CloseAllSecondaryWidgets() and moves to widget.h
IsAppWindow() is removed and replaced by set_is_secondary_widget on Widget.
* MenuHost ----
Subclasses Widget now.
* TabContentsViewViews ----
It looks like the Gtk-views code here was still using the old implementation of the Native version of this class - i.e. a class that subclassed TabContentsView AND WidgetGtk. A no-no. I had to write NativeTabContentsViewGtk, which is almost identical to NativeTabContentsViewWin with the Gtk bits of TabContentsViewGtk thrown in.
* BrowserFrame ----
Platform-specific functionality is now restricted to BrowserFrameWin/BrowserFrameGtk behind a NativeBrowserFrame interface. Construction is exposed via a static factory method on NativeBrowserFrame.
BrowserFrame becomes a concrete class that now subclasses Window.
As a result, it no longer needs a GetWindow() accessor method, so people with a BrowserFrame* can just call Window methods directly on it.
It is constructed directly, replacing the BrowserFrame::Create() method.
NativeBrowserFrameDelegate is no longer needed.
BrowserFrameChromeos is simpler as a couple of #ifdefs in BrowserFrame, so I got rid of that too.
* AutocompletePopupWin/Gtk ----
No longer required. AutocompletePopupContentsView now just uses a Widget directly.
* There is some lingering ugliness:
- If you set a native_window field on Window::InitParams you must also manually set widget_init_params.native_widget. I will make InitParams do more of this automatically later.
- It'd be nice for the ContentsView to be specified via InitParams. I'll get to this later.
- NativeBrowserFrame could probably disappear as an interface. It only exists to provide a couple of methods that may be implemented in other ways.
- delete_on_destroy should now be an ownership directionality enum. I will do this later.
- Secondary-widgetness should somehow be inferred from transience. Later.
- set_focus_on_creation for both the NativeWidgets should probably move to Widget if it is really needed.
- WidgetWin/Gtk::SetInitialFocus seems like it could move to Widget.
- I need to clean up function order in some cases.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7012006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It wasn't related, it was an IncrediBuild issue. IB was enabled yesterday and I
didn't realize it was just enabled. It has now been disabled.
TBR=nsylvain@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6969065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LNK1318 is transient and can be taken care of by a clobber.
LNK1000 is a out of memory condition and can be worked around only by disabling
incremental linking for debug build or (hopefully) disable optimization for
release build.
Take a chance with disabling optimization.
TBR=nsylvain@chromium.org
BUG=none
TEST=pray it works
Review URL: http://codereview.chromium.org/7014043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed version of issue 6904042.
BUG=61676
TEST='QuotaManagerTests.*'
Review URL: http://codereview.chromium.org/7004019
Patch from Taiju Tsuiki <tzik@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a retry of http://codereview.chromium.org/7002029/ after it has been reverted because of the failing test BrowserTest.CloseWithAppMenuOpen (failed only on buildbot)
BUG=chromium-os:15129
TEST=tests
TBR=dpolukhin
TBR=glotov@google.com
Review URL: http://codereview.chromium.org/7016033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6969061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60101
TEST=no
Review URL: http://codereview.chromium.org/6931055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=82078
TEST=None
R=joaodasilva@chromium.org,mnissler@chromium.org
Review URL: http://codereview.chromium.org/7012013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/6969032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a retry of http://codereview.chromium.org/7002029/ after it has been reverted because of the failing test BrowserTest.CloseWithAppMenuOpen (failed only on buildbot)
BUG=chromium-os:15129
TEST=tests
TBR=dpolukhin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
There where failures on memory waterfall
Review URL: http://codereview.chromium.org/7012035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=disallow all cookies, go to a website, click on the blocked cookie icon, there should be an option to allow cookies from that site
Review URL: http://codereview.chromium.org/7014034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7011034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_tests.
Now running the script for non-webkit canary bots makes sense.
This addresses the first half of Bug 78538.
(For the last half, see http://codereview.chromium.org/6993006/)
Example:
$ ./webkit/tools/layout_tests/canary-webkit-revisions.py "XP Tests (dbg)" "Vista Tests"
Oldest revision to check: 86223
"XP Tests (dbg)"
"Vista Tests"
**** Failing revisions *****
The last run was at r86225 on "XP Tests (dbg)" and the following 1 tests failed
compile failed
**** Passing revisions *****
No passing runs on "XP Tests (dbg)"
The last passing run was at r86223 on "Vista Tests"
Passing revision range: r86223 - r86223
TEST=run the script manually
BUG=78538
Check the canary builds up to the last-rolled WebKit revision.
The script now examines the DEPS file to know the WebKit revision.
This patch solves the last half of BUG 78538.
TEST=run canary-webkit-revisions.py and observe.
BUG=78538
Review URL: http://codereview.chromium.org/7004017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
function hasn't been in TabContents for a while.
TBR=nkostylev
Review URL: http://codereview.chromium.org/7012032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add user data to content::ResourceContext that points to chrome's ProfileIOData. That way when the embedder code is called by content, it can get back to its profile specific data structures like HostContentSettingsMap.
BUG=76793
Review URL: http://codereview.chromium.org/7014025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The script now examines the DEPS file to know the WebKit revision.
This patch solves the last half of BUG 78538.
TEST=run canary-webkit-revisions.py and observe.
BUG=78538
Review URL: http://codereview.chromium.org/6993006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the keyboard overlay.
BUG=chromium-os:15191
TEST=manual
Review URL: http://codereview.chromium.org/7015021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82506
TEST=BrowserNavigatorTest.NavigateToCrashedSingletonTab
Review URL: http://codereview.chromium.org/7014032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
migrated data from user prefs to local state in M12.
Changes to get ssl preferences from local state in IO thread.
Replaced uses of CreateSystemSSLConfigService with
new net::SSLConfigServiceDefaults so that we could delete
CreateSystemSSLConfigService method.
Deleted ssl_config_service_manager_system.cc
Review URL: http://codereview.chromium.org/6810010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=80308
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the following tests for bookmark sync:
TwoClientLiveBookmarksSyncTest.MC_DuplicateFolders
TwoClientLiveBookmarksSyncTest.MC_BookmarkNameChangeConflict
TwoClientLiveBookmarksSyncTest.MC_BookmarkURLChangeConflict
TwoClientLiveBookmarksSyncTest.MC_FolderNameChangeConflict
It also adds TCM annotations for the following tests:
TwoClientLiveBookmarksSyncTest.MC_MergeSimpleBMHierarchySubsetUnderBMFolder
TwoClientLiveBookmarksSyncTest.MC_MergeSimpleBMHierarchySubsetUnderBookmarkBar
TwoClientLiveBookmarksSyncTest.MC_Merge_SimpleBMHierarchy_Under_BMFolder
TwoClientLiveBookmarksSyncTest.MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BMFolder
TwoClientLiveBookmarksSyncTest.MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BookmarkBar
TwoClientLiveBookmarksSyncTest.MC_Merge_SimpleBMHierarchy_DuplicateBMs_Under_BMBar
BUG=76988
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6997004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Ran the test multiple times on Windows 7 chrome-bot in the qa env and did not encounter errors.
BUG=76639
TEST=none
Review URL: http://codereview.chromium.org/7012019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the prerender icon reappear, as well as fixes issues with histograms.
BUG=None
TEST=Navigate to a prerendered page, see icon.
Review URL: http://codereview.chromium.org/7016019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also initialize a few more fields in the session_params object.
Remove unused net_log params.
BUG=82365
TEST=Turn on sync, look in chrome://sync-internals for entries for talk.google.com
Review URL: http://codereview.chromium.org/7014009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pre-fill the notification info map with all known data types.
Combine the two notification tables into one.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7015031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
+jamesr for OWNERS on content/renderer because nobody else on GPU has owners there. :s
BUG=81481
Review URL: http://codereview.chromium.org/6976012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81451
TEST=greener tree
Review URL: http://codereview.chromium.org/6969052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Integration tests that disable sync are red on the buildbots and green
on the trybots. Marking as failing until they're investigated.
TBR=rohitrao,alekseys
BUG=82489
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/7012029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also delete two unused strings while I'm here.
BUG=76870
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6973044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7011030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=can authenticate.
Review URL: http://codereview.chromium.org/6973034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds comments about some of the ownership issues.
BUG=75020
TEST=BUILD
Review URL: http://codereview.chromium.org/7016025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fixes bug where user could (in certain circumstances) get stuck with an orphaned, uncloseable popup menu.
BUG=69002
R=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/7016028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a bunch of P0 sync integration tests for apps and
extensions that were previously blocked due to missing hooks in the
integration test harness.
Tests added:
TwoClientLiveAppsSyncTest.Add
TwoClientLiveAppsSyncTest.Uninstall
TwoClientLiveExtensionsSyncTest.Add
TwoClientLiveExtensionsSyncTest.Uninstall
Note: Do not commit before http://codereview.chromium.org/6995011 is landed.
BUG=82195
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/7008001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7011028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85221 0039d316-1c4b-4281-b951-d872f2087c98
|