| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
sync.
If we have a freshly opened AVFormatContext, telling it to seek to the beginning (pts=0) apparently causes the video and/or audio streams to get timestampped incorrectly, causing video sync issues. If the video has been playing a bit, a seek to the beginning causes no issues. Go figure.
BUG=17832
TEST=ogg videos should remain in sync
Review URL: http://codereview.chromium.org/159438
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/16459
Review URL: http://codereview.chromium.org/159323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Same for hung renderer dialog.
BUG=13000
Review URL: http://codereview.chromium.org/160147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17631
Review URL: http://codereview.chromium.org/160131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
only have a single button for undo.
Review URL: http://codereview.chromium.org/160200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pulls in new selenium (selenium_rc)
and removes old selenium (java, py) dependencies
also removes doxygen dependency
This is dependent on this CL
http://codereview.appspot.com/96131
Review URL: http://codereview.chromium.org/160089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17695
TEST=Open the browser in a RTL locale. Drag a link from the tab contents into the tabstrip. The drop arrow should be positioned correctly.
Review URL: http://codereview.chromium.org/159394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Use long for int64 (still 64 bits) to avoid annoying nspr clash.
- Fix some incorrect define guards and add some functions to atomicops.
Review URL: http://codereview.chromium.org/159428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
coordinate system.)
BUG=http://crbug.com/17716
TEST=as in bug
Review URL: http://codereview.chromium.org/160194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
va_copy is a builtin, you can't just pass it references like we did previously.
Review URL: http://codereview.chromium.org/160191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're displaying to stdout, we don't want to dump arbitrary bytes
to the IPC log. Make it display only ASCII and clip it to a reasonable
max length.
(PS: I tried to resolve the vector<char> / vector<unsigned char> schism
at first but it bleeds across out entire codebase...)
Review URL: http://codereview.chromium.org/159430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specifying "frame_color" and "inactive_frame_color" in the gtk_color_scheme.
Also attempts to do a better job matching the frame color. Most window
managers (defined as metacity default theme and xfwm's default theme)
take bg[SELECTED] tint it by 80%. We hand code that behaviour in, as it
will be wrong a smaller percentage of the time then our current
behaviour.
http://crbug.com/16271 (dark theme bug)
http://crbug.com/13967 (theme color metabug)
Review URL: http://codereview.chromium.org/160188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
handling for calls
R=aa
Review URL: http://codereview.chromium.org/160129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=5146
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=4139
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159352
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17800
TEST=none
Review URL: http://codereview.chromium.org/159414
Patch from Fabien Tassin <fta@sofaraway.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
helper function, so that it will be easier for the ICO favicon test to ask for a particular frame.
Right now this isn't necessary; that test still wants frame 0. After I land some patches upstream, however, this will change (and all the "testing_favicon_size_" crap will disappear, it's just a temporary hack).
BUG=none
TEST=Covered by existing unittests
Review URL: http://codereview.chromium.org/160123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Thiago Farina. Original review: http://codereview.chromium.org/160151
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/160185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
added for the bots. Once the bots are bounced to the new configs, this target could go away completely.
Review URL: http://codereview.chromium.org/159422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14903
BUG=http://crbug.com/14904
BUG=http://crbug.com/14905
TEST=Findbar should function normally, as before.
Review URL: http://codereview.chromium.org/160144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
still failing.
Make downloads not prevent tabs from closing. If a download creates a
cross-site transition (for example, if you click a link in Gmail that results
in a download in a new tab), that tab will be stuck and you can't close it or
the browser. This is the opposite problem with a similar cause as bug 16246. In
both cases we were using some secondary signal to tell us if we're closing for
a cross site transition or closing the tab, and that signal was wrong. In this
case, we were running the onunload handler, but because there was a pending
RenderViewHost, the RenderManager would think that the close was a cross-site
one, and not forward the close message to actually close the tab. This patch
adds a flag to the on unload handlers that indicates whether it's for a tab
closure or a cross-site transition, so we can do the right thing unambiguously
when the message returns. In this case I keep this information in the
RenderView in case we send multiple close requests, we'll close the tab if any
of them were for the entire tab, even if that particular one was dropped
because we don't want to have more than one in flight at once. BUG=17560
TEST=none.
Review URL: http://codereview.chromium.org/160122
Review URL: http://codereview.chromium.org/159426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/160187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
InspectorBackend."
This reverts commit 836fec2217b4a8ddb16c957b4b86f72252e31ce3.
Review URL: http://codereview.chromium.org/160186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The transport canvas and the backing store canvas are upside down relative to eachother, so the rects need some massaging.
BUG=none
TEST=YouTube videos should play without sections drawing in the wrong place, and plugins scrolled partially offscreen should draw the right section.
Review URL: http://codereview.chromium.org/159423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
InspectorBackend.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In the recent refactoring of IPC, it appears logging on POSIX was
lost. The file modified here later checks an #ifdef that is set
by the now-included ipc_message.h to set up POSIX logging.
Review URL: http://codereview.chromium.org/159418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
would close if any one listener on the channel called "disconnect()".
BUG=16644
TEST=no
Review URL: http://codereview.chromium.org/155476
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
seen this morning in
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/1364/steps/valgrind%20test:%20unit/logs/stdio
BUG=17385
TEST=watch valgrind unit tests go green
Review URL: http://codereview.chromium.org/160168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not necessary. This is to work around janky scrolling behavior
that brad was seeing. I can't repro, so he'll have to tell me if
this works for him
BUG=16786
Review URL: http://codereview.chromium.org/160179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/waterfall/builders/Linux%20UI%201%20of%203%20(valgrind)/builds/239/steps/valgrind%20test:%20ui/logs/stdio
this morning (and fairly often before that).
BUG=17795
TEST=watch valgrind UI bots for a day or two and verify no leak in SVGNames::init
Review URL: http://codereview.chromium.org/159420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a download creates a cross-site transition (for example, if you click a
link in Gmail that results in a download in a new tab), that tab will be stuck
and you can't close it or the browser.
This is the opposite problem with a similar cause as bug 16246. In both cases
we were using some secondary signal to tell us if we're closing for a cross site
transition or closing the tab, and that signal was wrong.
In this case, we were running the onunload handler, but because there was a
pending RenderViewHost, the RenderManager would think that the close was a
cross-site one, and not forward the close message to actually close the tab.
This patch adds a flag to the on unload handlers that indicates whether it's
for a tab closure or a cross-site transition, so we can do the right thing
unambiguously when the message returns. In this case I keep this information in
the RenderView in case we send multiple close requests, we'll close the tab if
any of them were for the entire tab, even if that particular one was dropped
because we don't want to have more than one in flight at once.
BUG=17560
TEST=none.
Review URL: http://codereview.chromium.org/160122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I used a mock url request job which is guaranteed to finish after the timeout the test uses.
TEST=none
http://crbug.com/16462
Review URL: http://codereview.chromium.org/155941
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although we will also need to implement certain other hotkeys such as Ctrl+C and so forth, I see no point in adding an accelerator group as we do not want the accelerators to work when the tree views don't have focus. Also we don't want the menu to show the accelerators.
Also, fix a bug where the organize menu could be stale. mdm pointed out that ctrl+clicking the selection could lead to an empty selection.
BUG=17393
Review URL: http://codereview.chromium.org/160137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since our packagers have been requesting that we support using more
system libraries, I'm starting to commit these sorts of changes.
However, please note that one MUST NOT use the system libpng on, at
least, Ubuntu 64-bit. Because Chromium on Linux is still a 32-bit
build we end up with the 32-bit compat versions of libraries and, on
Ubuntu at least, this includes a very old libpng with security issues.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and we want to show it again.
I think this will be very WM-specific on whether it works. It seems that a lot of WMs don't want to allow windows from groups that don't have focus to do this. For example: http://blogs.gnome.org/metacity/2007/12/24/stacking/
BUG=17767
Review URL: http://codereview.chromium.org/160149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Symbol `SSL_ImplementedCiphers' has different size in shared object, consider re-linking"
if SSL_ImplementedCiphers is different size on target system than it was on build system.
BUG=12826
TEST=run on Jaunty, look for "Symbol `SSL_ImplementedCiphers' has different size in shared object" in console output
Review URL: http://codereview.chromium.org/118367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crash a page and see if the icon shows up (animated)
Review URL: http://codereview.chromium.org/160113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* The menu has two sections: most visited and recently closed.
* Creates a HistoryMenuBridge that observes different data sources and stores
results for use in the menu.
* Creates a HistoryMenuController to respond to Cocoa IBActions from the menu.
BUG=14933
TEST=History menu in mac should populate with most visited and recently closed
sites.
RELEASE_NOTES=Add initial implementation of the Mac history menu.
Patch by Robert Sesek.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15363
TEST=ExtensionsService.LoadAllExtensionsFromDirectorySuccess
Review URL: http://codereview.chromium.org/159388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wrapping. When second step is executed debugger_agent_manager will autocontinue
on break. We assume that second step doesn't call user scripts.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21635
Review URL: http://codereview.chromium.org/159395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
wrapping. When second step is executed debugger_agent_manager will autocontinue
on break. We assume that second step doesn't call user scripts.
Review URL: http://codereview.chromium.org/159395
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17667
TEST=see bug
Review URL: http://codereview.chromium.org/160142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=glen@chromium.org
BUG=None
Test=None
Review URL: http://codereview.chromium.org/159393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21633 0039d316-1c4b-4281-b951-d872f2087c98
|