| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=42965
Review URL: http://codereview.chromium.org/1703025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. An confirmation
dialog box should be shown. No other visible change.
Review URL: http://codereview.chromium.org/1687017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resized poolballs.png to power-of-two dimensions. Retested all
o3d-webgl samples in top of tree Firefox, WebKit and Chromium.
BUG=none
TEST=none
TBR=gman,petersont
Review URL: http://codereview.chromium.org/1695031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/42743
TEST=as in bug
Review URL: http://codereview.chromium.org/1687025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42497
Review URL: http://codereview.chromium.org/1691023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1808005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When launching from a read-only disk image, if no installed copy exists in
/Applications, and the user chooses to install from the disk image:
If it appears that there isn't permission to write to /Applications, prompt
the user to authenticate as an administrator. If authentication is
successful, copy the application as root, set its permissions, and promote
Keystone to use a system ticket.
BUG=40265
TEST=Remove the application from /Applications and test, as both an admin
user and a normal user, installation directly from the disk image. When
installation occurs after authentication, Chrome should be on a system
ticket.
Also, make sure that normal in-app Keystone promotion continues to work
as expected.
Review URL: http://codereview.chromium.org/1792013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This patch is a bit ugly. I think it might make sense to split out the SYN_STREAM parsing from the SYN_REPLY parsing at this point.
Review URL: http://codereview.chromium.org/1769012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Includes some IPv6 fixups for Alternate-Protocol.
* Refactors some Alternate-Protocol code, moves the check from DoInitConnection() to DoResolveProxy() so we can send the updated endpoint to the ProxyResolver.
BUG=42666
Review URL: http://codereview.chromium.org/1750020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42958
Review URL: http://codereview.chromium.org/1712028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=manually
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1741016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1775004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
or marked as flaky.
BUG=21110,38562
TEST=unittests
Review URL: http://codereview.chromium.org/1800010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=42943
TEST=none
TBR=rafaelw
Review URL: http://codereview.chromium.org/1810012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Reverting 46012.
Review URL: http://codereview.chromium.org/1815003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42896
Review URL: http://codereview.chromium.org/1712027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
some refactoring of the WebDataServiceTest to allow some code sharing between the two.
Review URL: http://codereview.chromium.org/1739017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42941,42942
Review URL: http://codereview.chromium.org/1752023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Other users of the temp directory will be altered in a subsequent CL.
BUG=13044
TEST=SandboxedExtensionUnpackerTest.*, ScopedTempDir.UniqueTempDirUnderPath, FileUtilTest.CreateNewTempDirInDirTest, manual testing on win, linux, mac.
Review URL: http://codereview.chromium.org/1582022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension is enabled for incognito.
BUG=39113
Review URL: http://codereview.chromium.org/1789010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the WebDataService.
BUG=35038
TEST=PasswordStoreDefaultTest.*
Review URL: http://codereview.chromium.org/1572040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
running.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1810008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(i.e. DownloadInHost) request is already received.
BUG=42104
Review URL: http://codereview.chromium.org/1705018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the observer in ~TabStrip. By the time TabStrip's destructor was run the model's destructor had already run. I've changed BrowserView to explicitly delete the TabStrip before the browser. See the change between v1 and v2 of this patch in BrowserView for the relevant part.
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/1817001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It was reverted as http://codereview.chromium.org/1822001 the fix in Valgrind scripts has been commited as http://codereview.chromium.org/1736026
TEST=trybots
Review URL: http://codereview.chromium.org/1763023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
third_party/nss was added to DEPS in r37022; third_party/mingw-w64 was added to
DEPS in r40062. Both changes forgot to update .gitignore.
Review URL: http://codereview.chromium.org/1796005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36415
TEST=none
Review URL: http://codereview.chromium.org/1575033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
been fixed
BUG=http://code.google.com/p/data-race-test/issues/detail?id=34
TBR=glider
Review URL: http://codereview.chromium.org/1744010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1731019
TBR=pfeldman
Review URL: http://codereview.chromium.org/1758019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Shift-clicking on a checkbox in the history editing mode now sets all checkboxes from the last click to the current click to the state of the just clicked checkbox. Also, the last clicked checkbox is focused to indicate the anchoring.
BUG=42827
TEST=See bug.
Review URL: http://codereview.chromium.org/1718021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1819004
TBR=pfeldman
Review URL: http://codereview.chromium.org/1796006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(landing on behalf of satish@chromium.org from http://codereview.chromium.org/1769008/show)
BUG=41015
TEST=Open the test page given in the bug and hit submit, verify that the autofill setup infobar does not pop up.
Review URL: http://codereview.chromium.org/1822002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=willchan
Review URL: http://codereview.chromium.org/1800011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23416,42925
TBR=timurrrr
Review URL: http://codereview.chromium.org/1739023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1822001
Review URL: http://codereview.chromium.org/1736026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fast/canvas-empty-image-pattern.html passes since WebKit r58480:r58515 (win), r58439 (linux) and never failed on mac according flakiness_dashboard
BUG=none
TEST=none
RBT=agl
Review URL: http://codereview.chromium.org/1692018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib):
The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them.
At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|.
The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|.
BUG=38021
TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet.
Review URL: http://codereview.chromium.org/1760001
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1790009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib):
The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them.
At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|.
The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|.
BUG=38021
TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet.
Review URL: http://codereview.chromium.org/1760001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This broke the memory waterfall, failed to import protobuf.
TBR=nick
Review URL: http://codereview.chromium.org/1822001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42921
TBR=glider
Review URL: http://codereview.chromium.org/1708020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that is compiled only in Release builds.
TBR=eroman
Review URL: http://codereview.chromium.org/1687024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/1808004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- URLRequestTestContext (from now on use TestURLRequestContext)
- TestServerPageW (use TestServerPage).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1814002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1801007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured.
Make the sync_integration_tests run by default against the test server. An externally-provided --sync-url will give the old behavior.
Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf).
Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore.
Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work.
Flakiness fix: Port sync_integration_tests to the out-of-process test runner.
Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure.
BUG=20905,40980
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45916
Review URL: http://codereview.chromium.org/1622012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=yaar
Review URL: http://codereview.chromium.org/1801010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of app container you wanted to launch in so that we could try out different things.
My change to window affinity change broke this for tabs. This should fix it.
Review URL: http://codereview.chromium.org/1811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class forwards notifications from a NetworkChangeNotifier on one
thread to an observer on another. This will be used to enable
the sync threads to listen to NCN notifications from the IO thread.
BUG=42606
TEST=unittests
Review URL: http://codereview.chromium.org/1704014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
last bookmark within the folder. Bringing up a contextual menu on an open bookmark bar folder no longer closes the folder.
BUG=32064
TEST=1) Copy a bookmark item. Using the contextual menu, paste the bookmark item just copied onto the top of a folder in the bookmark bar. Open that folder and verify that the pasted item appears as the last bookmark therein. 2) Copy a bookmark item. Pop open a bookmark bar folder which itself contains a folder. Paste the bookmark item onto the top of that subfolder. Verify that the subfolder now contains the pasted bookmark item as its last bookmark. 3) Pop open a bookmark folder. Bring up the contextual menu on that folder. Verify that the folder window is not automatically closed when the contextual menu is presented.
Review URL: http://codereview.chromium.org/1732029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46032 0039d316-1c4b-4281-b951-d872f2087c98
|