summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Replace hard-coded media_format() methods with Google Mock methods declared ↵scherkus@chromium.org2009-11-186-52/+97
| | | | | | | | | | | | | | | | in mock_filters.h. Updated unit tests accordingly. Patch by Dominic Jodoin <dominic.jodoin@gmail.com> BUG=21040 TEST=Run the media_unittests and AudioRendererImplTest test suite in unit_tests. Ensure there is no Google Mock failures and that all tests are passing. Review URL: http://codereview.chromium.org/404016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32267 0039d316-1c4b-4281-b951-d872f2087c98
* Roll O3D's DEPS for Chromium 28829:32206.senorblanco@chromium.org2009-11-181-1/+1
| | | | | | | | | BUG=none TEST=does it build? Review URL: http://codereview.chromium.org/397033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32266 0039d316-1c4b-4281-b951-d872f2087c98
* Launch processes asynchronously so as not to block the UI thread. For now, ↵jam@chromium.org2009-11-1819-336/+488
| | | | | | | | | renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203) BUG=6844 Review URL: http://codereview.chromium.org/397031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32264 0039d316-1c4b-4281-b951-d872f2087c98
* Stop top-crasher regression by disabling WebSocketExperimentRunnerjar@chromium.org2009-11-181-0/+4
| | | | | | | | | | | | | | There was a race to destroy histograms held by an instance within WebSocketExperimentRunner, and this was causing the crash when histograms were being recorded at shutdown. See bug 28096 for re-enabling this feature. BUG=27856 r=wtc,ukai Review URL: http://codereview.chromium.org/404017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32263 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash source in test_shell when running DB tests.dumi@chromium.org2009-11-182-7/+46
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/404013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32262 0039d316-1c4b-4281-b951-d872f2087c98
* Use an explicit boolean has_new_first_party_for_cookies insteadwtc@chromium.org2009-11-1816-22/+52
| | | | | | | | | | | | of an empty, invalid URL to indicate whether the first party for cookies URL needs changing when following a redirect. R=eroman BUG=25133 TEST=none Review URL: http://codereview.chromium.org/405011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32260 0039d316-1c4b-4281-b951-d872f2087c98
* Added 2 more flakes. Removed one flake that was already there.yaar@chromium.org2009-11-181-3/+4
| | | | | | TBR: idana,erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32258 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser tests for the BLOCK_THIRD_PARTY_COOKIES policywtc@chromium.org2009-11-182-0/+88
| | | | | | | | | | | | to verify we allow first-party cookies in the regular and redirected cases. R=abarth,eroman BUG=25133 TEST=new browser tests are added Review URL: http://codereview.chromium.org/401009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32257 0039d316-1c4b-4281-b951-d872f2087c98
* linux: set a compiler flag that drops the eh_frame sectionevan@chromium.org2009-11-181-0/+4
| | | | | | | | | | | | eh_frame is data used for exception frames. We already disable exceptions, but it turns out this obscure extra flag was responsible for the eh_frame making it into our binaries. This shaves off another few megabytes from our binaries. Review URL: http://codereview.chromium.org/397032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32254 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes up TabStripControllerTests so that they work with CocoaTest.dmaclach@chromium.org2009-11-182-25/+44
| | | | | | | | | | | | Enhances BrowserTestHelper so that you can create and close the browser window. BUG=none TEST=none Review URL: http://codereview.chromium.org/402035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32253 0039d316-1c4b-4281-b951-d872f2087c98
* more test expectation changeserikkay@chromium.org2009-11-181-0/+5
| | | | | | | | | | BUG=28074,28075,28077,28079,28080 TEST=layout tests TBR=yaar,idana Review URL: http://codereview.chromium.org/401017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32252 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for parent window closing behind the bookmark bubble.dmaclach@chromium.org2009-11-185-142/+146
| | | | | | | | | BUG=27752 TEST=none Review URL: http://codereview.chromium.org/397006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32251 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes detection logic for IE under XP SP2.slightlyoff@chromium.org2009-11-181-2/+10
| | | | | | | | | BUG=28038 Test=none Review URL: http://codereview.chromium.org/397028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32250 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32244 - linux: pass gcsections in link lineidana@chromium.org2009-11-181-3/+0
| | | | | | | | | | | | | We have compile flags set up to support using gcsections, but apparently we aren't using it for the actual link? This has a large difference on binary size. Review URL: http://codereview.chromium.org/399048 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/401018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32248 0039d316-1c4b-4281-b951-d872f2087c98
* Tightening latest expectations changes and fixing typo.yaar@chromium.org2009-11-181-8/+8
| | | | | | TBR: idana,erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32247 0039d316-1c4b-4281-b951-d872f2087c98
* Move TaskManagerMacUnitTest over to Cocoatest.dmaclach@chromium.org2009-11-181-5/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/404010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32246 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up check so that it reads correctly when it fails.dmaclach@chromium.org2009-11-181-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/399047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32245 0039d316-1c4b-4281-b951-d872f2087c98
* linux: pass --gc-sections in link lineevan@chromium.org2009-11-181-0/+3
| | | | | | | | | | We have compile flags set up to support using --gc-sections, but apparently we aren't using it for the actual link? This has a large difference on binary size. Review URL: http://codereview.chromium.org/399048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crashing bug around ApplicationCacheDispatcherHost::Initialize in the ↵michaeln@google.com2009-11-181-4/+8
| | | | | | | | | | | mac port. TEST=existing tests BUG=26754 Review URL: http://codereview.chromium.org/402025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32243 0039d316-1c4b-4281-b951-d872f2087c98
* Add three Valgrind suppressions for one leak and two invalid reads.idana@chromium.org2009-11-181-0/+70
| | | | | | | | | BUG=28071,28072,28073 TEST=none TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32242 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the refcount on InternalGetCommandRequest stays non-zero through ↵jamesr@chromium.org2009-11-181-1/+1
| | | | | | | | | | | | | | | a PostTask The problem was that BaseSessionService::ScheduleGetLastSessionCommands() was posting a task with a InternalGetCommandsRequest* request parameter by calling NewRunnableMethod(.., &SessionBackend::ReadLastSessionCommands, request). SessnionBackend::ReadLastSessionCommands takes one parameter of type scoped_refptr<InternalGetCommandsRequest>. However, NewRunnableMethod was matching the template because an InternalGetCommandsRequest* is implicitly convertable to a scoped_refptr<InternalGetCommandsRequest> but it was not actually creating the scoped_refptr<> (and thus bumping the refcount) until the task was dispatched. By this time the refcount on the InternalGetCommandsRequest had already dropped to zero, leading to memory corruption. This fixes the problem by passing a scoped_refptr<...> in to NewRunnableMethod() to ensure that it is copied and that the refcount stays up. TEST=covered by TabRestoreUITest.RestoreIntoSameWindow - caused very intermittend failures locally BUG=none Review URL: http://codereview.chromium.org/404012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32240 0039d316-1c4b-4281-b951-d872f2087c98
* Add a string to be used in new extension promo message.mirandac@chromium.org2009-11-181-1/+4
| | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/403007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32239 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32203,32204,32205 - Launch processes asynchronously so as not to ↵jam@chromium.org2009-11-1816-482/+330
| | | | | | | | | | | block the UI thread. For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change. BUG=6844 Review URL: http://codereview.chromium.org/397002 Review URL: http://codereview.chromium.org/402033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32238 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32176 - Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-187-37/+24
| | | | | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/399051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32237 0039d316-1c4b-4281-b951-d872f2087c98
* Added updated crash expectation forerikkay@chromium.org2009-11-171-1/+1
| | | | | | | | | | | | LayoutTests/dom/html/level2/html/HTMLElement95.html BUG=28057 TEST=LayoutTests/dom/html/level2/html/HTMLElement95.html TBR=yaar,idana Review URL: http://codereview.chromium.org/397030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32234 0039d316-1c4b-4281-b951-d872f2087c98
* Added test expectations to 3 flaky tests:yaar@chromium.org2009-11-171-0/+5
| | | | | | | | | | LayoutTests/fast/body-propagation/overflow/004.html LayoutTests/storage/domstorage/clear.html LayoutTests/websocket/tests/frame-length-skip.html TBR: idana@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32225 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a test that I mistakenly removed from failing expectations.dglazkov@chromium.org2009-11-171-0/+2
| | | | | | | | | | TBR=erikkay TEST=none BUG=8630 Review URL: http://codereview.chromium.org/400021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32224 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK when trying to remove multiple engines from the Manage Search ↵pkasting@chromium.org2009-11-171-1/+1
| | | | | | | | | Engines dialog. Original patch by Thiago Farina (see http://codereview.chromium.org/401013 ), r=me. BUG=5227 TEST=Select multiple engines and hit "Remove" in a debug build; should not checkfail. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32223 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lint errors in app/ and turn on presubmit check.erg@google.com2009-11-1711-16/+41
| | | | | | Review URL: http://codereview.chromium.org/400016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32222 0039d316-1c4b-4281-b951-d872f2087c98
* Fix checkfailure caused by stupidity.pkasting@chromium.org2009-11-171-1/+1
| | | | | | | | BUG=23400 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32221 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline a few more of the repaint tests.dglazkov@chromium.org2009-11-1738-13/+507
| | | | | | | | | | | | | | The difference in upstream repaint areas as compared to upstream results is due the difference in repaint logic. Safari/Mac port uses NSView's native rectangle collection/unification, and we just unify all into one damage rect. Plus, our results don't fit on one page (scollbars appear), which in some cases repaints the entire scrolled area. R=jparent BUG=8630 TEST=none Review URL: http://codereview.chromium.org/402015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32219 0039d316-1c4b-4281-b951-d872f2087c98
* I've moved toolbar_controller_unittest over to CocoaTest which should be ↵dmaclach@chromium.org2009-11-171-23/+19
| | | | | | | | | | | | | better about cleaning things up properly. Let's see if this fixes the world. BUG=27920 TEST=none Review URL: http://codereview.chromium.org/399041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32218 0039d316-1c4b-4281-b951-d872f2087c98
* Add new failure to expectations on MAC.erikkay@chromium.org2009-11-171-1/+1
| | | | | | | | | | BUG=28034 TEST=LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny.html TBR=yaar,idana Review URL: http://codereview.chromium.org/399046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32217 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly set an icon color for Incognito on Mac.avi@google.com2009-11-171-12/+16
| | | | | | | | | BUG=http://crbug.com/27867 TEST=incognito icons should be black Review URL: http://codereview.chromium.org/405008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32216 0039d316-1c4b-4281-b951-d872f2087c98
* Strings to localize for the try-chrome again toastcpu@chromium.org2009-11-172-0/+40
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/397026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32215 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanups for BrowserThemeProvider. Move the globaltony@chromium.org2009-11-172-53/+64
| | | | | | | | | | | | stl containers into helper functions to defer init and to ensure we only initialize once. Move some consts into the namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/399042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32214 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race conditions where an object's constructor uses PostTask on itself. ↵jam@chromium.org2009-11-1712-46/+70
| | | | | | | | | This isn't safe since the posted task can execute before the constructor returns, leading to destruction of the object. BUG=27944 Review URL: http://codereview.chromium.org/399016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32213 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a problem where queued checks' clients would never be called back if ↵pkasting@chromium.org2009-11-172-44/+74
| | | | | | | | | | | | when the check finally ran it passed the prefix check (the common case). This was made more noticeable by r31950 since before that things wouldn't be queued unless we were resetting the database (rare) or caught a narrow timing window where |database_| was true but |database_loaded_| was false; after that, we could get this on startup, and with r32136, after closing the database as well. This also removes some unnecessary bits now that we don't queue during a reset. BUG=23400 TEST=none Review URL: http://codereview.chromium.org/402004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32212 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in signal thread destructor.zork@google.com2009-11-172-2/+14
| | | | | | | | | BUG=23251 TEST=none Review URL: http://codereview.chromium.org/402026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32211 0039d316-1c4b-4281-b951-d872f2087c98
* Add CRASH to Linux expectations forerikkay@chromium.org2009-11-171-1/+1
| | | | | | | | | | | | LayoutTests/plugins/embed-attributes-setting.html BUG=15797 TEST=LayoutTests/plugins/embed-attributes-setting.html TBR=idana Review URL: http://codereview.chromium.org/400019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32210 0039d316-1c4b-4281-b951-d872f2087c98
* Added two suppressions for a leak and an invalid read in WebCore.idana@chromium.org2009-11-171-0/+52
| | | | | | | | | BUG=28026,28027 TEST=none TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32209 0039d316-1c4b-4281-b951-d872f2087c98
* Allow multiselection deletion of engines in the Manage Search Engines ↵pkasting@chromium.org2009-11-171-9/+15
| | | | | | | | | dialog. Original patch by Thiago Farina (see http://codereview.chromium.org/402020 ), r=me, tweaked. BUG=16842 TEST=Select multiple engines. "Remove" should be enabled iff the selected set does not include the default engine. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32208 0039d316-1c4b-4281-b951-d872f2087c98
* UI Changes for benchmark:mbelshe@google.com2009-11-171-5/+11
| | | | | | | | | | | | | a) Remove the "Config" button; instead, the configuration is always just applied to a run. b) Make the clear button work properly Put in UI when there are no results to display. BUG=none TEST=none Review URL: http://codereview.chromium.org/397025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32207 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 424:428, and enable Skia SSE2 optimizations for Linux and ↵senorblanco@chromium.org2009-11-173-13/+58
| | | | | | | | | | | | | Mac. Due to unfortunate limitations in gcc and gyp, this required creating a new static library target, skia_sse2 (see skia.gyp for the gory details). I did a search-and-replace in all .gyp files in the tree, but if there are other projects outside this tree which refer to skia.gyp, they will have to be modified as well. This also required rolling DEPS for O3D Skia 376:428, since O3D uses chrome's skia.gyp file. Since this update brings ~25M of HTML docs, I pared the DEPS file down to just src/ and include/ (as we do in Chrome). I built O3D on 32bit Linux to test; hopefully other platforms will be ok. BUG=none TEST=green bots Review URL: http://codereview.chromium.org/402016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32206 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break on Mac release.jam@chromium.org2009-11-171-2/+3
| | | | | | | | BUG=6844 TBR=darin Review URL: http://codereview.chromium.org/405006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32205 0039d316-1c4b-4281-b951-d872f2087c98
* fix include orderjam@chromium.org2009-11-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32204 0039d316-1c4b-4281-b951-d872f2087c98
* Launch processes asynchronously so as not to block the UI thread. For now, ↵jam@chromium.org2009-11-1716-330/+481
| | | | | | | | | renderer only, I'll take care of plugin/worker/utility processes in a followup change. BUG=6844 Review URL: http://codereview.chromium.org/397002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32203 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use TabSwitchPaintDuration in tab switching test."chase@chromium.org2009-11-171-21/+20
| | | | | | | | | | | | | | Turns vista perf red. Original review URL: http://codereview.chromium.org/385121. Original revision r32196. TBR=nsylvain BUG=4104 TEST=vista perf tab switching test goes green Review URL: http://codereview.chromium.org/402024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32202 0039d316-1c4b-4281-b951-d872f2087c98
* Do not open a new connection if one has already been opened.dumi@chromium.org2009-11-171-0/+5
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/405005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32201 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac/Linux] Fix WordIterator::GetWord() for UTF-16 surrogate pairs.shess@chromium.org2009-11-172-0/+63
| | | | | | | | | | | | | | | | For systems where !defined(WCHART_T_IS_UTF16), WordIterator transforms the input into UChar data. But GetWord() was using the resulting offsets as indices into the original string, so it could return incorrect data and/or attempt to index off the end of the input. This changes GetWord() to do do the inverse conversion from Init() for those systems. BUG=27698 TEST=See bug. Review URL: http://codereview.chromium.org/399010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32199 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 16:37:07 +0000