| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Also modifies it so that we only modify the wmclass_name, and not the
wmclass_class because the internal application names aren't meant for display
and are very ugly.)
BUG=20587
TEST=Verify with xprop that the WM_CLASS of application desktop links mmatches the StartupWMClass key in the desktop file.
Review URL: http://codereview.chromium.org/6759076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=70659
TEST=none
Review URL: http://codereview.chromium.org/6801012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DesktopNotificationsTest.TestShow
DesktopNotificationsTest.TestClose
DesktopNotificationsTest.TestCancel
DesktopNotificationsTest.TestPositioning
DesktopNotificationsTest.TestVariableSize
DesktopNotificationsTest.TestQueueing
DesktopNotificationsTest.TestUserInputEscaping
Also Mark TaskManagerBrowserTest.NoticeNotificationChanges as disabled under windows.
TBR=mmenke
BUG=78597
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80629
Review URL: http://codereview.chromium.org/6804020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
can be pretty slow. To avoid this, don't try to switch to the currently-bound egl context.
BUG=
TEST=JSGameBench
Review URL: http://codereview.chromium.org/6720041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like all ProxyResolverV8Test doesn't run properly on tsan/mac.
TBR=eroman@chromium.org
BUG=78536
TEST=none
Review URL: http://codereview.chromium.org/6805014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To my knowledge, none of these NaCl processes need to filter for resource request IPCs. Thus there's no reason to pass in RDH to BrowserChildProcessHost.
Moreover, it's bad because passing in RDH will make the ResourceMessageFilter use the default request context, which we're trying to eliminate.
BUG=78596
TEST=none
Review URL: http://codereview.chromium.org/6801010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The current granularity [500ms between buckets at peak points] makes it difficult to compare performance.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6802010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buffer class that doesn't throw exceptions.
The new buffer class is pretty simple and relies on the MemoryAllocator class that I previously to back large
allocations with mapped files when memory is scarce. That reduced the number of crashes quite a bit but we
still crash on machines that are simply out of diskspace as well. So, the right thing to do is to expect and
handle failures which is what this cl is all about. What we should see once this has landed is that crash
dumps due to courgette running out of disk space should disappear from crash/ and instead we should see the
number of users that run into this particular problem in dashboards.
TEST=Courgette out-of-memory/out-of-diskspace errors should disappear from crash/
BUG=74777
Review URL: http://codereview.chromium.org/6677141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2/3.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6805012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide a new one that doesn't make it easy to use the default URLRequestContext.
BUG=78596
TEST=none
Review URL: http://codereview.chromium.org/6802007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following additional information is returned:
(1) Whether the app is a component extension.
(2) Whether the app is disabled.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6689019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6803014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Setup pointers to cmd buffer GLES2 interface in Ganesh
Review URL: http://codereview.chromium.org/6691042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tkent@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This helps eliminate the need to construct a ResourceMessageFilter for these process hosts.
This is important since ResourceMessageFilters will need to take a per-profile object containing the data necessary to load resources.
BUG=78596
TEST=none
Review URL: http://codereview.chromium.org/6792067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77786
TEST=Visit a page that redirects on reload, then stop before it finishes.
Review URL: http://codereview.chromium.org/6793029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/chromium/issues/detail?id=78074
TEST= ppapi/tests/test_case.html?testcase=Graphics2D
Patch by Sang Ahn
Original Review http://codereview.chromium.org/6728034/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Data learned during navigation, about subresources, was
only being trimmed (pruned?) at shutdown. This CL regularly
calls for reductions in contents. Without this, long lived
clients can accumulate large lists.
We also form two preconnections to a site if we have no
prior info about its sub-resources. This accelerates
learned activity. This CL also sets the initial estimate
of number of connections needed to 2, so that we are more
aggressive in our learning curves about sub-resources.
R=mbelshe
BUG=75200
Review URL: http://codereview.chromium.org/6628063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
out an entry for a specific version of chrome.
BUG=78064
TEST=unittest
Review URL: http://codereview.chromium.org/6693080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from local_state on Windows and Mac.
BUG=76551
TEST=testing SSL preferences with options UI
R=wtc
Review URL: http://codereview.chromium.org/6693077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6800015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tkent@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1/3.
BUG=None
TEST=None
R=avi@chromium.org
Review URL: http://codereview.chromium.org/6689029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Windows:ExtensionCrashRecoveryTest.BasicExtensionCrashRecoveryTest.CloseAndReloadExtensionCrashRecoveryTest.ReloadIndependentlyChangeTabsExtensionCrashRecoveryTest.ReloadIndependentlyNavigatePageExtensionCrashRecoveryTest.ReloadIndependentlyTwoInfoBarsExtensionCrashRecoveryTest.ReloadIndependentlyTwoInfoBarsSameBrowserExtensionCrashRecoveryTest.TwoExtensionsCrashFirstExtensionCrashRecoveryTest.TwoExtensionsCrashSecondExtensionCrashRecoveryTest.TwoExtensionsCrashBothAtOnceExtensionCrashRecoveryTest.TwoExtensionsOneByOneExtensionCrashRecoveryTest.TwoExtensionsIgnoreFirstExtensionCrashRecoveryTest.TwoExtensionsReloadIndependentlyExtensionCrashRecoveryTest.CrashAndUninstallTBR=mmenkeBUG=78598TEST=noneReview URL: http://codereview.chromium.org/6804012
TBR=mmenke@chromium.org
Review URL: http://codereview.chromium.org/6804013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionCrashRecoveryTest.Basic
ExtensionCrashRecoveryTest.CloseAndReload
ExtensionCrashRecoveryTest.ReloadIndependentlyChangeTabs
ExtensionCrashRecoveryTest.ReloadIndependentlyNavigatePage
ExtensionCrashRecoveryTest.ReloadIndependentlyTwoInfoBars
ExtensionCrashRecoveryTest.ReloadIndependentlyTwoInfoBarsSameBrowser
ExtensionCrashRecoveryTest.TwoExtensionsCrashFirst
ExtensionCrashRecoveryTest.TwoExtensionsCrashSecond
ExtensionCrashRecoveryTest.TwoExtensionsCrashBothAtOnce
ExtensionCrashRecoveryTest.TwoExtensionsOneByOne
ExtensionCrashRecoveryTest.TwoExtensionsIgnoreFirst
ExtensionCrashRecoveryTest.TwoExtensionsReloadIndependently
ExtensionCrashRecoveryTest.CrashAndUninstall
TBR=mmenke
BUG=78598
TEST=none
Review URL: http://codereview.chromium.org/6804012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DesktopNotificationsTest.TestShow
DesktopNotificationsTest.TestClose
DesktopNotificationsTest.TestCancel
DesktopNotificationsTest.TestPositioning
DesktopNotificationsTest.TestVariableSize
DesktopNotificationsTest.TestQueueing
DesktopNotificationsTest.TestUserInputEscaping
Also Mark TaskManagerBrowserTest.NoticeNotificationChanges as disabled under windows.
TBR=mmenke
BUG=78597
TEST=none
Review URL: http://codereview.chromium.org/6802009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(No code changes.)
nist.der contains a certificate issued directly from a root. This will be used
in a future unittest however, committing it now allows the try servers to
process the unittest before it's landed.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a RDH is passed to the parent class, it will create a ResourceMessageFilter to handle resource loads.
ProfileImportProcessHost shouldn't need to load resources. It's just importing the profile.
This is part of the effort to pass a per-profile content::ResourceContext object to all message filters that need it. We need to avoid creating message filters unless we need them. We don't need a ResourceMessageFilter here.
BUG=78596
TEST=none
Review URL: http://codereview.chromium.org/6805006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=all automated tests pass
Review URL: http://codereview.chromium.org/6756044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=78463
TEST=None
Review URL: http://codereview.chromium.org/6691065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not a real crash, it is caused by wrapping TestSuite::Run in
an exception filter. DllRedirector test uses VerQueryValue to query
version from version resource. VerQueryValue, on windows XP, takes
a const pointer but tries to modify it causing access violation.
So where do you fix this bug? You guessed it right: in
kernel32!UnhandledExceptionFilter :)
UnhandledExceptionfilter checks if the crash address belongs to a
resource section of a binary and then makes it writable. If we
install exception filter around VerQueryValue this does not happen
and we treat it as a crashed test.
solution is to remove the exception filter. This might result in
tests crashing levaing around zombie IE/Firefox. We will deal with
that when that happens.
TEST=DllRedirectorLoadingTest.TestDllRedirection
BUG=78209
Review URL: http://codereview.chromium.org/6792053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move the non-extension app icon code to extension_tab_helper, merge with extension app code.
BUG=71097
TEST=no visible change
Review URL: http://codereview.chromium.org/6792059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=pfeldman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9164
TEST=Manual
Review URL: http://codereview.chromium.org/6806008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6800013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
more testableIn particular:- Add various status accessors to ExtensionServiceInterface (e.g., IsExtensionEnabled())- Convert IsIncognitoEnabled() to take an ID instead of an Extension*.- Add CheckForUpdates() to ExtensionServiceInterface.- Remove various unneeded accessors from ExtensionServiceInterface.Rewrite some sync utility functions to take advantage of the newinterface (although it will be rewritten more in a future CL).BUG=77995TEST=Review URL: http://codereview.chromium.org/6720042
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6804010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the automation framework could miss a browser
crash during shutdown on POSIX (on Windows there is
crash_service.exe that should catch all crashes).
This change makes the automation framework avoid losing
information about the browser process' exit status
(CrashAwareSleep), and fixes a bug in base::WaitForExitCodeWithTimeout
(which on POSIX never reported the process has been signaled).
Finally, it makes the automation framework use WaitForExitCodeWithTimeout
instead of WaitForSingleProcess. This way we can get the exit status
information in an accurate and cross-platform way.
To avoid trying to close the same process handle twice (it's only an issue on Windows) I've changed WaitForExitCodeWithTimeout not to close the passed handle. It's only used in few places and I think this CL fixes all of them.
I've tested this change locally on Mac with a UI test that SIGKILLs the browser.
Before this change the test passed (it shouldn't), and after this change
the test failed with an information that the browser has not exited cleanly.
BUG=56644
Review URL: http://codereview.chromium.org/6689014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69810
TEST=Open DevTools, open site having data url resource, observe small time/latency values (e.g. 2ms).
Review URL: http://codereview.chromium.org/6693095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
SO_PEERCRED, not file permissions.BUG=TEST=Run Chrome & configure a service, to get the service process to start. Close Chrome and run a copy as a different user, but from the same user-data-dir. New Chrome should not be able to communicate with the service process.Review URL: http://codereview.chromium.org/6631002TBR=wez@chromium.orgReview URL: http://codereview.chromium.org/6806006
TBR=wez@chromium.org
Review URL: http://codereview.chromium.org/6806007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52444
TEST=Install an App from the gallery, then type a substring from its name (or it's launch url) and see it appear as a suggestion in the Omnibox.
Review URL: http://codereview.chromium.org/6758031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
permissions.BUG=TEST=Run Chrome & configure a service, to get the service process to start. Close Chrome and run a copy as a different user, but from the same user-data-dir. New Chrome should not be able to communicate with the service process.Review URL: http://codereview.chromium.org/6631002
TBR=wez@chromium.org
Review URL: http://codereview.chromium.org/6806006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is already the case in mac and windows, this CL fixes the linux version to match them.
BUG=none
TEST=manual, click on the speech button and verify that the bubble stays same size between warm up and recording states.
Review URL: http://codereview.chromium.org/6800011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Run Chrome & configure a service, to get the service process to start. Close Chrome and run a copy as a different user, but from the same user-data-dir. New Chrome should not be able to communicate with the service process.
Review URL: http://codereview.chromium.org/6631002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Broken by crrev.com/80540
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6806005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only reload it if the user requested the deletion through the history page itself.
BUG=49475
TEST=none
Review URL: http://codereview.chromium.org/6691055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's still only enabled for non-official builds, since the connection to
GAIA and policy infrastructure is still missing.
BUG=chromium-os:13277
TEST=manual
Review URL: http://codereview.chromium.org/6689010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this, the enrollment UI is now functional up to the point of
actually passing the auth credentials on to the policy subsystem.
BUG=chromium-os:13277
TEST=manual
Review URL: http://codereview.chromium.org/6759055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a WebUI-based flow to the enterprise enrollment screen that
first prompts for credentials and then shows a confirmation screen.
BUG=chromium-os:13277
TEST=manual
Review URL: http://codereview.chromium.org/6778014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of instance variables.
Also corrected naming of the other file-scoped globals in that vicinity.
BUG=none
TEST=none, no change in functionality.
Review URL: http://codereview.chromium.org/6794058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80596 0039d316-1c4b-4281-b951-d872f2087c98
|