| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Will submit this TBR.
Propogating fix from mainline sct.
Review URL: http://codereview.chromium.org/9663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it easier to share inputs among files, in preparation for the symbian port.
Also, some small fixes:
- Added a hack to the third party lib scripts to place the libraries in the
right directory. Normally SCons does this, but fails due to a bug when
COMPONENT_LIBRARY_DIR is changed.
- Added fake notifier targets to make the win32 installer happy.
- Added NPAPI's gears.dll to the win32 installer dependencies, so it is built (even though it isn't used by the installer).
- Added symbian file to sqlite compile.
Review URL: http://codereview.chromium.org/9657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of some unnecessary addRepository() calls that mapped specific
webkit\port\ subdirectories to third_party\WebKit\WebCore subdirectories,
in ways that were already covered by the mapping in webkit\SConscript of
all of $WEBKIT_DIR\port to third_party\WebKit\WebCore.
This takes about 40 duplicate /I options out of a typical compilation
command line (and, more importantly, out of the .h file searches).
Add additional comments about future potential efficiency that we
can get from eliminating the quirky way we remap specific directories
into webkit\port, instead of just maintaining a completely parallel
directory structure and mapping the whole tree once.
Review URL: http://codereview.chromium.org/9466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that the tree still flicker during a resize
on RTL locales but not on LTR.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Initialize PAINTSTRUCT to prevent crash if BeginPaint fails.
* Sanitize width-height for empty bitmaps.
* Return failure from initialize instead of crashing at that point.
BUG=3795
Review URL: http://codereview.chromium.org/9459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1442838
Review URL: http://codereview.chromium.org/9422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208
Review URL: http://codereview.chromium.org/9613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
let it drop on the floor.
Review URL: http://codereview.chromium.org/9653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/9467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/9460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add password_autocomplete_listener.cc to the build
TBR=mark
Review URL: http://codereview.chromium.org/9648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also added a histogram to show effective bandwidth of the download.
r=darin,wtc
Review URL: http://codereview.chromium.org/9625
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"config.h" needs to be included first
TBR=mark
Review URL: http://codereview.chromium.org/9647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add autocomplete_input_listener.cc to the glue lib
TBR=mark
Review URL: http://codereview.chromium.org/9645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
add dom_operations.cc to the mac build
TBR=mark
Review URL: http://codereview.chromium.org/9644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of these files that I don't added to the build would even compile
and link, but don't yet pass with current test_shell on Linux.
They just hang.
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com> on
http://codereview.chromium.org/9417
Review URL: http://codereview.chromium.org/9641
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
select boxes (but does not affect scroll bars). I created a helper class, ThemeHelperWin, which automatically wraps the logic necessary to do this. There are three modes: draw the form control normally, draw it at a different size (for scaling, just tell Windows it's a different size and don't transform the graphics coordinates), or arbitrary transforms (where it's drawn to an offscreen buffer and transformed by our graphics layer.
Review URL: http://codereview.chromium.org/9008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
vector growth / copies for the typical cookie database.
Review URL: http://codereview.chromium.org/9437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was already removed from Debug). Remove the trailing space on the
FEATURE_DEFINES setting in debug mode; it was causing a DOUBLE space in the
--defines string being passed to generate-bindings.pl, of which that script is
intolerant.
Review URL: http://codereview.chromium.org/9640
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With V8 r648 (Review URL: http://codereview.chromium.org/8909) attaching the debugger to V8 will initialize V8 if not already initialized. This needs to be serialized with the initialization of V8 in the renderer thread.
This change does not require the changes in V8 r648, but will not have any effect without.
Added a few comments.
BUG=3723
Review URL: http://codereview.chromium.org/8735
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IMEs.
Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect.
Also, this change fixes cursor positions for Japanese IMEs.
BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition"
BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window."
BUG=2775 "IME: Caret is always displayed at the last of IME composition."
Review URL: http://codereview.chromium.org/7385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I tested on the buildbot
and this is the only one I could see leaks in. If it stays green, I'll narrow it more by modifying the
test.
TBR=erikkay
Review URL: http://codereview.chromium.org/9451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements the following features
1. Toolbar import always available after first run
2. Deduping of imported favorites
3. Removes attempt to import favicons (not supported through Toolbar UI atm)
4. Always the user to cancel from the UI safely
5. Unittests for parsing
(TODO Better UI for login)
Review URL: http://codereview.chromium.org/9414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
see how it could happen.
Just bullet-proofing the code so we don't crash.
BUG=981648
Review URL: http://codereview.chromium.org/9190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
when packages are not found by pkg-config.
Review URL: http://codereview.chromium.org/9618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closing the tab if the beforeunload /unload handler hangs. This patch does the right user-visible behavior, but I'm not a huge fan of the plumbing necessary to make it work. Totally open to cleanup suggestions.
There's also currently one bug that I haven't been able to pinpoint in the UI test. It only treats the first UI test of the four that I run as a cross-site navigation. No matter which test I run first. I wonder if there is some state I should be setting/clearing before/after each test run?
Also there's a DHECK that we hit that the UI test exposed. I 'm not sure it's a case that a user could actually hit though and it's not new with this code, so I added a TODO.
Can I get help from a mac person on adding the UI test to the xcode project?
BUG=3198
Review URL: http://codereview.chromium.org/8920
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- like c:\bang.
- it will crash at startup on a bad iterator use.
BUG=4112
Review URL: http://codereview.chromium.org/9610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/9617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but no user name associated.
This was causing some wekbit layout tests to fail.
TEST=Run the webkit layout tests.
Review URL: http://codereview.chromium.org/9612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also modified WidgetChromium to use ChromiumBridge instead of talking to ChromeClientChromium. I want to eliminate that fake interface in favor of just having our code talk directly to ChromeClientImpl, but that means a dependency on webkit/glue, so I needed to use ChromiumBridge. Long-term, I'd like to propose changes upstream to HostWindow and ChromeClient to avoid this usage of ChromiumBridge.
The most impactful part of this CL is the change to move the enumeration of cursor types from WebCursor to PlatformCursor. This means that WebCursor consumers no longer have access to the type enumeration. I replaced that with helper functions on WebCursor. I think the result not only achieves the goal of breaking CursorChromium's dependency on webkit/glue but is also much cleaner.
R=iyengar,eseidel
Review URL: http://codereview.chromium.org/9072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make everything use ARGB order in registers (B.G.R.A order in memory on
little-endian systems)
Review URL: http://codereview.chromium.org/8227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
an infinite recursion of assertion messages during a painting error.
BUG=4139
Review URL: http://codereview.chromium.org/9608
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which was a hang while loading certain PDF files. This was a regression caused by support for NPN_RequestRead (PDF Fast Webview). We had incorrectly assumed that the Content Type showing up for partial HTTP Responses would always end with the boundary. A content type can show up like multipart/byteranges; boundary=--bound--; charSet=utf8. As a result we would look for the wrong boundary in the actual data resulting in a hang.
The parsing code now accounts for this. Added a unit test to test this case.
Bug=4076
R=jam
Review URL: http://codereview.chromium.org/9198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
functions in the upstream version of WebKit.
Review URL: http://codereview.chromium.org/9210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9611
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4834 0039d316-1c4b-4281-b951-d872f2087c98
|