| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=155413
TEST=cc_unittests
R=enne@chromium.org,jamesr@chromium.org
TBR=jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11228059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The magic code that this is currently testing is at the end of
RenderViewImpl::willSendRequest, which sets the UA override (if there is
one). The network stack will only ask UrlRequestContext for a user agent
if it is not already set.
BUG=
Java test change. Ran through android java trybot
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11227059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org,avi@chromium.org
BUG=107201
Review URL: https://chromiumcodereview.appspot.com/11189143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in lieu of a proper drop shadow, pending the refactoring described in http://crbug.com/157161.
Screenshot: http://imgur.com/Hau7Z
BUG=140548
Review URL: https://chromiumcodereview.appspot.com/11175039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of crrev.com/163511, which was reverted as "return"
statement was missing where it should not.
The crash reported at crbug.com/157057 can occur if the 2nd parameter to
std::string constructor is negative here:
bool ResumeUploadOperation::GetContentData(std::string* upload_content_type,
std::string* upload_content) {
*upload_content_type = params_.content_type;
*upload_content = std::string(params_.buf->data(),
params_.end_range - params_.start_range + 1);
return true;
}
Looking at the code, this can occur if reading of a file failed in
DriveUploader::ReadCompletionCallback().
BUG=157057
TEST=none. This crash is hard to reproduce
Review URL: https://codereview.chromium.org/11231068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11235066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
button aligned to the hung pages table. The same views::kUnrelatedControlLargeHorizontalSpacing padding value is now used both for hung pages table and Kill pages button.
BUG=118130
TEST=Open an HTML page which hungs the renderer (e.g. a page with infinite JavaScript loop). Wait until Page(s) Unresponsive dialog shows up. Kill pages button should be left-aligned with the hung pages list.
Review URL: https://chromiumcodereview.appspot.com/11226015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Both linux_aura versions have had a persistent problem where if you drag a tab
out of a window, you have to click on either window to get mouse input working
in the web content area. This is because the RootWindow still thinks a mouse
drag is in progress.
BUG=146077
Review URL: https://chromiumcodereview.appspot.com/11189148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11234064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also don't display the UI for sideload-wipeout extensions (when the feature is
enabled).
BUG=137469
Review URL: https://chromiumcodereview.appspot.com/11229071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11198091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No functional change.
BUG=b/7399968
Review URL: https://chromiumcodereview.appspot.com/11227063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checks some system settings and looks for module names of
known assistive technology. Also moves the accessibility histogram
code into a different thread so there's no chance that the
system calls will cause any jank.
BUG=99504
TBR=creis
Review URL: https://chromiumcodereview.appspot.com/11238018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Localized strings for HTML constants; automatically select events and metrics so
that something is seen immediately on startup; warn the user if the gathering
switch is not enabled; add the flag to the about:flags.
BUG=130212
Review URL: https://chromiumcodereview.appspot.com/11053010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
linker error on the Windows builder.
BUG=157184
TBR=cpu
Review URL: https://codereview.chromium.org/11229074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=rnk
Review URL: https://codereview.chromium.org/11229073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we navigated to urls with anchors from an external program, chrome would end up navigating to
the url without the anchor tag. This was because of a bug in the DelegateExecute handler. We retrieve
the url being navigated to via the IShellItem::GetDisplayName function. This does not return the full url
for some reason.
Workaround is to bind to the underlying IDataObject wrapped by the IShellItem and retrieve the url from there.
If we fail to bind to the IDataObject/retrieve the url from there, we fallback to the current approach of retrieving
the url via the GetDisplayName mechanism.
BUG=157184
R=cpu
Review URL: https://codereview.chromium.org/11175073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11235068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ARM ABI has been stabilized.
BUG= http://code.google.com/p/chromium/issues/detail?id=145694
Review URL: https://chromiumcodereview.appspot.com/11180005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11092054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11228061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=154716
Review URL: https://chromiumcodereview.appspot.com/11235072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=156415
TEST=DnsProbeServiceTest, included
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11189025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iOS sets a single supported scale factor at runtime, either 100P or 200P
depending on whether the device is hidpi. This CL also corrects some conversion
methods that did not properly support 200P scale factors.
BUG=None
TEST=Image unittests all pass on hidpi devices.
Review URL: https://chromiumcodereview.appspot.com/11233040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11238013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:35568
TEST=manually tested on the device (see bug for repro step). Also added test case for this.
Review URL: https://chromiumcodereview.appspot.com/11227060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable 4 prefs_ui tests failing on all platforms:
prefs_ui.BasicSettingsUITest.testCancelStartupURLSetting
prefs_ui.BasicSettingsUITest.testSetStartupPages
prefs_ui.PrefsUITest.testDeleteExceptionUI
prefs_ui.BasicSettingsUITest.testUseCurrentPagesForStartup
BUG=157271
TEST=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11233068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove BubbleDelegateView's explicit SetFocusedView() call.
( workaround for old focus problems from http://crrev.com/108167 )
Have HWNDMessageHandler::Show() call ShowWindowWithState().
( calls needed HWNDMessageHandlerDelegate::HandleInitialFocus() )
Add a BubbleDelegateViewTest.InitiallyFocusedView unit test with TODO.
( demonstrates a bug with the workaround for http://crbug.com/125976 )
This fixes BookmarkBubbleView's title textfield focus for native textfields.
( but does not fix the issue for the experimental NativeTextfieldViews )
( nixing the NativeWidgetWin::RestoreFocusOnActivate() workaround does )
BUG=145732,125976
TEST=Bookmark bubble initially focuses the title textfield.
Review URL: https://chromiumcodereview.appspot.com/10908233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collapses the Init() method into the constructor since it was always
called immediately anyways and provides a more useful method for
performing initialization on the audio thread.
BUG=153056
TEST=media_unittests continue to work and pass.
Review URL: https://chromiumcodereview.appspot.com/11175066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=151626
Review URL: https://chromiumcodereview.appspot.com/11235065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When resuming (power_on=1, all_display=1), use the current
state to restore display.
- Don't turn off the internal display even for mirror mode.
chrome never remove the internal display and this was
confusing chrome. (I'll do right fix on 25)
BUG=chrome-os-partner:14980, 157284
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/11233052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11185011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Assets for http://codereview.chromium.org/11229022/
BUG=150872
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11233066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that new message files can't be added to chromium without triggering a security review.
Review URL: https://chromiumcodereview.appspot.com/11048038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure it does not run on other platforms besides Windows, where it was intended (for now).
Fix the problem with bubble appearing to the right of the browser.
Make sure the bubble does not appear on next run after explicitly dismissing it.
Enable sideload wipeout by default.
BUG=154624
TEST=None
Review URL: https://codereview.chromium.org/11232060
TBR=finnur@chromium.org
Review URL: https://codereview.chromium.org/11175075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:15574
TEST=.S files show up in makefiles.
TBR=fischman
Review URL: https://codereview.chromium.org/11229070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I felt like all the platform checks should only be in one place
and the workarounds should work on flags rather than specific
platforms.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11250002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=144596
Review URL: https://chromiumcodereview.appspot.com/11175049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=157467
R=mmenke@chromium.org
TBR=mmenke@chromium.org
Review URL: https://codereview.chromium.org/11238071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure it does not run on other platforms besides Windows, where it was intended (for now).
Fix the problem with bubble appearing to the right of the browser.
Make sure the bubble does not appear on next run after explicitly dismissing it.
Enable sideload wipeout by default.
BUG=154624
TEST=None
Review URL: https://codereview.chromium.org/11232060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
With this CL LoadProgressChanged is only called on android, earlier it was never called.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11194043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
encountered.
Advantages of this approach:
- We will be getting crash reports from the field when fatal mistakes happen.
- The exponential backoff counter will not be reset.
BUG=134694
Review URL: https://chromiumcodereview.appspot.com/11234034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11189147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the only mode that makes sense for platform apps, so no other option is allowed in the manifest.
BUG=155130
Review URL: https://chromiumcodereview.appspot.com/11228048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
draggable region is specified
This happens because RWHV is created for the new RVH instead of the existing RVH associated with the web contents when navigating a web contents to extension URL (see http://crbug.com/123007). When ShellWindowViews tries to set the clickthrough region for resizing purpose, it fails due to no RWHV for the existing RVH. The fix is to make the native window do it again when RWHV is available after RVH is updated.
BUG=145175
TEST=Manual test by launching and resizing frameless window without draggable region specified
Review URL: https://chromiumcodereview.appspot.com/11205004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=szym
Review URL: https://codereview.chromium.org/11233073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was disabled in r163152 to fix a problem caused by r163108, but was fixed
by r163309.
BUG=156985
TBR=yurys
Review URL: https://chromiumcodereview.appspot.com/11235063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crash in chromeos when trying to switch the desktop from the wrench menu.
BUG=157384
Review URL: https://codereview.chromium.org/11235071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163694 0039d316-1c4b-4281-b951-d872f2087c98
|