| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8341137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before we were ending up with different preferences set in
different locations.
I'm not sure if this approach is right from the content-team's
point of view.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8403024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8399028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8403023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=102134
TBR=hbono
TEST=TSan bots mostly green
Review URL: http://codereview.chromium.org/8341136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=102255,102256,10227
TEST=Memory FYI waterfall is so much greener
TBR=hbono
Review URL: http://codereview.chromium.org/8416062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
downloads.DownloadsTest.testPauseAndResume, as it is failing sporadically on pyauto win vista, and cause is not understood.
BUG=102228
Review URL: http://codereview.chromium.org/8413065
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/8341134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=BrowserFeatureExtractorTest
Review URL: http://codereview.chromium.org/8400050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As they are now virtual.
BUG=chromium-os:22197
TEST=chrome and tests build
Review URL: http://codereview.chromium.org/8400077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests have been failing since crrev.com/107314 due to the hacky
workaround I added.
Along the way, rework other tests to use MockDBusThreadManager. These
weren't failing but using the mock would make the tests faster and more
reliable.
For signed_settings_unittest.cc to pass, add expectations for StorePolicy().
We didn't need this before, as we were using stub implementation that
always ran callback.Run(true), but we are now using mocks, so we should
add this behavior manually.
BUG=chromium-os:22183
TEST=Run UpdateScreenTest, NetworkScreenTest, ExistingUserControllerTest, SignedSettingsHelperTest with the debug build.
Review URL: http://codereview.chromium.org/8418037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup while I was doing this.
-got rid of SandboxInitWrapper, since I didn't see a need to expose given that we can just expose sandbox::SandboxInterfaceInfo
-got rid of the duplicated code to initialize the broker
-since I made MainFunctionParams only have the sandbox struct on Windows, I also made the mac specific auto release pool behind an ifdef as well. It seemed odd to make something so mac specific compile on all platforms to save some #ifdefs.
BUG=98716
Review URL: http://codereview.chromium.org/8414020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eroman
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/7981004/
BUG=95714
TEST=base_unittests
Review URL: http://codereview.chromium.org/8418044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8418043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=try, WebGL conformance tests
Review URL: http://codereview.chromium.org/8413053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=caseq
Review URL: http://codereview.chromium.org/8416059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I thought we wouldn't need a mock for this, but I was wrong.
To properly fix crosbug.com/22183, we need to mock out DBusThreadManager.
As always, it's never too late to do the right thing.
BUG=chromium-os:22197
TEST=D-Bus functions work as before (brightness change keys work)
Review URL: http://codereview.chromium.org/8343069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
[ Re-land of 107815 ]
Review URL: http://codereview.chromium.org/8416055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hans
Review URL: http://codereview.chromium.org/8413055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8392025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8395031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
failing sporadically on pyauto win vista, and cause is not understood.
BUG=102228
Review URL: http://codereview.chromium.org/8413065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it easy to search through trace data.
This also adds a trace_analyzer::TraceEvent class that can be constructed from JSON data (via base::Value). TraceEvent mirrors base::debug::TraceEvent in a form that is lower performance and easier to use in test code.
BUG=95714
TEST=base_unittests
Review URL: http://codereview.chromium.org/7981004
TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/8413063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=101853
TEST=none
Review URL: http://codereview.chromium.org/8343048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/8400079
TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/8400081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 8162015 failed the trybot and was reverted.
But I could not reproduce the issue in my local machine, so I just make a new CL and test it on trybot again.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8361031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
full screen" button.
The crash was due to the fact that Browser::OnDenyFullscreenPermission causes BrowserWindow::ExitFullscreen to be called, which causes the FullscreenExitBubbleController to be destroyed. [FullscreenExitBubbleController deny:] was sending a -hideSoon message to its zombie self following the call to Browser::OnDenyFullscreenPermission.
BUG=101835
TEST=The browser doesn't crash when you click "Exit full screen" on a fullscreened page.
Review URL: http://codereview.chromium.org/8399017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8351008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8353025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:101435
TEST=manual
Review URL: http://codereview.chromium.org/8413050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the bug where you're able to click on the wrench of panels whose originating extension has been unloaded, resulting in a crash.
BUG=101118
TEST=PanelBrowserTest.NonExtensionDomainPanelsCloseOnUninstall
Review URL: http://codereview.chromium.org/8387010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetNextIdThunkType with DownloadIdFactory (RefCountedThreadSafe, created by DownloadService).
DownloadService uses the same DownloadIdFactory for an OTR profile as its original profile.
DownloadService passes the DownloadIdFactory into the DownloadManager so that the DownloadManager can allocate new valid ids for items loaded from the history or downloads started on the ui thread.
Since the DownloadService precedes and outlives its DownloadManager, DownloadManager does not have a scoped_refptr<DownloadIdFactory>. Objects that do have a scoped_refptr<DownloadIdFactory>: DownloadService, ProfileIOData, ShellBrowserContext, ShellResourceContext.
The DownloadIdFactory must be RefCountedThreadSafe because ProfileIOData outlives Profile and because it's used in both the OTR and original profiles.
Longer term, the import process should strictly precede profile initialization, and the next_download_id counter should be loaded from the History db strictly before DownloadService is created and creates a DownloadIdFactory.
BUG=98966
Review URL: http://codereview.chromium.org/8401001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=102161
Review URL: http://codereview.chromium.org/8414031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:18457
TEST=None
Review URL: http://codereview.chromium.org/8413026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=alicet
Review URL: http://codereview.chromium.org/8418042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
render view status was not
propagated correctly.
BUG=ChromeFrame tests should now pass on IE8.
TBR=robertshield
Review URL: http://codereview.chromium.org/8418041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/8400079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bots to go red) - Roll webkit 98723:98752
TBR=caseq
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8343072
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/8343076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handle the case
where a new AutomationResourceMessageFilter instance was created for a render view/render process id
combination. This happens typically on IE8 and above where new windows could go into a different IE process.
BUG=none
TBR=robertshield
Review URL: http://codereview.chromium.org/8414038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8413052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes BrowserNonClientFrameViewAura's translucent gray
background always stick out a bit beyond the sides and
bottom of windows, instead of just peeking out when the user
hovers for resizing.
I originally added a separate view for this, but it looked
strange since Chrome already draws a shadow along the top of
the tab strip.
BUG=101977
TEST=manual
Review URL: http://codereview.chromium.org/8343066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
usage to Bind for Sync module
BUG=102167
TEST=unit_tests/regression
Review URL: http://codereview.chromium.org/8341117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98322
TEST=None
Review URL: http://codereview.chromium.org/8319008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we failed to startup, Stop() doesn't get called, so ensure we cleanup up
properly in StartDoneImpl.
BUG=102009
TEST=unit_tests
Review URL: http://codereview.chromium.org/8341091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8418026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107819 0039d316-1c4b-4281-b951-d872f2087c98
|