summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-0453-395/+459
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of data races on booleanstimurrrr@chromium.org2009-12-043-18/+19
| | | | | | | | | BUG=21468,22520 For the explanation why these are data races, see http://code.google.com/p/data-race-test/wiki/PopularDataRaces Review URL: http://codereview.chromium.org/251027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33825 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for 64-bit Windows build: base and chrome/appgregoryd@google.com2009-12-043-2/+8
| | | | | | | | | | | This is required to support Native Client on 64-bit Windows. Native Client will use a small 64-bit executable to load NaCl modules on 64-bit Windows. This 64-bit executable will use Chrome code, but some functionality has to be removed to minimize dependencies. This functionality may be enabled later if we decide that it is necessary. TEST=None BUG=28176 Review URL: http://codereview.chromium.org/371073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33823 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionApiTest.Bookmarks from DISABLED to FLAKY since it doesn'terikkay@chromium.org2009-12-041-1/+1
| | | | | | | | | | | crash. BUG=19866 TEST=ExtensionApiTest.Bookmarks Review URL: http://codereview.chromium.org/465034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33822 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: restore window size/position when hiding bookmark bar or download shelf.viettrungluu@chromium.org2009-12-043-34/+253
| | | | | | | | | | | | | | | This applies in particular when the bookmark bar or download shelf causes the window to grow at the top (due to there not being enough space at the bottom of the screen). Note that resizing or moving reset the state (* for moving it's a bit more subtle), so hiding afterwards will always shrink the window from the bottom. BUG=29192 TEST=(1) Navigate to a normal (non-NTP) page and hide bookmark bar; move window close to the bottom of the screen (keeping the window fully on-screen); Shift-Cmd-B to show the bookmark bar (which show grow maybe a bit downwards and then upwards); Shift-Cmd-B to hide it again; it should shrink from the top and from the bottom, restoring its original size/position. (2) Do the same but move the window away from the bottom of the screen after the first Shift-Cmd-B; now upon hiding it should only shrink at the bottom. (3) Check that if the window is far enough away from the bottom of the screen to begin with, then growing/shrinking only occurs at the bottom. (4) Do (1)-(3) for the download shelf (download something to show the shelf; then hide it by closing it). Review URL: http://codereview.chromium.org/465024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33821 0039d316-1c4b-4281-b951-d872f2087c98
* List the gcov symbols to get the mac code coverage bot happy.thomasvl@chromium.org2009-12-041-0/+17
| | | | | | | | TEST=code coverage bot doesn't compile fail on verify_order. BUG=none Review URL: http://codereview.chromium.org/464036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33820 0039d316-1c4b-4281-b951-d872f2087c98
* Check that frame has not been closed when getting DevToolsAgent.yurys@chromium.org2009-12-043-8/+20
| | | | | | | | | | Updated test expectations. The test that used to crash is failing on Linux(it is already expected to crash or fail on Win and Mac). BUG=29339 Review URL: http://codereview.chromium.org/460072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33819 0039d316-1c4b-4281-b951-d872f2087c98
* Manual review: add lighttpd since it is pulled via DEPSthomasvl@chromium.org2009-12-040-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33818 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark sync menu item use title case.pinkerton@chromium.org2009-12-041-6/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/468006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33817 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Check that frame has not been closed when getting DevToolsAgent." ↵yurys@chromium.org2009-12-042-19/+7
| | | | | | | | | | | Linux layout tests started failing for some reason: http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/14966/steps/webkit_tests/logs/stdio BUG=29339 TBR=pfeldman Review URL: http://codereview.chromium.org/466034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33816 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a test as flaky that failed for 1/2 of yesterday on one bot. Doing ↵thomasvl@chromium.org2009-12-041-0/+4
| | | | | | | | | | fine on others. BUG=28445 TEST=none Review URL: http://codereview.chromium.org/460071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33815 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.0.3sgjesse@chromium.org2009-12-041-1/+1
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/466032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33814 0039d316-1c4b-4281-b951-d872f2087c98
* Check that frame has not been closed when getting DevToolsAgent.yurys@chromium.org2009-12-042-7/+19
| | | | | | | | BUG=29339 Review URL: http://codereview.chromium.org/464033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33813 0039d316-1c4b-4281-b951-d872f2087c98
* Update test_expectations.txtukai@chromium.org2009-12-041-3/+0
| | | | | | | | | | | WebKit r51667 fixed the test. BUG=29251 TEST=none Review URL: http://codereview.chromium.org/466030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33809 0039d316-1c4b-4281-b951-d872f2087c98
* LayoutTests/fast/images/animated-svg-as-image.html is flaky in MAC DEBUG.yutak@chromium.org2009-12-041-1/+1
| | | | | | | | | | | | This test started to be flaky in MAC DEBUG at r33775. TBR=beng,cpu BUG=23560 TEST=none Review URL: http://codereview.chromium.org/462033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33808 0039d316-1c4b-4281-b951-d872f2087c98
* Split FTP LIST parsing code into individual files for each listing style.phajdan.jr@chromium.org2009-12-0421-1015/+1176
| | | | | | | | | | | | This turns out to be much better code organisation strategy. We're going to have even more parsers. TEST=Covered by net_unittests. BUG=25520 Review URL: http://codereview.chromium.org/465035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33807 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit to 51681.atwilson@chromium.org2009-12-042-2/+19
| | | | | | | | | | | Updated expectations accordingly. TBR=ajwong BUG=none TEST=none Review URL: http://codereview.chromium.org/462032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33806 0039d316-1c4b-4281-b951-d872f2087c98
* Downward drag after mouse-down is now causing bookmark bar folders to open, ↵zelidrag@google.com2009-12-045-2/+54
| | | | | | | | | | | | | | rather than drag. The bar folder can still be dragged in any other direction. Please note that this change is already reviews in http://codereview.chromium.org/463001, hence TBR field here. I needed to move to a different client to check it in. BUG=9016 TEST=Open bookmark bar. Select folder button and try to drag it down. Observe that now if dragged straight downward, the folder button will open its menu. TBR=sky Review URL: http://codereview.chromium.org/467017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33805 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in ICU @ 33767.jshin@chromium.org2009-12-041-1/+1
| | | | | | | | | | | | | | | | ( http://codereview.chromium.org/467013) Update am and sw locale data with the latest data collected. The last time I updated them (3 days ago), sw data was rather incomplete. Now, it's rather full. For Amharic, date formats are slightly changed per our Amharic linguist. While I'm at it, I'm fixing yet another bug in Korean data (which is rather conspicuous). BUG=25451 TEST=When Chrome is run in '--lang=sw' (or LANGUAGE=sw chrome on Linux), 1. Options | Under the hood | Fonts & Languages | Languages show most language names in Swahili. TBR=mal Review URL: http://codereview.chromium.org/460061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33804 0039d316-1c4b-4281-b951-d872f2087c98
* Adding instrument to NotificationRegistrar to checkhuanr@chromium.org2009-12-044-0/+42
| | | | | | | | | | | | | | | Add() and Remove() are called from same thread. Note I already checked in a fix for the bug. The CL is trying to check whether the issue exists in other code path. TEST=none BUG=27834 Review URL: http://codereview.chromium.org/449044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33802 0039d316-1c4b-4281-b951-d872f2087c98
* Add valgrind suppressions for FlipSession/FlipSessionPool leak.yutak@chromium.org2009-12-041-0/+18
| | | | | | | | | | TBR=mbelshe BUG=29392 TEST=none Review URL: http://codereview.chromium.org/467018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33801 0039d316-1c4b-4281-b951-d872f2087c98
* Enable remote fonts by default. This change introduces ↵yusukes@google.com2009-12-044-7/+7
| | | | | | | | | | | --disable-remote-fonts flag and obsoletes --enable-remote-fonts. BUG=17818 TEST=(1) Start chromium WITHOUT --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _remote_ fonts (reference image: http://www.alistapart.com/d/cssatten/poen.png ) / (2) Start chromium WITH --disable-remote-fonts. Visit http://www.alistapart.com/d/cssatten/poen.html . Verify that the page is rendered using _local_ fonts Review URL: http://codereview.chromium.org/165236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33800 0039d316-1c4b-4281-b951-d872f2087c98
* arm: Add thumb target and associated fixesjoel@chromium.org2009-12-042-10/+27
| | | | | | | | | | Add arm_thumb=1 to GYP_DEFINES to enable BUG=29203 Review URL: http://codereview.chromium.org/463027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33799 0039d316-1c4b-4281-b951-d872f2087c98
* Fix download dialog truncation in German locale.finnur@chromium.org2009-12-0453-4/+123
| | | | | | | | | BUG=23178 TEST=Requires manual inspection for text trunction on --lang=de (when closing Chrome while downloading) Review URL: http://codereview.chromium.org/465041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33798 0039d316-1c4b-4281-b951-d872f2087c98
* Improve reporting of subprocess crashes.asargent@chromium.org2009-12-0410-9/+75
| | | | | | | | | | | | | | | | | -Split extension renderer crashes out of the existing UMA renderer crash metric into its own metric. -Add a new metric for the sum of all ChildProcessHost crashes. -Add histograms for each crash type. BUG=28022 TEST=We should start getting more crash reports in UMA and histograms. Review URL: http://codereview.chromium.org/468005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33794 0039d316-1c4b-4281-b951-d872f2087c98
* Implement keyboard access between bookmarks and main toolbar.mhm@chromium.org2009-12-0412-315/+425
| | | | | | | | | | | | | | | | Allow ALT+SHIFT+T and TAB to traverse between bookmarks bar and main toolbar, same thing goes for SHIFT+TAB. Once any toolbar is focused, the arrow keys are used to traverse its children views. Any toolbar that needs to be traversable needs to extend "AccessibleToolbarView", that class will deal with all the toolbar accessibility needs such as handling ESC, Left/Right arrows, Enter, Drop downs, and traversals with Tab/Shift+Tab. There is one abstract method that the views who are extending this would need to implement if needed which allows the toolbar to skip views that are being traversed: bool IsAccessibleViewTraversable(views::View* view) BUG=25625 TEST=Test to see if the main toolbar and bookmarks bar is traversable. Review URL: http://codereview.chromium.org/333010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33793 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where FLIP sessions can crash if the connect fails.mbelshe@google.com2009-12-043-2/+58
| | | | | | | | | | | | | | Update the mocksocket so that we can test connection statuses. Verified that the test case crashes without the flip_session.cc fix. BUG=none TEST=FlipNetworkTransaction.ConnectFailure Review URL: http://codereview.chromium.org/462023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33792 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak reported in extensions_quota_service_unittest.cctim@chromium.org2009-12-042-7/+5
| | | | | | | | TBR=nick Review URL: http://codereview.chromium.org/468018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33791 0039d316-1c4b-4281-b951-d872f2087c98
* Minor docs fixgman@chromium.org2009-12-041-56/+57
| | | | | | Review URL: http://codereview.chromium.org/460065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33790 0039d316-1c4b-4281-b951-d872f2087c98
* Disable hindi-whitespace.html for now.atwilson@chromium.org2009-12-041-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33789 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the retarded broken check deps.mbelshe@google.com2009-12-041-0/+3
| | | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33786 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselined SVG test (win rebaseline does not suffice)atwilson@chromium.org2009-12-041-0/+18
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33785 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling more tests from last webkit roll.atwilson@chromium.org2009-12-041-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33784 0039d316-1c4b-4281-b951-d872f2087c98
* Add block-mask-overlay-image.html as failed testatwilson@chromium.org2009-12-041-0/+2
| | | | | | | TBR=ajwong Review URL: http://codereview.chromium.org/465050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33783 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 263.0 to 264.0chrome-bot@google.com2009-12-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33782 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaselining Linux tests.atwilson@chromium.org2009-12-042-0/+24
| | | | | | | | hamaji, I think this is correct - please confirm that this test is indeed passing now. TBR=hamaji git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33781 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetStringUTF16 to return string16 instead of std::wstring in bookmark ↵nick@chromium.org2009-12-041-4/+5
| | | | | | | | | | | | | manager. Patch by Thiago Farina <thiago.farina@gmail.com>. BUG=none TEST=none Review URL: http://codereview.chromium.org/460056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33780 0039d316-1c4b-4281-b951-d872f2087c98
* Actually, it looks like this causes flakiness on the Windowsojan@chromium.org2009-12-041-1/+1
| | | | | | | | | | | debug bots. The V8-Latest bots are release only. :( Once we get a better handle on http flakiness on Windows, we can try to shard the http tests again. Or, we could just shard them on linux/mac. For now, I'm just reverting to avoid leaving the tree in a bad state. Review URL: http://codereview.chromium.org/460064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GKURL SameGetters and Different Gettersukai@chromium.org2009-12-041-11/+9
| | | | | | | | | | | | | | | | WebKit r51589 fixed chromium's KURL::query() to match with original KURL. query() returns an empty string if query is specified but empty. (e.g. http://example.com/path?) query() returns a null string if query is not specified. (e.g. http://example.com/path) This is necessary to distinguish these two URLs. BUG=29212 TEST=test_shell_tests passes Review URL: http://codereview.chromium.org/462017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33778 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromium os build.estade@chromium.org2009-12-042-0/+7
| | | | | | Review URL: http://codereview.chromium.org/468016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33777 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to 51642, update expectations.atwilson@chromium.org2009-12-043-11/+25
| | | | | | Review URL: http://codereview.chromium.org/468015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33776 0039d316-1c4b-4281-b951-d872f2087c98
* Make the default RendererPreferences smarter.estade@chromium.org2009-12-0413-15/+37
| | | | | | | | | | | Change the default RenderViewHostDelegate::GetRendererPrefs to a singleton because initialization may not always be cheap (we assume copying is, however). BUG=29043 TEST=if you focus a link in an extension popup, you can actually see the focus ring (the focus ring had been set to 0x000000 color) Review URL: http://codereview.chromium.org/458013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33775 0039d316-1c4b-4281-b951-d872f2087c98
* Update another expectation to be more accurate.ojan@chromium.org2009-12-041-1/+3
| | | | | | Review URL: http://codereview.chromium.org/462029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33774 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the compiled o3djs libraries.gman@chromium.org2009-12-041-1/+1
| | | | | | | | | | | | | | | | | | | | The issue was that lineprimitves.js creates an object that inherits from something in primitives.js but because it appeared first in the compiled version the inherit command failed since the object it inherited from was not yet defined. It might be possible to make build_docs.py move all the inherit commands to the end of the compiled o3djs libs. I'll have to look into it. In the meantime here is a manual fix. Review URL: http://codereview.chromium.org/464030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33773 0039d316-1c4b-4281-b951-d872f2087c98
* Don't check deps for flip_server yet.mbelshe@google.com2009-12-041-0/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/467014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33772 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove hacky way the New Tab button is obtained from the nib.viettrungluu@chromium.org2009-12-045-14/+37
| | | | | | | | | | | | | | | I added a member variable and an accessor/mutator ... and hooked up that up in the nib. Changes to BrowserWindow.xib: hook up the New Tab button to |newTabButton| in TabBar. Unit test fixed. Previously committed at r33758, reverted at r33761. BUG=none TEST=Make sure it builds, runs, and that the New Tab button still works. Review URL: http://codereview.chromium.org/460058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33771 0039d316-1c4b-4281-b951-d872f2087c98
* Add ExtensionsQuotaService to limit abusive amounts of requeststim@chromium.org2009-12-0416-59/+1146
| | | | | | | | | | | | | | | | to mutating extension functions, as discussed on chromium-dev and in Extensions quotaserver design doc. Add a hook in the dispatcher to have the quota service assess the request. Wire up bookmarks.{create, move, remove, update} to the service. BUG=19899 TEST=ExtensionsQuotaServiceTest, QuotaLimitHeuristicTest (both new) Review URL: http://codereview.chromium.org/441006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33770 0039d316-1c4b-4281-b951-d872f2087c98
* Shard the svg directories as well. This should buy another ~20 secondsojan@chromium.org2009-12-041-1/+1
| | | | | | | on the dbg-3 test runners. Review URL: http://codereview.chromium.org/463024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33769 0039d316-1c4b-4281-b951-d872f2087c98
* Landing the open source version of the FLIP server.mbelshe@chromium.org2009-12-0424-0/+10105
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/463009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33766 0039d316-1c4b-4281-b951-d872f2087c98
* Revise run_webkit_test.PrepareListsAndPrintOutput() to keep accurate countsdpranke@google.com2009-12-041-22/+34
| | | | | | | | | | | | when we are sharding the tests. R=ojan@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/466029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33765 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 06:04:18 +0000