summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use ASCII strings for switch names.evan@chromium.org2009-10-1369-652/+679
| | | | | | Review URL: http://codereview.chromium.org/270062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: avoid a hang brought on by an infinite size-allocate queue.estade@chromium.org2009-10-132-3/+17
| | | | | | | | | | | This is not the most satisfying fix imaginable. I'm not sure why we are getting size-allocate events where the visibility of the chevron has changed but our allocation is not yet updated. In principle I suppose it would be better not to call any function that might cause an allocation from within a size-allocate handler, but guaranteeing that is probably pretty hard. BUG=24470 TEST=repro steps no longer repro; also, verified that the early return line is actually being hit. Review URL: http://codereview.chromium.org/270078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28778 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: draw the secure scheme color over the correct char range.estade@chromium.org2009-10-131-3/+5
| | | | | | | | | BUG=none TEST=go to gmail.com Review URL: http://codereview.chromium.org/272028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28777 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't dcheck when user dismisses print dialog.estade@chromium.org2009-10-131-0/+1
| | | | | | | | | BUG=none TEST=ctrl+p, escape in debug mode does not dcheck Review URL: http://codereview.chromium.org/272030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28776 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Select a row in Languages table when the user delete an item.mattm@chromium.org2009-10-132-5/+19
| | | | | | | | | | | | This is to work in the same way as in Windows version. BUG=None TEST=add some languages, remove them, should work fine. Review URL: http://codereview.chromium.org/270013 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28775 0039d316-1c4b-4281-b951-d872f2087c98
* linux: drop linux-specific CommandLine functionevan@chromium.org2009-10-134-14/+9
| | | | | | | | We can just call this from the appropriate constructor internally. Review URL: http://codereview.chromium.org/271051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28773 0039d316-1c4b-4281-b951-d872f2087c98
* Add some unimplemented methods from my last CL.michaeln@google.com2009-10-133-2/+43
| | | | | | | | | TEST=yes, appcache_storage_unittest.cc BUG=none Review URL: http://codereview.chromium.org/266042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28772 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup for theme provider code, including:pkasting@chromium.org2009-10-139-293/+246
| | | | | | | | | | | | | | | | | | | | | * Use correct indentation/alignment in a number of places * Use early-return to avoid long code block indenting * Use for() instead of while() in cases where that's what the code is actually doing * Consistent naming for iterators ("foo_iter", "bar_iter" instead of sometimes that way and sometimes "found") * Use {} when needed, don't use when not * Do not use "else" after "return" * Shorten overly-verbose code * Pull some trivial functions into the header * Eliminate unused function * Use STLDeleteValues() helper where appropriate Some of this was originally in my patch that modified constness, but I've split it out to make that more sane. BUG=none TEST=none Review URL: http://codereview.chromium.org/272033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28771 0039d316-1c4b-4281-b951-d872f2087c98
* Use full pathname to perf_expectations in test.chase@chromium.org2009-10-131-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28770 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to purge memory to the ProxyResolver.pkasting@chromium.org2009-10-139-3/+79
| | | | | | | | BUG=23400 TEST=none Review URL: http://codereview.chromium.org/272018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28769 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28716 - Gets blocked popups to work on views/gtk. I had to fix a ↵nsylvain@chromium.org2009-10-138-235/+133
| | | | | | | | | | | | | | | | | | | | | | | couple of additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/261051 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/267069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28768 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed lame typo.oshima@chromium.org2009-10-131-2/+2
| | | | | | | | | | | | Doh, I forgot that linux try bot does not compile this file. BUG=None TEST=compiled with chromeos=1 TBR=sky Review URL: http://codereview.chromium.org/269061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28767 0039d316-1c4b-4281-b951-d872f2087c98
* Doesn't run the TestStressDrawShapes test on IE, because selenium/ie is too ↵kkania@google.com2009-10-131-1/+2
| | | | | | | | slow (IE6 5-10 min). Review URL: http://codereview.chromium.org/272034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28766 0039d316-1c4b-4281-b951-d872f2087c98
* This removes the command buffer tests from the non-command buffergspencer@google.com2009-10-132-15/+23
| | | | | | | | builds because they fail with the current version of nacl, and Al is busy making command buffer code that doesn't use nacl anyhow. Review URL: http://codereview.chromium.org/266057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28765 0039d316-1c4b-4281-b951-d872f2087c98
* include CHROMEOS files and defintions in TOOLKIT_VEIWS build.oshima@chromium.org2009-10-1211-18/+59
| | | | | | | | | | | | | | | | | * changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1 * changed to define OS_CHROMEOS when toolkit_views==1 * changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1 I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow from xid. Looks like I need to register it somewhere Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine. BUG=none TEST=run views unit test and browser. Review URL: http://codereview.chromium.org/262027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
* Add explicit dependency to x11. This comes from webkit as well, but ↵oshima@chromium.org2009-10-121-1/+1
| | | | | | | | | | | | | views/gtk depends on this, and a program that uses views without webkit fails to link. BUG=None TEST=None Review URL: http://codereview.chromium.org/270054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28763 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a CopyRecursiveDirNoCache to use FilePaths insteadtony@chromium.org2009-10-128-39/+34
| | | | | | | | | of wstrings. Also convert template_user_data_ in UITest to be a FilePath. Review URL: http://codereview.chromium.org/273021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28762 0039d316-1c4b-4281-b951-d872f2087c98
* Enables the sending of Timeline Agent and Resource messages to the devtools ↵jamesr@chromium.org2009-10-1217-67/+135
| | | | | | | | api in extensions. Review URL: http://codereview.chromium.org/267013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28761 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePaths in chrome_url_data_manager.evan@chromium.org2009-10-122-14/+14
| | | | | | | | | BUG=24672 TEST=still compiles Review URL: http://codereview.chromium.org/267065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28760 0039d316-1c4b-4281-b951-d872f2087c98
* Make the timeout for tests that need to be marked as SLOW be 2X inojan@chromium.org2009-10-121-34/+53
| | | | | | | | | debug mode. There's a lot of tests that are only slow in DEBUG mode. While it would be good to address them, it's really just not worth the maintenance headache. Review URL: http://codereview.chromium.org/267057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28759 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old NTParv@chromium.org2009-10-127-1073/+5
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/271057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28758 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bubble demo use the command buffer structs.gman@google.com2009-10-123-375/+242
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Please chime in on how you would like this changed. Issues *) should I delete the old nacl setup code? Basically I commented out the old NaCl initialization code and then copied the initialization code from big_test. My understanding is whatever the old way was is no longer current. If I don't delete the old code should I go through the trouble of separating the common code "bubble_demo" from the setup code? I'd prefer to just leave it as is and let someone who knows the nacl stuff better to fix it. *) How do I make it build correctly and also for gyp? Also I'm not sure how to build it correctly. The build.scons works but I get warnings like: scons: warning: Two different environments were specified for target cross\buffer_sync_proxy.obj, but they appear to have the same action: $CXX $_MSVC_OUTPUT_FLAG /c $CHANGED_SOURCES $CXXFLAGS $CCFLAGS $_CCCOMCOM File "C:\src\o3d_spud\o3d\site_scons\site_tools\component_builders.py", line 249, in ComponentLibrary Review URL: http://codereview.chromium.org/251052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28757 0039d316-1c4b-4281-b951-d872f2087c98
* TBR=dglazkovhclam@chromium.org2009-10-123-27/+11
| | | | | | | | | | - Roll WebKit to r49473 - Re-enable failing ui_tests due to last roll - Remove some failing layout tests expectations Review URL: http://codereview.chromium.org/267060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28755 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DLOG error to the command buffer and removegman@google.com2009-10-128-69/+173
| | | | | | | | | | | | | | | | | a little of the macro magic. Also, fix the build. Renderer_cb was missing some functions. I seems like it would be really good if we could add something like this to the non-debug version because developers need an easy way to check for errors. Maybe these errors can go to the chrome error console or something, at least in chrome. Review URL: http://codereview.chromium.org/267061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28753 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: rejigger how initialization works.evan@chromium.org2009-10-126-75/+70
| | | | | | | | | | I'm attempting to clean up CommandLine. This change rearranges how initialization is done. I am trying to eliminate redundant functions; more will come in subsequent changes. Review URL: http://codereview.chromium.org/273018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28752 0039d316-1c4b-4281-b951-d872f2087c98
* In a signal handler, call _exit, not exit.jrg@chromium.org2009-10-121-1/+4
| | | | | | | | | | | | | | | | | I found a case of renderers trying to die in a signal handler but a corrupt heap (and some atexit() handlers installed by XmlSomething) made us hang forever. BUG=http://crbug.com/23590, http://crbug.com/23919, http://crbug.com/22287 (maybe) It isn't clear this fixes any known renderer hangs (e.g. the bugs above) but it's a step in the right direction. TEST=no known way to reliably hit this state. Review URL: http://codereview.chromium.org/261059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28750 0039d316-1c4b-4281-b951-d872f2087c98
* Status bubbles should wait before showing and hiding, and should fade in andmark@chromium.org2009-10-123-56/+665
| | | | | | | | | | | | | | | | | | | | | | | out on the Mac. This fixes the fades, which were actually written but unfortunately not working due to a silly bug. It also adds the delays, cleaning up a TODO. It fixes some questionable logic ("hide by calling Hide() and then FadeIn()"). Finally, it allows better reuse of the status bubble NSWindow, and fixes a bug that prevented the status bubble window from properly attaching to its parent window if the parent was offscreen at attachment time. Unit tests for the new behavior are included, and as a bonus, I've added better testing for some existing behavior. See http://dev.chromium.org/user-experience/status-bubble for the design of the status bubble. Also, consult chrome/browser/views/status_bubble_views.cc for the implementation used on Windows. BUG=24495 TEST=Mouse over some links Review URL: http://codereview.chromium.org/269045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28749 0039d316-1c4b-4281-b951-d872f2087c98
* Configure git-cl hooks based on git-cl-upload-hook.chase@chromium.org2009-10-121-0/+2
| | | | | | | | | | BUG=5339 TEST=git cl config downloads and installs configured hooks Review URL: http://codereview.chromium.org/257070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28748 0039d316-1c4b-4281-b951-d872f2087c98
* Use size_t rather than uint32 in a few more placesmbelshe@chromium.org2009-10-122-4/+4
| | | | | | | | | | | to fixup some warnings. BUG=none TEST=none Review URL: http://codereview.chromium.org/274009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28747 0039d316-1c4b-4281-b951-d872f2087c98
* Changes assertMatrix to call get_eval per matrix instead of per every value ↵kkania@google.com2009-10-122-8/+10
| | | | | | | | in the matrix, in order to fix RotateModel test on ie6. Review URL: http://codereview.chromium.org/271062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28746 0039d316-1c4b-4281-b951-d872f2087c98
* Disable nested message loops in Mac for now. There seems to be a problem ↵jam@chromium.org2009-10-122-0/+7
| | | | | | | | | with the message pumping or IPC channel where the sent reply from the browser doesn't make it to the renderer main thread. BUG=24337 Review URL: http://codereview.chromium.org/273023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28745 0039d316-1c4b-4281-b951-d872f2087c98
* More gypbuild infrustructure.gman@google.com2009-10-121-21/+95
| | | | | | | | | | | | | No idea if this is the best structure or the correct options but I have to start somewhere. If you have better ideas speakup or start editing :-D If there is a way to get gpy to list the targets please tell me so I can call it. Review URL: http://codereview.chromium.org/242068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28744 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed data race between GetDatabase and CheckURL at startup.erikkay@chromium.org2009-10-127-58/+23
| | | | | | | | | | | Also did a bit of code cleanup. BUG=11106 TEST=use tsan on ViewSourceTest.DoesBrowserRenderInViewSource Review URL: http://codereview.chromium.org/273020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28743 0039d316-1c4b-4281-b951-d872f2087c98
* Step 2 in porting disk cache to using FilePath.tony@chromium.org2009-10-1210-19/+41
| | | | | | | | BUG=24444 Review URL: http://codereview.chromium.org/270066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28742 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for canvas.drawBitmapgman@google.com2009-10-124-6/+9
| | | | | | Review URL: http://codereview.chromium.org/269055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28741 0039d316-1c4b-4281-b951-d872f2087c98
* Separated CommandBuffer and GPUProcessor into separate static library so O3D ↵apatrick@google.com2009-10-121-32/+38
| | | | | | | | | | | can link against it in the interim. TEST=none BUG=none Review URL: http://codereview.chromium.org/255098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28740 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to reflect failureshclam@chromium.org2009-10-121-1/+1
| | | | | | | | | | | TBR=darin The following test crashes on linux: LayoutTests/http/tests/xmlhttprequest/web-apps/012.html Review URL: http://codereview.chromium.org/267058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28739 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a layout test as crashhclam@chromium.org2009-10-121-0/+1
| | | | | | | | | | TBR=darin LayoutTests/fast/events/invalid-001.html crashes on windows, mark it so. Review URL: http://codereview.chromium.org/271059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28737 0039d316-1c4b-4281-b951-d872f2087c98
* Mark some more WorkerTest as failhclam@chromium.org2009-10-121-2/+4
| | | | | | | | | | | | TBR=darin BUG=24652 WorkerTest.MultipleWorkers and WorkerTest.LimitPerPage are failing too. Review URL: http://codereview.chromium.org/270071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28736 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some more tests in WorkerTesthclam@chromium.org2009-10-121-3/+6
| | | | | | | | | | | | | TBR=darin These tests are failing on xp and vista: WorkerTest.SingleWorker WorkerTest.WorkerFastLayoutTests WorkerTest.WorkerXhrHttpLayoutTests Review URL: http://codereview.chromium.org/269056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28735 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "[Mac] Add breakpad info for crashes in the target/action dispatcher."shess@chromium.org2009-10-121-47/+0
| | | | | | | | | | Breaks the Release compile somehow. Sigh. TBR=michaeln,mmoss Review URL: http://codereview.chromium.org/266053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28734 0039d316-1c4b-4281-b951-d872f2087c98
* Disable WorkerTest.LimitTotalhclam@chromium.org2009-10-121-1/+2
| | | | | | | | | | | | TBR=darin BUG=24652 WorkerTest.LimitTotal starts to fail consistently after WebKit merge 40414:49432, disable it. Review URL: http://codereview.chromium.org/272031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28733 0039d316-1c4b-4281-b951-d872f2087c98
* Layout test results and style fix in webkit/api/srchclam@chromium.org2009-10-122-7/+10
| | | | | | | | | | TBR=darin Some tests are failing in win and mac, mark them so. Review URL: http://codereview.chromium.org/270070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28732 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add breakpad info for crashes in the target/action dispatcher.shess@chromium.org2009-10-121-0/+47
| | | | | | | | | | | | | | | -[NSApplication sendAction:to:from:] is a central dispatcher for target-action messages sent by controls. Backtraces from here often contain only Cocoa messages, making it hard to tell where things are at when a freed target gets messaged. Add additional info like the action being requested and the tag of the sender. http://crbug.com/24460 TEST=Browser continues to work. Review URL: http://codereview.chromium.org/269039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28731 0039d316-1c4b-4281-b951-d872f2087c98
* First version of pepper api implementation:sehr@google.com2009-10-127-34/+665
| | | | | | | | | | | | | | | Adds a severely pared down version of webplugin_delegate files that are not currently used to create any instances. Also adds calls for render APIs that remain to be connected to the impelementation. The function pointers are returned by NPN_GetValue calls with new enumerated values. I have also added Nicholas' NPEvent definitions. These changes are to permit further collaboration between sehr, brettw, and cpu. Review URL: http://codereview.chromium.org/270024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28730 0039d316-1c4b-4281-b951-d872f2087c98
* Converts some uses of native_view to native_window. This is necessitatedsky@chromium.org2009-10-1248-149/+118
| | | | | | | | | | | | by wanting to parent bookmarkeditor to browserwindow, which returns a native_window. BUG=none TEST=none Review URL: http://codereview.chromium.org/270067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28728 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to r49432hclam@chromium.org2009-10-123-3/+33
| | | | | | | | | | | TBR=darin Also provide stub method for GraphicsContext3D::getActiveAttrib() and GraphicsContext3D::getActiveUniform(). Review URL: http://codereview.chromium.org/274006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28727 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old data, once we are not using it.fbarchard@chromium.org2009-10-122-2/+0
| | | | | | Review URL: http://codereview.chromium.org/270045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28726 0039d316-1c4b-4281-b951-d872f2087c98
* Make function definition order (.cc) match function declaration order (.h). ↵pkasting@chromium.org2009-10-121-399/+399
| | | | | | | | | | No code changes. BUG=none TEST=none Review URL: http://codereview.chromium.org/267055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28725 0039d316-1c4b-4281-b951-d872f2087c98
* AppendText was appending twice due to bad merge happened in the past.oshima@chromium.org2009-10-122-5/+8
| | | | | | | | | | | Added append scenario to view_examples BUG=None TEST=run unit_tests and verify with view_examples. Review URL: http://codereview.chromium.org/271055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28724 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 05:39:11 +0000