summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add a unit test to mac build.ericroman@google.com2008-12-202-6/+19
| | | | | | Review URL: http://codereview.chromium.org/15090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7339 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my CL to fix build bustage.jcampan@chromium.org2008-12-2040-3135/+2633
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/15099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7338 0039d316-1c4b-4281-b951-d872f2087c98
* For non-detached processes, manually read and print out stdout and stderr.erikkay@google.com2008-12-201-1/+31
| | | | | | | | | | | | By default, the subprocess is supposed to inherit these from its parent, however when run under buildbot, it seems unable to read data from a grandchild process, so we have to read the child and print the data as if it came from us for buildbot to read it. We're not sure why this is necessary. Review URL: http://codereview.chromium.org/15092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7337 0039d316-1c4b-4281-b951-d872f2087c98
* This CL moves the different resource handlers from ↵jcampan@chromium.org2008-12-2040-2633/+3135
| | | | | | | | | | | | | | | | resource_dispatcher_host.cc into their own files, into a new renderer_host directory. Their is no functionality change in this CL. The motivation for doing that was: - resource_dispatcher_host.cc has become very long and more than 1/3 of the code is for the resource handler. - having the resource handler in their own file allows having unit tests for them. BUG=none TEST=run all unit tests and UI tests. Review URL: http://codereview.chromium.org/14487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7336 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed two layout tests.estade@chromium.org2008-12-203-4/+1
| | | | | | | | | * get-set-properties: updated baseline that had been outdated by webkit change r39097 * document-open-return-value: changed document.open() to return this rather than null as per https://bugs.webkit.org/show_bug.cgi?id=14968 Review URL: http://codereview.chromium.org/14877 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7333 0039d316-1c4b-4281-b951-d872f2087c98
* tests failing on wintc@google.com2008-12-201-0/+3
| | | | | | | | | | | these pass on windows, dunno what's wrong. TBR=eroman Review URL: http://codereview.chromium.org/15094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7331 0039d316-1c4b-4281-b951-d872f2087c98
* The unit test WebContentsTest.ShowInterstitialProceedMultipleCommands was ↵jcampan@chromium.org2008-12-191-5/+49
| | | | | | | | | | | | crashing. This was caused by a class dereferencing a pointer to a local variable out of the scope of the local var, trashing the stack. BUG=5700 TEST=Run the unit tests. Review URL: http://codereview.chromium.org/14909 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7330 0039d316-1c4b-4281-b951-d872f2087c98
* Updates tests_fixable to indicate a couple of bugs have been filed.sky@google.com2008-12-191-2/+2
| | | | | | | | I know why these ones are failing, just haven't finalized the right thing. Review URL: http://codereview.chromium.org/14905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7328 0039d316-1c4b-4281-b951-d872f2087c98
* remove wrong baselinestc@google.com2008-12-1922-105/+3
| | | | | | | | | | | | We used to output the path data incorrectly (missing spaces between numbers) and checked in baselines with the wrong output. Remove the wrong output and either mark the test as passing or add a comment to the tests_fixable list. Review URL: http://codereview.chromium.org/14910 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7326 0039d316-1c4b-4281-b951-d872f2087c98
* De-basify SkiaFontwindglazkov@google.com2008-12-191-7/+15
| | | | | | Review URL: http://codereview.chromium.org/15091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7325 0039d316-1c4b-4281-b951-d872f2087c98
* Use appropriate version of delete in storage blockrvargas@google.com2008-12-192-6/+15
| | | | | | | | | | | depending on how storage was allocated. B=5041 Review URL: http://codereview.chromium.org/15032/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7324 0039d316-1c4b-4281-b951-d872f2087c98
* Split ProxyResolver into two interfaces: A. interface for retrieving the ↵ericroman@google.com2008-12-1921-228/+277
| | | | | | | | system proxy settings (ProxyConfigService) B. interface for resolving the proxy (ProxyResolver)The motivation behind this change is: 1. Simplify sharing the WinHTTP code that fetches IE settings, with the V8 proxy resolver (avoids having platform-specific code in ProxyResolverV8). 2. Restrict objects to one thread. (ProxyService calls the config getter on IO thread, and the proxy resolving on the PAC thread).(ProxyResolver is now only 1 method, but this will grow shortly). Review URL: http://codereview.chromium.org/15070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7323 0039d316-1c4b-4281-b951-d872f2087c98
* After staring at this line of code I realized it was saying something much ↵pkasting@chromium.org2008-12-191-3/+1
| | | | | | | | simpler. Review URL: http://codereview.chromium.org/14904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7322 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing files from previous checkin.brettw@google.com2008-12-192-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7321 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7318.brettw@google.com2008-12-1910-135/+165
| | | | | | Review URL: http://codereview.chromium.org/14903 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7320 0039d316-1c4b-4281-b951-d872f2087c98
* Implement command line switch to allow using a FIFO or a socketpair() for ↵jeremy@chromium.org2008-12-196-33/+169
| | | | | | | | IPC on POSIX. Review URL: http://codereview.chromium.org/14863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7319 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7317.brettw@google.com2008-12-1910-164/+135
| | | | | | Review URL: http://codereview.chromium.org/15089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7318 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base dependencies in the Windows-specific skia/ext code.brettw@google.com2008-12-1910-135/+164
| | | | | | Review URL: http://codereview.chromium.org/14900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7317 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on base/string_util.h, and rename some methods to betterdarin@chromium.org2008-12-191-10/+17
| | | | | | | | | | match WebKit style. R=brettw Review URL: http://codereview.chromium.org/15058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7316 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent a crash when a popup menu is closing.estade@chromium.org2008-12-191-1/+0
| | | | | | | | See http://codereview.chromium.org/13214 Review URL: http://codereview.chromium.org/14884 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7315 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line flag to the Purify script to allow skippingpaulg@google.com2008-12-191-3/+6
| | | | | | | the chrome.dll re-instrumentation step when running tests manually. Review URL: http://codereview.chromium.org/15085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7313 0039d316-1c4b-4281-b951-d872f2087c98
* Changing which installation the Channel Changer uses.finnur@google.com2008-12-191-23/+37
| | | | | | | | | If System-level Chrome is installed, Channel Changer will choose that. If not found, it will look for User-level Chrome and update that. Review URL: http://codereview.chromium.org/15084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7312 0039d316-1c4b-4281-b951-d872f2087c98
* plumb missing image code through the chrome bridge. Use the .gif version ↵pinkerton@google.com2008-12-196-71/+67
| | | | | | | | instead of the .tiff version. Point testShell at the resources folder rather than the source tree for loading resources on Mac. Move ImageMac.cpp into the chromium port and give it a new name. Review URL: http://codereview.chromium.org/14893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7310 0039d316-1c4b-4281-b951-d872f2087c98
* update linux test results, these tests are flaky.tc@google.com2008-12-191-0/+2
| | | | | | | | | TBR=evanm Review URL: http://codereview.chromium.org/14895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7309 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7304 to reapply 7296. It wasn't its fault.maruel@chromium.org2008-12-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/15083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7308 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7306 to reapply 7296. It wasn't its fault.maruel@chromium.org2008-12-191-0/+1
| | | | | | Review URL: http://codereview.chromium.org/15603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7307 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to force a build. NO CODE CHANGE.maruel@chromium.org2008-12-191-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7306 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7296.maruel@chromium.org2008-12-191-4/+4
| | | | | | | | From http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Reliability There is a clear increase of crashes after this change. It really seems like a heap overflow but it's hard to tell. Reverting to see if it helps the reliability tests. If not, we can reapply this change and find another culprit. Review URL: http://codereview.chromium.org/15081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7304 0039d316-1c4b-4281-b951-d872f2087c98
* fix some more mac tests by rebasing v8 vs. JSC differencespinkerton@google.com2008-12-193-0/+61
| | | | | | Review URL: http://codereview.chromium.org/15080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7302 0039d316-1c4b-4281-b951-d872f2087c98
* Changes docking behavior to not offer a maximize drop target if theresky@google.com2008-12-192-8/+35
| | | | | | | | | | | | | | | | | is a maxmized tabbed browser on the monitor already. I don't feel this is the right long term behavior, but until we figure that out I'm going with this. BUG=4878 TEST=maximize a tabbed browser, drag a tab out of the tabbed browser toward the top of the screen and make sure you aren't offered a dock target. Now restore the tabbed browser, drag a tab toward the top of the screen and make sure you are offered a maximized drop target. Review URL: http://codereview.chromium.org/14858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7301 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we wouldn't necessarily start throbber timer on dropsky@google.com2008-12-191-0/+7
| | | | | | | | | | | | | | | | of a tab if the page was loading. The fix is to call LoadingStateChanged, which makes sure everything is in sync and the timer is running (if necessary). BUG=2524 TEST=Create two windows. In one of the windows load a page that takes a long time to load. Drag the tab into the first window and make sure when the tab snaps to the final position the throbber starts appropriately. Review URL: http://codereview.chromium.org/15056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7300 0039d316-1c4b-4281-b951-d872f2087c98
* Ignoring test for the BOM characters. We've decided to be compatible witholehougaard@google.com2008-12-192-3/+6
| | | | | | | Firefox and IE here. Review URL: http://codereview.chromium.org/14891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7299 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to initialize the proxy before using it's dom constructorager@google.com2008-12-191-0/+2
| | | | | | | map. Review URL: http://codereview.chromium.org/15074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7298 0039d316-1c4b-4281-b951-d872f2087c98
* Initial generation of native Visual Studio solution filessgk@google.com2008-12-1998-2817/+4984
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (project files still to come). To wit: * Solution file configuration is in *_sln.scons files (base\base_sln.scons, chrome\chrome_sln.scons). * Individual Project file configuration is in the the .scons file for the relevant target (base\base_unittests.scons, third_party\libxml\libxml.scons, etc.)--that is, where their file lists will live. * MSVSProject() calls are currently placeholders that establish the existence of Project Nodes (and Project dependencies) but don't yet have actual Project configuration information (file lists, .vsprops, etc.). * Configuraiton is very manual. In particular, the entries in the .sln file will be written out in exactly the order specified in the configuration(s). The current ordering is taken from our existing .sln files, so we can generate virtually the same configurations on output. * Generated solution files are nearly byte-for-byte identical with our existing .sln files, modulo: * net\dump_cache has a WebsiteProperties sections (making that configurable per project isn't important right now); * sandbox\sandbox.sln was missing a dependency of base.vcproj on on debug_message.vcproj (present in other .sln files) * webkit\webkit.sln was missing dependencies of WebCore.vcproj on libxml_config.vcproj and libxslt_config.vcproj (present in chrome.sln); * add a handful of other miscellaneous missing dependencies on various .vcproj definitions in chrome.sln (present in other .sln files). * remove stats_viewer.csproj from chrome.sln (sorry, mbelshe), which was complicating the solution configuration with unnecessary (for us) "Mixed Platform" types; * All MSVSFolder(), MSVSProject() and MSVSSolution() calls have hard-wired guid= values taken from our existing configuration, so we can: 1) verify generation of working configs; 2) minimize diffs when checking in generated .sln files. We can remove these in the future in favor of extracting them from existing .sln files if we wish. * Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution() wrappers to chromium_builders.py, that gate the underlying call to the env.MSVS*() builders based on whether env.Bit('msvs') is set (i.e., we're in --mode=msvs). * Remove platform-specific gating of to-be-ported .scons files that we now need to load on any platform to generate coheren MSVS files. Move the env.Bit('windows') tests for actually building their executables into the individual .scons files. Review URL: http://codereview.chromium.org/14472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
* Switched dns_global.cc over to UTF-8 strings.scherkus@chromium.org2008-12-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/15065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7296 0039d316-1c4b-4281-b951-d872f2087c98
* Documenting the current status of a few layout tests.olehougaard@google.com2008-12-191-1/+3
| | | | | | Review URL: http://codereview.chromium.org/15034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7295 0039d316-1c4b-4281-b951-d872f2087c98
* Select the Languages tab of the fonts and languages dialog when using ↵pkasting@chromium.org2008-12-195-12/+37
| | | | | | | | spellcheck context menu commands to change spellchecking options. Patch by Mohamed Mansour, r=me,sky; see http://codereview.chromium.org/15031. Tweaked by me. BUG=5639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 3 erroneous layout test baselines on linux.estade@chromium.org2008-12-197-6/+3
| | | | | | | | Guess these slipped through. The new baselines not only pass but also look a lot closer to the windows baselines (i.e., only some font glyph differences). Review URL: http://codereview.chromium.org/14880 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7287 0039d316-1c4b-4281-b951-d872f2087c98
* We need to add UI test for "Encoding" menu to avoid regression.jnd@google.com2008-12-199-27/+312
| | | | | | | | | | | | | | | | | | | For this purpose, I have created several methods in automation API. They can be used for the above UI tests. 1 get the current used encoding name of the page in the specified tab. 2 get value of the encoding auto detection option. 3 enables and disable the encoding auto detection. 4 use the specified encoding to override the encoding of the page in the specified tab. BUG=5515 The corresponding UI test is coming soon Review URL: http://codereview.chromium.org/14162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7286 0039d316-1c4b-4281-b951-d872f2087c98
* Add a filter for ui_tests that don't (yet) work under Purify.paulg@google.com2008-12-191-0/+9
| | | | | | Review URL: http://codereview.chromium.org/14879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7285 0039d316-1c4b-4281-b951-d872f2087c98
* The WebContentsTest.ShowInterstitialProceedMultipleCommands unit test seem ↵jcampan@chromium.org2008-12-191-1/+2
| | | | | | | | | | | | | | | to crash on the "XP Test" build bot and has been temporarily disabled. Not sure yet why it crashes, I cannot repro locally and Purify is not reporting any memory errors. Disabling it temporarily. BUG=5700 Review URL: http://codereview.chromium.org/14876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7284 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SessionStartupPref to use UTF-8 strings.scherkus@chromium.org2008-12-191-2/+2
| | | | | | Review URL: http://codereview.chromium.org/14875 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7283 0039d316-1c4b-4281-b951-d872f2087c98
* Updated HtmlDialogContents to use UTF-8 strings.scherkus@chromium.org2008-12-191-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7282 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/14809jcampan@chromium.org2008-12-1938-1601/+1099
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7281 0039d316-1c4b-4281-b951-d872f2087c98
* Add the CertVerifier class. It is based on thewtc@google.com2008-12-193-3/+208
| | | | | | | | | | HostResolver class. It's not being compiled yet. R=eroman BUG=3592 Review URL: http://codereview.chromium.org/14868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7280 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium half of the WebKit merge from 39335 to 39369.pamg@google.com2008-12-195-6/+21
| | | | | | Review URL: http://codereview.chromium.org/15404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7279 0039d316-1c4b-4281-b951-d872f2087c98
* Added the new isCommandEnabled() layout test function to the layout test ↵estade@chromium.org2008-12-186-2/+29
| | | | | | | | | | controller. Fixes one new layout test. Review URL: http://codereview.chromium.org/14871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7277 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork CachedPage for Linux builddglazkov@google.com2008-12-182-2/+1
| | | | | | Review URL: http://codereview.chromium.org/15068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7276 0039d316-1c4b-4281-b951-d872f2087c98
* green linux buildertc@google.com2008-12-183-1/+3
| | | | | | | | | | | | | | Add a new baseline for basic-shadows.html, it passes the fuzzer. Update beforeSelectorOnCodeElement.html which crashes on the buildbot. TBR=evan Review URL: http://codereview.chromium.org/14872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7274 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 4222: Clear data dialog has new fields, butfinnur@google.com2008-12-1849-52/+52
| | | | | | | | | | | | | size has not increased in non-US locales. While verifying on all locales, I noticed three locales that had this dialog wider than others and I shrunk those too. Those were locales: el, fil and sv. Review URL: http://codereview.chromium.org/15066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7273 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 07:47:40 +0000