| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest.
Rename HttpStreamFactory to HttpStreamFactoryImpl.
Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here).
Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist.
Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness.
I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup.
BUG=54371,42669
TEST=unit tests
Review URL: http://codereview.chromium.org/6543004
TBR=willchan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename StreamFactory and StreamRequest to HttpStreamFactory and HttpStreamRequest.
Rename HttpStreamFactory to HttpStreamFactoryImpl.
Create HttpStreamFactoryImpl::Request (inherits from HttpStreamRequest) and HttpStreamFactoryImpl::Job (most of the old HttpStreamRequest code, other than the interface, moved here).
Currently there is still a strong binding within HttpStreamFactoryImpl between requests and jobs. This will be removed in a future changelist.
Note that due to the preparation for late binding, information like HttpRequestInfo and SSLConfig and ProxyInfo are just copied. It's possible we can consider refcounting them to reduce copies, but I think it's not worth the effort / ugliness.
I also did some minor cleanups like moving SpdySettingsStorage into SpdySessionPool and some CloseIdleConnections() cleanup.
BUG=54371,42669
TEST=unit tests
Review URL: http://codereview.chromium.org/6543004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This speeds up chromeos builds by a little bit because then we don't need to compile gtest/gmock and makes for faster iterations because we don't need to relink the views tests all the time.
BUG=none
TEST=touch a file in base, make chrome, check that views_unittests doesn't get build
Review URL: http://codereview.chromium.org/6542073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/.
I'll updated the references and delete the stub files later.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigate chrome to
the correct URL to ensure that scripts on the page see the correct URL. This functionality
regressed when the protocol sink patch landed.
Fix is to read the URL from the ProtData object which wraps the underlying protocol sink,
when our active document loads.
Removed stale code from the Chromeframe moniker patch which eventually needs to go.
Fixes bug http://code.google.com/p/chromium/issues/detail?can=2&q=71860
BUG=71860
TEST=As described in the bug.
Review URL: http://codereview.chromium.org/6469103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome-extension:// pages.
BUG=72523
TEST=ExtensionApiTest.Capture*
Review URL: http://codereview.chromium.org/6534005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69316
TEST=See bug.
Review URL: http://codereview.chromium.org/6520014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Picks up:
r894: make: use 4 threads for linking if the linker supports it
Review URL: http://codereview.chromium.org/6538101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
rest in another cl.
TBR=avi
Review URL: http://codereview.chromium.org/6538100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
os before login).
This is a workaround until http://code.google.com/p/chromium/issues/detail?id=73768 is fixed.
BUG=73658
TEST=with chromeos=1 build, go to any site and check no crash.
Review URL: http://codereview.chromium.org/6544023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tracking work properly when initiated by a click on the chevron button.
BookmarkBarController unit tests are happy with the change.
BUG=59868
TEST=Click on the chevron button, then track onto other bookmark bar buttons and bookmark bar folder buttons, rapidly becoming amazed that everything actually works now.
Review URL: http://codereview.chromium.org/6541075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Dead code cleanup.
BUG=none
TEST=Unit tests.
Review URL: http://codereview.chromium.org/6542007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a ChromeDriver commandline argument for specifying a custom dir.
Switch to using ProxyLauncher directly instead of inheriting from UITestBase.
BUG=56865
TEST=none
Review URL: http://codereview.chromium.org/6469085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Picks up:
r893: make: test for ar's "T" flag at gyp time
r892: Switching off external makefile (which requires cygwin on windows).
r891: Disabling failing scons tests so we notice regressions.
Review URL: http://codereview.chromium.org/6541081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/78541.
BUG=73055,73059
TEST=none
Review URL: http://codereview.chromium.org/6525059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is launched.
This is so that a renderer that was previously sending messages to the browser regarding a particular GPU process, it can be informed that a new one has been launched and that it has to start over. This part is not done yet.
Both GpuProcessHost and GpuProcessHostUIShim are now identified by a common host ID. Neither are singletons.
This is also a step towards allowing multiple GPU processes.
TEST=trybots, check WebGL and 3D CSS work, check terminating Chrome works while running WebGL, check --single-process works, checking terminated GPU process is relaunched and that 3D CSS restarts automatically
BUG=none
Review URL: http://codereview.chromium.org/6473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
--enable-accelerated-plugins. --enable-accelerated-layers is not needed anymore.
Review URL: http://codereview.chromium.org/6546071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was failing on check_perms. Check http://build.chromium.org/p/chromium/builders/Linux/builds/3520 for more info.
BUG=None
TEST=BrowserInitTest.*
Review URL: http://codereview.chromium.org/6543006
TBR=skerner@google.com
Review URL: http://codereview.chromium.org/6469100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't include the container type ("vector") in the typedef for "a bunch of children". Users generally should not know or care what the container is, so this makes reading easier as the code is not constantly pointing out to you, "hey! I'm a vector!" Added bonus: less verbose, allows condensing a lot of loop declarations onto one line.
* Consistently put getters before setters.
* Remove 4-arg form of SetBounds() and make people use Rects (we should move the codebase towards Points, Sizes, and Rects wherever possible).
* Use "origin" instead of "position" to be consistent with Rect's terminology.
* Minor naming changes, e.g. GetViewById() -> GetViewByID().
* Remove const qualifier on member functions that are not logically const. This also got rid of all the const_cast<>()s.
* Better comments.
* Use const ref args for Views whenever the provided View is not being modified, to make that obvious to the caller.
* Turn some accessors into pairs of (non-const, const) accessors. In these cases make the non-const version call the const version. (GetWidget() does this in the header because the const version is virtual; this way people who override the const version can see why they don't need to override the non-const version).
* Make RemoveChildView() take a bool for consistency with RemoveAllChildViews() (also eliminates the need to return a View*).
* Add STL-style iterators and rename a few accessors to match STL terminology ("size" instead of "count").
* Turn IsFocusable() into a cheap inline getter.
* Greatly simplify private tree ops ("NotifyHierarchyChangedXXX()") by realizing that they were always being called with |parent| == |this|.
* Declare iterators inside loops, not above them.
* Standardize iterator naming to |i|. The existing code wasn't always consistent, and while there's nothing wrong with |it|, using that would have made almost every loop declaration into two lines instead of one.
* Simpler code, sometimes by using STL algorithms.
* Unindent via early-returns.
* Use CHECK_NE() and similar where possible.
* Fix memory corruption in RemoveAllChildViews() due to using an iterator after modifying its container.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6541030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23581
Review URL: http://codereview.chromium.org/6526027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flag for turning on composite-to-texture behaviour. This will facilitate running GPU tests against both composite-to-display and composite-to-texture.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6134012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6546063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=73425
TEST=NONE
Review URL: http://codereview.chromium.org/6549022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- linux-release-hardy/dhtml/vm_rss_final_b/vm_rss_f_b
- linux-release-hardy/dhtml/vm_rss_final_r/vm_rss_f_r
- linux-release-hardy/dhtml/vm_rss_final_t/vm_rss_f_t
- linux-release-hardy/dhtml/vm_size_final_b/vm_size_f_b
- linux-release-hardy/dhtml/vm_size_final_r/vm_size_f_r
- linux-release-hardy/dhtml/vm_size_final_t/vm_size_f_t
- linux-release-hardy/intl2/times/t
- linux-release-hardy/moz/times/t
- mac-release-10.5/intl1/times/t
- mac-release-10.5/intl2/vm_rss_final_b/vm_rss_f_b
- mac-release-10.5/intl2/vm_rss_final_r/vm_rss_f_r
- mac-release-10.5/intl2/vm_rss_final_t/vm_rss_f_t
- mac-release-10.5/intl2/vm_size_final_b/vm_size_f_b
- mac-release-10.5/intl2/vm_size_final_r/vm_size_f_r
- mac-release-10.5/intl2/vm_size_final_t/vm_size_f_t
BUG=none
TEST=perf steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/6538097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73268
TEST=look at the memory bots this time
Review URL: http://codereview.chromium.org/6469036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a new histogram, Net.HttpStartTime, which tracks the
amount of time from the creation of an UrlRequestHttpJob, until the
first data is available to be passed back. This is part of issue
70957, and arguably the easier half.
BUG=70957
TEST=none
Review URL: http://codereview.chromium.org/6537025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the version of ChromeDriver.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6485027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=73740
Review URL: http://codereview.chromium.org/6549019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3796006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run with --enable-print-preview on Linux.
Review URL: http://codereview.chromium.org/6546033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6542027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=BrowserInitTest.*
Review URL: http://codereview.chromium.org/6543006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
which isn't moving. I incorrectly moved it.
Review URL: http://codereview.chromium.org/6538095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Despite obvious warnings about not using this flag
in deployment, we are turning off sqlite sync in ChromeOS
and relying on the underlying journaling filesystem
to do error recovery properly. It's much faster.
BUG=chromium-os:12328
TEST=Build both with and without SQLITE_NO_SYNC, and measured power
usage at the SATA rail. Power reduction is about 2-3%, and light use
so far produced no data corruption.
Review URL: http://codereview.chromium.org/6544025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69594
TEST=updated unit tests
Review URL: http://codereview.chromium.org/6526037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will only show up for users who have prerendering enabled (mainly via about:flags)
This CL does not include the logic for displaying whether prerender failed on the referring page.
BUG=73065
TEST=Start Chrome with prerendering enabled, go to a page with a <link rel=prefetch> element, navigate to the referred page, and see icon appear.
Review URL: http://codereview.chromium.org/6529031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ViewHostMsg_FrameNavigate.
This will be used to run pre-classification checks for client-side phishing
detection, and will also enable the socket address to be exposed via the
webRequest extension API. This is adapted from the original patch by pmarks
on http://codereview.chromium.org/6369003/ .
BUG=51663
TEST=added socket address checks to various unittests
Review URL: http://codereview.chromium.org/6488010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=60822
Review URL: http://codereview.chromium.org/6549018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the mouse over an element.
/session/:sessionId/element/:id/hover
Drag and drop an element. The distance to drag an element should be
specified relative to the upper-left corner of the page.
/session/:sessionId/element/:id/drag
Click on an element.
/session/:sessionId/element/:id/click
The events in this CL use Webkit events and do not use OS level calls.
BUG=none
TEST=webdriver_remote_tests.py
Review URL: http://codereview.chromium.org/4681007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved all stuff related to GetOwnershipStatus from user_cros_settings.cc where it was irrelevant to OwnershipService.
Prefetch and cache ownership status in order not to block on UI thread.
BUG=chromium:70097
TEST=Manual
Review URL: http://codereview.chromium.org/6538057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
infobars.InfobarTest.testPluginCrashForMultiTabs.
BUG=72664
TEST=none
Review URL: http://codereview.chromium.org/6546060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73590
TEST=Go to http://it.wikipedia.org to get a translate infobar. Open Find in Page. Findbar is visible and can be used.
Review URL: http://codereview.chromium.org/6541063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser plugin. This step rolls the o2d renderer and the gl renderer
into the same linux plugin. Unfortunately the code path for which one
gets used is still controlled by a compile time switch. That switch is
force_cairo which is set to 0 by default (meaning o3d) in common.gypi.
Review URL: http://codereview.chromium.org/6532010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To avoid having the first test flakily time out on a busy bot (usually Windows one), the out-of-process testrunner launches an empty test with a long timeout at the beginning. That preloads everything needed to run tests into memory, so the following tests should run faster.
However, I didn't take sharding into account when implementing the above. This CL fixes that issue (the preloading test not being run on sharding bots).
BUG=72962
TEST=browser_tests
Review URL: http://codereview.chromium.org/6542050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6549020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splitting the existing single shortcuts test into different tests so that even if one fails other shortcuts would be verified.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6543022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Possibly a Webkit bug, but may also be autofill::FormManager::ResetFrame.
BUG=73575
TEST=none
Review URL: http://codereview.chromium.org/6546041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove all the ugly code to have reverse rows. All images are upright now.
BUG=71872
TEST=Everything in chromoting still works and upright.
Review URL: http://codereview.chromium.org/6546057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= related to 70011
TEST= tested on Linux
Instead of defaulting to the dir where Chrome launched, it defaults to the equivalent of "Documents" directory for every platform.
Review URL: http://codereview.chromium.org/6532027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A tool for using tiles to render an image.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6542045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75607 0039d316-1c4b-4281-b951-d872f2087c98
|