summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* When a nested run loop is driven directly by Run/DoRun as opposed to being amark@chromium.org2009-10-132-18/+30
| | | | | | | | | | | | | nested native loop run by code outside of our control, and the nested run loop stops, don't schedule nesting-deferred work until returning fron Run/DoRun. BUG=24337, 24383 TEST=With r28745 backed out or an equivalent change recommitted: 1. Test case from bug 24337: the window should close 2. Test case from bug 24383: no Chromium processes should use 100% CPU Review URL: http://codereview.chromium.org/264042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28811 0039d316-1c4b-4281-b951-d872f2087c98
* Turn NULL used as int to 0.phajdan.jr@chromium.org2009-10-1319-39/+47
| | | | | | | | | | | | | (Excluding chrome/browser/...) Landing patch for Jacob Mandelson. Original review: http://codereview.chromium.org/195067 BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/267076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28810 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add breakpad info for crashes in the target/action dispatcher.shess@chromium.org2009-10-132-0/+48
| | | | | | | | | | | | | | | -[NSApplication sendAction:to:from:] is a central dispatcher for target-action messages sent by controls. Backtraces from here often contain only Cocoa messages, making it hard to tell where things are at when a freed target gets messaged. Add additional info like the action being requested and the tag of the sender. http://crbug.com/24460 TEST=Browser continues to work. Review URL: http://codereview.chromium.org/269039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28809 0039d316-1c4b-4281-b951-d872f2087c98
* LTTF: rebaseline fast/css/pseudo-cache-stale .hamaji@chromium.org2009-10-133-2/+1
| | | | | | | | | BUG=17398 TEST=none Review URL: http://codereview.chromium.org/267073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28808 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.5 to 222.6laforge@chromium.org2009-10-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28807 0039d316-1c4b-4281-b951-d872f2087c98
* Fix parsing of the first race report for ThreadSanitizertimurrrr@chromium.org2009-10-131-6/+7
| | | | | | | | | We've introduced a mistake recently which results in hiding the first race report. The reason was the "main thread" line which doesn't contain "{{{" and doesn't have context printed. Please note that after submitting of this CL ThreadSanitizer bots can become red for a while. Review URL: http://codereview.chromium.org/272026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28806 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressed test-only race on bool, improved existing suppressions.timurrrr@chromium.org2009-10-131-3/+19
| | | | | | | | Fixed indentations and added comments for some old suppressions. TBR=dank,stuartmorgan Review URL: http://codereview.chromium.org/269053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28805 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add methods to our InspectorController stub to prepare for a ↵mnaganov@chromium.org2009-10-131-0/+16
| | | | | | | | | | | change in WebKit. BUG=none TEST=none Review URL: http://codereview.chromium.org/273034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28804 0039d316-1c4b-4281-b951-d872f2087c98
* Do not run FlipNetworkTransactionTest.Connect under ThreadSanitizer on Mac OStimurrrr@chromium.org2009-10-131-0/+1
| | | | | | | | | | | | | | The pre-3.5 version of ThreadSanitizer reports "aspacem" warnings on this test, the latest Tsan hangs silently. This test case was enabled in http://src.chromium.org/viewvc/chrome?view=rev&revision=28793, so we haven't seen the complaints before. This patch was prepared by Alexander Potapenko (cc'ed) TBR=dank Review URL: http://codereview.chromium.org/270083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28803 0039d316-1c4b-4281-b951-d872f2087c98
* 64 bit linux yuvfbarchard@chromium.org2009-10-132-40/+120
| | | | | | | | BUG=23263 TEST=media_unittest should pass and run much faster: faster than 32 bit even. Review URL: http://codereview.chromium.org/268029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28802 0039d316-1c4b-4281-b951-d872f2087c98
* This is a second attempt at submitting this changelist. The original one wasmarkus@chromium.org2009-10-138-17/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/196053 It turns out, since none of our tests abstract time correctly, unittests are very sensitive to subtle changes in timing. This made some of the valgrind tests on Linux fail, and unfortunately, neither my desktop nor the trybots could reproduce the problem reliably. As far as I can tell, all the (design) bugs are in the unittests. The browser is actually fine. Tweaked the code a little more. Will resubmit and carefully monitor the buildbots. Original change description follows: When converting between units of time or data types of different precision, we have to be careful to consistently round in the same direction. Timeout checks usually check if Now() is less or equal to a deadline in order to determine if a timeout has occurred. This correctly handles the case where actual sleep times are equal or longer than requested sleep times. But if we round down when setting the sleep delay, this can result in unnecessary and expensive looping. Make sure, we always round up when converting to a format with less precision. BUG=none TEST=none Review URL: http://codereview.chromium.org/257044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28801 0039d316-1c4b-4281-b951-d872f2087c98
* Importing dromaeo performance tests to src/chrome/test/data.asargent@chromium.org2009-10-13104-0/+109376
| | | | | | | | | | | | | Committing this for Anton Muhin (antonm@chromium.org). BUG=none TEST=none Review URL: http://codereview.chromium.org/269054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28800 0039d316-1c4b-4281-b951-d872f2087c98
* Mix mismatched new[] with delete. (should be delete[]).mbelshe@google.com2009-10-132-8/+8
| | | | | | | | | | BUG=none TEST=none TBR=jar@chromium.org Review URL: http://codereview.chromium.org/267071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28799 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 28607.darin@chromium.org2009-10-135-113/+98
| | | | | | Review URL: http://codereview.chromium.org/275001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28798 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28796 - This is a simple integration test that loads a simple nexe ↵gregoryd@google.com2009-10-134-73/+1
| | | | | | | | | | | | and verifies that Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree. Review URL: http://codereview.chromium.org/272005 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/270080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28797 0039d316-1c4b-4281-b951-d872f2087c98
* This is a simple integration test that loads a simple nexe and verifies that ↵gregoryd@google.com2009-10-136-1/+210
| | | | | | | | Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree. Review URL: http://codereview.chromium.org/272005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28796 0039d316-1c4b-4281-b951-d872f2087c98
* Adding native-client-reviews to watch nacl changesgregoryd@google.com2009-10-131-134/+139
| | | | | | Review URL: http://codereview.chromium.org/264039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28795 0039d316-1c4b-4281-b951-d872f2087c98
* Make SSLClientSocketNSS full-duplexukai@chromium.org2009-10-132-99/+238
| | | | | | | | | BUG=13289,12497 TEST=visit https site and works as before. Review URL: http://codereview.chromium.org/255074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28794 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line switch to enable flip sockets.mbelshe@google.com2009-10-136-1/+42
| | | | | | | | | | | | With this change, flip code is now compiled and the limited unit tests actually run. BUG=none TEST=none Review URL: http://codereview.chromium.org/259064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28793 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for https://bugs.webkit.org/show_bug.cgi?id=30262darin@chromium.org2009-10-131-0/+10
| | | | | | | | | | R=eseidel BUG=none TEST=none Review URL: http://codereview.chromium.org/261058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28792 0039d316-1c4b-4281-b951-d872f2087c98
* More build a-fixin for GCF related to base/test move.slightlyoff@chromium.org2009-10-131-2/+2
| | | | | | | | | | BUG=None TEST=None TBR=joshia@chromium.org,ananta@chromium.org Review URL: http://codereview.chromium.org/270079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28791 0039d316-1c4b-4281-b951-d872f2087c98
* Add scripts to start/stop PyWebSocket server that is used for testing Web ↵yuzo@chromium.org2009-10-135-3/+172
| | | | | | | | | | | Socket. BUG=none TEST=none Review URL: http://codereview.chromium.org/267002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flashing issue when hitting escape while find bar is active.mhm@chromium.org2009-10-132-0/+15
| | | | | | | | | | | When the View try's to focus to the last focused component, it can't, because ToolBarView is not Focusable, hence overriding IsFocusable will fix the flashing, but will create a focusable ring around the whole toolbar. BUG=15228 TEST=ALT+SHIFT+T press left arrow until page menu, and select find in page. Press ESC numerous times, no more flashing issues for the find bar. Review URL: http://codereview.chromium.org/265056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28789 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up bookmark all tabs on linux.sky@chromium.org2009-10-137-37/+77
| | | | | | | | | | | | BUG=2935 TEST=Create two tabs, press control-shift-d. You should be presented with a dialog that lets you give a name to a folder. Change the name, press enter and make sure you get a bookmark folder populated with the urls of any open tabs. Review URL: http://codereview.chromium.org/268038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28788 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code to reset cursor on leave. We need to do this or cursor cansky@chromium.org2009-10-132-0/+9
| | | | | | | | | | | get stuck. BUG=none TEST=none Review URL: http://codereview.chromium.org/274008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28787 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetLinuxDistro thread-safe.thestig@chromium.org2009-10-131-8/+61
| | | | | | | | BUG=24659 TEST=none Review URL: http://codereview.chromium.org/273026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28785 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete source excludes in base/gfx. The files have been moved to ↵thestig@chromium.org2009-10-131-6/+0
| | | | | | | | | | app/gfx/ BUG=none TEST=none Review URL: http://codereview.chromium.org/273030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28784 0039d316-1c4b-4281-b951-d872f2087c98
* Remove typos for gtk_native_view_id_manager in app.gyp. Make complains: ↵thestig@chromium.org2009-10-131-2/+0
| | | | | | | | | | Circular out/Debug/obj/app/gfx/gtk_native_view_id_manager.o <- out/Debug/obj/app/libapp_base.a dependency dropped. BUG=none TEST=Make no longer complains about circular dependencies in app/gfx. Review URL: http://codereview.chromium.org/267068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28783 0039d316-1c4b-4281-b951-d872f2087c98
* Spawn the pepper WebPluginDelegateImpl when a MIME type begins with "pepper-".brettw@chromium.org2009-10-131-0/+9
| | | | | | | | | | | This is a temporary hack for testing. I wrapped it in USE_PEPPER_PLUGINS ifdef, what ifdef are you using in real life? BUG=none TEST=none Review URL: http://codereview.chromium.org/271047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28782 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS build.evan@chromium.org2009-10-131-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28781 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the IcognitoDownload as flaky because it keepsnsylvain@chromium.org2009-10-131-1/+2
| | | | | | | | | failing on mac. BUG:24684 Review URL: http://codereview.chromium.org/266059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28780 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASCII strings for switch names.evan@chromium.org2009-10-1369-652/+679
| | | | | | Review URL: http://codereview.chromium.org/270062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: avoid a hang brought on by an infinite size-allocate queue.estade@chromium.org2009-10-132-3/+17
| | | | | | | | | | | This is not the most satisfying fix imaginable. I'm not sure why we are getting size-allocate events where the visibility of the chevron has changed but our allocation is not yet updated. In principle I suppose it would be better not to call any function that might cause an allocation from within a size-allocate handler, but guaranteeing that is probably pretty hard. BUG=24470 TEST=repro steps no longer repro; also, verified that the early return line is actually being hit. Review URL: http://codereview.chromium.org/270078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28778 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: draw the secure scheme color over the correct char range.estade@chromium.org2009-10-131-3/+5
| | | | | | | | | BUG=none TEST=go to gmail.com Review URL: http://codereview.chromium.org/272028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28777 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't dcheck when user dismisses print dialog.estade@chromium.org2009-10-131-0/+1
| | | | | | | | | BUG=none TEST=ctrl+p, escape in debug mode does not dcheck Review URL: http://codereview.chromium.org/272030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28776 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Select a row in Languages table when the user delete an item.mattm@chromium.org2009-10-132-5/+19
| | | | | | | | | | | | This is to work in the same way as in Windows version. BUG=None TEST=add some languages, remove them, should work fine. Review URL: http://codereview.chromium.org/270013 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28775 0039d316-1c4b-4281-b951-d872f2087c98
* linux: drop linux-specific CommandLine functionevan@chromium.org2009-10-134-14/+9
| | | | | | | | We can just call this from the appropriate constructor internally. Review URL: http://codereview.chromium.org/271051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28773 0039d316-1c4b-4281-b951-d872f2087c98
* Add some unimplemented methods from my last CL.michaeln@google.com2009-10-133-2/+43
| | | | | | | | | TEST=yes, appcache_storage_unittest.cc BUG=none Review URL: http://codereview.chromium.org/266042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28772 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup for theme provider code, including:pkasting@chromium.org2009-10-139-293/+246
| | | | | | | | | | | | | | | | | | | | | * Use correct indentation/alignment in a number of places * Use early-return to avoid long code block indenting * Use for() instead of while() in cases where that's what the code is actually doing * Consistent naming for iterators ("foo_iter", "bar_iter" instead of sometimes that way and sometimes "found") * Use {} when needed, don't use when not * Do not use "else" after "return" * Shorten overly-verbose code * Pull some trivial functions into the header * Eliminate unused function * Use STLDeleteValues() helper where appropriate Some of this was originally in my patch that modified constness, but I've split it out to make that more sane. BUG=none TEST=none Review URL: http://codereview.chromium.org/272033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28771 0039d316-1c4b-4281-b951-d872f2087c98
* Use full pathname to perf_expectations in test.chase@chromium.org2009-10-131-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28770 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to purge memory to the ProxyResolver.pkasting@chromium.org2009-10-139-3/+79
| | | | | | | | BUG=23400 TEST=none Review URL: http://codereview.chromium.org/272018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28769 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28716 - Gets blocked popups to work on views/gtk. I had to fix a ↵nsylvain@chromium.org2009-10-138-235/+133
| | | | | | | | | | | | | | | | | | | | | | | couple of additional things here: . Avoid doing anything in OnSizeAllocation if the size hasn't changed. Because of how gtk works I was getting stuck in a loop if I OnSizeAllocate did anything if the size hadn't changed. . Applied similar shortcut to TabContentsViewGtk. . Made SimpleMenuModel only ask delegate for checked state if the item is a check. BUG=none TEST=none Review URL: http://codereview.chromium.org/261051 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/267069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28768 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed lame typo.oshima@chromium.org2009-10-131-2/+2
| | | | | | | | | | | | Doh, I forgot that linux try bot does not compile this file. BUG=None TEST=compiled with chromeos=1 TBR=sky Review URL: http://codereview.chromium.org/269061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28767 0039d316-1c4b-4281-b951-d872f2087c98
* Doesn't run the TestStressDrawShapes test on IE, because selenium/ie is too ↵kkania@google.com2009-10-131-1/+2
| | | | | | | | slow (IE6 5-10 min). Review URL: http://codereview.chromium.org/272034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28766 0039d316-1c4b-4281-b951-d872f2087c98
* This removes the command buffer tests from the non-command buffergspencer@google.com2009-10-132-15/+23
| | | | | | | | builds because they fail with the current version of nacl, and Al is busy making command buffer code that doesn't use nacl anyhow. Review URL: http://codereview.chromium.org/266057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28765 0039d316-1c4b-4281-b951-d872f2087c98
* include CHROMEOS files and defintions in TOOLKIT_VEIWS build.oshima@chromium.org2009-10-1211-18/+59
| | | | | | | | | | | | | | | | | * changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1 * changed to define OS_CHROMEOS when toolkit_views==1 * changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1 I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow from xid. Looks like I need to register it somewhere Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine. BUG=none TEST=run views unit test and browser. Review URL: http://codereview.chromium.org/262027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28764 0039d316-1c4b-4281-b951-d872f2087c98
* Add explicit dependency to x11. This comes from webkit as well, but ↵oshima@chromium.org2009-10-121-1/+1
| | | | | | | | | | | | | views/gtk depends on this, and a program that uses views without webkit fails to link. BUG=None TEST=None Review URL: http://codereview.chromium.org/270054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28763 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a CopyRecursiveDirNoCache to use FilePaths insteadtony@chromium.org2009-10-128-39/+34
| | | | | | | | | of wstrings. Also convert template_user_data_ in UITest to be a FilePath. Review URL: http://codereview.chromium.org/273021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28762 0039d316-1c4b-4281-b951-d872f2087c98
* Enables the sending of Timeline Agent and Resource messages to the devtools ↵jamesr@chromium.org2009-10-1217-67/+135
| | | | | | | | api in extensions. Review URL: http://codereview.chromium.org/267013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28761 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePaths in chrome_url_data_manager.evan@chromium.org2009-10-122-14/+14
| | | | | | | | | BUG=24672 TEST=still compiles Review URL: http://codereview.chromium.org/267065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28760 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 05:20:24 +0000