summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix an ExternalTabContainer leak caused in the code path which attaches an ↵ananta@chromium.org2010-02-112-3/+4
| | | | | | | | | | | ExternalTabContainer to an IE tab, which connects to it. The leak occurs because of a refcount leak. This causes the AutomationProvider to not get released thus resulting in a running chrome.exe instance even after we shutdown IE. Review URL: http://codereview.chromium.org/600063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38735 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38692 to see if this fixes ChromeFrame net tests.ananta@chromium.org2010-02-111-9/+0
| | | | | | | | | Review URL: http://codereview.chromium.org/600032 TBR=stoyan@chromium.org Review URL: http://codereview.chromium.org/602026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38734 0039d316-1c4b-4281-b951-d872f2087c98
* Hooked up network selection and account creation screens to login wizard soavayvod@chromium.org2010-02-1110-55/+144
| | | | | | | | | | | | | | | | when these screens exit, login screen is shown. Separated loading l10n strings to simplify implementation of ui language switch. Fixed some style issues. BUG=none TEST=Start with --login-manager=network and connect to network - login screen should appear. Start with --login-manager=create_account and hit Enter or click Create Account - login screen should appear. Review URL: http://codereview.chromium.org/596041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38733 0039d316-1c4b-4281-b951-d872f2087c98
* Updated translationsoritm@google.com2010-02-1151-255/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38732 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the revert... This has the cumulative effect of relanding 38694.eroman@chromium.org2010-02-1110-65/+234
| | | | | | | | | | | | | | | | The chrome frame failure appears to be unrelated. Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/596048 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/604012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38728 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented linux-specific NPAPI interface for pepper demos.alokp@chromium.org2010-02-111-7/+46
| | | | | | | BUG=26099 Review URL: http://codereview.chromium.org/599020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38727 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up client side of per-datatype GetUpdates.nick@chromium.org2010-02-1126-88/+554
| | | | | | | | | | | Which datatypes are fetched is dictated by the ModelSafeRoutingInfo. We change the semantic of the ModelSafeRoutingInfo so that datatypes which should not be synced are not in the map. We will do GetUpdates for GROUP_PASSIVE datatypes. BUG=29905 TEST=included unit tests Review URL: http://codereview.chromium.org/594024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38726 0039d316-1c4b-4281-b951-d872f2087c98
* Do not delete cookies when deleting history.jochen@chromium.org2010-02-111-1/+0
| | | | | | | | | BUG=35302 TEST=delete history of last day, check cookies Review URL: http://codereview.chromium.org/593046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38723 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Make the Linux valgrind layout test work again.thestig@chromium.org2010-02-111-1/+1
| | | | | | | | | TBR=glider BUG=none TEST=none Review URL: http://codereview.chromium.org/603016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38722 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to delete browsing history of the last hour.jochen@chromium.org2010-02-116-13/+44
| | | | | | | | | BUG=35302 TEST=manually test Review URL: http://codereview.chromium.org/596047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38721 0039d316-1c4b-4281-b951-d872f2087c98
* Fix recently added FormField constructors that I missed in the last commit.jhawkins@chromium.org2010-02-111-4/+8
| | | | | | | | | TBR=zork BUG=none TEST=none Review URL: http://codereview.chromium.org/598047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38718 0039d316-1c4b-4281-b951-d872f2087c98
* Replace __MSG_some_name__ template within extension css files with localized ↵cira@chromium.org2010-02-1117-50/+732
| | | | | | | | | | | | | messages. We avoid replacing messages within html and js extension files for security reasons. Also, developers can already localize messages in html/js using chrome.i18n.getMessage calls. TEST=Localize extension, try body{direction: __MSG_@@bidi_reversed_dir__;} in popup.css, while using non-rtl locale. Text should be alligned to the right (as if we were using rtl locale). BUG=26144 Review URL: http://codereview.chromium.org/570007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38717 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Add a load log to the DoomEntry operation.rvargas@google.com2010-02-113-4/+25
| | | | | | | | | | BUG=26729 TEST=unittest Review URL: http://codereview.chromium.org/603011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38713 0039d316-1c4b-4281-b951-d872f2087c98
* Make context menu in Browser Action overflow menu do something.finnur@chromium.org2010-02-116-29/+35
| | | | | | | | | | | | | | | | | | | | | In a previous reorg change the lifetime of the context menu changed, causing it to get deleted before executing its actions. This change makes the browser action container own the context menu, lazily create it and reuse it for every browser action from that point on. Also delaying a bit when we clear the drop indicator (it shouldn't go away until the dropdown menu appears). BUG=34796 TEST=Context menu off of the Browser Action Container overflow menu should now work. Dragging and dropping between the container and the overflow menu should still work (and reordering within both as well). Review URL: http://codereview.chromium.org/601033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38712 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r38570. The underlying bug has been fix.jhawkins@chromium.org2010-02-118-61/+113
| | | | | | | | | | | Move conditions of FormField creation to FormFieldHistoryManager; AutoFill does not have the same conditions. This required manipulating the FormField data structure to add necessary field data. TBR=tony BUG=none TEST=none Review URL: http://codereview.chromium.org/603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38711 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IOleCommandTarget::Exec handling taking into account command group id.stoyan@chromium.org2010-02-111-30/+36
| | | | | | | | BUG=none TEST=chrome_frame_tests Review URL: http://codereview.chromium.org/594034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38710 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Doc Changes (no building or testable changes).rafaelw@chromium.org2010-02-111-1/+1
| | | | | | | | | | Fix build.py script breakage. TBR=aa,kathyw Review URL: http://codereview.chromium.org/596049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38708 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38694 - For some reason this seems to be hanging chrome frame tests, ↵eroman@chromium.org2010-02-1010-234/+65
| | | | | | | | | | | | | even though this should be a strictly no-op change... Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/596048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38707 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak more bug ids, triaging layout test failures.dglazkov@chromium.org2010-02-101-1/+1
| | | | | | | | | | TBR=hamaji TEST=none BUG=none Review URL: http://codereview.chromium.org/597028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38706 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix clicking on security or blocked contents of non-active window ↵mattm@chromium.org2010-02-109-38/+59
| | | | | | | | | | | | | | | showing wrong data. Change the location bar code on all platforms to not use BrowserList::GetLastActive. Makes GetTabContents part of the LocationBar interface. BUG=none TEST=open two windows that show security or blocked popups. click the icon in the non-focused one. Review URL: http://codereview.chromium.org/573038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38705 0039d316-1c4b-4281-b951-d872f2087c98
* translate infobars: reimplement, fix bugskuan@chromium.org2010-02-109-469/+535
| | | | | | | | | | | | | - 35077: redesign and reimplement infobars and infobars delegates to merge before- and after-translate infobars into one, whose state transitions from before-translate to translating to after-translate - 35080: modify gradient of blue infobar per roma (to differentiate from default chrome theme) - 35052: fix white-pixel lines in infobar buttons by stretching image sets instead of tiling them BUG=35052,35080,35077 TEST=verify per all bug reports. Review URL: http://codereview.chromium.org/604001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38704 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor PostClientToServer message, include new unit tests for it. In prep ↵chron@google.com2010-02-104-74/+244
| | | | | | | | | | | for adding auth filter changes. TEST=unit tests included BUG=35321 Review URL: http://codereview.chromium.org/597025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38703 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix label color and text color for DarkRoom.erg@chromium.org2010-02-101-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/596046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38702 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_output_xml_to_json.py not to fail when results_directory requires ↵kinuko@chromium.org2010-02-101-1/+1
| | | | | | | | | | | recursive mkdir BUG=32152 TEST=run test_output_xml_to_json.py with option "--results-directory=a/b" and see if it does not exit with "No such file or directory: 'a/b'" error. Review URL: http://codereview.chromium.org/595016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38701 0039d316-1c4b-4281-b951-d872f2087c98
* Add expectations for the test we pass, but Win upstream doesn't.dglazkov@chromium.org2010-02-102-1/+12
| | | | | | | | | | TBR=darin TEST=none BUG=33359 Review URL: http://codereview.chromium.org/601034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38700 0039d316-1c4b-4281-b951-d872f2087c98
* Added the GetAllAutofillEntries function to the WebDatabase class in ↵skrul@chromium.org2010-02-106-0/+97
| | | | | | | | | | | preparation for autofill sync. BUG=30959 TEST=WebDatabaseTest.GetAllAutofillEntries Review URL: http://codereview.chromium.org/598004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38699 0039d316-1c4b-4281-b951-d872f2087c98
* Update bug id on color-correction-related tests.dglazkov@chromium.org2010-02-101-4/+2
| | | | | | | | | | TBR=dimich TEST=none BUG=28317 Review URL: http://codereview.chromium.org/600057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38698 0039d316-1c4b-4281-b951-d872f2087c98
* Use Chrome update UI for Chrome OS updates.davemoore@chromium.org2010-02-106-41/+169
| | | | | | | | | BUG=279 (Chromium OS) (Not Complete) TEST=none Review URL: http://codereview.chromium.org/587006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38697 0039d316-1c4b-4281-b951-d872f2087c98
* Mark CookiesWindowControllerTest.RemoveButtonEnabled as flaky.rsesek@chromium.org2010-02-101-1/+7
| | | | | | | | | BUG=35327 TEST=Flaky on Mac Valgrind unit Review URL: http://codereview.chromium.org/603013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38696 0039d316-1c4b-4281-b951-d872f2087c98
* Update more test expectations to match reality.dglazkov@chromium.org2010-02-101-5/+3
| | | | | | | | | | TBR=zork TEST=none BUG=none Review URL: http://codereview.chromium.org/593048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38695 0039d316-1c4b-4281-b951-d872f2087c98
* Add some tests to CookieMonster for overwriting persistent cookies, and ↵eroman@chromium.org2010-02-1010-65/+234
| | | | | | | | checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38694 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/600032stoyan@chromium.org2010-02-101-0/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38692 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the SWP_NOMOVE flag to SetWindowPos in ↵mpcomplete@chromium.org2010-02-101-1/+4
| | | | | | | | WebPluginDelegateImpl::WindowedReposition or all plugins will be incorrectly moved to (0,0). Review URL: http://codereview.chromium.org/577027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38691 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Temporarily turn off use of X shared memory extension.thestig@chromium.org2010-02-101-0/+9
| | | | | | | | BUG=25324 TEST=No more crashes in libX11? Review URL: http://codereview.chromium.org/598025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38690 0039d316-1c4b-4281-b951-d872f2087c98
* Make linux_views depend on new gtk_theme_provider dependencies.erg@chromium.org2010-02-101-0/+2
| | | | | | TBR=estade git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38689 0039d316-1c4b-4281-b951-d872f2087c98
* Dialog showed now only if profiles are loaded - if not it waits until they are.georgey@chromium.org2010-02-104-15/+60
| | | | | | | | | Added capability of multiple observers for profile loading. BUG=33026 TEST=If loading of profiles takes time (slow connection, for example), dialog does not appear until they are loaded. Review URL: http://codereview.chromium.org/601010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38688 0039d316-1c4b-4281-b951-d872f2087c98
* CL implementing focus-dismissal of the chrome.experimental.popup set of ↵twiz@chromium.org2010-02-1027-31/+423
| | | | | | | | | | | | | | | | | extension APIs. Specifically, these changes cause a displayed pop-up to be dismissed when the focus shifts away from both the pop-up view, and the extension-view that launched the pop-up.I had to do a lot of investigating and trial-and-error to converge to the solution present here. I was hoping to be able to piggy-back on the existing FocusManager's various listener routines, but because the pop-up is hosted in a BubbleWidget, which is a separate top-level window with its own focus manager, I could not rely on a given focus manager to take care of the focus change notifications. To get around the above issue, I added a new type of focus listener that can listen on native-window focus change events. I added invocations to this listener throughout the Widget classes in the system so that registered listeners will be notified on focus change. I found some of the focus change events problematic, as the system will arbitrarily reassign the focus to the main browser window when shifting activation between chrome windows. (SeefocusManagerWin::ClearNativeFocus). To prevent this focus bounce from confusing focus listeners, I added a means to suppress notification of focus change during these operations. I added GTK and Mac stubs for the new widget functions that will assert when called. GTK and Cocoa development is not my expertise, so I thought // TODO(port) would be wiser.I'm uncertain of the best means to unit-test these changes. Direction in this regard would be appreciated. BUG=None TEST=None Review URL: http://codereview.chromium.org/552167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38685 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: lighten the color of the download item status/label text.estade@chromium.org2010-02-101-16/+36
| | | | | | | | | | | This doesn't use the same technique as windows/mac, which both draw the text first, then draw the download item shading over it. To do that for GTK results in very delicate and complicated code, so instead I just alpha-blended the text color manually with hard-coded values. BUG=21176 TEST=see bug Review URL: http://codereview.chromium.org/598033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38684 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use color data from the MetaFrames class in newer versions of GTK+.erg@chromium.org2010-02-105-28/+80
| | | | | | | | | | | | | | | When codereviewing my r36867, evmar suggested that I implement our trying to match WM frames in terms of gtk_rc_get_style_by_paths(). This worked... on the version of gtk+ included with hardy. It notably doesn't work under the version included with Karmic. This is the original patch from CL 552092 with some cleanup, before I rewrote it. BUG=32173 TEST=New Wave has a dark border color under GNOME on Karmic. Review URL: http://codereview.chromium.org/564048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38682 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Add support for EAT interceptions in 64 bit.rvargas@google.com2010-02-107-20/+128
| | | | | | | | | | BUG=27218 TEST=manual integration tests. Review URL: http://codereview.chromium.org/600035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38681 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore .m files in addition to .mm on non-Macs.mark@chromium.org2010-02-101-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/594031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38680 0039d316-1c4b-4281-b951-d872f2087c98
* Wait a second before initializing the Mac notifier thread.willchan@chromium.org2010-02-102-9/+32
| | | | | | | | | This should prevent slowing down Mac startup. BUG=34926 Review URL: http://codereview.chromium.org/593039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38679 0039d316-1c4b-4281-b951-d872f2087c98
* Add new valgrind suppression to green the tree.estade@chromium.org2010-02-101-0/+17
| | | | | | | | | | BUG=35318 TEST=none TBR=zork Review URL: http://codereview.chromium.org/603012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38675 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux Views and ChromiumOS builds following r38658.mark@chromium.org2010-02-109-15/+224
| | | | | | | | | | | | | chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to be a views file, not a Windows file, so why is it named with _win.cc? This is a speculative change. BUG=none TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps turn green Review URL: http://codereview.chromium.org/600049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38672 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chromium XP (clobber) build following r38658:mark@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | | tools\test_shell\resources\test_shell.rc(3) : fatal error RC1015: cannot open include file 'resource.h'. This file is compiled in a different directory now. BUG=none TEST=Chromium XP Review URL: http://codereview.chromium.org/600048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38670 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux Views and ChromiumOS builds following r38658.mark@chromium.org2010-02-106-11/+11
| | | | | | | | | | | | | chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to be a views file, not a Windows file, so why is it named with _win.cc? This is a speculative change. BUG=none TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps turn green Review URL: http://codereview.chromium.org/596040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38669 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux Views and ChromiumOS builds following r38658.mark@chromium.org2010-02-101-2/+2
| | | | | | | | | | | | | | | chrome/browser/views/tab_contents/render_view_context_menu_win.cc appears to be a views file, not a Windows file, so why is it named with _win.cc? This is a speculative change. It may not work, in which case the file will need to be renamed. BUG=none TEST=Linux Builder (Views dbg) and Linux Builder (ChromiumOS) compile steps turn green Review URL: http://codereview.chromium.org/598042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38667 0039d316-1c4b-4281-b951-d872f2087c98
* Better alignment for Star button and location bar.avayvod@chromium.org2010-02-101-3/+7
| | | | | | | | | BUG=none TEST=Toggle compact location bar. Star button should be now aligned with Reload button, not be above it. Review URL: http://codereview.chromium.org/601012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38666 0039d316-1c4b-4281-b951-d872f2087c98
* base::SharedMemory does not set the size in other than the creatingsehr@google.com2010-02-103-3/+16
| | | | | | | | process. Create an API to get the size of the audio shared memory region. Review URL: http://codereview.chromium.org/596038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38665 0039d316-1c4b-4281-b951-d872f2087c98
* Include test_shell.gypi in webkit.gyp instead of maintaining a distinctmark@chromium.org2010-02-107-77/+90
| | | | | | | | | | | | | | | | | | test_shell.gyp. This allows the removal of webkit.gyp:pull_in_test_shell, eliminating the circular relationship between webkit.gyp and test_shell.gyp. The expected semantics of building all of test_shell during a webkit.gyp:All build is performed are retained. This change depends on GYP r781 (in Chromium at r38526) for GYP suffix operator path section treatment. It also depends on Chromium r38519 and r38658 for common.gypi treatment of chromium_code. BUG=33186 TEST=Xcode no longer holds stale project files in memory Review URL: http://codereview.chromium.org/602006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38664 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 08:53:13 +0000