| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
happens in the browser with the correct profile.
BUG=86361
TEST=Create two profiles. Don't be signed in to either. Try to import bookmarks from Google Toolbar in Profile 1. When the alert dialog comes up to tell you to sign into GAIA, switch to the browser window for Profile 2. Now close the alert -- the page opening to let you sign in should appear on the window for Profile 1.
Review URL: http://codereview.chromium.org/8345006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PreviewArea class is responsible for what is happening in the preview area, and therefore some logic in print_preview.js that existed before PreviewArea class existed should be moved.
BUG=88098
TEST=NONE
Review URL: http://codereview.chromium.org/8320004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changelist does nothing but improve the formatting of comments.
BUG=94494
TEST=None; no code changed.
Review URL: http://codereview.chromium.org/8344012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68267
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8346013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass the Desktop's MessageLoop::Dispatcher to
MessageLoopForUI::RunAllPendingWithDispatcher() instead of
just calling RunAllPending() without a dispatcher.
Otherwise, we frequently get stuck forever in
MessagePumpX::RunOnce(). g_main_context_iteration() appears
to return true (indicating that it performed work)
indefinitely there for reasons that are unclear to me.
BUG=100671
TEST=ran aura_unittests successfully locally in conjunction with a change that was previously hanging consistently
Review URL: http://codereview.chromium.org/8346023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Python documentation recommends setting os.environ rather than calling
os.putenv. Both affect the environment for subprocesses, but variables set
with os.putenv are not visible to other Python code that calls os.getenv or
looks at os.environ. This is useful if e.g., test code needs to vary its
behavior based on which flags were passed to Chrome.
BUG= none
TEST= none
R=nirnimesh@chromium.org,ncbray@google.com
Review URL: http://codereview.chromium.org/8348020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
which is not defined when piping the output of the tests.
BUG=81271
TEST=none
Review URL: http://codereview.chromium.org/8267017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I fixed the thumbnail dimensions and changed the overlap offset (7px horizontal,0px vertical) according to the latest email from Josh.
BUG=chromium-os:20552
TEST=
Review URL: http://codereview.chromium.org/8353008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
BUG=98908
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's hard to tell the behaviors of those tests on the gpu bots, so I'll watch the bots after this lands, and update the test_expectations file accordingly.
BUG=none
TEST=gpu bots
Review URL: http://codereview.chromium.org/8346024
TBR=zmo@google.com
Review URL: http://codereview.chromium.org/8342042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's hard to tell the behaviors of those tests on the gpu bots, so I'll watch the bots after this lands, and update the test_expectations file accordingly.
BUG=none
TEST=gpu bots
Review URL: http://codereview.chromium.org/8346024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting UI.
If an extension sets a (wildcard, wildcard) content setting, disable the default
setting UI and display a banner.
BUG=NONE
TEST=manual
Review URL: http://codereview.chromium.org/8333015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Also adding a Reset method and a DCHECK to catch memory leaks.
Review URL: http://codereview.chromium.org/8356003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide.
Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists.
BUG=97185
TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/
Review URL: http://codereview.chromium.org/8317018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
After renaming the enum constants |marginValidationStates| in margin_utils.js, some call sites where not updated.
BUG=Grab a margin line and drag outside the page very fast, the line should snap on the min/max allowed value. Instead it stops somewhere within the page.
TEST=Lines snap correctly.
Review URL: http://codereview.chromium.org/8349022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90857
TEST=none
Review URL: http://codereview.chromium.org/8342012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeContentRendererClient transmits the plugin URL when it asks
the browser for plugin content settings.
BUG=81179
TEST=plugins.py plugins.PluginsTest.testBlockPluginExceptionWithSecondaryURL
Review URL: http://codereview.chromium.org/8132001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In previous CL, moved VIEW_GPU_IMAGE_TRANSPORT to UI_COMPOSITOR_IMAGE_TRANSPORT at reviewer request. Forgot to move views_gpu_image_transport to ui_compositor_image_transport.
R=ben@chromium.org
BUG=none
TEST=none (CL is a no-op)
Review URL: http://codereview.chromium.org/8353007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the PlatformFontPango implementation and the comments for
|GetFontSize()|. Update users of this API appropriately and update header
comments to clarify that sizes are in pixels. Also, a few misc cleanup
changes.
BUG=none
TEST=Existing unit tests pass. Font sizes in Chromium UI do not change.
Review URL: http://codereview.chromium.org/8267009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98345
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8343021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Show the bubble UI (http://crosbug.com/11690#c18) when both Shift keys are pressed.
BUG=chromium-os:11690
TEST=ran browser_tests
Review URL: http://codereview.chromium.org/8330016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WindowSizer up to it. Also removes window_sizer_win when building aura
as we shouldn't be using it with aura. Lastly I had to add AURA_EXPORT
to the FocusManager as visual studio doesn't like it when you try to
export a class that inherits from a non-exported class.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8346026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added QuotaManager::DeleteHostData method that takes host name
and deletes data for all origins related to the host.
As it is planned to provide quota manager users with a list
of hosts, they would not be able to delete host data, as
currently it is only possible to delete data by origin.
R=kinuko@chromium.org
BUG=none
TEST=QuotaManagerTest.DeleteHostData*
Review URL: http://codereview.chromium.org/8349032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8355002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20552
TEST=None
Review URL: http://codereview.chromium.org/8342035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:21065,chromium-os:21781,chromium-os:21755,chromium-os:21538
TEST=
Review URL: http://codereview.chromium.org/8354001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8336025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Short-circuit saving the InMemoryURLCache earlier if there is no history directory (helps with unit tests).
Check in ~InMemoryURLIndex to insure the cache has been saved before dtor called. (This will signal if the dtor is called before ShutDown for some reason.)
BUG=95876
TEST=Unit tests continue to succeed.
Review URL: http://codereview.chromium.org/8344002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for plug-ins.
We now check in the renderer if a plug-in is allowed by default, which is the case if the matching patterns are wildcards.
BUG=100581
TEST=see bug
Review URL: http://codereview.chromium.org/8334020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes chrome_frame_net_tests failure caused by r106214.
R=joaodasilva@chromium.org
BUG=None
TEST=Run KeywordTableTest.* and WebDatabaseMigrationTest.* in unit_tests. Verify that Web Data file without default search provider id is migrated to v40 successfully.
Review URL: http://codereview.chromium.org/8353001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
count the null character.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/8347019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=nirnimesh@chromium.org
BUG=100867
TEST=pyautos pass
Review URL: http://codereview.chromium.org/8357001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
error bubble.
BUG=100585
TEST=manual
Review URL: http://codereview.chromium.org/8321015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xkeyboard.cc.
BUG=None
TEST=ran try
Review URL: http://codereview.chromium.org/8344039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=73197
TEST=Remove an item from history and check that the remove button should be brought back to disabled state when no more items are selected for deletion.
Review URL: http://codereview.chromium.org/8341006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Panel doesn't hide when focus gets empty.
BUG=chromium-os:20552
TEST=None
Review URL: http://codereview.chromium.org/8336019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1076/1077: Allow gyp to support RULE_INPUT_DIRNAME so that output from rules can
have a similar path and not risk collision.
1078: Re-resolve conflict/collision between 1074 and 1076 commits.
1079/1080: make: SunOS / Solaris support.
BUG=none
TEST=none
TBR=mark
Review URL: http://codereview.chromium.org/8344033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization
Now that http://trac.webkit.org/changeset/97613 is rolled the test should be
steadily passing.
BUG=100538
TEST=WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization
TBR=pfeldman
Review URL: http://codereview.chromium.org/8346031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:19534
TEST=none
Review URL: http://codereview.chromium.org/8334019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dpranke
Review URL: http://codereview.chromium.org/8348030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=37978
TEST=Verify that history page with zero items should not display Edit Items button.
Review URL: http://codereview.chromium.org/8334010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add SpeechSynthesizerClient which consists the code copied from chromeos_speech_synthesis.cc
Remove the test ExtensionApiTest.TtsChromeOs from extension_tts_apitest.cc
BUG=chromium-os:16560
TEST=Enable accessibility feature by pressing Ctrl+Alt+Z on the login screen, ensure that it is speaking as before.
Review URL: http://codereview.chromium.org/8334018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106246 0039d316-1c4b-4281-b951-d872f2087c98
|