| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
code from chrome\common.
Also added canvas support and hooked up NPAPI interface functions.
No tests have been added yet, so this is probably not fully ready.
Review URL: http://codereview.chromium.org/291001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parsing the Http traffic. HttpBasicStream delegates parsing to HttpStreamParser in preparation for HttpPipelinedStream.
Original review: http://codereview.chromium.org/249031
BUG=13289
TEST=unittests
Review URL: http://codereview.chromium.org/283022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=asargent
Review URL: http://codereview.chromium.org/293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/294001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The InitFromValue code was modifying the JSON with some local data which
was then being re-used by the unpacker and sent up to the browser which
caused it to use this temporary local data as if it was the original
manifest source.
BUG=24398
TEST=pack and install override_igoogle extension
Review URL: http://codereview.chromium.org/276074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests (at least one of which I know was fixed upstream), record some more flakiness and crashiness.
BUG=7465,10311,17499,23498,24121,24182,24865
TEST=green bots
TBR=dglazkov
Review URL: http://codereview.chromium.org/292009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IMO, the original code was a premature optimization, and worse yet, it
had a subtle off by 1 bug due to floating point rounding (which was
identified by ERoman.... Thanks!!).
This CL removes the special code from linear histograms, and relies on
the "standard" binary search approach to locate the correct bucket
when a new sample is processed.
r=eroman
BUG=24160
Review URL: http://codereview.chromium.org/273065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
statically in the registry.TEST=Try disabling GCF and see if the chromeframe tag in the user agent is still set. It should not be. Also make sure you don't have an older version installed... the chromeframe tag should not be in the registry - if it is, you've got an older version still registered. This should fix the issue with going to wave.google.com after disabling chrome frame and seeing the white page of death.R=amitBUG=22760
Review URL: http://codereview.chromium.org/259025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves corresponding WebView and WebViewDelegate methods too.
This uses the term "Frontend" for what was previously known as "Client" in the
devtools interfaces. This is to avoid awkward "ClientClient" naming. Frontend
was Pavel Feldman's suggested renaming. In a follow up patch, I will be
renaming WebDevToolsClient{Delegate} to WebDevToolsFrontend{Client}.
R=dglazkov
BUG=24597
TEST=none
Review URL: http://codereview.chromium.org/287009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create TestHttpBridge for use by ProfileSyncServiceUnittest, so it
doesn't crash.
DoInitialize has been changed to take a HttpPostProviderFactory
before the core initialization. The HttpBridge is now created
on the UI thread instead of the core thread.
Create fake tagged nodes in the order that they are requested.
Make the request order consistent and in visual order since this is the
most natural way to request them.
TEST=Ran the affected unit tests on Windows, tested basic sync functionality with two concurrent browsers.
BUG=25021
Review URL: http://codereview.chromium.org/292008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we set the status of a URLRequestStatus to URLRequestStatus::CANCELED.
R=eroman
BUG=24674
TEST=none
Review URL: http://codereview.chromium.org/269064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907,25094
TEST=n/a
Review URL: http://codereview.chromium.org/283025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows 19px icons to be able to be used for both
browser and page icons.
I think it looks nicer with the page actions slightly smaller, and that is what we also usually do in Chrome,
but some Chrome location bar icons use 18px for soft edges,
so I guess this will just have to be something we advise
developers on.
We can actually fit up to 21 (whoa nelly) pixels on Windows,
but apparently the space is slightly smaller on mac.
Also minor layout fix. We were sizing the browser action
buttons 1px too short.
BUG=24881
TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should be 17px for the page action and 19px for the browser action and centered nicely in the space.
Review URL: http://codereview.chromium.org/286001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- So respawning the browser is more reliable.
BUG=25091
TEST=see bug
Review URL: http://codereview.chromium.org/283024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
lands.
BUG=9798,13708
TEST=tree should go green
Review URL: http://codereview.chromium.org/274084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=screenshot
Review URL: http://codereview.chromium.org/289004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25066
TEST=none
Review URL: http://codereview.chromium.org/274083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Avoid #ifdef in general, favoring #if defined().
In one spot, use PlatformThread::Sleep instead of rolling our own.
Review URL: http://codereview.chromium.org/267125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've added a GetModifiers() function to accompany the GetExpectations()
function for a given test - this allows clients to get all of the information
about a given file without having to dig at the implementation.
R=pam@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25098
TEST=make -j6 -r qt_faststart BUILDTYPE=Release
Review URL: http://codereview.chromium.org/289009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
attempts.
BUG=24996
TEST=Manually tested
Review URL: http://codereview.chromium.org/284008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tracking the thread id in the constructor, destructor and Start()
shows that the thread object can be started and stopped on
different threads. This means that there is a race condition
if Stop() or Join() gets called during Start(), which could cause
the thread to start with a pointer to a deleted object.
BUG=23251
TEST=none
Review URL: http://codereview.chromium.org/274079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24391
TEST=ResourceDispatcherHostTest.MimeSniff204
Review URL: http://codereview.chromium.org/274075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
patch by Thiago Farina
original review: http://codereview.chromium.org/268040/show
Review URL: http://codereview.chromium.org/290004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NTP fullscreen.
BUG=24463
Review URL: http://codereview.chromium.org/287015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
revocation checking
BUG=none
TEST=https://www.paypal.com and other EV sites should have green text to the right of the lock icon in the address field
Review URL: http://codereview.chromium.org/283005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
serverconnectionmanager won't get an auth_token set until
the Authenticator validates it. We had a bug where when we come online and the server connection manager determines
that a server is reachable, we would drop the request to authenticate (which is the first step in getting the auth token
set properly). This was resulting in subsequent requests returning 401 UNAUTHORIZED, and sync getting stuck in an offline
state.
The fix is to set the auth token on startup, so the gaia authenticator and server connection manager start off on the same
page.
BUG=24973
TEST=setup sync, shutdown chrome. ipconfig /release, start chrome, ipconfig /renew. about:sync shoudl show 'READY'.
Review URL: http://codereview.chromium.org/285008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds two breakpad keys. "firstexception" will store the name and
reason for the first NSException caught by the event loop.
"lastexception" will store the same for the last one seen before
crashing.
http://crbug.com/24462
TEST=Hard to test without known exceptions to handle.
Review URL: http://codereview.chromium.org/275008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mark
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=13907
TBR=hclam
Review URL: http://codereview.chromium.org/284018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
theme.
BUG=18585
TEST=clicking
Review URL: http://codereview.chromium.org/289007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=13907
TEST=green tree plz
Review URL: http://codereview.chromium.org/289010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=dumps uploaded to crashserver has correct version info.
BUG=24900
Review URL: http://codereview.chromium.org/283019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
makes it so that bookmark all tabs only creates the folder if the user
presses ok. I wasn't happy adding another random arg to
BookmarkEditor::Show, so I added in a structure an enum. This makes it
clearer what Show should do.
I also fixed the following:
. On gtk we wouldn't always pick the right parent for nodes.
. The context menu item is now enabled on views/gtk.
And this now breaks the mac side. I'll straighten that out right after
landing this.
BUG=24367
TEST=Make sure 'bookmark all tabs' works, as well as the bookmark
editor work. (get to the bookmark editor by creating a new bookmark,
then clicking edit, or right clicking a bookmark on the bookmark bar and
choosing edit).
Review URL: http://codereview.chromium.org/271115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome\tools\test\reference_builds.
This CL updates the chrome frame tests to register the chrome frame dll from the correct path and deletes
the reference build used by ChromeFrame.
Fixes http://code.google.com/p/chromium/issues/detail?id=23382
Bug=23382
Review URL: http://codereview.chromium.org/284016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/283016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enabled tests that may trigger this condition.
TEST=no new tests
BUG=none
Review URL: http://codereview.chromium.org/285006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25103
TEST=Start chrome, verify app menu says 'Synchronize my bookmarks...'.
Click it, and set up sync. Reopen app menu, and it should say 'Bookmarks synced...'
Review URL: http://codereview.chromium.org/274078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
autocomplete edit are returned correctly
to accessibility clients like screen readers.
We achieve this by sending off the WM_GETOBJECT message to the underlying native view HWND if the current
view cannot return accessibility information for its children.
Fixes portions of http://code.google.com/p/chromium/issues/detail?id=13291
Bug=13291
Review URL: http://codereview.chromium.org/287007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command line parameter to modify the behavior changes from
--enable-byte-range-support
to
--disable-byte-range-support
BUG=24989
TEST= current tests
Review URL: http://codereview.chromium.org/267132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Mostly, the tests are just slow and need to be given more time.
Review URL: http://codereview.chromium.org/283020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Still no actual drawing code for badges, though.
BUG=24635
TEST=Load the sample test_page_action extension and click the page action to cycle through various states.
Review URL: http://codereview.chromium.org/269079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=green! please!!!
TBR=hclam
Review URL: http://codereview.chromium.org/283021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that it assumed browser->window() was non-null, but with toolkit_views
this ends up being called before window has been assigned.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/290002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unecessay temporary copy of SkMatrix.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
TEST=none
BUG=24757
Review URL: http://codereview.chromium.org/290003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Run HeadersIterator_Reset and the Reset test for StringTokenizer
BUG=none
Review URL: http://codereview.chromium.org/276067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25070
TEST=add -fPIC to gcc. Old code failed to build. New code builds with 64 bit.
Review URL: http://codereview.chromium.org/269106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29329 0039d316-1c4b-4281-b951-d872f2087c98
|