| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/553118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension_popup_apitest.cc unit test.
I also removed the flaky designator from this test, as I was able to run the test (under stress conditions of 10 concurrent instances) without failure.
BUG=27271
TEST=extension_popup_apitest.cc (ExtensionApiTest.Popup)
Review URL: http://codereview.chromium.org/548157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32871
Review URL: http://codereview.chromium.org/548156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
TEST=none
BUG=33045
Review URL: http://codereview.chromium.org/556044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
TEST=none
BUG=33045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31719
TEST=none
Review URL: http://codereview.chromium.org/552174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
TEST=none
BUG=not anymore!
Review URL: http://codereview.chromium.org/554088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a prerequisite to change 545068.
BUG=27526
TEST=Added unit tests, manual testing on mac, linux, windows.
Review URL: http://codereview.chromium.org/543176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/waterfall.fyi/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/6369/steps/compile/logs/stdio
This has been broken for a long time, I think basically since Linux switched to
use_system_ssl=0.
Also fix a couple unrelated shared lib failures in media.
Review URL: http://codereview.chromium.org/553097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This uses some assembly that is NOT SECURE. This CL is for development
ONLY.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555082
TBR=dspringer@google.com
Review URL: http://codereview.chromium.org/548163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This uses some assembly that is NOT SECURE. This CL is for development
ONLY.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark-only columns. Add getters and setters for BookmarkSpecifics to
syncapi as well as syncable entries. Make the datatype be a required
property when creating a syncapi node. Add a datatype for the 'google
chrome' top level folder. Add database migrations from version 67 to
the new schema. Add infrastructure to support migrations generically.
Add unit tests for the migrations.
Pull a new version of the protobuf library to pick up a fix for a
bug that this change exposed (I upstreamed the fix).
Fix some example code in the sql helpers so that it would actually
compile.
BUG=29899,30041
TEST=New unit tests for migrations: unit tests are based on actual
database dumps. Additionally, I manually tested 2-client sync using
combos of old-protocol servers, new-protocol servers, and initial
database versions v67, v68, and v0 (new client). I manually verified
that add/edit/delete works in these combination cases. Afterwards I
verified (by inspecting the sync databases) that the ModelTypes are
consistent across the various migration/protocol paths.
Review URL: http://codereview.chromium.org/554066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cookies by origin.
BUG=none
TEST=Mac Valgrind unit_tests
Review URL: http://codereview.chromium.org/555124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28062
Review URL: http://codereview.chromium.org/549173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=33197
TEST=Verified that Chrome builds.
Review URL: http://codereview.chromium.org/549163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
was passed to it or not. In the latter case 'Configure IME' menu is not
shown.
BUG=33197
TEST=Could be tested on login manager screen later. Right now browser can be set
to NULL in debugger manually.
Review URL: http://codereview.chromium.org/553096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this change images where copied inline in IPC messages on non-Windows platforms. Copying an oversized image would cause the IPC system to bork and crash the renderer.
Changes in this CL:
* All platforms use a unified mechanism to copy images using shared memory.
* Introduced a new IPC message so the renderer can allocated a shared memory segment on OS X.
* On OS X tried to keep as few copies of the image data in memory as possible.
BUG=26822
TEST=1)On all platforms: navigate to a webpage, right click on an image and copy. Then try pasting into an image editor. 2)Repro steps in bug should no longer crash the Renderer on Mac/Linux
Review URL: http://codereview.chromium.org/552129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows Debug.
Test seems to pass continuously on Mac -> remove from test_expectations.txt.
(see http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=tables/mozilla/bugs/bug28341.html)
BUG=32231
TEST=tables/mozilla/bugs/bug28341.html
Review URL: http://codereview.chromium.org/557015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from navigation
We now have 4 categories, and we gather histogram for each
of those categories.
In addition, I transitioned all the A/B experiments to use
the data only when a "real" navigation takes place, and not
when a reload or back/forward is instigated.
BUG=33229
r=darin
Review URL: http://codereview.chromium.org/555109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I forgot changing the test result for "LayoutTests/editing/pasteboard/paste-xml.xhtml" since my r37241 also fixes its output image.
TBR=dglazkov
BUG=none
Review URL: http://codereview.chromium.org/555128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rel="updates alternate". Now it is.
BUG=None
TEST=Covered by automated browser test (included).
Review URL: http://codereview.chromium.org/555127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a MockSpellCheck class, a mock implementation of our SpellCheck class, to test_shell so we can render dotted-underlines to misspelled words.
Unfortunately, this class is currently enabled only on Mac since it needs rebaselines on Windows and Linux.
BUG=11577,23497
TEST=run run_webkit_tests.sh on Mac
Review URL: http://codereview.chromium.org/493003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/556037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16447
TEST=Covered by automated tests.
Review URL: http://codereview.chromium.org/549168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=33247
TBR=ukai
Review URL: http://codereview.chromium.org/549170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r53844, and we don't need to do rebaseline for it.
BUG=10353
TEST=LayoutTests/fast/forms/textarea-rows-cols.html
Review URL: http://codereview.chromium.org/557013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until we create a chrome.windows-specific example
(see bug crbug.com/33213), we can point
to the tabs example that uses chrome.windows.
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/552172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supporting resize for the container).
Also improved RTL support a bit (the divider wasn't drawn on
the right side of the container and resizing was reversed).
BUG=32101
TEST=Overflow menu for browser action container should now work.
Make sure to test also right-clicking on a menu item in the overflow
menu to bring up a context menu for that item. And resizing the
container in RTL locales should work.
Review URL: http://codereview.chromium.org/557006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Cut/Copy/Paste items in page menu should work in both omnibox and web content.
Review URL: http://codereview.chromium.org/556016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/549169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/554085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
accordingly.
Bug=16447
TBR=finnur
Review URL: http://codereview.chromium.org/543223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/552063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initialization to SSLClientSocketNSS in src/net so that
src/base does not depend on the NSS SSL library. Call
PL_ArenaFinish in the NSPRInitSingleton destructor instead
of the NSSInitSingleton destructor because PLArena is part
of NSPR.
R=agl,ukai
BUG=28744
TEST=covered by existing tests.
Review URL: http://codereview.chromium.org/554096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installing / patching.
BUG=33217
TEST=chrome_frame_mini_installer.exe installs chrome frame correctly.
Review URL: http://codereview.chromium.org/557011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
get_absolute_path().
BUG=none
TBR=dglazkov@chromium.org
TEST=valgrind bots actually run :)
Review URL: http://codereview.chromium.org/555121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=satorux
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See bug for more details.
BUG=33120
TEST=Put sleep(15) before post of on_work_done_task, made sure OnAuthDone doesn't get called on shutdown.
Review URL: http://codereview.chromium.org/548147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run_webkit_tests doesn't complain about missing tests
R=jorlow@chromium.org
Review URL: http://codereview.chromium.org/553112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=33195
TBR=darin
Review URL: http://codereview.chromium.org/555117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9962
Review URL: http://codereview.chromium.org/557008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31846
TEST=None (automated tests will follow once the event-faking infrastructure is in place on the Mac)
Review URL: http://codereview.chromium.org/555107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made mac_util.mm and chrome_paths_mac.mm use GetUserDirectory().
Made firefox_importer_utils_mac.mm use PathService.
Added unittests for GetUserDirectory().
BUG=22045
TEST=trybots
Review URL: http://codereview.chromium.org/548123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
attribute of the button to the correct key.
BUG=33124
TEST=Check that the Certificate Information button is enabled on an https page.
Review URL: http://codereview.chromium.org/552171
Patch from Vernon Tang.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32996
TEST=Mouseover and drag should work correctly in Google Earth and Flash 10.1.
Review URL: http://codereview.chromium.org/551154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18063
TEST=Installer an update while Chrome is running. Log out of machine without closing Chrome first and make sure sure Chrome gets updated cleanly whenever it is launched next.
Review URL: http://codereview.chromium.org/553079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This matches Mozilla, which uses ~/.mozilla/plugins.
BUG=22261
TEST=watch an strace, see that it hits the appropriate dir when loading plugins
Review URL: http://codereview.chromium.org/553102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with PEP-8 in preparation for upstreaming this code to webkit.org.
This change was done by running the pep8_names.py script I wrote (
attached to https://bugs.webkit.org/show_bug.cgi?id=31498) with the following
command-line parameters:
% ./pep8_names.py -i --acronym WebKit --acronym LigHTTPd --acronym WDiff \
--acronym BuildBot *.py */*.py
The code was then reformatted to fit the 79-character line limit.
BUG=23099
TEST=none
R=levin@chromium.org
Review URL: http://codereview.chromium.org/553089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This fixes the crash in compact navigation bar without a adjustment.
- I didn't remove the adjustment because ths is necessary to make the compact navigation bar transparent. (currently, the clipping code assumes that the fixed widget and the actual opaque child have the same side, which is not the case for AutocompleteEditView.
BUG=chromium-os:1010
TEST=manual: compact nav bar does not crash.
Review URL: http://codereview.chromium.org/548151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37198 0039d316-1c4b-4281-b951-d872f2087c98
|