summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move the NTP HTML generation to early so we can avoid an extratony@chromium.org2009-11-243-20/+23
| | | | | | | | | | | | | trip to the UI thread later. Not sure if this will make a difference. Move the NTP and CSS handler init to after adding the MostVistedHandler. This should allow an earlier db fetch for the cases when the HTML/CSS are not in the cache (e.g., browser startup). Review URL: http://codereview.chromium.org/439013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32899 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes extension packing codepath that was hitting a race condition DCHECK ↵andybons@chromium.org2009-11-243-0/+8
| | | | | | | | | | described in http://crbug.com/27944. BUG=28530 TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash. Review URL: http://codereview.chromium.org/436008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32898 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for bellagio compatibility.ajwong@chromium.org2009-11-242-43/+46
| | | | | | Review URL: http://codereview.chromium.org/435011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32897 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame's host network stack implementation for IE full tab mode ↵ananta@chromium.org2009-11-245-50/+107
| | | | | | | | | | | | | | | | | | | | | | | | implicitly follows redirects. When Chrome receives a notification about a redirect it also attempts to follow the redirect request. While this works in most cases, some sites actually returned an error for the second request initiated by Chrome. Fix is to abort the request in urlmon, when we receive a notification about a redirect. I also fixed the IsRedirectResponse function in the UrlRequestAutomationJob class to only treat 301, 302, 303 and 307 as redirect codes on the same lines as the default http job. Test=covered by existing network tests. I also verified that http://code.google.com/p/chromium/issues/detail?id=25643 works with this CL. Fixes http://code.google.com/p/chromium/issues/detail?id=28296 Bug=28296 Review URL: http://codereview.chromium.org/402107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32896 0039d316-1c4b-4281-b951-d872f2087c98
* A mind numbing change to add the notion of a persistent groupId, and to get ↵michaeln@google.com2009-11-2412-61/+93
| | | | | | | | | | | | rid of the notion of an entryId. TEST=existing tests apply BUG=none Review URL: http://codereview.chromium.org/432012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32895 0039d316-1c4b-4281-b951-d872f2087c98
* Final part of PathString cleanup.munjal@chromium.org2009-11-2423-392/+295
| | | | | | | | | BUG=26342 TEST+exist Review URL: http://codereview.chromium.org/429003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32894 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show --help on ChromeOS.thestig@chromium.org2009-11-241-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/437030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32893 0039d316-1c4b-4281-b951-d872f2087c98
* Added main menu item for Sync in OS X. (Right below "Preferences..."). Made ↵akalin@chromium.org2009-11-2413-152/+340
| | | | | | | | | | | | | it work without a browser window being present. Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}. BUG=27995 TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in. Review URL: http://codereview.chromium.org/423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
* Updates demo to one that uses a texture.gman@chromium.org2009-11-2418-1289/+1728
| | | | | | | | | This excersized more code and found several bugs. Review URL: http://codereview.chromium.org/437020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32891 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline one layout test.jianli@chromium.org2009-11-243-68/+89
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/432011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32890 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when an extension popup shows a JS alert. Showing the alert takes...rafaelw@chromium.org2009-11-245-39/+76
| | | | | | | | | | | | | | | | Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show. Disable showing JS alerts from popups, because doing so makes the popup disappear immediately, which has all sorts of unfortunate side effects for the poor orphaned alert (see bug for details). BUG=27758 TEST=create extension with popup, put link with |onclick="alert('test');"| in it; install extension, open popup, and click link; see no crash (nor popup) Review URL: http://codereview.chromium.org/435010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98
* Variation of signature for suppression in bug 28027.tim@chromium.org2009-11-231-0/+26
| | | | | | | | | TBR=levin BUG=28027 Review URL: http://codereview.chromium.org/434029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32888 0039d316-1c4b-4281-b951-d872f2087c98
* page info dialog polish:estade@chromium.org2009-11-233-9/+8
| | | | | | | | | | | | | | GTK: - set default size of contents, rather than window as a whole---this gets line wrapping right. All: - change title string to Title Case instead of Sentence case - fix Connection text for mixed/unsafe content BUG=28507 Review URL: http://codereview.chromium.org/437026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32887 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 32807, which was incorrectly reverted.mbelshe@google.com2009-11-232-3/+9
| | | | | | | | | | | | | | | | | | The async notification via OnReadComplete was still posting a callback through this message loop. This makes it difficult to write tests, as callbacks already scheduled will go in front of the OnReadComplete(). Treat the notifications through OnReadComplete as synchronous always. This doesn't effect existing tests, but makes my new tests possible. BUG=none TEST=this is the test! Review URL: http://codereview.chromium.org/436014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32886 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ResourceBundle::LoadImageResourceBytes since it appears totony@chromium.org2009-11-2310-19/+9
| | | | | | | | | be identical to LoadDataResourceBytes. Migrate callers to LoadDataResourceBytes. Review URL: http://codereview.chromium.org/437019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
* Increasing the default DB quota for extensions from 5MB to 50MB.dumi@chromium.org2009-11-231-1/+8
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/434017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32883 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for back/forward for url fragments. Improvements in the testingamit@chromium.org2009-11-233-18/+227
| | | | | | | | | | | | framwork include a non-scriptable interface for getting window handles from chrome frame activex and methods for sending input in the WebBrowserSink. BUG=none TEST=back forward unit test for url fragments (anchor) Review URL: http://codereview.chromium.org/430002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32882 0039d316-1c4b-4281-b951-d872f2087c98
* Flip: Fix cancellation code path.willchan@chromium.org2009-11-231-8/+8
| | | | | | | | The current fix is suboptimal, since we're doing unnecessary work in the FlipStream (still handling reads and writes for a cancelled stream), but just don't ever hand the data over to a user since they've already cancelled the stream. We should fix this, but don't bother for now. Not calling any user_callback_ is good enough for now. Review URL: http://codereview.chromium.org/439002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32881 0039d316-1c4b-4281-b951-d872f2087c98
* Moved common OpenSyncMyBookmarksDialog() code into SyncStatusUIHelper.akalin@chromium.org2009-11-235-29/+32
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32880 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux packaging options more granular.mmoss@chromium.org2009-11-234-103/+285
| | | | | | | | | This allows us to not waste time building packages/channels we don't care about. Also added option to build new 'trunk' channel packages, which are a special configuration for developer testing. Review URL: http://codereview.chromium.org/418021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32879 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind suppression for atexit leaktim@chromium.org2009-11-231-0/+8
| | | | | | | | | TBR=timurrrr BUG=28633 Review URL: http://codereview.chromium.org/439012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32878 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline relative-positioned-inline-container.html which is all that is ↵levin@chromium.org2009-11-234-86/+102
| | | | | | | | | | | | | needed for that test. Add and fix some bug numbers for other layout tests. BUG=17015,28409,28417 TEST=None Review URL: http://codereview.chromium.org/439001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32877 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chrome frame builder redness.ananta@chromium.org2009-11-231-2/+5
| | | | | | | | | | | The CLSCTX_ENABLE_CLOAKING flag if passed in to CoCreateInstance for Internet Explorer on IE causes the API to fail with E_INVALIDARG. We now or in this flag only for vista or greater. TBR=stoyan Review URL: http://codereview.chromium.org/434013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32869 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the ExtensionApiTest.ExecuteScript test as flaky as it failed for no ↵ananta@chromium.org2009-11-231-1/+3
| | | | | | | | | | | | | | | | apparent reason on the vista dbg builder. Issue http://code.google.com/p/chromium/issues/detail?id=28630 has been logged to track this. TBR=aa Bug=28630 Review URL: http://codereview.chromium.org/432010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32866 0039d316-1c4b-4281-b951-d872f2087c98
* Disable these only on linuxtim@chromium.org2009-11-231-4/+15
| | | | | | | | | TBR=levin BUG=28445 Review URL: http://codereview.chromium.org/437021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32865 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for gcc. Removed unused file.apatrick@google.com2009-11-232-941/+1
| | | | | | Review URL: http://codereview.chromium.org/434012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32864 0039d316-1c4b-4281-b951-d872f2087c98
* Disable more tests causing crashes and failures on LinuxTest(dbg) and ↵tim@chromium.org2009-11-231-3/+8
| | | | | | | | | | | valgrind (respectively). TBR=levin BUG=28445 Review URL: http://codereview.chromium.org/438007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32862 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new icon.aa@chromium.org2009-11-231-0/+0
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32861 0039d316-1c4b-4281-b951-d872f2087c98
* posix: split OS-specific bits out of sys_info_posixevan@chromium.org2009-11-235-50/+104
| | | | | | | | Split into Linux and BSD-specific files. Review URL: http://codereview.chromium.org/427010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32860 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FlipStreamTest::SendRequest as it causes leaks.tim@chromium.org2009-11-231-1/+2
| | | | | | | | | | | | I'm sorry for reverting your change earlier, looks like it wasn't the cause :( TBR=mbelshe BUG=28622 TEST=FlipStreamTest Review URL: http://codereview.chromium.org/436009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32858 0039d316-1c4b-4281-b951-d872f2087c98
* Don't select a default entry in the password autofill popup. jcampan@chromium.org2009-11-231-2/+3
| | | | | | | | | | | | | | | It is annoying as pressing tab/enter after modifying the text field value would select the popup default entry again overriding your change. BUG=24550 TEST=Trigger the password autofill entry. Modify the suggested See review: http://codereview.chromium.org/433001/show login name, press tab. The login you entered should be preserved. Review URL: http://codereview.chromium.org/438004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32857 0039d316-1c4b-4281-b951-d872f2087c98
* A large Content-Length header followed by a connection close could trigger ↵vandebo@chromium.org2009-11-234-17/+28
| | | | | | | | | | | | an out of memory condition. Fixed problem, added unit test, and clarified the API. This is probably the real problem in issue 25826. BUG=28346, 25826 TEST=HttpNetworkTransactionTest.LargeContentLengthThenReset Review URL: http://codereview.chromium.org/418035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32856 0039d316-1c4b-4281-b951-d872f2087c98
* testjam@chromium.org2009-11-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/434021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32855 0039d316-1c4b-4281-b951-d872f2087c98
* Fix environment variables not being used after switching to ↵jam@chromium.org2009-11-235-14/+16
| | | | | | | | | | ChildProcessLauncher. BUG=28602 TEST=verified flash works on Mac Review URL: http://codereview.chromium.org/439005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32854 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension updates use omaha id when talking to omaha.asargent@chromium.org2009-11-233-1/+145
| | | | | | | | | | BUG=b/2168147 TEST=Extensions auto-updates should still work. Review URL: http://codereview.chromium.org/403026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32853 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 51253:51310.jianli@chromium.org2009-11-232-4/+20
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/431014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32852 0039d316-1c4b-4281-b951-d872f2087c98
* Removed browser owned by HtmlDialogWindowController. This fixes the crashakalin@chromium.org2009-11-232-28/+48
| | | | | | | | | | | | | | | | | | described in issue 28329. Use a non-incognito profile for HTML dialogs and any links launched from them. This diverges from the behavior on Windows, but according to beng this is okay. Made it so that HTML dialog boxes don't keep history. BUG=28329 TEST=made sure there is no crash when closing the browser with the sync setup wizard open Review URL: http://codereview.chromium.org/416004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32851 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all ErrorPage tests as FLAKY.phajdan.jr@chromium.org2009-11-231-75/+21
| | | | | | | | | | | | | | | It's a race condition which used to manifest more frequently on XP, but in fact it exists on all platforms. People started adding even more #ifdefs and things when tests failed on Linux too, so let's just say they're all flaky. :-( TEST=none BUG=22877 Review URL: http://codereview.chromium.org/437016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32849 0039d316-1c4b-4281-b951-d872f2087c98
* The appcache system uses two threads, an IO thread and a DB thread.michaeln@google.com2009-11-239-19/+166
| | | | | | | | | | | | | | | It does not create these threads, the embedder is responsible for providing them to the appcache library by implementing the class declared in appcache_thread.h. Also in this CL are two implementations, one for Chrome and another for test_shell. TEST=none BUG=none Review URL: http://codereview.chromium.org/409005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32846 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: display DOM calls in CPU profiles.mnaganov@chromium.org2009-11-231-2/+2
| | | | | | | | | | | | | This patch only allows the corresponding log entries to be processed and displayed. In order to have those entries in the log, a newer version of V8 is needed. BUG=27613 TEST=none Review URL: http://codereview.chromium.org/434008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32845 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted cleanup.estade@chromium.org2009-11-2315-61/+34
| | | | | | | | process: grep for TODO(port), find cruft, clean it up Review URL: http://codereview.chromium.org/427004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32844 0039d316-1c4b-4281-b951-d872f2087c98
* Add platform abstraction for simple error box, and use it in a couple ↵estade@chromium.org2009-11-2311-57/+46
| | | | | | | | | | | | extensions-related places. Also add a virtual destructor in some unrelated infobar. BUG=27691 Review URL: http://codereview.chromium.org/427002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32840 0039d316-1c4b-4281-b951-d872f2087c98
* Believe this causes the valgrind linux test failures. Since it is a small ↵tim@chromium.org2009-11-232-9/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | change I decided to revert instead of disable the test. Revert 32807 - The async notification via OnReadComplete was still posting a callback through this message loop. This makes it difficult to write tests, as callbacks already scheduled will go in front of the OnReadComplete(). Treat the notifications through OnReadComplete as synchronous always. This doesn't effect existing tests, but makes my new tests possible. TBR=mbelshe BUG=none TEST=this is the test! Review URL: http://codereview.chromium.org/414073 TBR=mbelshe@google.com Review URL: http://codereview.chromium.org/431016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32838 0039d316-1c4b-4281-b951-d872f2087c98
* views: remove some unnecessary static_cast<int>.maruel@chromium.org2009-11-232-6/+5
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/429004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32837 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind run.maruel@chromium.org2009-11-234-13/+116
| | | | | | | | TEST=valgrind works BUG=none Review URL: http://codereview.chromium.org/437014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32836 0039d316-1c4b-4281-b951-d872f2087c98
* Add a label member to the FormField class. This member will hold the value ↵jhawkins@chromium.org2009-11-235-18/+47
| | | | | | | | | | of the field's label once we parse this value from the DOM. BUG=none TEST=none Review URL: http://codereview.chromium.org/418032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32834 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug when accessing g_browser_process->broker_services() at shutdown.jam@chromium.org2009-11-236-22/+38
| | | | | | | BUG=28501 Review URL: http://codereview.chromium.org/435001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix recognizing FTP listings consisting of only one line.phajdan.jr@chromium.org2009-11-238-1/+66
| | | | | | | | | | | | | | It turns out we have to be a little more strict with that. Before this change both ls and VMS listing parsers would claim that they recognize the format. Also fallback to Mozilla code was broken in that case. TEST=Covered by net_unittests. BUG=28263 Review URL: http://codereview.chromium.org/421006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32831 0039d316-1c4b-4281-b951-d872f2087c98
* Roll GTM dep.thakis@chromium.org2009-11-231-1/+1
| | | | | | | | | | | Roll GTM dep to pick up http://code.google.com/p/google-toolbox-for-mac/source/detail?r=259 . BUG=28478 TEST=Install theme with light text on dark background; should look ok (see bug). Review URL: http://codereview.chromium.org/436005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32830 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing GCC 4.4 build fix (landing a patch for hbono)ian@chromium.org2009-11-231-1/+1
| | | | | | | | | | | | | | This patch was written by hbono, landing for him as he can't land this until tomorrow, and it's a patch to fix a build. Reviewed at http://codereview.chromium.org/414025 BUG=none TEST=GCC 4.4 compiles Review URL: http://codereview.chromium.org/436003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32829 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 20:53:11 +0000