| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GUI is still missing, so certificates and private keys have to be
stored manually, p.e.:
$ pk12util -d sql:$HOME/.pki/nssdb -i PKCS12_file.p12
Adds --auto-ssl-client-auth command-line option to enable this feature.
Patch contributed by Jaime Soriano <jsorianopastor@gmail.com>.
Original review URL: http://codereview.chromium.org/220009
R=wtc
BUG=16830
TEST=Try to connect to a web page that requires SSL authentication and
confirm that it connects if and only if a valid certificate is stored in
the ~/.pki/nssdb database.
Review URL: http://codereview.chromium.org/276037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on ENABLE_SHARED_WORKERS by default, but disable the SharedWorker bindings
so they are not available. This allows the SharedWorker code to get compiled in
to fight against bit rot, but prevents applications from using this API yet.
TEST=existing layout tests suffice
Review URL: http://codereview.chromium.org/273019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make all ICU symbols "private extern" on the Mac
BUG=24911
TEST=See r29177 and http://codereview.chromium.org/281006
Review URL: http://codereview.chromium.org/273071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24876
TEST=none
Review URL: http://codereview.chromium.org/267113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=24911
TEST=mac$ nm C.app/Contents/Versions/*/C F.framework/C F | grep " [A-TV-Z] "
should not show any NSPR symbols. The following NSPR symbols were
formerly exported:
__Z14PR_ImplodeTimePK14PRExplodedTime
__Z16PR_GMTParametersPK14PRExplodedTime
__Z16PR_NormalizeTimeP14PRExplodedTimePF16PRTimeParametersPKS_E
__Z18PR_ParseTimeStringPKciPx
These symbols should no longer be exported on any platform.
Review URL: http://codereview.chromium.org/274068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
need to leak beyond the module in which they're used.
BUG=24911
TEST=nm C.app/Contents/Versions/*/C F.framework/C F | grep " [A-TV-Z] " should
not show _MacConvertYUVToRGB32Row or _MacScaleYUVToRGB32Row.
Review URL: http://codereview.chromium.org/269098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=N/A
Review URL: http://codereview.chromium.org/282009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jeremy
Review URL: http://codereview.chromium.org/269097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests have been running fine since my fix. Also removing the traces I added for debugging.
TBR=jcampan
BUG=23686
TEST=Change is enabling the test.
Review URL: http://codereview.chromium.org/273069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24503,24936
TBR=dank
Review URL: http://codereview.chromium.org/273070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/282008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds support for SQLite memory use tracking in the task manager and enables it for the browser process. SQLite can get into the 10s of MB of memory pretty easily and it is nice to see exactly how much of a 'fat' browser process it is responsible for.
SQLite is also used in the renderer process for web databases, but since those are behind a flag and off by default I haven't added support for them yet.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/276009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
upcoming patch. TBR=nick
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21541
TEST=Covered by unit_tests.
Review URL: http://codereview.chromium.org/276047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=see bug report. Also play with entering and leaving fullscreen.
Review URL: http://codereview.chromium.org/269070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
being screwed up screwed up when DWM is toggled or themes are installed or reset.
The first part of the fix was to remove the hack I put in to hide then show the window while the frame type change occurs.
The hack was to work around the fact that upon returning to glass from non-glass, the area identified by BrowserFrameWin::OnNCCalcSize as client was filled with solid black vs. transparent black.
I don't know why this fix works, but returning a client size for the opaque frame as 1 pixel different to the window rect causes the blackness bug to not occur, so that's what I did (in addition to removing the hack).
I also had to put in a couple of fixes to accommodate the pixel turd we gain in the opaque frame. I renamed ChangeSize to LayoutRootView. When we're using the opaque frame, since the views system is rendering the entire content of the window all the time I always size the widget to the window rect rather than the client rect.
http://crbug.com/15424
TEST=change the frame type by:
- turning on/off aero glass
- installing a theme, then resetting
- running an app that forces the DWM off, e.g. the O3D plugin
The frame should appear correct after the transition in either direction, and window z-order should be preserved.
Review URL: http://codereview.chromium.org/266013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux.
Nanosleep on linux can miss its deadline by up to 10ms (according to the manpage). Pad 20ms (2x that amount) to give room for missed deadlines.
BUG=23974
TEST=listened to previously stuttering audio clip on low-end hardware.
Review URL: http://codereview.chromium.org/271081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in r405 - http://code.google.com/p/google-breakpad/source/detail?r=405
Which is needed for Mac Chromebot.
TEST=Crash reporting should still work on all platforms.
Review URL: http://codereview.chromium.org/269093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests are still leaking.
This reverts commit r29108.
TBR=rogerta
Review URL: http://codereview.chromium.org/264072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Make sure mini_installer Release still builds.
Review URL: http://codereview.chromium.org/271107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Massage test names into allowed set of characteres.
Luckily currently massaged names are still unique.
Review URL: http://codereview.chromium.org/269096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to add a test case that was failing before r29035
BUG=b/2071330
TEST=unittests
Review URL: http://codereview.chromium.org/281004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of white, black, and blue (respectively).
BUG=22967
TEST=Change system theme, start Chrome w/no theme, observe the NTP respects the system colors.
Review URL: http://codereview.chromium.org/273043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bug number. This should also allow linux to pass this test, since the failure appears to be win-specific.
BUG=24904
BUG=10353
TEST=no new redness
Review URL: http://codereview.chromium.org/281003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mac) can use it.
I will switch Windows over to the common function in a follow-up patch.
BUG=23882
TEST=gmail browser action sample extension
Review URL: http://codereview.chromium.org/279008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
link stage.
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/273067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
limit for a single browser test. I have therefore split it into three and added a more descriptive error message for when we time out.
I will remove the traces and the FLAKY_ label after a successful run or two on the bots.
BUG=23686
TEST=Tested by automated test.
Review URL: http://codereview.chromium.org/274066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=
*Search for something. Switch to textedit, search for something else. Switch back to chrome. The outdated "x of y" text should be invisble in the find bar, but the prev/next find result buttons should be enabled. Hit enter. Pages should be searched, "x of y " text should return.
* Open a findbar, search for something. Open new chrome window, hit cmd-f. findbar in new window should contain the text you searched for in the last window.
Review URL: http://codereview.chromium.org/267022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
results in thumbnails.
I could have added this directly to the new tab startup tests, but
that would mean turning on DOM automation for the new tab tests.
I was trying to avoid the extra code in the new tab startup tests.
Review URL: http://codereview.chromium.org/269060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash it appears that we're starting a drag for an index beyond that of
the model.
BUG=24132
TEST=none
Review URL: http://codereview.chromium.org/275023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was happenening because BrowserActionContainer, on receiving notification about an extension load/unload/change, deletes all BrowserAction views, re-adds all the views again, and asks the toolbar to SetBounds for the BrowserActionContainer. However, during deletion, it does not re-set the bounds. As a result, when SetBounds is called by the toolbar again, it does not see any changed in BrowserActionContainer, and does not layout again, causing all the browser actions to disappear. The solution lies in forcing Layout() after SetBounds() in ToolbarView.
BUG=23593
TEST=none
Review URL: http://codereview.chromium.org/276033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24902
TEST=Go to about:plugins, and verify that plugins in ~/Library/Internet Plug-Ins come before those in /Library/Internet Plug-Ins
Review URL: http://codereview.chromium.org/276045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The race is known but is not very severe and cannot be easily
fixed using locks due to the complexity of the third-party audio code.
BUG=24801
Review URL: http://codereview.chromium.org/282001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/274062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tab into it (allowing drags to window whose tab strip is fully obscured).
BUG=22283
TEST=all tab dragging between windows.
Review URL: http://codereview.chromium.org/281001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
context menu. Fix a typo in the grd file for adding a bookmark.
BUG=24363
TEST=bookmark all tabs, edit dialog still dims OK when url is invalid for bookmarks that aren't folders.
Review URL: http://codereview.chromium.org/269080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BrowserWindow::Activate(). Before this would ignore the existence of fullscreen windows.
BUG=http://crbug.com/21145
TEST=Trigger a javascript alert dialog. The original non-fullscreen window should not appear.
Review URL: http://codereview.chromium.org/274060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wstring. After this patch, I'm able to start chrome in a
user data dir with non-ascii characters on non-utf8 systems.
BUG=24444
Review URL: http://codereview.chromium.org/267085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
compiled one
and maintain it.
This is the first step towards shipping privacy blacklists in extensions.
The next step will be to make Profile own a BlacklistManager, and make ExtensionsService a BlacklistPathsProvider.
TEST=Covered by unit_tests.
BUG=21541
Review URL: http://codereview.chromium.org/164535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=24851,24852,24855,24856
TEST=none
Review URL: http://codereview.chromium.org/271103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
introduced a typo when converting CreateWebStorageNamespaceIfNecessary to use a conditional.
BUG=23400
TEST=none
TBR=jorlow
Review URL: http://codereview.chromium.org/282005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
underlying WebCore objects that manage the sqlite DB, causing its memory caches to be eliminated, and then recreates the objects on demand.
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/264062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HandleAuthChallenge.
Add a "const GURL& auth_origin" parameter to PopulateAuthChallenge, InvalidateRejectedAuthFromCache, and
SelectNextAuthIdentityToTry to eliminate the
AuthOrigin(target) calls in those three functions.
R=eroman
BUG=22264
TEST=none
Review URL: http://codereview.chromium.org/277005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BookmarkEditorController invalid for subsequent bookmark manipulation
(e.g. it can and does do a remove/add instead of an in-place edit).
Review URL: http://codereview.chromium.org/274039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29128 0039d316-1c4b-4281-b951-d872f2087c98
|