| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BrowserWindow interface that the Browser object can use to do locationbar-ey things without directly depending on Views.
Review URL: http://codereview.chromium.org/18826
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18772
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If you look at my last check-in you'll notice that all the lines have changed:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer.vcproj?r1=7827&r2=8652
Reitveld doesn't display these changes, which is why I didn't notice.
Review URL: http://codereview.chromium.org/18794
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- html, css and js to live in the installer as resources. The right combo of resources is selected based on system lang
- currently the approach is to have chrome show the eula by spawing setup.exe --show-eula
BUG=1468838
Review URL: http://codereview.chromium.org/18732
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
rebaselined. Georgian font is picked up now, so rebaseline two tests that depended on that fix.
Review URL: http://codereview.chromium.org/18834
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates the .vcproj files themselves for stylistic consistency
with the rest. Affected .vcproj files:
* No change (byte-for-byte identical):
third_party\libxml\build\libxml.vcproj
third_party\bsdiff\bsdiff.vcproj
third_party\sqlite\sqlite.vcproj
* Add empty <ToolFiles>, <References> and <Globals> sections:
third_party\libxslt\build\libxslt.vcproj
third_party\bspatch\bspatch.vcproj
third_party\bzip2\bzip2.vcproj
third_party\lzma\7z_C.vcproj
third_party\modp_b64\modp_b64.vcproj
third_party\libjpeg\libjpeg.vcproj
* Add explicit RootNamspace attribute:
third_party\bzip2\bzip2.vcproj
* Reorder DisableSpecificWarnings and PreprocessorDefinitions attributes
in VCCLCompilerTool:
third_party\bzip2\bzip2.vcproj
Review URL: http://codereview.chromium.org/18785
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(wtc says:
Jay Campan created the three certificates. He said
he created invalid_cert.pem by changing one byte in
the certificate's signature.
The reason we aren't using invalid_cert.pem is that our
test server won't start up with an invalid certificate.)
Review URL: http://codereview.chromium.org/18793
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
intermittent failure.
Review URL: http://codereview.chromium.org/18795
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/40146
http://trac.webkit.org/changeset/40148
Review URL: http://codereview.chromium.org/18791
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18796
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=5295
http://trac.webkit.org/changeset/39876
http://codereview.chromium.org/18201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18829
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=6315
Review URL: http://codereview.chromium.org/18672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18828
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18790
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18781
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This fixes the SHARED=1 build on Linux. sdch/SConscript last changed in r8644/issue 18717.
Review URL: http://codereview.chromium.org/18816
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/40144
http://trac.webkit.org/changeset/40147
Review URL: http://codereview.chromium.org/18787
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/40154
Review URL: http://codereview.chromium.org/18825
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18600
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
These were recently rebaselined on Windows. The differences are mostly due to recent SVG updates.
Review URL: http://codereview.chromium.org/18735
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18819
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke linux build.
Review URL: http://codereview.chromium.org/18820
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
isn't in chrome.sln).
TBR=rvargas
Review URL: http://codereview.chromium.org/18782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In the presence of an installed copy of the 6.1 SDK, SCons would pick up on the presence of the VC9 toolchain which tags along with it. It would proceed to populate the environment with a mismatched set of paths referring to VC9 includes and libs,
which in turn would cause the chrome base build to terminate with a LNK1103 error complaining of corrupt symbols.
Patch contributed by Siggi @ Google.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18817
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18764
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Reorganize the extensions in v8 (currently there was only one for GC debugging).
Review URL: http://codereview.chromium.org/18731
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
And build few files from there on Linux.
Review URL: http://codereview.chromium.org/18760
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
connectionerror.
BUG=1599954
Review URL: http://codereview.chromium.org/18811
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
modified the window layout (by a pixel or so) in the popup window case, which I haven't tried to make pixel-perfect yet anyway. Otherwise it's all reorg.
Clean up logic of nonclient view to be more consistent and coherent. Most things are now based on a small set of core functions that return various frame/nonclient thicknesses. This allows a noticeable reduction in the number of hardcoded constants, makes the code make more sense (even though a few places are longer than before), and makes it much easier to do things in the future like resizing various borders or handling system metrics better.
Rename and update comments for all constants to be more descriptive and less redundant.
Rename helper functions and variables for consistency, now that they've changed.
Remove an unused variant of TileImageInt(). Add a new one that takes an offset into the source image. This is used to rewrite the maximized bottom border tiling call in a way that doesn't rely on someone else clipping out or painting over the overdraw from tiling "too large" a source image. Probably no visible effect.
Make resize border hittest helper function able to handle borders of varying widths, and try to make parameter names more meaningful. Technically, we don't need the extra flexibility, since our bottom and side borders are the same thickness, but since there are different functions calculating that thickness on the caller side, it didn't hurt to not rely on that for the future.
BUG=5054
Review URL: http://codereview.chromium.org/18804
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18777
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
specific and it seems to confuse new folks from time to time.
Review URL: http://codereview.chromium.org/18812
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
which is reserved for command dispatch
Review URL: http://codereview.chromium.org/18773
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18538
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calling RegisterWaitForSingleObject with a handle to a process that has
already been terminated. (See the use of ProcessWatcher in the destructor
of BrowserRenderProcessHost.) I'm not sure that this explains why RWFSO
fails, but it seems like a reasonable change anyways. The MSDN docs do
not give any reasons for why RWFSO might fail.
R=maruel
BUG=3782
Review URL: http://codereview.chromium.org/18810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
current places where it triggers.
Fix thread_collision_warner for real this (third?) time.
Review URL: http://codereview.chromium.org/18569
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
On desktop environments like KDE, custom gtkrc files prevent test shell from
setting the theme correctly.
Review URL: http://codereview.chromium.org/18769
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is different on the buildbot than locally.
TBR=ojan
Review URL: http://codereview.chromium.org/18809
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/18529
TBR=brettw
Review URL: http://codereview.chromium.org/18808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the next modification.
Review URL: http://codereview.chromium.org/18719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also updates the .vcproj files themselves to fix minor stylistic
incompatibilities with the rest. Affected .vcproj files:
* No change (byte-for-byte identical):
media\build\media.vcproj
media\build\media_player.vcproj
media\build\media_unittests.vcproj
google_update\ondemand_updates.vcproj
* Remove .\ prefix where inconsistent with the rest of a filelist:
rlz\rlz.vcproj
breakpad\breakpad_handler.vcproj
* Add empty <ToolFiles>, <References> and <Globals> sections:
breakpad\breakpad_sender.vcproj
* Add explicit RootNamespace attribute:
sdch\sdch.vcproj
* Use Windows-canonical \ separators:
sdch\sdch.vcproj
* Remove unnecessary Filter and UniqueIdentifier attributes from
<Filter> declarations:
sdch\sdch.vcproj
Additional cleanups along for the ride:
* Split breakpad\SConscript logic into separate
breakpad_{handler,sender}.scons files.
* Add a media\media_player.scons configuration.
Review URL: http://codereview.chromium.org/18717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
more ifdefs.
Review URL: http://codereview.chromium.org/18766
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
due to small differences in font metrics and changes to form controls that have not been reflected in the baseline yet.
Review URL: http://codereview.chromium.org/18734
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8642 0039d316-1c4b-4281-b951-d872f2087c98
|