summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixing the flakiness in pyauto popup test.sunandt@google.com2011-04-221-1/+4
| | | | | | | | BUG=70659 TEST=popups.PopupsTest.testLaunchBlockedPopup Review URL: http://codereview.chromium.org/6898015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82698 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 84582:84639rolandsteiner@chromium.org2011-04-222-17/+18
| | | | | | | | BUG=none TEST=none TBR=johnnyg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82697 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced std::string argument storage in gpu_trace_event with faster ↵jbates@chromium.org2011-04-224-25/+215
| | | | | | | | | | | | | TraceValue. Second try to work around arm NULL definition bug. previous review: http://codereview.chromium.org/6877101 BUG=80172 TEST=tbd Review URL: http://codereview.chromium.org/6894016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82696 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82682 - Revert "Revert 82671 - V8ValueConverter: Handle exceptions ↵aa@chromium.org2011-04-223-332/+38
| | | | | | | | | when dealing with objectproperties.Review URL: http://codereview.chromium.org/6878086"This reverts commit 766b05b73a906cdcba68914a61dff49f398d87ad.TBR=joshia@chromium.org TBR=aa@chromium.org Review URL: http://codereview.chromium.org/6894032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82695 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable UILayoutTest.MediaUILayoutTest for Linux/Mac valgrind.scherkus@chromium.org2011-04-222-5/+0
| | | | | | | | | | | | Valgrind's slowness revealed an actual race condition that triggered a DCHECK. The race was fixed in r82683 so it's time to enable the tests! BUG=74473 TEST=MediaUILayoutTest no longer hit a DCHECK on valgrind TBR=timurrrr Review URL: http://codereview.chromium.org/6899035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82694 0039d316-1c4b-4281-b951-d872f2087c98
* Add .grd strings and remove outdated prototype.skerner@chromium.org2011-04-223-15/+16
| | | | | | | | | | BUG=None TEST=Builds Review URL: http://codereview.chromium.org/6898008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82693 0039d316-1c4b-4281-b951-d872f2087c98
* Use "Google Chrome Canary" instead of "Google Chrome Canary Build" asmark@chromium.org2011-04-221-1/+1
| | | | | | | | | | IDS_SXS_SHORTCUT_NAME. BUG=79814 TEST=none Review URL: http://codereview.chromium.org/6895023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82692 0039d316-1c4b-4281-b951-d872f2087c98
* Use "canary" instead of "canary build" as the channel name in the Windowsmark@chromium.org2011-04-222-13/+10
| | | | | | | | | | canary, matching the Mac canary and the new approved naming. BUG=79814 TEST=The About window Review URL: http://codereview.chromium.org/6895022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82691 0039d316-1c4b-4281-b951-d872f2087c98
* Use PseudoTcpAdapter in Chromotingsergeyu@chromium.org2011-04-224-96/+70
| | | | | | | | | | | | This will also avoid the problem with running cricket::PseudoTcpChannel in sandbox on Windows. BUG=None TEST=Unittests Review URL: http://codereview.chromium.org/6880126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82690 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky native events test. Failing on windows.kkania@chromium.org2011-04-221-2/+3
| | | | | | | | BUG=80295 TEST=none Review URL: http://codereview.chromium.org/6898018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82689 0039d316-1c4b-4281-b951-d872f2087c98
* Use large icon resource paksail@chromium.org2011-04-2216-80/+457
| | | | | | | | | | | | | | This is a part of r82185 that was reverted. The change was reverted because it caused a performance regression. In r82538 and r82584 I re-checked in code to split high-res icons into a seperate resource pak and load it. This change adds code to actually use use the high-res icons. BUG=None TEST=None Review URL: http://codereview.chromium.org/6897013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82688 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up valgrind suppressions for MediaTest.VideoBear tests.scherkus@chromium.org2011-04-222-4/+4
| | | | | | | | | | BUG=53825 TEST=should still be suppressed TBR=timurrrr Review URL: http://codereview.chromium.org/6880143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82687 0039d316-1c4b-4281-b951-d872f2087c98
* Extend PathService::Get to be able to return the X86 program files path.abodenha@chromium.org2011-04-223-13/+11
| | | | | | | | | | | | | | Cloud print's virtual driver needs this to be able to find the Chrome install directory. Since the port monitor is a 64 bit DLL on 64 bit Windows it needs to request the X86 folder explicitly. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82567 Review URL: http://codereview.chromium.org/6873159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82686 0039d316-1c4b-4281-b951-d872f2087c98
* Caused ARM build failure....amit@chromium.org2011-04-221-10/+2
| | | | | | | | Revert 82681 - [cros] Fixed order of enable/focus. Clear focus before settingR=altimofeev@chromium.orgBUG=chromium-os:13993TEST=Type wrong password on any pod on login screen. Try to login. Verify that focus is returned to cleared password field.Review URL: http://codereview.chromium.org/6880134 TBR=avayvod@chromium.org Review URL: http://codereview.chromium.org/6894030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82685 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the watchdog timer and some member variables from BufferedDataSource.scherkus@chromium.org2011-04-223-149/+0
| | | | | | | | | | | | | | | | | | | | | | | The root cause is that the WatchDogTask will always think the read has timed out since read_submitted_time_ only gets set during ReadTask. What this means is that while we may start the WatchDogTask inside InitializeTask... read_submitted_time_ remains 0 which means the initial loader can get killed if it takes longer than 2500ms to respond and for the initial ReadTask to get executed. In other words, a pretty likely scenario on laggier connections. Sequence of events: 1) Initial loader created and watch dog timer started in BDS::InitializeTask 2) The initial loader receives a response and BDS and rest of pipeline continues to initialize 3) BDS::WatchDogTask gets posted to render thread 4) FFmpegDemuxer issues a read, setting read_callback_ and posting BDS::ReadTask to render thread 5) BDS::WatchDogTask is executed, but since read_callback_ isn't NULL and read_submitted_time_ is zero the loader is recreated 6) BDS::ReadTask is executed and calls BRL::Read ***on the new loader*** 7) The new loader receives a response, which calls BDS::PartialReadStartCallback and calls BRL::Read 8) DCHECK(!read_callback_.get()) is hit inside BRL::Read BUG=74473 TEST=layout tests under valgrind Review URL: http://codereview.chromium.org/6899004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82683 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 82671 - V8ValueConverter: Handle exceptions when dealing with ↵aa@chromium.org2011-04-223-38/+332
| | | | | | | | | | objectproperties.Review URL: http://codereview.chromium.org/6878086" This reverts commit 766b05b73a906cdcba68914a61dff49f398d87ad. TBR=joshia@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82682 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Fixed order of enable/focus. Clear focus before settingavayvod@chromium.org2011-04-221-2/+10
| | | | | | | | | | R=altimofeev@chromium.org BUG=chromium-os:13993 TEST=Type wrong password on any pod on login screen. Try to login. Verify that focus is returned to cleared password field. Review URL: http://codereview.chromium.org/6880134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82681 0039d316-1c4b-4281-b951-d872f2087c98
* [Themes] Add UsingNativeTheme() method to ThemeServiceakalin@chromium.org2011-04-2214-119/+51
| | | | | | | | | | | | | | Remove GtkThemeInstalledInfobarDelegate and make ThemeInstalledInfobarDelegate use UsingNativeTheme(). Make some sync code use UsingNativeTheme(). BUG=80197 TEST= Review URL: http://codereview.chromium.org/6883129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82680 0039d316-1c4b-4281-b951-d872f2087c98
* This enlarges the dialog for the "pack extension" dialog boxgspencer@google.com2011-04-221-1/+1
| | | | | | | | | | | so that translated versions of the text will fit. BUG=(internal bug from translation team) TEST=Looked at dialog in French and Italian and saw that it was now able to contain the translated text. Review URL: http://codereview.chromium.org/6880125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82678 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82671 - V8ValueConverter: Handle exceptions when dealing with ↵aa@chromium.org2011-04-223-332/+38
| | | | | | | | | objectproperties.Review URL: http://codereview.chromium.org/6878086 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/6900020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82677 0039d316-1c4b-4281-b951-d872f2087c98
* Change status button menu (ClockMenu, NetworkMenu, PowerMenu) implementation ↵rhashimoto@chromium.org2011-04-2216-376/+589
| | | | | | | | | | | | | | | | from Menu2 to MenuItemView. This required modifying MenuItemView to support per-item fonts, which are needed to display the currently associated network in boldface. This CL depends on http://codereview.chromium.org/6870016/ to work properly on the ChromeOS login screen. BUG=chromium-os:13887 TEST=none Review URL: http://codereview.chromium.org/6811025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82676 0039d316-1c4b-4281-b951-d872f2087c98
* WebUI Prefs: Fix enter handling in homepage and start page autocomplete.stuartmorgan@chromium.org2011-04-222-2/+13
| | | | | | | | | BUG=80033 TEST=Type a URL into a start or home page field, and hit enter without selecting an autocomplete result. The edit should commit. Review URL: http://codereview.chromium.org/6891007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82675 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify class comment for ExtensionMessageHandler.aa@chromium.org2011-04-221-3/+2
| | | | | | TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82674 0039d316-1c4b-4281-b951-d872f2087c98
* Create media package and move media related files to it.nirnimesh@chromium.org2011-04-2216-31/+66
| | | | | | | Review URL: http://codereview.chromium.org/6880049 Patch from Kenji Imasaki <imasaki@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82673 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix valgrind errors in previous wmclass patch.erg@google.com2011-04-222-20/+1
| | | | | | | | | | | (Can't actually read that field; need to use the glib accessor.) BUG=80282,20587 TEST=valgrind goes green. Review URL: http://codereview.chromium.org/6896028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82672 0039d316-1c4b-4281-b951-d872f2087c98
* V8ValueConverter: Handle exceptions when dealing with objectaa@chromium.org2011-04-223-38/+332
| | | | | | | | properties. Review URL: http://codereview.chromium.org/6878086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82671 0039d316-1c4b-4281-b951-d872f2087c98
* Use HelpApp to show help on login screendpolukhin@chromium.org2011-04-222-85/+37
| | | | | | | | | | | instead of static help files from /usr/share/chromeos-assets/help. BUG=chromium-os:12741 TEST=manual Review URL: http://codereview.chromium.org/6895016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82670 0039d316-1c4b-4281-b951-d872f2087c98
* PrerenderManager is no longer refcounted.cbentzel@chromium.org2011-04-2213-153/+219
| | | | | | | | | | | | | | | | | | | | | | | | | | The PrerenderManager should be destroyed on the UI thread, along with the PrerenderContents that it owns. I originally did this by using the DeleteOnUIThread trait, but this leaked PrerenderManager's during browser shutdown, since the last reference was held by an object on the IO thread, and the DeleteTask was never processed. Now, the Profile owns the PrerenderManager's lifetime. All other references to the PrerenderManager are weak references. With the current thread-safety restrictions of WeakPtr's, this means that the presence of a PrererenderManager can not be checked on the IO thread, so all LOAD_PREFETCH requests will have a PrerenderResourceHandler constructed, regardless of whether the current profile supports prerendering. BUG=77930 TEST=Existing unit tests and browser tests. Review URL: http://codereview.chromium.org/6877085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82669 0039d316-1c4b-4281-b951-d872f2087c98
* Delay release of object Varspiman@google.com2011-04-222-6/+37
| | | | | | | | | BUG=chromium-os:14397 TEST=grooveshark Review URL: http://codereview.chromium.org/6900009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82667 0039d316-1c4b-4281-b951-d872f2087c98
* Only show 3g low data notification if we go from normal data to low data.chocobo@chromium.org2011-04-222-9/+32
| | | | | | | | BUG=chromium-os:12978 TEST=See notification when data runs low. Then disconnect from 3g and reconnect and see that we don't get another notification. Review URL: http://codereview.chromium.org/6880111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82665 0039d316-1c4b-4281-b951-d872f2087c98
* Scope some autorelease pools.avi@chromium.org2011-04-223-13/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6895019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82664 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82648 - roll skiaReview URL: http://codereview.chromium.org/6897017jar@chromium.org2011-04-221-1/+1
| | | | | | | | | Webkit has 9 red bots, and only 5 green. The tree can't stay this way. TBR=reed@google.com Review URL: http://codereview.chromium.org/6897020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82663 0039d316-1c4b-4281-b951-d872f2087c98
* Fix diagnostics and log messages in about:gpu.nduca@chromium.org2011-04-225-21/+51
| | | | | | | | BUG=78189 Review URL: http://codereview.chromium.org/6877028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82662 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: use default port for proxy server if none is specified.kuan@chromium.org2011-04-221-0/+2
| | | | | | | | BUG=chromium-os:14390 TEST=verify per bug report Review URL: http://codereview.chromium.org/6897004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82661 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Fix crash in NetworkLibrary - correct removal of NetworkDevice observers.nkostylev@chromium.org2011-04-224-9/+50
| | | | | | | | | BUG=chromium-os:14404 TEST=Manual. No crash with repro steps + status is monitored on resume. Review URL: http://codereview.chromium.org/6894019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82660 0039d316-1c4b-4281-b951-d872f2087c98
* ntp4 tweaks from alcorestade@chromium.org2011-04-223-5/+9
| | | | | | | | | | | | 1) fix fade effect on most visited (background color was blending with black; now it should just fade away) 2) reverse direction of horizontal scroll BUG=none TEST=none Review URL: http://codereview.chromium.org/6873144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82659 0039d316-1c4b-4281-b951-d872f2087c98
* Work around the special-case handling of 0 time values (see comment).brettw@chromium.org2011-04-221-0/+8
| | | | | | | | TEST=manual BUG=none Review URL: http://codereview.chromium.org/6894023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82652 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deletion of temp files from port monitor.abodenha@google.com2011-04-225-23/+37
| | | | | | | | | | | Adds a new switch to Chrome that will delete the printed file once the print dialog finishes. BUG= TEST= Review URL: http://codereview.chromium.org/6882092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82651 0039d316-1c4b-4281-b951-d872f2087c98
* Actually hook up the Pepper time message.brettw@chromium.org2011-04-221-0/+2
| | | | | | | TEST=manual Review URL: http://codereview.chromium.org/6898006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82650 0039d316-1c4b-4281-b951-d872f2087c98
* Allow I/O access on UI thread for theme pack loading.mirandac@google.com2011-04-221-0/+3
| | | | | | | | BUG=80206 TEST=no more thread access errors. Review URL: http://codereview.chromium.org/6880116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82649 0039d316-1c4b-4281-b951-d872f2087c98
* roll skiareed@google.com2011-04-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6897017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82648 0039d316-1c4b-4281-b951-d872f2087c98
* Increase prerender max-age limit to 30 seconds from 20 seconds.cbentzel@chromium.org2011-04-222-16/+20
| | | | | | | | | | | | Also, move the PrerenderManager constants out of a .h and into a .cc. BUG=None TEST=existing tests Review URL: http://codereview.chromium.org/6881113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82647 0039d316-1c4b-4281-b951-d872f2087c98
* More suppressions for MalwareDetailsTest::HttpCachecbentzel@chromium.org2011-04-221-0/+26
| | | | | | | | | BUG=79865 TEST=waterfall.sh match Review URL: http://codereview.chromium.org/6880136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82646 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix; don't overload GetConstrainingContents.avi@chromium.org2011-04-225-8/+9
| | | | | | | | | BUG=71097 TEST=none Review URL: http://codereview.chromium.org/6900017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82645 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leak in FileSystemDirURLRequestJobTest::SetUpcbentzel@chromium.org2011-04-221-0/+9
| | | | | | | | | BUG=80284 TEST=None Review URL: http://codereview.chromium.org/6895018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82644 0039d316-1c4b-4281-b951-d872f2087c98
* Move blocked content from TabContents to TabContentsWrapper.avi@chromium.org2011-04-2241-409/+621
| | | | | | | | | BUG=71097 TEST=hammer on popup blocking; should be no visible change Review URL: http://codereview.chromium.org/6854035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82643 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression for bug 80239cbentzel@chromium.org2011-04-221-1/+0
| | | | | | | | | BUG=80239 TEST=waterfall.sh match Review URL: http://codereview.chromium.org/6894021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82642 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for BrowserWindowGtk::Initcbentzel@chromium.org2011-04-221-1/+19
| | | | | | | | | BUG=80282 TEST=waterfall.sh match Review URL: http://codereview.chromium.org/6895017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82641 0039d316-1c4b-4281-b951-d872f2087c98
* net: add histograms for OCSP and CRL fetch failures.agl@chromium.org2011-04-221-30/+61
| | | | | | | | | | | | | Without parsing, we can't detect OCSP responses that actually mean "I don't know about this cert", or "This server has failed". But we can detect timeouts, HTTP errors etc. BUG=none TEST=none Review URL: http://codereview.chromium.org/6880123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82640 0039d316-1c4b-4281-b951-d872f2087c98
* Update DCHECK() usage to utilize the more expressive debugging functions.kushi.p@gmail.com2011-04-229-20/+20
| | | | | | | | BUG=58409 Review URL: http://codereview.chromium.org/6891008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82639 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 19:54:24 +0000