summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix two uninitialized memory accesses.deanm@chromium.org2008-12-042-3/+6
| | | | | | Review URL: http://codereview.chromium.org/12943 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6373 0039d316-1c4b-4281-b951-d872f2087c98
* Changed svn:eol-style of all .sln and .vcproj files to CRLFscherkus@chromium.org2008-12-04162-52514/+52514
| | | | | | Review URL: http://codereview.chromium.org/13133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
* tests_fixable edit FAIL (fix build)evanm@google.com2008-12-041-3/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6371 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in hammer changes.bradnelson@chromium.org2008-12-0413-67/+350
| | | | | | Review URL: http://codereview.chromium.org/13134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6370 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-pagefinnur@google.com2008-12-047-76/+174
| | | | | | | | | | | | | | | I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames. Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden). Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it. I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious). Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test. Review URL: http://codereview.chromium.org/13130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6369 0039d316-1c4b-4281-b951-d872f2087c98
* Add some failing tests to the fixable list in an attempt to get the Linux ↵evanm@google.com2008-12-041-1/+11
| | | | | | | | | builder green. Review URL: http://codereview.chromium.org/13136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6368 0039d316-1c4b-4281-b951-d872f2087c98
* really fix the ifdefpinkerton@google.com2008-12-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6367 0039d316-1c4b-4281-b951-d872f2087c98
* wrap logging with correct ifdefpinkerton@google.com2008-12-041-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6366 0039d316-1c4b-4281-b951-d872f2087c98
* Add support in spell check options sub-context menu to pop up fonts and ↵sidchat@google.com2008-12-042-3/+18
| | | | | | | | languages options menu. Review URL: http://codereview.chromium.org/12908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6364 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue in Spell Checker when certain words (such as especelly) did ↵sidchat@google.com2008-12-043-1674/+1732
| | | | | | | | | not give any suggestions. Issue=1677 Review URL: http://codereview.chromium.org/11285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6363 0039d316-1c4b-4281-b951-d872f2087c98
* Document WebKit Merge 38800:38850 regressionsdglazkov@google.com2008-12-041-0/+4
| | | | | | Review URL: http://codereview.chromium.org/13131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6362 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge 38800:38850, Part 3dglazkov@google.com2008-12-043-5/+9
| | | | | | Review URL: http://codereview.chromium.org/13118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6361 0039d316-1c4b-4281-b951-d872f2087c98
* add a target to run the ipc tests if and when they all pass. Fix up a ↵pinkerton@google.com2008-12-042-7/+79
| | | | | | | | signed/unsigned error in the ipc_message unit test. Review URL: http://codereview.chromium.org/12946 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6358 0039d316-1c4b-4281-b951-d872f2087c98
* Unify on "layout test mode" vs "interactive" and "non-interactive". We had ↵deanm@chromium.org2008-12-0413-54/+50
| | | | | | | | | | a layout test mode flag in some places, and an interactive flag in others. It was especially confusing since interactive = !layout_test_mode. This should make it much easier to grep for difference between layout test mode and normal "interactive" mode. Review URL: http://codereview.chromium.org/12940 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6357 0039d316-1c4b-4281-b951-d872f2087c98
* adding chrome_paths.ccpinkerton@google.com2008-12-041-0/+2
| | | | | | Review URL: http://codereview.chromium.org/13128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6355 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux match Windows and Mac in calling ResetWebPreferences. This was ↵deanm@chromium.org2008-12-041-1/+4
| | | | | | | | causing some slight font differences between layout test mode and interactive mode. Review URL: http://codereview.chromium.org/12941 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6354 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tests that pass on windows from failures list.ager@google.com2008-12-041-11/+3
| | | | | | Review URL: http://codereview.chromium.org/13124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6353 0039d316-1c4b-4281-b951-d872f2087c98
* Move ASSERT that was accidentally moved to the wrong position. Theager@google.com2008-12-041-6/+7
| | | | | | | | | | ASSERT is invalid in the new position and it is causing layout test failures in debug mode. TBR=feng Review URL: http://codereview.chromium.org/13123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6352 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore timeout of regexp-charclass-crash.html in debug mode.ager@google.com2008-12-041-0/+6
| | | | | | Review URL: http://codereview.chromium.org/13121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6351 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build by adding new V8 files to the xcode project.ager@google.com2008-12-041-2/+48
| | | | | | Review URL: http://codereview.chromium.org/13120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6350 0039d316-1c4b-4281-b951-d872f2087c98
* Update to latest trunk version of V8.ager@google.com2008-12-0413-27/+2980
| | | | | | | | | | | | | This includes Evan's change to use char instead of wchar_t for counter names. Also, because of changes to the regexp parser, we need to rebaseline a couple of tests mainly because of error message changes. Most of the tests were already rebaselined because of differences in error messages. Review URL: http://codereview.chromium.org/12902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6349 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing lib to fix windows webkit build.bradnelson@chromium.org2008-12-042-1/+2
| | | | | | Review URL: http://codereview.chromium.org/13119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6348 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off gtk double buffering of webwidget host's view_ widget, and manually ↵estade@chromium.org2008-12-041-2/+21
| | | | | | | | update underlying gdk window during paint operation. Review URL: http://codereview.chromium.org/13082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6347 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:eol-style LF for .h, .cc and .scons files.scherkus@chromium.org2008-12-043-444/+444
| | | | | | | | Set svn:eol-style native for .vcproj files. Set svn:eol-style CRLF for .sln files. Review URL: http://codereview.chromium.org/12931 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6346 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the compilation error in debug build on linux.fqian@google.com2008-12-041-0/+1
| | | | | | | | TBR = tony Review URL: http://codereview.chromium.org/12932 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6345 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: calculate fractional xheightagl@chromium.org2008-12-043-21/+29
| | | | | | | | | | | | | | | | | | | We need to push the calculation of the x-height into Skia. For one of the layout tests, it assumes that 2.5ex of Ahem is exactly 32px. Previously we calculated the x-height of Ahem to be 13px, so 2.5*13 was 33px. Now we use the 26.6 fixed point number from freetype's hinter and turn that directly into a floating point value (x-height is the only WebKit metric which is a floating point value). This lets us pass LayoutTests/css2.1/t1507-c526-font-sz-02-b-a.html (although the Windows baseline is wrong) Review URL: http://codereview.chromium.org/13112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6344 0039d316-1c4b-4281-b951-d872f2087c98
* De-peerable part 2. Lot of changes on the binding side.fqian@google.com2008-12-0412-412/+538
| | | | | | | | | | | The binding code relies on the type id to cast 'void*' to the right C++ type in order to call ref() and deref(). Bump third_party/WebKit to 6342 to include depeered RefCounted files and etc. Review URL: http://codereview.chromium.org/12903 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6343 0039d316-1c4b-4281-b951-d872f2087c98
* Stop filtering out the 'gears' SConscript on linux and mac.mpcomplete@chromium.org2008-12-041-2/+0
| | | | | | Review URL: http://codereview.chromium.org/12929 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6341 0039d316-1c4b-4281-b951-d872f2087c98
* Cut down on test shell chattiness.evanm@google.com2008-12-041-3/+0
| | | | | | | Review URL: http://codereview.chromium.org/13109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6340 0039d316-1c4b-4281-b951-d872f2087c98
* Add a flag to the layout test runner to run tests in random order.evanm@google.com2008-12-041-1/+9
| | | | | | | | | | This is useful for isolating whether a crash is caused by a particular test or by corruption in the test shell in general. Review URL: http://codereview.chromium.org/12926 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6339 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few screwed up bundle builders for Safari gears-scons.mpcomplete@chromium.org2008-12-041-4/+5
| | | | | | Review URL: http://codereview.chromium.org/13111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6338 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we end the update process if we get an errorfrom the servers. ↵paulg@google.com2008-12-043-8/+18
| | | | | | | | Previously, if we got a 400 (or other)error response, we'd leave the database and transactionopen.BUG=5060 (http://crbug.com/5060) Review URL: http://codereview.chromium.org/12918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6337 0039d316-1c4b-4281-b951-d872f2087c98
* fix buildtc@google.com2008-12-041-1/+1
| | | | | | | | | TBR=munjal Review URL: http://codereview.chromium.org/13110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6336 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: triage layout test issuesagl@chromium.org2008-12-041-3/+4
| | | | | | | | Two test failures are because of the lack of a Georgian font. One extra pass. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6335 0039d316-1c4b-4281-b951-d872f2087c98
* upgrade cache tool: Improve the handling of errors so thatrvargas@google.com2008-12-031-3/+14
| | | | | | | | | | we ignore as much as possible without aborting the whole process. R=nsylvain Review URL: http://codereview.chromium.org/12925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6334 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium-MultiProfile-Prototypemunjal@chromium.org2008-12-0377-19/+1376
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary ======= Implement a prototype of multiple profiles in Chrome by utilizing the functionality of user-data-dir command line flag that already exists. A profile in this case is an umbrella for all user data including cookies, history, bookmarks, settings, etc. Each profile gives the user a separation of all these data elements. User Interface ============== - Wrench > "New window in profile" menu item, with sub-menu items. This new menu item has sub menu items for each existing profile, for up to 9 profiles, and one more sub menu item to launch a window in a new profile. The 9 sub-menu items also have the accelerators like CTRL + SHIFT + 1, CTRL + SHIFT + 2, etc. If there are more than 9 profiles, we will also show an extra sub-menu item, "Other...". - New Profile dialog box This dialog box is shown to the use when (s)he clicks Wrench > New window in profile > <New Profile>. It lets the user specify a profile name, and also shows a checkbox to create a desktop shortcut to launch Chrome in that profile. - Choose profile dialog box This dialog box lets the user select a profile from a drop down to open a new window in. It also has an item <New Profile> in the drop down, selecting which will show the new profile dialog box mentioned above. CTRL + M shortcut also launches this dialog box. Code Organization ================= chrome\browser\user_data_dir_profile_manager.h/.cc: This class provides an abstraction of profiles on top of the user data dir command line flag. chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc New profile dialog box code. chrome\browser\views\user_data_dir_profiles_dialog.h/.cc Choose profile dialog box code. Review URL: http://codereview.chromium.org/12895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6333 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: another test passes now that we have arrows working.agl@chromium.org2008-12-031-1/+0
| | | | | | | (Arrows started working with missing glyph fallback) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6332 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove passing layout tests from the FAIL set.agl@chromium.org2008-12-031-22/+0
| | | | | | | | With CSS font-family fallback and missing glyph fallback now working, a bunch of layout tests now pass. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6331 0039d316-1c4b-4281-b951-d872f2087c98
* Remove trailing whitespace.evanm@google.com2008-12-031-26/+26
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6330 0039d316-1c4b-4281-b951-d872f2087c98
* update test list to explain failurestc@google.com2008-12-031-2/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6329 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use other fonts when the primary is missing glyphsagl@chromium.org2008-12-034-8/+46
| | | | | | | | | | | | | | | | | We had a bug where we weren't setting the fontdata for missing glyphs to NULL. This caused WebKit not to try to load other fonts when glyphs were missing. With that fixed, we can implement the code to find a font for a given set of code points. This uses fontconfig as it has this information already indexed. This fixes css2.1/t0805-c5519-brdr-r-00-a.html Review URL: http://codereview.chromium.org/13108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6328 0039d316-1c4b-4281-b951-d872f2087c98
* fix WebKitCSSTransformValue not being initializedtc@google.com2008-12-032-2/+6
| | | | | | | Review URL: http://codereview.chromium.org/13107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6327 0039d316-1c4b-4281-b951-d872f2087c98
* Have merge script update DEPS and gclient sync correctly.ojan@google.com2008-12-032-18/+34
| | | | | | Review URL: http://codereview.chromium.org/12924 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6326 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of webkit merge 38760:38800ojan@google.com2008-12-0313-114/+338
| | | | | | Review URL: http://codereview.chromium.org/13034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6325 0039d316-1c4b-4281-b951-d872f2087c98
* Added Keystone builder to gears-scons.mpcomplete@chromium.org2008-12-034-0/+51
| | | | | | Review URL: http://codereview.chromium.org/10423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6322 0039d316-1c4b-4281-b951-d872f2087c98
* add one test i seem to have missedpinkerton@google.com2008-12-031-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6321 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: support css font-family fallback.agl@chromium.org2008-12-034-1/+65
| | | | | | | | | | | | | | | Currently we'll always take the first element of a font-family list and run with it, using fontconfig's fallback. This adds a, slightly hacky, test to see if the fontconfig result is good enough and, if not, reports the failure back into WebKit so that other font-family elements can be tried. This fixes LayoutTests/css2.1/t040103-escapes-01-b.html Review URL: http://codereview.chromium.org/12914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6320 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaseline: css1/font_properties/font.htmlagl@chromium.org2008-12-033-195/+197
| | | | | | | | | | | The first time that I rebaselined I had stray patch included which screwed up the metrics. This corrects patch and the diff from the Windows version is the expected one-liner now. Review URL: http://codereview.chromium.org/12912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6319 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the IsHungAppWindow DCHECK as it does not seem to be indicatingananta@chromium.org2008-12-031-1/+0
| | | | | | | | | | | | | | | | anything useful about the window at this point. It seems to fire at times even when SendMessageTimeout succeeds on the plugin window, which indicates some race condition between Windows updating its state about whether the window is hung. Fixes http://code.google.com/p/chromium/issues/detail?id=5066 Bug=5066 R=nsylvain Review URL: http://codereview.chromium.org/12920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6318 0039d316-1c4b-4281-b951-d872f2087c98
* Unify mac fixable/ignore lists back into the mainlinepinkerton@google.com2008-12-034-2158/+1068
| | | | | | Review URL: http://codereview.chromium.org/13098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6317 0039d316-1c4b-4281-b951-d872f2087c98