summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove the temporary scaffolding stubs.phajdan.jr@chromium.org2010-02-1026-278/+303
| | | | | | | | | | | | | They have served they purpose well, but now it's time to retire. It's one of the things that draggen in the bad dependency of chrome/common on chrome/browser, and is sufficiently small now to stub things out individually. TEST=none BUG=none Review URL: http://codereview.chromium.org/593037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38639 0039d316-1c4b-4281-b951-d872f2087c98
* This CL addresses 2 issues:jcampan@chromium.org2010-02-107-6/+77
| | | | | | | | | | | | | | | | - we were not computing the max request text size correctly in some cases (by forgetting the size of the &q= string) causing assertions. - the translate server might send inconsistent response in some cases, this CL makes sure we deal with them. A common case is when sending separators only strings, which we are not doing now anymore. Other more complicated case are less clear. BUG=35055 TEST=Visit www.spiegel.de and translate the page. The page should be translated correctly. Review URL: http://codereview.chromium.org/594023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38637 0039d316-1c4b-4281-b951-d872f2087c98
* This reverts r38541, which reverts previous reverts.erg@chromium.org2010-02-104-14/+72
| | | | | | | | | | | | | This will re-introduce a mac performance regression but will make the code correct. R=mirandac (over shoulder) BUG=34775,34078 TEST=none Review URL: http://codereview.chromium.org/600045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38636 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for HTML5 databases to the cookie tree model.jochen@chromium.org2010-02-1028-263/+1441
| | | | | | | | | BUG=34633 TEST=create local databases, open cookie tree view from prefs. Review URL: http://codereview.chromium.org/596009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38635 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of Network selection/welcome screen for OOBE.nkostylev@google.com2010-02-1010-13/+342
| | | | | | | | | BUG=35016 TEST=With --login-manager=network screen should be shown. Currently this screen is not used in wizard process. Network selection is not fully supported. Review URL: http://codereview.chromium.org/570041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38634 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a UI test for WebKit fix to beforeunload bug.creis@chromium.org2010-02-101-0/+20
| | | | | | | | | | | The issue with Gmail warnings on cross-site navigations has been fixed upstream, and a recent WebKit DEPS roll pulled it in. This just adds an automated test for it in Chrome. BUG=32615 TEST=UnloadTest.BrowserCloseWithInnerFocusedFrame Review URL: http://codereview.chromium.org/594014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38633 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use the ExtensionToolbarModel for ordering of the Browser Actions. ↵andybons@chromium.org2010-02-109-84/+93
| | | | | | | | | | | | Prep for drag and drop for re-ordering. Also fixes crashers where if you tried to disable an extension via its context menu while an incognito window was key, boom. BUG=26990 TEST=none Review URL: http://codereview.chromium.org/595017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38632 0039d316-1c4b-4281-b951-d872f2087c98
* Initial Feedback from UX on the filebrowserdhg@chromium.org2010-02-104-45/+71
| | | | | | Review URL: http://codereview.chromium.org/596025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38631 0039d316-1c4b-4281-b951-d872f2087c98
* Mark download tests as flaky on all platform, just the sad truth.phajdan.jr@chromium.org2010-02-101-21/+17
| | | | | | | | | | TBR=dglazkov, kuchhal TEST=still flaky BUG=35275, 20809 Review URL: http://codereview.chromium.org/601030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38630 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-1049-195/+189
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in DownloadFile::Rename where we need to seek to the end of the file.jianli@chromium.org2010-02-102-1/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/601018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38628 0039d316-1c4b-4281-b951-d872f2087c98
* Move build/external_code.gypi into build/common.gypi.mark@chromium.org2010-02-102-44/+29
| | | | | | | | BUG=35184 TEST=none Review URL: http://codereview.chromium.org/593025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug 26397: Bookmark manager in Incognito mode doesn't show Sync ↵dantasse@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | | | | Bookmarks button The bug exists because the BookmarkManagerView checks the profile to see if it has a ProfileSyncService set up to see whether it should show the "Sync Bookmarks" button. Incognito profiles do not have a ProfileSyncService, even if the corresponding "original profile" has a PSS. So the fix is to check the original profile (here called "profile_"), not the profile. This is already fixed in Linux (bookmark_manager_gtk.cc). Also, all native versions are scheduled to be replaced by a common bookmark manager soon. BUG=26397 TEST=manual Review URL: http://codereview.chromium.org/574022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38625 0039d316-1c4b-4281-b951-d872f2087c98
* Only show one FileBrowse pop up for the same folderxiyuan@chromium.org2010-02-102-15/+42
| | | | | | | | | | | | Check existing FileBrowse pop ups before opening new one so that we only show one per folder; BUG=none TEST=On ChromeOS, download multiple files to default downloads dir and there should be only one FileBrowse pop up showing up. Review URL: http://codereview.chromium.org/601013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38624 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of tweaks to the cookie prompt dialog:sky@chromium.org2010-02-108-82/+66
| | | | | | | | | | | | | | | . Fixes bug that lead to randomly expanding and not (expanded_view_ wasn't in the member initializer list). . Fixed bug where expanding/collapsing would result in dialog changing to wrong size. . Persist expanded state to prefs. BUG=35092, 35165 TEST=see bugs Review URL: http://codereview.chromium.org/595014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38622 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation proxy methods for sending InstallExtension message.kkania@chromium.org2010-02-102-0/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/595013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38621 0039d316-1c4b-4281-b951-d872f2087c98
* Fix event generation for layout tests. Key codes are 'A'..'Z' so we must ↵avi@chromium.org2010-02-101-4/+7
| | | | | | | | | | | ensure that the values used are they. BUG=none TEST=none Review URL: http://codereview.chromium.org/582023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38620 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in CookiesWindowControllerTest and remove the appropriate suppressionrsesek@chromium.org2010-02-102-7/+5
| | | | | | | | | BUG=31586 TEST=Mac Valgrind unit tests Review URL: http://codereview.chromium.org/597015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38619 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix the shared build by excluding cookie_modal_dialog.craig.schlenter@chromium.org2010-02-101-0/+1
| | | | | | | | | | | | | | | | | This will have to be reverted of course once the linux-gtk implementation of CookiePromptModalDialog lands. Error was: out/Debug/lib.target/chrome/libbrowser.so: undefined reference to `vtable for CookiePromptModalDialog' BUG=None TEST=compiles Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/595002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38618 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to 54596jorlow@chromium.org2010-02-101-1/+1
| | | | | | | | | | TBR=yurys TEST=none BUG=none Review URL: http://codereview.chromium.org/603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38617 0039d316-1c4b-4281-b951-d872f2087c98
* Remove poll'n'loop code from extension_browsertest.cc.phajdan.jr@chromium.org2010-02-107-115/+123
| | | | | | | | | | | | Also use a common wait function from extension_browsertest in the page action popup test. BUG=34339 TEST=browser_tests Review URL: http://codereview.chromium.org/582013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38615 0039d316-1c4b-4281-b951-d872f2087c98
* Added sanity checks for base_unittests to Memcheck and ThreadSanitizer test ↵glider@chromium.org2010-02-104-16/+44
| | | | | | | | | runners. Note that the sanity checks may fail if the tests are ran with the sanity tests excluded (e.g. local test runs). I suppose this shouldn't be a problem, because the exit code matters only on buildbots. Review URL: http://codereview.chromium.org/598013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38612 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the part of http://codereview.chromium.org/593018 touching ↵phajdan.jr@chromium.org2010-02-101-4/+17
| | | | | | | | | | | | | | | | unload_uitest.cc The test started to hang mysteriously on Linux Tests(dbg)(1) and I remember some past problems about this test. Would need more investigation. The test is fine on all other platforms and bots, including Linux Tests(dbg)(2). TBR=brettw TEST=stop hanging BUG=none Review URL: http://codereview.chromium.org/597020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38611 0039d316-1c4b-4281-b951-d872f2087c98
* Really enable JAVASCRIPT_DEBUGGER WebKit feature for Chromium.mnaganov@chromium.org2010-02-101-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/596035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38610 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 323.0 to 324.0chrome-release@google.com2010-02-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38608 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: switch to upstreamed version of DevTools *.js files. Second ↵yurys@chromium.org2010-02-1022-6549/+8
| | | | | | | | | | attempt to land the patch 598014. Now with concatenated file name changed from devtools.js to DevTools.js BUG=34411 Review URL: http://codereview.chromium.org/601025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38606 0039d316-1c4b-4281-b951-d872f2087c98
* Make several tests more snappy, less sleepy.phajdan.jr@chromium.org2010-02-107-138/+96
| | | | | | | | | | | Some also say it's good for reducing flakiness. TEST=Changing ui_tests. BUG=none Review URL: http://codereview.chromium.org/593018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38605 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic tests for extension crash recovery.phajdan.jr@chromium.org2010-02-107-10/+187
| | | | | | | | | | | Also update the test infrastructure to support the required features. TEST=browser_tests BUG=30405 Review URL: http://codereview.chromium.org/572038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38604 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "DevTools: switch to upstreamed version of DevTools *.js files"yurys@chromium.org2010-02-1022-6/+6547
| | | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/602019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38600 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: switch to upstreamed version of DevTools *.js filesyurys@chromium.org2010-02-1022-6547/+6
| | | | | | | | BUG=34411 Review URL: http://codereview.chromium.org/598014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38595 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare for removing glue/devtools: move devtools_message_data.* to glue/yurys@chromium.org2010-02-107-14/+12
| | | | | | | | BUG=34411 Review URL: http://codereview.chromium.org/599005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38590 0039d316-1c4b-4281-b951-d872f2087c98
* Added initial implementation of account creation view.avayvod@chromium.org2010-02-107-23/+381
| | | | | | | | | | BUG=35157 TEST=Run chrome with --login-manager=create_accout and verify that screen works as intended. Review URL: http://codereview.chromium.org/600003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38588 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to suppress HTTP Referer header.jochen@chromium.org2010-02-104-6/+23
| | | | | | | | | BUG=none TEST=start chrome and run tcpdump -A. Should be contain any referer header. Review URL: http://codereview.chromium.org/600008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38587 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the following net tests for ChromeFrame as this functionality does ↵ananta@chromium.org2010-02-101-1/+5
| | | | | | | | | | | | | | | | not exist there. 1. URLRequestTest.DoNotSendCookies 2. URLRequestTest.DoNotSendCookies_ViaPolicy_Async 3. URLRequestTest.CancelTest_During_OnGetCookiesBlocked 4. URLRequestTest.CancelTest_During_OnSetCookieBlocked TBR=amit Review URL: http://codereview.chromium.org/601020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38585 0039d316-1c4b-4281-b951-d872f2087c98
* Remove empty directories from svn.tony@chromium.org2010-02-100-0/+0
| | | | | | TBR=dpranke git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38584 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome crash which occurs in a ChromeFrame instance while servicing a ↵ananta@chromium.org2010-02-103-6/+110
| | | | | | | | | | | | | | | | | | | | | | | read request in the automation job. The crash based on the dump occurs while dereferencing a NULL message filter, which means that we received a read request for a disconnected/terminated job. This happens when a request is paused while waiting for the renderer to ack sent data packets Following fixes:- 1. NULL check the message_filter pointer before dereferencing it in URLRequestAutomationJob::ReadRawData. 2. Only complete the job when we receive a Read request for it or if we have a pending read. Added ASSERTS in OnDataAvailable to check if we receive unexpected data. Fixes bug http://code.google.com/p/chromium/issues/detail?id=34819 Bug=34819 Test=Covered by ui test. Review URL: http://codereview.chromium.org/577033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38583 0039d316-1c4b-4281-b951-d872f2087c98
* A few minor changes to windows implementation on windows.alokp@chromium.org2010-02-101-2/+5
| | | | | | Review URL: http://codereview.chromium.org/601016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38582 0039d316-1c4b-4281-b951-d872f2087c98
* Files that should have been included in the last webkit roll.tony@chromium.org2010-02-102-0/+0
| | | | | | | TBR=jorlow Review URL: http://codereview.chromium.org/596031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38581 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit from 54559 to 54585.tony@chromium.org2010-02-1018-117/+122
| | | | | | | | | A few layout test changes. TBR=jorlow Review URL: http://codereview.chromium.org/593032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38580 0039d316-1c4b-4281-b951-d872f2087c98
* disabled another worker test on mac valgrindatwilson@chromium.org2010-02-101-0/+1
| | | | | | | | | | TBR=levin BUG=35224 TEST=none Review URL: http://codereview.chromium.org/597018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38579 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the height of the clear browsing data dialog so it's not smashed ↵pkasting@chromium.org2010-02-101-1/+1
| | | | | | | | | | together at the bottom. BUG=35089 TEST=Clear browsing data dialog should look OK in Windows Classic Review URL: http://codereview.chromium.org/600034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38577 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fullscreen mode work (still not enabled).viettrungluu@chromium.org2010-02-108-170/+423
| | | | | | | | | | | | | Change the way different things ensure the floating bar is visible. The new model is that things can "lock bar visibility" (and this locking can continue even outside fullscreen mode). Set up explicit timers for showing/hiding. BUG=31638 TEST=Things still work normally. Review URL: http://codereview.chromium.org/587015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38574 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move conditions of FormFields creation to FormFieldHistoryManager;tony@chromium.org2010-02-108-113/+61
| | | | | | | | | | | | | AutoFill does not have the same conditions. This required manipulating the FormField data structure to add necessary field data." This reverts commit r38570. TBR=jhawkins Review URL: http://codereview.chromium.org/602014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38573 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit from 54550 to 54559.tony@chromium.org2010-02-1055-49/+173
| | | | | | | | | Some new svg tests. TBR=jorlow Review URL: http://codereview.chromium.org/598032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38572 0039d316-1c4b-4281-b951-d872f2087c98
* Fix using of OmxInputBufferhclam@chromium.org2010-02-101-15/+12
| | | | | | | | | | OmxInputBuffer is now ref counted, but some code still try to delete it explicitly. This delete call is hidden in a template function so it was hard to find! Review URL: http://codereview.chromium.org/601015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38571 0039d316-1c4b-4281-b951-d872f2087c98
* Move conditions of FormFields creation to FormFieldHistoryManager; AutoFill ↵jhawkins@chromium.org2010-02-108-61/+113
| | | | | | | | | | does not have the same conditions. This required manipulating the FormField data structure to add necessary field data. BUG=none TEST=none Review URL: http://codereview.chromium.org/602008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38570 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make spacing/indenting of Privacy section clearer.pkasting@chromium.org2010-02-101-12/+14
| | | | | | | | BUG=35088 TEST=Open preferences window, go to third page, top two buttons shouldn't look related to stuff below them. Review URL: http://codereview.chromium.org/598030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38568 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled new shared worker tests for valgrind.atwilson@chromium.org2010-02-102-2/+11
| | | | | | | | | BUG=35224, 28439 TBR=levin Review URL: http://codereview.chromium.org/601017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38567 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit from 54530 to 54550tony@chromium.org2010-02-1027-41/+183
| | | | | | | | | Just some tests that are new or changed upstream. TBR=jorlow Review URL: http://codereview.chromium.org/600031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38566 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac compile by removing obsolete string and updating another.rsesek@chromium.org2010-02-101-117/+68
| | | | | | | | | | | | This is the second half of http://codereview.chromium.org/597013. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/596027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38565 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 09:57:08 +0000