| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=70427
Convert all users to the shim header for speex.
BUG=68524
TEST=none
Review URL: http://codereview.chromium.org/5968013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6106001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per comment from arv, move the background image from span to div,
and remove the span element.
The previous patch: http://codereview.chromium.org/5965003/
BUG=confirmed that the page was displayed properly
TEST=chromium-os:9254
Review URL: http://codereview.chromium.org/5995011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The ConfigurationPolicyProviderKeeper (and therefore the individual ConfigurationPolicyProviders) is now a member variable of the BrowserProcess instead of a singleton. This fixes memory leaks at the cost of slightly more complicated shutdown (the PolicyProviders must die while the file thread is still alive, but the preference system observing the providers for policy changes lives longer than that).
BUG=66054, 66102
TEST=existing unit tests; valgrind
Review URL: http://codereview.chromium.org/5962016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68562
TEST=policy_templates.zip should reappear in the offical builds
Review URL: http://codereview.chromium.org/6019008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The layout of the delete menu is bad for Japanese, and probably
other languages as well.
TEST=confirmed the delete menu is nicely layouted for English and Japanese.
BUG=chromium-os:10589
Review URL: http://codereview.chromium.org/6000012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Explicitly cast the variable to void rather than assign to self
to avoid warnings about unused variables.
This fixes the following Clang warning:
webkit/tools/test_shell/test_shell_main.cc:120:12: error: explicitly assigning a
variable of type 'bool' to itself [-Wself-assign]
ux_theme = ux_theme;
~~~~~~~~ ^ ~~~~~~~~
1 error generated.
(This is a new warning since Clang r122804.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6005012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=andreip
Review URL: http://codereview.chromium.org/6032008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It made memory_test crashing on Windows.
TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/5960011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Increase padding between right edge of security text (e.g. "PayPal, Inc. [US]") and right edge of green security box thing by one pixel. The total padding is now 2 pixels, which matches windows.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6072012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method will be called just before calling RunTestOnMainThread(), so
that custom setup code shared among all tests can be put here. So CLs like: http://codereview.chromium.org/5982005/ can be simplified by eliminating those duplicated ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
BUG=49355
TEST=none
Review URL: http://codereview.chromium.org/2812061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where it is needed
- WriteInstallerResult is no longer called on uninstall (Google Update doesn't check it on uninstall)
- Introduced the poorly named InstallationState (state of the system based on registry inspection) and InstallerState (state of the current operation) classes
- Product::GetInstalledVersion and Product::IsInstalled are gone; use InstallationState instead
- A few cleanups to make the code comply with the style guide
- UpdateDiffInstallStatus has been renamed to UpdateInstallStatus
- Chromium builds noop in UpdateInstallStatus (this was always the case for the browser, but now also is for GCF and the multi-installer package).
- The -multifail suffixes is now added to/removed from the Google Update "ap" value by UpdateInstallStatus on the basis of multi-install success/failure.
- Added code to update the Google Update "ap" value based on the set up products/options installed
- ChannelInfo is now an ordered list of modifiers and suffixes. We're careful to keep -full at the end since that was an operating assumption previously.
- ActivePackageProperties is a typedef to either the Chrome or Chromium PackageProperties class
TEST=Some existing unit tests updated; more new unit tests to follow.
BUG=61609
Review URL: http://codereview.chromium.org/5988007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6085004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also tries to fix AutocompleteEditViewTest.* tests on windows.
BUG=12316
BUG=57965
TEST=Pasting into omnibox should not trigger inline autocomplete.
Review URL: http://codereview.chromium.org/5982005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=andreip
Review URL: http://codereview.chromium.org/6035015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59281
TEST=none
Review URL: http://codereview.chromium.org/6083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
regress.
Also reenabled a test that I think is no longer flaky.
BUG=61757,58810
TEST=n/a
Review URL: http://codereview.chromium.org/6078012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=with demo_simple_vertex_shader, rate control works
Review URL: http://codereview.chromium.org/5944001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5960010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dialog has the prefix: "This extension can access:", so the current wording
was a little strange.
BUG=67859
TEST=Install an extension that uses the management permission.
Review URL: http://codereview.chromium.org/6065013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Need to wait long enough for plugin process to get created after killing it.
Review URL: http://codereview.chromium.org/5999011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28174
TEST=manual
Review URL: http://codereview.chromium.org/6004008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/5677001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) When there's blank space at the end of the string in the textfield and the
cursor is at the end, 'move cursor to previous word' should move the cursor at
the beginning of the last word.
(2) When there's blank space at the end of the string, and the cursor is at the
end of the last word, 'move cursor to next word' should move the cursor at the
end.
(3) Moving the cursor should make the cursor immediately visible. This is more
inline with how GTK+ cursors behave. For example, constantly pressing the
home-key in a GTK+ textfield makes the cursor visible for the duration of the
keypress.
BUG=none
TEST=NativeTextfieldViewsTest.CursorMovement
Review URL: http://codereview.chromium.org/5972008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
alt-enter. In this case we would invoke HideInstant to remove the
fade, but at the time we did this instant was still enabled so that
Hide wouldn't completely remove everything.
BUG=67490
TEST=see bug
Review URL: http://codereview.chromium.org/6053009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42315
TEST=none
Review URL: http://codereview.chromium.org/6075010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are installed in webstore-non-supported locales.
BUG=67073
Review URL: http://codereview.chromium.org/6040005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68241
TEST=none
Review URL: http://codereview.chromium.org/6019009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the unused RRResolverJob::Cancel method.
Remove job from inflight_ if worker cannot be started.
R=agl
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5574008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=kathyw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sites with multiple plugins will load that many child processes, which is bad.
This works by having creators of out-of-process plugins add it to a list in the
PepperPluginRegistry. The items are deleted from this list by a new delegate
implementation for the module to tell the registry that it's being destroyed.
It's a little awkward since the PluginModule can't know about the
PepperPluginRegistry, and all other pepper "delegates" are associated with the
Instance/RenderView, so by definition can't be used when the module is being
torn down since there are no instances.
It might have been nice to have an Add function on the lifetime delegate so
that the module will add itself to the list. But the plugin path name is
currently not available in all code paths, and it seemed messy to add.
TEST=manual
BUG=none
Review URL: http://codereview.chromium.org/6085007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=Pressing backspace in a textfield in a web-page triggers the 'navigate back'
action in the browser. This is because the accelerator gets triggered before the
renderer has a chance to get to the key. To fix this bug, rearrange the keypress
event handler for RenderWidgetHostViewViews. The views-way of keypress handling
is more similar on windows and linux with this change.
TEST=see bug
Review URL: http://codereview.chromium.org/6002007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The tabstrip gets removed and then added when switching between vertical/horizontal tabs. |tabstrip_| is invalid for a short while in between. So reset it to NULL when it's removed. Also, remove the old strip only after the new strip has been created and added.
BUG=switching to vertical tabs causes a crash
TEST=see bug
Review URL: http://codereview.chromium.org/5964012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pressing 0-9 in a textfield with caps lock turned on would generate shifted
keyevents, which it shouldn't. So distinguish between caps-lock and shift.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6068005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests were using a timeout of 30 seconds for live
operations. Some of the sync stress tests are timing out because it
takes longer for a full sync cycle to complete.
This patch increases the timeout to 45 seconds, and should eliminate the
occasional failures on the builders.
TBR=tim@chromium.org
BUG=68207
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6023011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
O3D is frozen on an old version of base, so I believe you want to avoid
updating it in future base changes.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6075009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64983
TEST=none
Review URL: http://codereview.chromium.org/6018015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Though we build two libraries here, we always use them together,
and it simplifies the gyp files to have one.
BUG=68551
TEST=compiles
Review URL: http://codereview.chromium.org/5986015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=the keyboard no longer 404s in touchui builds
Review URL: http://codereview.chromium.org/5977007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68553
TEST=Linux Valgrind unit test gets greener.
TBR=willchan
Review URL: http://codereview.chromium.org/6099007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=akalin
BUG=63357,67239
TEST=no compliation errors.
Review URL: http://codereview.chromium.org/6016001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=csilv
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6035013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36605
TEST=Valgrind Mac unit test goes green.
TBR=brettw
Review URL: http://codereview.chromium.org/5998009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
69849 went in with an incorrect message. It was actually this issue:
http://codereview.chromium.org/6011005/
This CL adds some clean-up requested in the review.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6033011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=csilv
BUG=59281
TEST=none
Review URL: http://codereview.chromium.org/6025016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do a bunch of string fixes along the way.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/5985007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67797
TEST=net_unittests
Review URL: http://codereview.chromium.org/6096006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6049009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The basic, unencrypted store is still available with --password-store=basic.
BUG=25404
TEST=on gnome, kde 4, and probably xfce we should now use system-level stores
Review URL: http://codereview.chromium.org/3326010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70431 0039d316-1c4b-4281-b951-d872f2087c98
|