| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
I don't know exactly what the cause of the bug is. But through experimentation I found that the plugin starts painting after the second NPP_Setwindow call.
BUG=24883
Review URL: http://codereview.chromium.org/315013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than global accross all contexts.
Before there was a singleton "request tracker" (URLRequest::InstanceTracker) that kept track of all outstanding requests and recently completed.
Whereas now, each URLRequestContext gets its own "request tracker" (URLRequestTracker) to track the requests associated with that context.
This change is to limit the lifetime of information relating to incognito windows. Before you were able to see the recent requests issued by incognito windows even after the last incognito windows was closed (by loading about:net-internals in a non-incognito window).
Whereas now you can only see the incognito requests information by loading "about:net-internals" within an incognito tab. And once the last incognito tab is closed, the OTR context is destroyed, which in turn destroys any profiling information that was being stored.
BUG=24630
Review URL: http://codereview.chromium.org/295050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/320004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
mode (via a "--server" command line).
This allows the test executable to just start the local server and wait which can be useful for debugging failing tests.
Review URL: http://codereview.chromium.org/307042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
running a Chrome Frame install.
BUG=http://crbug.com/24033
TEST=Post installation, there is no -full ap value in the Omaha key.
Review URL: http://codereview.chromium.org/306034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
BUG=none
TEST=these
Review URL: http://codereview.chromium.org/307044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Haven't tested outside of mac yet, so the guard for GetSafeFilename is still present for linux. Trybot should be run to make sure it passed in Win.
BUG=21632
TEST=none
Review URL: http://codereview.chromium.org/296001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/306055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tc,jorlow
Review URL: http://codereview.chromium.org/314011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=21383
TEST=unit tests
(original review for r25873: http://codereview.chromium.org/201065)
Review URL: http://codereview.chromium.org/313013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/307040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20805
TEST=green linux ui valgrind bots
Review URL: http://codereview.chromium.org/320002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
myIpAddress()
dnsResolve()
isResolvable()
This makes us behave more like IE and less like Firefox for scripts where IPv6 addresses are not expected.
BUG=24641
TEST=ProxyResolverJSBindingsTest.DontUseIPv6
Review URL: http://codereview.chromium.org/303022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(alongside the existing cases for Windows with 16-bit wchars and Linux with
32-bit wchars) so that it becomes possible to compile and link the Chromium
base together with third-party libraries that require short wchars.
BUG=none
TEST=none
Original review http://codereview.chromium.org/315004
Patch by mdsteele@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a new notification that tells the popup to close.
BUG=23897
TEST=--load-extension=chrome/test/data/extensions/samples/buildbot
TEST=--load-extension=chrome/test/data/extensions/samples/set_page_color
Review URL: http://codereview.chromium.org/314008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
OK button enabling.
In the BookmarkEditor.xib: Connect the NSBrowser's delegate (showing the bookmark tree) to the File's Owner (BookmarkEditorController).
Patch from Mike Rossetti (mrosseti@chromium.org)
Original review at: http://codereview.chromium.org/287014
BUG=17613
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We now detect these types of navigations in RenderView and allow the browser process to handle them. This allows us to swap process if the navigation is cross-site. Requires exposing suppressOpenerInNewFrame in WebFrame to accurately detect these links.
BUG=24447
TEST=RenderViewHostManagerTest.SwapProcessOnRelNoreferrerWithTargetBlank
Review URL: http://codereview.chromium.org/284015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/292056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=24961,24962
TEST=none
Review URL: http://codereview.chromium.org/316012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead have it write directly to the returned SkBitmap.
BUG=http://crbug.com/24493
TEST=Perf should get better. On the perf trybot, tab_complex_theme_cold got an average of ~40ms better.
Review URL: http://codereview.chromium.org/305001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch scoped_ptr to OwnPtr.
Switch base::RefCounted to WTF::RefCounted.
Switch string16/wstring to WebCore::String
Switch DCHECK to ASSERT.
Switch from Chromium #ifdefs to WebKit #ifdefs for ports.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adding support for constrained dialogs with toolkit_views.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/322002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/295046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=22060
TEST=See bug.
Review URL: http://codereview.chromium.org/306019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a kCFRunLoopBeforeSources observer. A busy loop that's driven with a nonzero
duration might not go to sleep or exit soon after a nested loop exits, so
calling MaybeScheduleNestingDeferredWork from the existing
kCFRunLoopBeforeWaiting and kCFRunLoopExit observers may not be sufficient to
guarantee processing of nesting-deferred work in all situations.
BUG=24968
TEST=All of the test cases listed in the commit message from r29749.
No new test cases; this change addresses a purely theoretical case.
Review URL: http://codereview.chromium.org/315010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/315001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from registry settings first, rather than defaulting to Local State.
R=cpu,kuchhal
TEST=Turn on usagestats in options, close chrome, set usagestats off in registry, restart and verify it is turned OFF in options.
BUG=7547
Review URL: http://codereview.chromium.org/295035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/306049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
buildbots seemed to ignore the heapchecker symbols defined previously in ldflags)
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=evan,mbelshe,bradn already LGTM'd at http://codereview.chromium.org/300039
Review URL: http://codereview.chromium.org/315015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In layout_tests, test_shell crashed by
/base/ref_counted.cc(60)] Check failed: in_dtor_. RefCountedThreadSafe object deleted without calling Release()
in context of
test_shell(webkit_glue::WebSocketStreamHandleImpl::Context::DidClose(WebKit::WebSocketStreamHandle*)+0x7d) [0x8f6b34b]
Since bridge instance is ref counted object, we must not delete it.
Make base class WebSocketStreamHandleBridge RefCountedThreadSafe,
and manage it by scoped_refptr.
BUG=25399
TEST=layout tests not crashed in XHR tests.
Review URL: http://codereview.chromium.org/316008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CRASH
TBR=nsylvain
BUG=25399
TEST=none
Review URL: http://codereview.chromium.org/315014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old image had the "inset" border though this field has "inputtext"
CSS class, which has "border:1px solid #bdc7d8".
It still fails on WIN-VISTA. The field on WIN-VISTA is wider than on
WIN-XP by 2 pixels.
BUG=21859
TEST=none
Review URL: http://codereview.chromium.org/307035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSocketStreamHandleBridge.
Fix memory leak of WebSocketStreamHandleBridge hold in Context.
Detach Context before WebSocketStreamHandle is deleted.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/315011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These tests are no longer failing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/306045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/303032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=erikkay
Review URL: http://codereview.chromium.org/306046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23974
TEST=http://fbarchard-kir.ad.corp.google.com/testmatrix/red/red2.ogv
Review URL: http://codereview.chromium.org/316005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The compiler warned about this. See
http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol-49#section-4.2
for how to calculate the length.
Review URL: http://codereview.chromium.org/293055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Review: http://codereview.chromium.org/297003
BUG=24846
TEST=URLRequestTest.DataURLImageTest, NetUtilTest.GetSuggestedFilename
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move security related methods out of WebKit.h into its own class WebSecurityPolicy. This involves these functions:
- registerURLSchemeAsLocal
- registerURLSchemeAsNoAccess
- whiteListAccessFromOrigin
- resetOriginAccessWhiteLists
BUG=24601
TEST=Compiled locally, try bot'ed.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29639
Review URL: http://codereview.chromium.org/293021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=should start passing
TBR=hclam
Review URL: http://codereview.chromium.org/318001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/49619 add a mac baseline where the test is expected to fail. Refer to https://bugs.webkit.org/show_bug.cgi?id=26856 for discussion.
We're still passing the test, so we need yet another baseline.
BUG=n/a
TEST=should pass again
TBR=dglazkov
Review URL: http://codereview.chromium.org/307034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has been merged.
BUG=13907
TEST=it should start running + passing
TBR=hclam
Review URL: http://codereview.chromium.org/292062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
session/local storage.
BUG=none
TEST=|'localStorage' in window| should only be true iff enablelocalstorage
is specified
Review URL: http://codereview.chromium.org/293032
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/315009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the media resource is a file:// we can always report that we have enough data to play the file. We end up passing a bunch of layout tests.
BUG=13907
TEST=more layout tests pass
Review URL: http://codereview.chromium.org/316003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
more like the mocks).
BUG=12119
TEST=chrome://extensions page should look more like the screenshot in the bug.
Review URL: http://codereview.chromium.org/303028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=13907
TEST=go go green tree!
TBR=hclam
Review URL: http://codereview.chromium.org/316007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
well for nested run loops under our own control (those started by Run) and
those beyond our control (native event loops).
Previously, upon any exit from a nested native loop, we would schedule
nesting-deferred work for processing. However, some nested native loops do
not execute in a single loop; rather, they start and stop the CFRunLoop
rapidly. In such cases, each exit from the CFRunLoop would cause
nesting-deferred work to be scheduled, and on each new entry to the CFRunLoop,
we would attempt to process it. This rapid-fire action meant that we'd never
sleep. Nested loops managed by Run were exempt from these problems since
r28811, because we could defer scheduling nesting-deferred work until
returning to Run.
The new strategy is to detect whether any nested loops (native or managed by
Run) had run before the run loop goes to sleep or exits. If any nested loops
did run, nesting-deferred work is scheduled for processing.
BUG=24968
TEST=1. Test case from bug 24968, printing: open any page, press command-P,
leave the dialog up, and check Chrome's CPU usage. No Chrome process
should be monopolizing any CPU. This tests nested native run loops.
2. Test case from bug 24337, JS alerts: open Gmail, start composing a new
message in a new window, address it to yourself, move focus to the
subject field, click the Discard button, and click "OK" at the alert.
The alert and composition window should close.
3. Test case from bug 24383, JS alerts: no Chrome processes should use
100% CPU after visiting javascript:alert("hi"). The JS alert cases
test nested run loops managed by Run.
4. Test case from bug 13468 comment 5, autocomplete: autocomplete should
still work after using "Back" from a contextual menu. This tests
that nesting-deferred work is processed after leaving a nested run
loop.
5. First run UI test case (no bug). Remove or move aside the profile
directory (~/Library/Application Support/Chromium or
~/Library/Application Support/Google/Chrome) and launch the
application. There should be first-run UI and it should be usable.
Upon clicking "Start (application)", the application should start and
be usable as normal. This tests delegateless run loops and
delegateless work redispatch.
6. base_unittests --gtest_filter='MessageLoopTest.*'
Review URL: http://codereview.chromium.org/300044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29749 0039d316-1c4b-4281-b951-d872f2087c98
|