summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove unnecessary use of atomic operations. Getting the pid on windows is ↵deanm@google.com2008-07-311-6/+1
| | | | | | very fast (just a fetch from the PEB). If this turns out to be expensive on other platforms, we might want to add caching methods to process_util. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178 0039d316-1c4b-4281-b951-d872f2087c98
* Trap all malloc/new allocation failures in chrome.dll at allocation point. ↵maruel@google.com2008-07-311-0/+13
| | | | | | | | This won't fix the failure but this will help classifying minidumps. BUG=1298132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177 0039d316-1c4b-4281-b951-d872f2087c98
* Support RanAllPending() rather than RunOnce(), and integrated into ↵jar@google.com2008-07-313-17/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ipc_sync_channel. RunOnce() semantics were not sufficient to support the effort to pump messages in ipc_sync_channel, as ipc_sync_channel is not able to detect pending Tasks. This change list switches to RunAllPending() tasks, rather than just Running the items that avail themselves in one run of the loop. This is a very small mod of the existing code. I'm still trying to stay focused on the bug at hand, and minimize chances of unrelated regressions (we only modify IPC channel semantics). The slight semantic change (from original attempts to call Quit() externally and then Run()) is that we now terminate the message loop after also servicing the high-resolution timer tasks. bug=1291034 r=darin M base/message_loop.h M base/message_loop.cc M chrome/common/ipc_sync_channel.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chrome to pull in fix for subtle issue where we would use more ↵kasperl@google.com2008-07-311-1/+1
| | | | | | | | memory than we requested through VirtualAlloc on win32. This may - or may not - have an effect on the issue 1252221 where we have seen memory corruption in the last words of an allocated page. BUG=1252221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175 0039d316-1c4b-4281-b951-d872f2087c98
* Initial cleanups en route to coalescing the get-it-built cut-and-paste from ↵sgk@google.com2008-07-3154-718/+433
| | | | | | | | | | | | | | | | | | various SConscripts into readable and maintainable shape. To wit: * Put the near-universal settings of /DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS, /DWIN32_LEAN_AND_MEAN, /wd4503 and /wd4819 in the base construction environment. * Sort various unsorted source file lists. * Fix indentation and quoting for consistency in a couple SConscript files that escaped previous dragnets. * Eliminate two left-over uses of Split() for input file lists. * Give the devenv invocation to build v8_shell.exe the full path to the relevant .vcproj file. * Add /nologo to the base LINKFLAGS setting. * Remove various CPPPATH and other settings that have been hanging around commented out from the Visual Studio build (in case we needed them, which we evidently don't). * Get rid of unnecessary env.File() and env.Dir() calls in various settings (esp. CPPPATH) and source file lists. * Add copyright notice to an overlooked SConscript file. * Clean up version.bat invocation. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174 0039d316-1c4b-4281-b951-d872f2087c98
* rollback these changesbeng@google.com2008-07-313-20/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage, not sure why this didn't break on my machinebeng@google.com2008-07-311-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out the files to be used for the new browser frame.beng@google.com2008-07-3112-0/+677
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168 0039d316-1c4b-4281-b951-d872f2087c98
* Should not be able to construct a CustomFrameWindow directly. Should use ↵beng@google.com2008-07-312-11/+17
| | | | | | | | | | CreateChromeWindow instead. Move CustomFrameWindow's two constructors to the protected section. They should be called by subclasses only. B=1293984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167 0039d316-1c4b-4281-b951-d872f2087c98
* Make Visual Studio ignore the return value of the xcopy command since the ↵nsylvain@google.com2008-07-311-1/+1
| | | | | | files copied are not always available. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159 0039d316-1c4b-4281-b951-d872f2087c98
* Move some methods from public to protected, since only subclasses should be ↵beng@google.com2008-07-313-82/+79
| | | | | | | | | | calling them. Move some data members from protected to private and provide a protected setter, per C++ style guidelines. B=1293984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these filesbeng@google.com2008-07-314-460/+75
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154 0039d316-1c4b-4281-b951-d872f2087c98
* Move dialog-specific aspects of ClientView into a new subclass DialogClientView.beng@google.com2008-07-3118-222/+714
| | | | | | | | | | | | | | ClientView becomes a generic representation of the View that occupies the "client area" of a window. All Windows now require a Client View (though they can use the default). Adjust WindowDelegate to provide a method for constructing the ClientView for a Window. The DialogDelegate overrides this to construct the DialogClientView. In the future, other specialized delegates will construct ClientViews specific to them, e.g. WizardDelegate would construct WizardClientView. Adjust the Window Init method to set up this new required Client View, and make some tweaks to CustomFrameWindow to make all this work. Remove all traces of dialog specific handling in Window into DialogClientView. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153 0039d316-1c4b-4281-b951-d872f2087c98
* Adds exitcodes for the TerminateProcess calls on hung renderers. There are ↵ojan@google.com2008-07-313-3/+5
| | | | | | still plenty of TerminateProcess(..., 0) calls, but these are the ones I know. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152 0039d316-1c4b-4281-b951-d872f2087c98
* I looked at the full dump from the previous crashes and it looks like a ↵brettw@google.com2008-07-307-29/+88
| | | | | | testing issue. Hopefully it will be magically unbroken. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151 0039d316-1c4b-4281-b951-d872f2087c98
* At the first run use Omaha usagestats key to determine whether to collect ↵rahulk@google.com2008-07-304-3/+5
| | | | | | | | | | | user metrics. BUG=1299579 TEST=With clean profile and no "first run" file, start Chrome and make sure that Under the Hood->Help make Chrome better... option is checked or unchecked depending on whether the value of HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96}\usagestats key is 1 or 0. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149 0039d316-1c4b-4281-b951-d872f2087c98
* Add views\non_client_view.cc to the SCons build.sgk@google.com2008-07-301-0/+1
| | | | | | TBR: beng git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak when simulating failures in unit tests.rvargas@google.com2008-07-301-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146 0039d316-1c4b-4281-b951-d872f2087c98
* This changes the assertion somewhat. We get NULL a lot, just with no ↵brettw@google.com2008-07-301-6/+21
| | | | | | | | characters. The case we want to catch is when there is a character count but no characters. BUG=1296904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145 0039d316-1c4b-4281-b951-d872f2087c98
* Removes a method never implemented in HistoryDB.sky@google.com2008-07-301-3/+0
| | | | | | | | | BUG=none TEST=none; this is just cleanup git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144 0039d316-1c4b-4281-b951-d872f2087c98
* Make the download arrow show and hide correctly in response to shelf ↵glen@google.com2008-07-305-9/+10
| | | | | | | | visibility. This was caused by both the shelf_visible_ bool not being set by the download shelf correctly, and the tab renderer not being aware of the new state. BUG=1300997 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143 0039d316-1c4b-4281-b951-d872f2087c98
* Simple change to make the "New [incognito] window" commands work like you'd ↵pkasting@google.com2008-07-302-6/+5
| | | | | | | | | | | | expect. The old behavior disabled "New incognito window" when in incognito windows, created a new incognito tab instead of a new window when you already had an incognito window open, and gave you no way to get a non-incognito window from an incognito one. Now, both commands are always enabled, and both do exactly what they say they'll do no matter what type of window you're currently in. BUG=1190035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142 0039d316-1c4b-4281-b951-d872f2087c98
* Make NonClientView an interface independent of CustomFrameWindow (i.e. move ↵beng@google.com2008-07-306-149/+229
| | | | | | | | | | | | it into its own file). Rename NonClientView's HitTest method to NonClientHitTest, so it doesn't collide with View's HitTest method. Also, consolidate some duplicated code between CustomFrameWindow and ConstrainedWindow's non-client view impl. B=1300864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141 0039d316-1c4b-4281-b951-d872f2087c98
* sidchat@google.com2008-07-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140 0039d316-1c4b-4281-b951-d872f2087c98
* Made changes to display tooltip window when user navigates through the icons ↵stanguturi@google.com2008-07-304-8/+121
| | | | | | | | in the toolbar using keyboard arrow keys. I have already fixed this issue. (Issue:801). I have got LGTM also. But, I have checked in the code when tree was closed. So, all my changes were reverted. So, this new issue is created to upload the same changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests to the disk cache to verify that a failure during cache ↵rvargas@google.com2008-07-304-39/+86
| | | | | | reinitialization is handled properly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137 0039d316-1c4b-4281-b951-d872f2087c98
* M webkit/glue/webframe_impl.ccbrettw@google.com2008-07-301-21/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136 0039d316-1c4b-4281-b951-d872f2087c98
* Update SCons build for recent changes:sgk@google.com2008-07-304-15/+16
| | | | | | | | | | Delete chrome_frame.cc, add frame_util.cc. url_request_http_cache_job.cc => url_request_http_job.cc. Rename sandbox *tests.exe to sbox_*.exe per upstream. Define ENABLE_CROSS_DOCUMENT_MESSAGING when generating V8 bindings. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135 0039d316-1c4b-4281-b951-d872f2087c98
* Change the proxy failover to be less aggressive. We now clear the list of ↵nsylvain@google.com2008-07-302-22/+140
| | | | | | bad proxies when we get a new configuration or when a direct connection fails and we try again to get the pac. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134 0039d316-1c4b-4281-b951-d872f2087c98
* It appears that if the character pointer in an iterator is ever NULL, we ↵brettw@google.com2008-07-301-6/+21
| | | | | | | | should stop iterating. BUG=1296904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133 0039d316-1c4b-4281-b951-d872f2087c98
* (Re-landing of) Support RunOnce() in message loop.jar@google.com2008-07-303-48/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | Deeply nested calls to MessageLoop::Run() were made, and a multitude of Quit() messages were handled at the most nested level. This left outer invocations hung, waiting for "their" kQuitMsg to arrive (but the the nested loop had already discarded them in its processing of pending messages before exit :-/ ). We now use a more controlled run of the message loop, which does not rely on kQuitMsg. This re-landing doesn't have the anti-hang assertion, which was breaking a lot of tests. bug=1291034 r=darin,mpcomplete M base/message_loop.h M base/message_loop.cc M chrome/common/ipc_sync_channel.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130 0039d316-1c4b-4281-b951-d872f2087c98
* further adjust test results to match the new realitydarin@google.com2008-07-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129 0039d316-1c4b-4281-b951-d872f2087c98
* Insert a commasidchat@google.com2008-07-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128 0039d316-1c4b-4281-b951-d872f2087c98
* Install the "First Run" file next to chrome.exe.sgk@google.com2008-07-301-1/+9
| | | | | | | Add a place-holder comment for the dependencies.py call we'll need when we handle the release build. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two issues with Visual Studio 2008.maruel@google.com2008-07-302-2/+2
| | | | | | BUG=1290595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126 0039d316-1c4b-4281-b951-d872f2087c98
* Replace scoped_ptr with scoped_array.rvargas@google.com2008-07-302-2/+2
| | | | | | BUG=1291138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125 0039d316-1c4b-4281-b951-d872f2087c98
* Add obj to the ignore list.maruel@google.com2008-07-300-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124 0039d316-1c4b-4281-b951-d872f2087c98
* Now uninstall entry is called Google Chrome so delete the old entry that was ↵rahulk@google.com2008-07-301-0/+5
| | | | | | | | | called Chrome for users that upgrade. BUG=1300325 TBR=tc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123 0039d316-1c4b-4281-b951-d872f2087c98
* DirectoryListing is now in the net namespace.darin@google.com2008-07-301-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122 0039d316-1c4b-4281-b951-d872f2087c98
* Use own our bzip2 error handler instead of the default which prints error ↵deanm@google.com2008-07-303-0/+4
| | | | | | | | | messages to STDERR and calls exit(1). This is better, since we will now crash instead of exiting. This also removes some unnecessary code and error strings from bzip2. BUG=1289861 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121 0039d316-1c4b-4281-b951-d872f2087c98
* Document that the callback parameter ofwtc@google.com2008-07-303-23/+35
| | | | | | | | | | | | HostResolver::Resolve can be null. In tcp_client_socket_unittest.cc, allow sock.Connect to succeed synchronously. Break out of the infinite loop if sock.Read fails. R=darin git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we remove info-bars on reload.jcampan@google.com2008-07-301-1/+3
| | | | | | | BUG=1296826 TEST=See bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119 0039d316-1c4b-4281-b951-d872f2087c98
* Rename URLRequestHttpCacheJob to URLRequestHttpJob.darin@google.com2008-07-304-60/+59
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118 0039d316-1c4b-4281-b951-d872f2087c98
* Adding validation tests for OpenInputDesktop and SwitchDesktop API calls. ↵cpu@google.com2008-07-303-17/+61
| | | | | | | | They should fail under sbox - There was no test for the winstation handle. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more classes from net/base into the net:: namespace.darin@google.com2008-07-3062-188/+232
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116 0039d316-1c4b-4281-b951-d872f2087c98
* Use own our bzip2 error handler instead of the default which prints error ↵deanm@google.com2008-07-303-0/+41
| | | | | | | | messages to STDERR and calls exit(1). This is better, since we will now crash instead of exiting. This also removes some unnecessary code and error strings from bzip2. BUG=1289861 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115 0039d316-1c4b-4281-b951-d872f2087c98
* Send the "shutdown didn't get to finish" metric to UMA.evanm@google.com2008-07-301-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the sandbox tests to look better on the submodules waterfall page.nsylvain@google.com2008-07-304-7/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113 0039d316-1c4b-4281-b951-d872f2087c98
* Fix most issues when building base as a x64 target.maruel@google.com2008-07-308-14/+80
| | | | | | BUG=1282556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the property sheet (.vsprops) inheritance.maruel@google.com2008-07-302-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 07:28:25 +0000