| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and display_height in preparation for letting the user
choose the backbuffer size.
The issue is the current "render_width" and "render_height"
really mean display_width and display_height where as
the true "render_width" and "render_height" need to be
different.
Review URL: http://codereview.chromium.org/179058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when presented with Chrome built with -O1.
(The gdb lives in /usr/local/valgrind-10771/bin, so should not interfere
with the system gdb.)
Review URL: http://codereview.chromium.org/178042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
// These tests went red with r47922 change to FontLinux, possibly need rebaselining.
BUG_MICHAELN LINUX : LayoutTests/fast/text/drawBidiText.html = FAIL
BUG_MICHAELN LINUX : LayoutTests/fast/text/international/bidi-control-chars-treated-as-ZWS.html = FAIL
BUG_MICHAELN LINUX : LayoutTests/fast/text/international/bidi-listbox-atsui.html = FAIL
TBR=yusukes,victorw
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also refactor URI list/named url packing code.
BUG=19008
Review URL: http://codereview.chromium.org/175036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20807,20808,20814
TEST=More green runs on the Mac UI valgind bots
Review URL: http://codereview.chromium.org/177056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run the view unit-tests.
See original review:
http://codereview.chromium.org/165512/show
Review URL: http://codereview.chromium.org/180061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm just making the order of the methods match the
order of declaration again.
BUG=nonde
TEST=none
Review URL: http://codereview.chromium.org/175042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of tests over all the builders.
BUG=none
TEST=manual
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/175047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Sheriffs: warning, dangerous patch)
On Chronos, with the slower CPU, it appears that page scrolling
sigificantly lags the mouse cursor sometimes. Some amount of lag will
always happen, but it appears that we are queuing old mouse positions.
This patch makes it so that we don't ACK a mouse move event if there
is a resulting paint pending. Current we get something like this:
Renderer: Browser:
<------- HandleInputEvent --------
(handles the event and defers
the painting)
-------- ACK ------------------->
(has a mouse move saved up)
... HandleInputEvent ---------
(painting starts)
----------- PaintRect ------------->
<----...
At this point, we buffered a mouse position while painting. If we
don't ACK the event until we have finished painting, we can get a more
up-to-date event.
This will need careful observation of the perf bots to check that
nothing bad happens.
http://codereview.chromium.org/173285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
marked flaky but haven't failed recently.
BUG=10453
BUG=9798
BUG=18802
TEST=green layout test buildbots
Review URL: http://codereview.chromium.org/179066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
task manager to GDK_WINDOW_TYPE_HINT_NORMAL. This allows the
dialogs to go behind browser windows in metacity.
I did it for these two dialogs mainly because they have links
to web pages. The links should be able to open on top of the
dialog.
Review URL: http://codereview.chromium.org/179014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on the mac.
Review URL: http://codereview.chromium.org/183031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16326,16579,17795,17966,20653,20778,20805
TEST=greenish valgrind bots
Review URL: http://codereview.chromium.org/180060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rohitrao
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/179067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/177055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
test_shell close.
Review URL: http://codereview.chromium.org/175049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Themes.
http://crbug.com/20629
Review URL: http://codereview.chromium.org/181022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
more than one tab. Don't use animation on new tab button
BUG=none
TEST=NTB shows up correctly and doesn't show during drags.
Review URL: http://codereview.chromium.org/174579
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that have passed for all configurations that they were listed for, for at least 100 runs.
TEST=ran through layout test try bots
BUG=10464,10476,9798,11832,11898,18206
Review URL: http://codereview.chromium.org/181027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should make licensing terms and third-party origin of the code more clear.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/179041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
BUG=20795
TEST=none
Review URL: http://codereview.chromium.org/176061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/179063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
none of which will help my crasher :(
* Force the query to stop if the user deletes a match. This makes more sense from a UI perspective and allows some code to be simpler.
* Prevent us from potentially doing a "minimal changes" match in a different profile (hard to trigger, likely no practical effects)
* Remove unneeded Reset() call on a repeating timer (which will auto-reset itself)
* Rename one of the notifications and move its listener to the edit, since that's who really cares about it anyway.
* Make the controller's Stop(true) notify the popup via the normal observer pipeline rather than coding something special into the popup's StopAutocomplete().
* Rename |paste_and_go_controller| |synchronous_controller| and use it instead of using the main popup controller to do the synchronous query when calling URLsForDefaultMatch(). This makes things both simpler and safer.
BUG=none
TEST=Using the omnibox still works fine
Review URL: http://codereview.chromium.org/178049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting it on the class. I did this for the textbox and I think it's a bit
better. The old way set it, but that function didn't add it to the view
hierarchy. This means that the pointer is technically "unowned" when the
CreateWrapper function returns.
This new way makes pointer ownership more clear. It becomes the caller's
problem, and the caller immediately inserts it into the view hierarchy which
then manages the lifetime.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/180041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
See original review:
http://codereview.chromium.org/179048/show
Review URL: http://codereview.chromium.org/177053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.../src/chrome/app/breakpad_mac.mm: In function ‘void InitCrashReporter()’:
.../src/chrome/app/breakpad_mac.mm:56: error: ‘parsed_command_line’ was not declared in this scope
IMPORTANT NOTE: When you're making changes to files that aren't part of the
normal build, you MUST test them. The next time I see an obvious case of
"oops, I never actually built that file," I'm just going to back it out. As
for this instance, I'm fixing it now, but you MUST build and test your change
locally. We can't afford accidentally losing Breakpad coverage. I've already
seen an embarrassing number of instances of "oops, Breakpad's broken" but we've
fortunately caught them all before integrating them into a release.
BUG=It doesn't build
TEST=Does it build now?
Review URL: http://codereview.chromium.org/178056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/183021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This update contains only a fix for crashes in the 64-bit port on
machines that do not support the 'sahf' instruction.
Review URL: http://codereview.chromium.org/179064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20793
TEST=none
TBR=rohitrao
Review URL: http://codereview.chromium.org/175048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Updated, added an example, and added more explanatory
text.
TBR=aa, rafaelw
Review URL: http://codereview.chromium.org/183029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19099,17288
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks
Review URL: http://codereview.chromium.org/183020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/178037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=20786
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This will be necessary for SSLClientSocketPool since the SSLConnectJob will contain a ClientSocketHandle for the TCPClientSocketPool. SSLConnectJob::GetLoadState() will forward to ClientSocketHandle::GetLoadState() if the SSLConnectJob is waiting on requesting a TCP socket.
BUG=http://crbug.com/13289.
Review URL: http://codereview.chromium.org/176024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Glen, please pay special attention to the intro, properties section,
and the start of the tints section. Besides beefing those up,
I also did a bit of reorganizing and reformatting, and I removed
implementation info that didn't seem relevant to developers.
TBR=glen,rafaelw
Review URL: http://codereview.chromium.org/181032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this, I had to commit several crimes against humanity. In
particular, Cocoa doesn't generate the required extra hit tests during
animations, so we have to. Sometimes, it gets really messed up and ends
up hitting the "drag blocking view". Moreover, we have to account for
the possibility of the mouse down hitting a moving tab, and going up on
the close button, etc.
BUG=17720
TEST=Mash the close tabs button under a wide variety of situations. \
Also make sure that the handling of the tabs (dragging, etc.) \
hasn't accidentally been messed up.
Review URL: http://codereview.chromium.org/174461
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the tweak info.plist script to work on frameworks as well as apps.
Remove the bundle version since the script manages that.
BUG=20503
TEST=The framework should now have an valid info.plist file in it's resources folder.
Review URL: http://codereview.chromium.org/178055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20755
TEST=Launch Chrome-branded build and look at the Application menu
Review URL: http://codereview.chromium.org/180058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa,rafaelw
Review URL: http://codereview.chromium.org/179061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Although, no other target actually references them, they are still invoked during the build.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/178052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
detach; mitigate new callframe migration in WebKit.
BUG=20554
Review URL: http://codereview.chromium.org/178053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to bookmarks and update static files.
TBR=rafaelw@chromium.org,kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
honor #anchors in dynamic mode.
TBR=rafaelw@chromium.org,kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/181030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appropriate.
A few places used pseudoRandom. That is in math.js
now so they use that.
Other places there is now
o3djs.material.createBasicMaterial and
o3djs.material.createMaterialFromFile that save
10-20 lines per sample.
This CL will require new reference images.
There are 2 other things I'd like to consider.
#1) Changing every sample that uses shaders/texture-only.shader
to use o3djs.material.createConstantMaterial or some variation.
The problem with o3djs.material.createConstantMaterial is it
requires you pass it a texture if you want a constant textured
material. All the samples create the material first, then
later add the texture.
So, I could add a new o3djs.material.createTextureOnlyMaterial.
At the same time that would mean changing those samples from
setting stuff on 'texSampler0' to 'emissive'
#2) I'd like to change the shader builder so it stops
adding "Sampler" to textured materials. As it is if
the material uses a color it makes the param called "diffuse"
but if it's a texture it makes it "diffuseSampler".
That sucks because it means the code has to do crap like
var param = material.getParam('diffuse');
if (param) {
// it's a color
} else {
param = material.getParam('diffuseSampler');
if (param) {
// it's a texture.
}
}
If we stopped that silliness we could just do
var param = material.getParam('diffuse');
if (param) {
if (param.isA('o3d.ParamTexture')) {
// it's textured.
} else {
// it's not.
}
}
Unfortunately to fix this requires changing the o3dConverter
as well since it uses those conventions. Should we do this?
Review URL: http://codereview.chromium.org/182024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25015 0039d316-1c4b-4281-b951-d872f2087c98
|