| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=30681
TEST=None
TBR=brettw
Review URL: http://codereview.chromium.org/504048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enabled by default in Skia.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/502057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/30397
TEST=Valgrind should still be happy.
Review URL: http://codereview.chromium.org/502020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30154
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/491059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reapplies 34794 and 34779 with one additional fix,
which were reverted by 34798.
TBR=mpcomplete@chromium.org
BUG=30507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=xp dual core intl2 perf test stays green
Review URL: http://codereview.chromium.org/500103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29831
TEST=ProfileSyncServiceTest
Review URL: http://codereview.chromium.org/507039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automation url request context used
by the host network stack implementation with a NULL AutomationResourceMessageFilter pointer.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=29025
Will add a test for this in a subsequent CL.
Bug=29025
Review URL: http://codereview.chromium.org/505033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/501062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=27324
Review URL: http://codereview.chromium.org/501034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Init allocated pixels to ARGB(0,0,0,0) in CreateSkBitmapFromHICON per
issue 30584.
BUG=30584
TEST=wine-valgrind should no longer complain as in issue 30584.
Review URL: http://codereview.chromium.org/504035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
underlying renderer URL changes, the virtual URL displayed in the address bar can be updated to reflect that. Currently apply that technique only to view-source rewrites, so it will follow redirects.
BUG=19444
TEST=go to view-source:http://crbug.com
Review URL: http://codereview.chromium.org/493001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
KF_ALTDOWN is more accurate than GetKeyState(VK_MENU). When usre presses
RightShift+RightAlt, the fake VK_CONTROL generated carries KF_ALTDOWN in
its flags but GetKeyState(VK_MENU) is clear.
BUG=30244
TEST=Verify RightAlt+RightShift does not change to RTL and issue 24888 does not regress. However, RightShift+RightAlt still changes RTL as this is the behavior of richedit.
Review URL: http://codereview.chromium.org/505026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
one that timed out. My theory is that this is causing the memory leak with
this extension.
BUG=29919
Review URL: http://codereview.chromium.org/502046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DirectoryBackingStore::SafeDropTable() to use the standard Chromium wrappers.
BUG=none
TEST=Run the sync unit tests and observe that they still pass.
Review URL: http://codereview.chromium.org/500102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Added default locale to the url context
2. Removed old code that was uploading catalogs on load (to renderer)
3. Removed message bundle object from Extension class.
BUG=27361
TEST=Open Chrome with --lang=sr and load src\chrome\common\extensions\docs\examples\api\i18n\getMessage extension from chrome://extensions page. Click on icon and text in popup should be localized.
Review URL: http://codereview.chromium.org/463011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now we have states for writing and reading the
cached headers.
BUG=26726, 18055
TEST=covered by current unit tests
Review URL: http://codereview.chromium.org/500009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/30382
TEST=Valgrind mac should stay happy.
Review URL: http://codereview.chromium.org/506055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30703,30704
TEST=Linux valgrind bots
Review URL: http://codereview.chromium.org/500101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix leak of page_action_views_ in LocationBarViewMac.
TEST=covered by unit tests and valgrind UI tests
BUG=30448, 12281
Review URL: http://codereview.chromium.org/506046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30607
TBR=ananta
Review URL: http://codereview.chromium.org/504047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in if the radius is >= 8, which is the case for the full screen
exit bubble.
We could tweak the radius needed to trigger this-- I didn't actually
test to see what radii looked good and what radii looked bad.
BUG=8405
Review URL: http://codereview.chromium.org/505029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(not related to roll, they have been flaky for a week).
TBR=pkasting
TEST=canary bots, try servers
BUG=9798
Review URL: http://codereview.chromium.org/502053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 30702
TEST= none
Review URL: http://codereview.chromium.org/506056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiun-os:916
TEST=None
Review URL: http://codereview.chromium.org/506045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instances of using controller indices instead of model indices.
BUG=28325
TEST=See bug
Review URL: http://codereview.chromium.org/506022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Tikhonovsky: http://codereview.chromium.org/500098
BUG=30653
Review URL: http://codereview.chromium.org/500100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the bottom of the window (for example, if the download manager was showing).
BUG=30586
TEST=dragging things from the browser should work as before
Review URL: http://codereview.chromium.org/504046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
uninstallation. Restore the original intent of the --force-uninstall flag, in that it guarantees completely silent uninstalls.
BUG=None
TEST=Both Chrome and Chrome Frame uninstalls are completely silent if this flag is passed.
Review URL: http://codereview.chromium.org/500079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
BUG=30681
Review URL: http://codereview.chromium.org/503043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/502052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
error in the V8 runtime.
TEST=covered by layout tests
BUG=none
Review URL: http://codereview.chromium.org/502051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=timurrrr,dank
Review URL: http://codereview.chromium.org/505035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tools_sanity_test.cc contains positive tests for tools used on the buildbots.
ToolsSanityTest.MemoryLeak contains an memory leak reportable by Memcheck and
heap leak checker.
ToolsSanityTest.DataRace contains a data race reportable by ThreadSanitizer.
The corresponding suppressions are in
tools/valgrind/{memcheck,tsan}/suppressions.txt
The idea is to check the tools' reports for their presence when testing
base_unittests.
Review URL: http://codereview.chromium.org/491044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly on Mac.
This issue was introduced by http://codereview.chromium.org/258032, which just unset isSystemKey flag for RawKeyDown events but not for Char and KeyUp events, while the correct behavior is, like what the browser does, to keep isSystemKey consistent among RawKeyDown, Char and KeyUp events.
This issue hides a webkit bug https://bugs.webkit.org/show_bug.cgi?id=32213, and incorrectly makes LayoutTests/fast/forms/access-key.html pass.
To test this CL, first you need to revert the fix for the webkit bug 32213. Then apply this CL should make the access-key.html test fail. The test should pass again after applying the fix for the webkit bug 32213.
BUG=23221
TEST=See above description.
Review URL: http://codereview.chromium.org/465147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=30653
TEST=trybots
TBR=jparent
Review URL: http://codereview.chromium.org/504040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
performance and memory use improvements.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/502050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
TBR=jparent
Review URL: http://codereview.chromium.org/507034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Mac/Linux
BUG=29213
TEST=Check 'Ask where to save each file before downloading' in 'Under the Hood' preferences. Open a page that has links to downloadable items (like http://ftp.sunet.se/pub/Linux/kernels/v1.0/). Right-click on one of the item and choose 'Open Link in New Tab'.
Make sure an empty tab opens and a dialog appears for asking where to save the file. Make sure the dialog does not disappear immediately. Make sure that closing the empty tab do not crash the browser.
Review URL: http://codereview.chromium.org/507024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dank
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/506049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
since language detection is temporarily disabled.
BUG=30662
TEST=None
TBR=brettw
Review URL: http://codereview.chromium.org/504041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=30667
Review URL: http://codereview.chromium.org/506051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the CLD library.
Temporarily disabling the CLD detection while investigating.
BUG=30662
TEST=None
TBR=brettw
Review URL: http://codereview.chromium.org/500091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=30661
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/502049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=30661
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/503040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30360
TEST=none
Review URL: http://codereview.chromium.org/503039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34813 0039d316-1c4b-4281-b951-d872f2087c98
|