summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove <iostream> where possible.erg@google.com2010-07-2039-44/+18
| | | | | | | | | | | | | <iostream> creates a static initializer. Most people don't need <iostream> anyway--they really need <ostream> for operator<< overloads. <iostream> should *never* be included in a header file; <iosfwd> exists for that purpose. BUG=none TEST=none Review URL: http://codereview.chromium.org/3014015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
* Make ResourceDispatcherHostRequestInfo own SSLClientAuthHandler and ↵davidben@chromium.org2010-07-203-15/+18
| | | | | | | | | | | | | | | | | | LoginHandler references This avoids problems where the objects disappear while the ResourceDispatcherHostRequestInfo still holds pointers. In particular, SSLClientAuthHandler handler adds and removes a reference to itself when the user dismisses the dialog. ResourceDispatcherHost, however, still holds a pointer and may attempt to notify it of a cancelled request. This stray write may NULL out a useful field and crash. BUG=49352 TEST=steps in bug report Review URL: http://codereview.chromium.org/3043008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53082 0039d316-1c4b-4281-b951-d872f2087c98
* In an attempt to clear up the Issue 48553 memory leak during init, I ↵davej@google.com2010-07-202-61/+86
| | | | | | | | | | | | | | re-ordered some of the startup calls, most important being to call pa_threaded_mainloop_start() right away instead of after further calls, and creating pa_context_ while the lock was held. BUG=48553 TEST=See if Valgrind stops suppressing 48553 Review URL: http://codereview.chromium.org/2948013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53081 0039d316-1c4b-4281-b951-d872f2087c98
* If the default theme is synced to the server, make new sync clients with ↵albertb@chromium.org2010-07-204-59/+58
| | | | | | | | | | | custom themes "win" at model association time. BUG=48155 TEST=manually tested Review URL: http://codereview.chromium.org/2856040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53080 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53076 - GYP changed to extract D3DX9 DLL into product dir.pinkerton@chromium.org2010-07-203-39/+1
| | | | | | | | | | | | | | | | | This is so ANGLE will find it. Also added ANGLE as a Chrome dependency. There must be a better way to detect whether there is a directxsdk directory in third_party. I'm open to ideas. TEST=try, check d3dx9 is copied to product dir when building chrome, check ANGLE initializes BUG=45898 Review URL: http://codereview.chromium.org/2843060 TBR=apatrick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53079 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome crash observed in ChromeFrame reliability test runs. The crash ↵ananta@chromium.org2010-07-201-4/+10
| | | | | | | | | | | | | | | | | occurs while processing the ViewHostMsg_UpdateRect message and occurs due to dereferencing a NULL view_ pointer. It looks that the view_ pointer got destroyed and effectively NULL'ed out in the context of the call to the MovePluginWindows function. Fix is to add a NULL check for the same. Fixes bug http://code.google.com/p/chromium/issues/detail?id=39356 Bug=39356 Review URL: http://codereview.chromium.org/3043009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53078 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 for: Add support for SymmetricKey to import raw keys when using NSS.albertb@chromium.org2010-07-205-26/+97
| | | | | | | | | BUG=48701 TEST=unittests Review URL: http://codereview.chromium.org/2985008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53077 0039d316-1c4b-4281-b951-d872f2087c98
* GYP changed to extract D3DX9 DLL into product dir.apatrick@chromium.org2010-07-203-1/+39
| | | | | | | | | | | | | | | This is so ANGLE will find it. Also added ANGLE as a Chrome dependency. There must be a better way to detect whether there is a directxsdk directory in third_party. I'm open to ideas. TEST=try, check d3dx9 is copied to product dir when building chrome, check ANGLE initializes BUG=45898 Review URL: http://codereview.chromium.org/2843060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53076 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: fix the name of some histograms.rvargas@google.com2010-07-201-9/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2824059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53075 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53062 - Makes the toolbar visible for apps again. Here's the set of ↵pinkerton@chromium.org2010-07-2042-34/+464
| | | | | | | | | | | | | | | | | | patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53073 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use VIEW_ID_PAGE_MENU, which has been removed.suzhe@chromium.org2010-07-201-1/+0
| | | | | | | | | BUG=none TEST=none TBR:pinkerton@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53071 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding: Personal stuff page in tabbed optionssargrass@google.com2010-07-2010-36/+329
| | | | | | | | | | | Relanding issue 2819046 BUG=48883 TEST=Exercise Personal Stuff page via --enable-tabbed-options Review URL: http://codereview.chromium.org/3042005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53070 0039d316-1c4b-4281-b951-d872f2087c98
* Replace cookies with site data in collected cookies dialog strings.jochen@chromium.org2010-07-201-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3005021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53069 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for WebKit 63707:63745.senorblanco@google.com2010-07-201-1/+1
| | | | | | | | | BUG=none TEST=none TBR=tc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53068 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Implement ViewID support. (third approach)suzhe@chromium.org2010-07-2024-11/+379
| | | | | | | | | | | | | | | | This CL adds several extension methods to NSView class for ViewID support, and uses a map to store ViewIDs of views. Each view requiring ViewID support can set its ViewID upon initialization and unset it before destruction. When looking up a view with a specific ViewID, just search all sub views recursively from the root view of a window. BUG=44692 need ViewIds on mac TEST=none Review URL: http://codereview.chromium.org/2878037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53067 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling test that hangs botpinkerton@chromium.org2010-07-201-1/+2
| | | | | | | | BUG=39070 TEST=none Review URL: http://codereview.chromium.org/2819058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53063 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the toolbar visible for apps again. Here's the set of patches Isky@chromium.org2010-07-2042-464/+34
| | | | | | | | | | | | | | reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53062 0039d316-1c4b-4281-b951-d872f2087c98
* Add some plumbing for in-progress work on enabling SSL proxy support.mbelshe@chromium.org2010-07-204-2/+62
| | | | | | | | | BUG=29625 TEST=none Review URL: http://codereview.chromium.org/2832057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53061 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for gman@chromium.org2010-07-208-15/+242
| | | | | | | | | | | | | | GL_OES_texture_float, GL_OES_texture_float_linear, GL_OES_texture_half_float, GL_OES_texture_half_float_linear TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/3005017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53060 0039d316-1c4b-4281-b951-d872f2087c98
* Bumped ANGLE rev to 342.apatrick@chromium.org2010-07-201-1/+1
| | | | | | | | | TEST=try BUG=none Review URL: http://codereview.chromium.org/2812060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53059 0039d316-1c4b-4281-b951-d872f2087c98
* Check localaccount when unlocking.oshima@chromium.org2010-07-202-6/+14
| | | | | | | | | BUG=chromium-os:4375 TEST=manual: login using local account,lock scren using ctrl-alt-l then unlock. no password required. Review URL: http://codereview.chromium.org/3010015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53058 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed standalone command buffer demos.apatrick@chromium.org2010-07-201-1/+7
| | | | | | | | | TEST=try BUG=none Review URL: http://codereview.chromium.org/2870056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53057 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent NotificationRegistrar from pulling in platform threading stuff.erg@chromium.org2010-07-204-15/+19
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3013018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53055 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the notifications options menu. If the notification came from an ↵johnnyg@chromium.org2010-07-201-8/+46
| | | | | | | | | | | extension, show the option to disable the extension rather than revoke permission. Also give a link to the notifications content settings panel.OB BUG=49019 TEST=create notification from page & extension, open the menu Review URL: http://codereview.chromium.org/3034015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53054 0039d316-1c4b-4281-b951-d872f2087c98
* Download code cleanup:phajdan.jr@chromium.org2010-07-208-107/+202
| | | | | | | | | | | | | | | | | | - choose better names for some helper methods - move code to less random places This change also adds bigger tuples support, up to Tuple8 in base/tuple.h. The plan is to stop using such big number of parameters, but for now it's not trivial. This change also fixes some UI tests, not sure why it is so. TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/2805091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53053 0039d316-1c4b-4281-b951-d872f2087c98
* Add some histograms to help measure extension context menu performanceasargent@chromium.org2010-07-201-0/+9
| | | | | | | | | BUG=49560 TEST=none (no user-visible changes) Review URL: http://codereview.chromium.org/3022013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53051 0039d316-1c4b-4281-b951-d872f2087c98
* Use the WS_EX_NOACTIVATE flag for popup widgets. This is essentially a ↵johnnyg@chromium.org2010-07-201-1/+1
| | | | | | | | | | | no-op for the views which are contained within Chrome, but for desktop notifications which are shown when other applications are active, this prevents clicking the notification from changing the active window. BUG=47334 TEST=focus another application, close a notification. look for no flicker. Review URL: http://codereview.chromium.org/3029010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53050 0039d316-1c4b-4281-b951-d872f2087c98
* Add Spdy ConnectFailure test back into spdy network tests.erikchen@google.com2010-07-201-1/+78
| | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3040005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53049 0039d316-1c4b-4281-b951-d872f2087c98
* Clear TopSites when deleting history.nshkrob@chromium.org2010-07-201-4/+42
| | | | | | | | | | | Update top_sites_ right away, then request an update from the HistoryService. TEST=TopSitesTest BUG=none Review URL: http://codereview.chromium.org/2964009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53048 0039d316-1c4b-4281-b951-d872f2087c98
* Roll ICU to 53046 to grab my use_system_icu gyp updates.phajdan.jr@chromium.org2010-07-201-1/+1
| | | | | | | | | | | TBR=jshin TEST=none BUG=28294 Review URL: http://codereview.chromium.org/3010017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53047 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression for memory leak in ExtensionsServiceTest.InstallExtension unit testdhollowa@chromium.org2010-07-201-1/+1
| | | | | | | | | | | http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/6623/steps/memory%20test:%20unit/logs/stdio BUG=30264 TEST=ExtensionsServiceTest.InstallExtension Review URL: http://codereview.chromium.org/3037011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53045 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Make AppendDataToBody() not append empty data.viettrungluu@chromium.org2010-07-201-1/+2
| | | | | | | | | BUG=none TEST=no DCHECK() failures with Trung's Flash Review URL: http://codereview.chromium.org/3051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53044 0039d316-1c4b-4281-b951-d872f2087c98
* Break out histogram counter variables as CookieMonster instance variables.rdsmith@google.com2010-07-203-21/+83
| | | | | | | | | | | | This avoids racing on the initialization of the statics usually declared when doing histogram accumulation. BUG=49142 TEST=net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.* (to confirm I didn't break anyting; this doesn't reproduce the race.) Review URL: http://codereview.chromium.org/2832061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53042 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad.gyp for Mac compatibility with Breakpad r627 as used bymark@chromium.org2010-07-201-5/+25
| | | | | | | | | | Chromium r52958. BUG=none TEST=official build Review URL: http://codereview.chromium.org/3008012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53041 0039d316-1c4b-4281-b951-d872f2087c98
* First step for cleaning registration code for ChromeFrame.stoyan@chromium.org2010-07-204-61/+24
| | | | | | | | Create separate RGS file for registering CLSID as a BHO. Remove the code that manually did the BHO registration. BUG=48987 Review URL: http://codereview.chromium.org/3029007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53040 0039d316-1c4b-4281-b951-d872f2087c98
* Initial SPDY flow control supportagayev@chromium.org2010-07-2013-16/+267
| | | | | | | | | | | BUG=48100 TEST=net_unittests --gtest_filter="SpdyProtocolTest.ControlFrameStructs:SpdyNetworkTransactionTest.WindowSizeChange:SpdyNetworkTransactionTest.WindowSizeOverflow" Contributed by: agayev@google.com Review URL: http://codereview.chromium.org/2805083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53039 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tsan failure in SpdyStreamTest.ukai@chromium.org2010-07-202-1/+3
| | | | | | | | | | | | | Under tsan, tcp connect job tries to connect several times and fails to find data provider for mock socket. Make connect synchronous (as done in SpdySessionTest) fixes the issue. BUG=none TEST=./tools/valgrind/chrome_tests.sh --build_dir out/Debug --test net --tool tsan --gtest_filter='SpdyStreamTest.*' Review URL: http://codereview.chromium.org/3054002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53036 0039d316-1c4b-4281-b951-d872f2087c98
* Add "settings.language.preferred_languages" for Chromium OS's Languages and ↵satorux@chromium.org2010-07-207-26/+59
| | | | | | | | | | | | | | | Input dialog. Before this change, we used to get the list of preferred languages based on the active input methods. This is tricky. Having a preference for the value is simpler, and makes it easier for us to implement the DOM UI version. BUG=none TEST=manually Review URL: http://codereview.chromium.org/3012012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53035 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 472.0 to 473.0chrome-release@google.com2010-07-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53033 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace updates for BrowserEncodingTest.FLAKY_TestEncodingAutoDetec from ↵thestig@chromium.org2010-07-2014-14/+40
| | | | | | | | | | | webkit r63517. BUG=none TEST=BrowserEncodingTest.FLAKY_TestEncodingAutoDetec passes. TBR=abarth Review URL: http://codereview.chromium.org/3047003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53031 0039d316-1c4b-4281-b951-d872f2087c98
* Pulls hunspell 1.2.11.hbono@chromium.org2010-07-201-1/+1
| | | | | | | | | | | This change pulls the latest hunspell (including our BDICT change) to the trunk. TBR=estade BUG=40909 TEST=unit_test --gtest_filter=SpellCheckTest* Review URL: http://codereview.chromium.org/3033008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53030 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Update Valgrind suppressions.thestig@chromium.org2010-07-201-22/+23
| | | | | | | | | BUG=46886 TEST=Valgrind gets greener. TBR=glider Review URL: http://codereview.chromium.org/3015010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53029 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Another NPAPITester -> LayoutPluginTester test rename.thestig@chromium.org2010-07-202-3/+2
| | | | | | | | BUG=none TEST=Valgrind UI gets greener. Review URL: http://codereview.chromium.org/3050006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53028 0039d316-1c4b-4281-b951-d872f2087c98
* Call rand_s() in a worker process before entering the sandbox.yutak@chromium.org2010-07-202-0/+5
| | | | | | | | | | | | We need to do it to cause advapi32.dll to load the sandbox is turned on. Otherwise rand_s() will fail in the sandbox. BUG=47390 TEST=Run "ui_tests --gtest_filter=WorkerTest.WorkerWebSocketLayoutTests". Review URL: http://codereview.chromium.org/2799047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53027 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace updates for BrowserEncodingTest.FLAKY_TestOverrideEncoding from ↵thestig@chromium.org2010-07-201-1/+2
| | | | | | | | | | | webkit r63517. BUG=none TEST=BrowserEncodingTest.FLAKY_TestOverrideEncoding passes. TBR=abarth Review URL: http://codereview.chromium.org/2861066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53026 0039d316-1c4b-4281-b951-d872f2087c98
* [mac] Use the cross-platform menu model for the notifications options menu, ↵johnnyg@chromium.org2010-07-202-10/+11
| | | | | | | | | | | instead of something mac-specific. BUG=none TEST=create notification on mac, the options menu should work normally Review URL: http://codereview.chromium.org/3020015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53024 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Speculative fix for a possible trigger to bug 48502. tim@chromium.org2010-07-201-1/+4
| | | | | | | | | | | | | If the user configures data types before the sync backend is initialized, we wind up trying to associate models before a Directory exists, which is badness. BUG=48502 TEST=none Review URL: http://codereview.chromium.org/3028013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53023 0039d316-1c4b-4281-b951-d872f2087c98
* [GRD] Add notification strings for collected cookies dialog.jochen@chromium.org2010-07-201-0/+18
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3033009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53021 0039d316-1c4b-4281-b951-d872f2087c98
* [Win] Correct CRLF endings on .adm template and fix wordingdanno@chromium.org2010-07-202-262/+265
| | | | | | | | | BUG=49541 TEST=manual Review URL: http://codereview.chromium.org/2884028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53020 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53016 - Makes the browser fetch the translate script regularly.jcivelli@chromium.org2010-07-2010-137/+72
| | | | | | | | | | | | | | | | | | | | New versions of that script may get pushed from time to time. Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions. Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide). BUG=None TEST=Run the unit-tests. Original review: http://codereview.chromium.org/3034013/show Review URL: http://codereview.chromium.org/3041010 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/2881024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53019 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 13:07:01 +0000