| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the Mac implementation of auxiliary profile retrieval (Address Book data) to properly
manage unique ids assigned to profiles originating from the Address Book.
BUG=49657
TEST=PersonalDataManagerTest.*, and manual steps of (1) load a fillable HTML form, (2) click fillable field, (3) pick profile originating from Address Book, (4) observe that it fills the form.
Review URL: http://codereview.chromium.org/3055011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit prevents the default context menu from being rendered.
Depends on:
https://bugs.webkit.org/show_bug.cgi?id=42808
R=stuartmorgan
BUG=48129
TEST=none
Review URL: http://codereview.chromium.org/2858065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options
Review URL: http://codereview.chromium.org/3056010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4996
TEST=manual: run debug build on the device. it should start without DCHECK error described in the bug above.
Review URL: http://codereview.chromium.org/2824068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
avoid memory errors.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3048012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Always show a "translating..." infobar when initiating a translation from the context menu, or when the translation is automatic (always translate option). It does not make sense not to show one, as translation may take several seconds and no having any feedback during that time is confusing (also this is what translate in toolbar does).
- Don't enable the translate context menu until we get the page language. This is an effort to ensure the translate infobar delegate always get an original language.
- Makes the translate manager deals correctly with unknown languages to avoid a crasher (bug 49018)
BUG=49018
TEST=See bug. And also, start a translation from the context menu, while the page is being translated a "translating..." infobar should be shown. Also, tests that when a language was selected for "always translate", navigating to a page in that language triggers a "translating..." infobar.
Review URL: http://codereview.chromium.org/3026002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
upstream test_expectations file.
BUG=none
TEST=none
TBR=bulach
Review URL: http://codereview.chromium.org/3035018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Non
TBR=nshkrob
Review URL: http://codereview.chromium.org/3012022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=check_perms goes green
TBR=luchen
Review URL: http://codereview.chromium.org/3061005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just hooks up the renderer side of the IPC.
R=brettw
BUG=49789
TEST=none
Review URL: http://codereview.chromium.org/3053009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prepopulated URLs are also moved into TopSites.
When TopSites becomes the default (without the flag), the corresponding code in MostVisitedURLs can be removed.
BUG=48564, 48566
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/3036003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverses the order that sockets removed from the idle list and deleted.
It also detects and handles recursive calls to CleanupIdleSockets.
BUG=49387
TEST=none
Review URL: http://codereview.chromium.org/2856049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the hacky layout_test_controller.html with a real LayoutTestController
implementation before running sync DB tests as UI tests.
BUG=49118
TEST=none
Review URL: http://codereview.chromium.org/2824067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable the test.
BUG=49799
TEST=TopSitesTest::DeleteNotifications.
Review URL: http://codereview.chromium.org/2847066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
least one field has text. Also, fixes crash if you double click and
the table is empty.
BUG=47742
TEST=create a new address/credit card in the autofill profile manager
and make sure the ok button is only enabled if at least one field has
text.
Review URL: http://codereview.chromium.org/2809070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and resumes. When
this happens, we were not reconnecting to pulse, and so could not adjust volume from that point on.
BUG=4017
TEST=In shell, kill the pulseaudio process. It will auto-restart and volume keys should still work
Review URL: http://codereview.chromium.org/2959015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
particle versions. Differences in the non-particle version:
* Switched the created energy texture from 3x32 (NPOT) to 4x32; made the energy shard width smaller.
* In the shaders, added abs before the sqrt call to normalize behavior across CG/GLSL.
Translated GLSL shader string in particles.js to be more human readable.
Review URL: http://codereview.chromium.org/2934013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=bulach
Review URL: http://codereview.chromium.org/3034024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Coverity issue 7161.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2873060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=8457
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3033019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3010024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3039019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=8477
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2811064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base test were failing after http://codereview.chromium.org/2840037, which adds id numbers to suppression names.
TBR=thestig@chromium.org
BUG=none
TEST=valgrind base tests should pass.
Review URL: http://codereview.chromium.org/3033018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3053011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke webkit build.
BUG=None
TEST=Nont
TBR=jiesun
Review URL: http://codereview.chromium.org/3015018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
merge).
This goes back to the M5 logic for managing Flash model negotiation on the Mac.
BUG=49169
TEST=Flash should not negotation Core Animation mode unless --enable-flash-core-animation is passed. White flickering shouldn't happen, find bar and full screen UI should show.
Review URL: http://codereview.chromium.org/3044015
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/2832074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
save form data if the form was not user-submitted.
BUG=48225
TEST=none
Review URL: http://codereview.chromium.org/2842062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. add ffmpeg_video_allocator.cc/h
2. add omx_bufferheader type and av_frame type of video_frame.
please see http://codereview.chromium.org/2992002/show
for full commit. this is used to split that change to reviewable size of changelist.
Review URL: http://codereview.chromium.org/3006001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fixed some lint issues.
Minor Coverity issue (9399 and 9400).
BUG=None
TEST=Part of unit test.
Review URL: http://codereview.chromium.org/3014024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
corresponding js file.
BUG=chromium-os:4806
TEST=manually on the netbook
Review URL: http://codereview.chromium.org/3017026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but not port number.
TEST=none
BUG=48078
Review URL: http://codereview.chromium.org/2834062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add missing first run bubble back to opening page.
Wait for search engines to load before displaying first run bubble, so correct search engine is displayed in first run.
Because some distributions use "skip-first-run-ui", add back the "import_items" code that passes values to this code path. Because this code path is obsolete (most import is silent), this needs to be refactored in the long term.
Fix some spelling issues.
BUG= 42612
TEST= import with --skip-first-run-ui works
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53198
Review URL: http://codereview.chromium.org/3042010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This goes back to the M5 logic for managing Flash model negotiation on the Mac.
BUG=49169
TEST=Flash should not negotation Core Animation mode unless --enable-flash-core-animation is passed. White flickering shouldn't happen, find bar and full screen UI should show.
Review URL: http://codereview.chromium.org/3044015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two classes of refactoring in this submission:
* Enabled by moving domain->CanonicalCookie. This is mostly just
eliminating domain from various argument lists.
* Combination of code that will make the next CL easier. This is
rewriting GetAllCookiesForURL in terms of FindCookiesForHostAndDomain
and nuking FindRawCookies; it'll allow me to change the basic
algorithm for probing the cookie map in a single place.
BUG=8850
TEST=Linux, net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.*
Review URL: http://codereview.chromium.org/2904006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49920
Review URL: http://codereview.chromium.org/3012019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=46591
TEST=layout tests
http://codereview.chromium.org/2808058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Function override signature doesn't match the one in its base class.
BUG=None
TEST=Fixing a unit test.
Review URL: http://codereview.chromium.org/3015017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3056012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes a use of accept(). This will allow removal of the
special hole in the Mac sandbox that was opened for NaCl.
BUG=26781
TEST=all tests pass, especially nacl_ui_tests
This is also needed to pull in NaCl's r2744 to get sel_main_chrome.c.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=642
BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
Review URL: http://codereview.chromium.org/2873059
TBR=mseaborn@chromium.org
Review URL: http://codereview.chromium.org/2847067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the new NaClMainForChromium() from the NaCl tree, instead of
sel_main.cc in the Chromium tree.
Use the new variant of RegisterInternalNaClPlugin() that can receive
multiple functions instead of just one.
This depends on r2744 from NaCl.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=642
BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
TEST=Chromium's nacl_ui_tests
Review URL: http://codereview.chromium.org/3039016
TBR=mseaborn@chromium.org
Review URL: http://codereview.chromium.org/2832071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the new NaClMainForChromium() from the NaCl tree, instead of
sel_main.cc in the Chromium tree.
Use the new variant of RegisterInternalNaClPlugin() that can receive
multiple functions instead of just one.
This depends on r2744 from NaCl.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=642
BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
TEST=Chromium's nacl_ui_tests
Review URL: http://codereview.chromium.org/3039016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes a use of accept(). This will allow removal of the
special hole in the Mac sandbox that was opened for NaCl.
BUG=26781
TEST=all tests pass, especially nacl_ui_tests
This is also needed to pull in NaCl's r2744 to get sel_main_chrome.c.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=642
BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
Review URL: http://codereview.chromium.org/2873059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49920
Review URL: http://codereview.chromium.org/3010023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3037014
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/2809068
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/2881029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/2861074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
actual EULAs are displayed.
BUG=crosbug.com/3178
TEST=chrome --login-manager --login-screen=eula
Review URL: http://codereview.chromium.org/3026008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3037014
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/2809068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Suppress the TEXT diff while waiting for new expectations from upstream.
BUG=49912
TEST=Layout test should not fail
Review URL: http://codereview.chromium.org/3041017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3037014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53323 0039d316-1c4b-4281-b951-d872f2087c98
|