| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
old size. Changed several ints to size_t.
BUG=55119
TEST=None
Review URL: http://codereview.chromium.org/3302024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
can be stored correctly.
TEST=tests pass
BUG=54065
Review URL: http://codereview.chromium.org/3358031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/3224001
Revert review: http://codereview.chromium.org/3317023
Relanding because it didn't cause the problem.
BUG=54453
TEST=chromebot
Review URL: http://codereview.chromium.org/3396001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a SignedSettingsHelper that serializes all SignedSettings ops,
provides a unified callback interface and allows canceling callback of
requested ops;
- Move MockOwnershipService into a header file;
- Add a unit test for SignedSettingsHelper;
BUG=chromium-os:968
TEST=none. This is still plumbing work required users options ui.
Review URL: http://codereview.chromium.org/3373008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of clients in the max-sockets tests from 20-25% to 1%.
BUG=52807
TEST=n/a
Review URL: http://codereview.chromium.org/3392003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
match upstream WebKit http://trac.webkit.org/changeset/61153
BUG=46538
Review URL: http://codereview.chromium.org/3332015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 59362 - net: Rename ProxyService::CreateNull to ProxyService::CreateDirect.
(Note: This was a TODO for eroman).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3336021
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/3444001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we wouldn't call the handshake callback if both False
Start and Snap Start were enabled on a connection.
BUG=none
TEST=none, because we haven't got the Snap Start code in yet.
http://codereview.chromium.org/3247006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The patch was prepared by Evgeniy Stepanov and
reviewed as http://codereview.chromium.org/3296016
TBR=glider
TEST=TSan bots shouldn't be affected by this for now
Review URL: http://codereview.chromium.org/3418003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mac and linux.
BUG=None (js column was added for windows in http://codereview.chromium.org/276009 ), 27226 (v8 column)
TEST=Add v8 and javascript columns using the task manager's context menu. should work on all platforms now.
Review URL: http://codereview.chromium.org/3419001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
links to break on the Extensions page.
BUG=55164
TEST=See bug.
Review URL: http://codereview.chromium.org/3438001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and display them on a new net-internals tab. On other OSes, the new tab is always hidden.
BUG=53474
TEST=manual
Review URL: http://codereview.chromium.org/3329016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This was a TODO for eroman).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3336021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handled by IME.
BUG=53397
BUG=chromium-os:6471
TEST=Manually. See bug report.
Review URL: http://codereview.chromium.org/3307020
Patch from James Su <suzhe@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CERT_STATUS_UNABLE_TO_CHECK_REVOCATION
CERT_STATUS_NO_REVOCATION_MECHANISM
Note: The Omnibox shows no_revocation_mechanism as skull and bones, but that's a separate issue.
BUG=http://crbug.com/52916
TEST=Requires server with cert errors.
Review URL: http://codereview.chromium.org/3293019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=RunningOnValgrind() should be fixed on Windows
TBR=glider
Review URL: http://codereview.chromium.org/3437001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=55533
TBR=glider
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=52916
TEST=out/Debug/chrome --enable-new-page-info-bubble. Go to https://google.com,
click on the omnibox icon, see the icon is showed for the the First Visit
section.
Review URL: http://codereview.chromium.org/3364018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* This patch is extracted from the patch (http://codereview.chromium.org/3304002/show)
Candidate window created shortcut and candidate columns in variable width,
so these columns were not aligned.
In this patch, candidate window computes column width and creates columns
in fixed width.
BUG=chromium-os:6377
TEST=manual
Review URL: http://codereview.chromium.org/3412002
Patch from Hiroki Nakagawa <nhiroki@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change removes supression rules for Bug 54689 because Jay landed its WebKit fix. (See <https://bugs.webkit.org/show_bug.cgi?id=45287>.)
BUG=54689
TEST=keep the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3417002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't use the constructor directly, as it causes link errors for the multi-dll
build. This relies on WebKit having rolled to r67378.
BUG=none
TEST=Chromium XP (dbg shared) compiles successfully
Review URL: http://codereview.chromium.org/3311027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change caused too many layout problems; such as Issue 50100 and 51562. I would like to revert this change now and send another change when I fix them.
When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later.
BUG=1715,36939
TEST=Run chrome.exe on the screen resolution higher than 120 DPI.
Review URL: http://codereview.chromium.org/2867031
TBR=hbono@chromium.org
Review URL: http://codereview.chromium.org/3435002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Clang complains about this unused return value.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3334016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=55517
TBR=glider
Review URL: http://codereview.chromium.org/3400002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks.
To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage.
Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely.
BUG=52393
TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug.
Review URL: http://codereview.chromium.org/3325012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51906
TEST=none
Review URL: http://codereview.chromium.org/3410004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Record metrics with associated input method IDs, and language codes,
to make the metrics data more useful.
Update chromeactions.txt as follows:
% cd chrome/tools
% PYTHONPATH=../../tools/python python extract_actions.py --hash
BUG=chromium-os:2637
TEST=manually.
Review URL: http://codereview.chromium.org/3330021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
values.
Also rework preference notifications so they're not sent when a pref store rewrites the same value it already had,
to avoid infinite recursion in places that set a pref in response to a notification that that pref has changed.
This allows notifications to be sent properly when another PrefStore takes control from a default value.
BUG=52719, 54950
TEST=covered by unit tests (PrefValueStoreTest.*, PrefNotifierTest.*, and ExtensionPrefStoreTest.*)
Review URL: http://codereview.chromium.org/3323022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add an ability to enable extension in incognito mode by default from external_extensions.json file.
BUG=chromium-os:6516
TEST=unit_tests --gtest_filter=ExtensionsServiceTest.ExternalPrefProvider
Review URL: http://codereview.chromium.org/3360020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4023, chromium-os:4117, chromium-os:4117
TEST=Manual test first OOBE screen
Review URL: http://codereview.chromium.org/3166028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32597
TEST=manual
Patch by morrita@google
Original code review: http://codereview.chromium.org/3333018/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/3431001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added 250ms delay for notification nudges
- Bumped up limits for Tango to reduce the number of registration replies
BUG=55279
TEST=manual
Review URL: http://codereview.chromium.org/3411004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54197
TEST=none
Review URL: http://codereview.chromium.org/3396002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This partially fixes a high QPS issue we're seeing with notifications.
BUG=55279
TEST=Manually
Review URL: http://codereview.chromium.org/3410002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=hope
TBR=dpranke
Review URL: http://codereview.chromium.org/3423001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes AutoFill CreditCard class to initialize billing_address_id_ member in constructors. This was causing initialization errors to be flagged in Valgrind on Mac and Linux. Initializing member to 0 fixes Valgrind.
Suppression (error hash=#FFFFFFFFF153AE3B#):
{
<insert_a_suppression_name_here>
Memcheck:Cond
fun:__udivdi3
fun:sqlite3VXPrintf
fun:sqlite3_snprintf
fun:sqlite3VdbeMemStringify
fun:applyAffinity
fun:sqlite3VdbeExec
fun:sqlite3Step
fun:sqlite3_step
fun:_ZN3sql9Statement3RunEv
fun:_ZN11WebDatabase13AddCreditCardERK10CreditCard
fun:_ZN14WebDataService17AddCreditCardImplEPNS_14GenericRequestI10CreditCardEE
fun:_Z16DispatchToMethodI14WebDataServiceMS0_FvPNS0_14GenericRequestI10CreditCardEEES4_EvPT_T0_RK6Tuple1IT1_E
fun:_ZN14RunnableMethodI14WebDataServiceMS0_FvPNS0_14GenericRequestI10CreditCardEEE6Tuple1IS4_EE3RunEv
fun:_ZN11MessageLoop7RunTaskEP4Task
fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE
fun:_ZN11MessageLoop6DoWorkEv
fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE
fun:_ZN11MessageLoop11RunInternalEv
fun:_ZN11MessageLoop10RunHandlerEv
}
etc.
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/7521/steps/memory%20test:%20unit/logs/stdio
http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(1)/builds/5915/steps/memory%20test:%20unit/logs/stdio
BUG=49094
TEST=Run Valgrind, verify no leaks or errors reported.
TBR=jhawkins
Review URL: http://codereview.chromium.org/3422001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=petersont
Review URL: http://codereview.chromium.org/3411002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Having the pointer would be useful for those who want to use
RecordComputedAction(). For instance, I spent some to find out
the script.
BUG=none
TEST=compiled.
Review URL: http://codereview.chromium.org/3364020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port SymmetricKeyTest.ImportGeneratedKey and
SymmetricKeyTest.ImportDerivedKey to all platforms. On Mac,
the salt for PBKDF2 must be at least 8 bytes long.
R=tim
BUG=none
TEST=base_unittests --gtest_filter=SymmetricKeyTest.ImportDerivedKey
should pass on Windows.
Review URL: http://codereview.chromium.org/3361020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3421001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55045
TEST=manual
Review URL: http://codereview.chromium.org/3399003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54197
TEST=browse to page with a 2d canvas with no command line flags, verify that it uses the GPU
Review URL: http://codereview.chromium.org/3382003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionInstallUI::Delegate::InstallUIProceed.
Reason: We don't support shortcut creation from this dialog anymore.
(Note: this was a TODO for Aaron).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3305030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invasive. (identified by mehmet@chromium.org)
e.g. kBookmarkHorizontalPadding split into kBookmarkHorizontalPadding
and kBookmarkSubMenuHorizontalPadding.
Make padding on very top and very bottom of folder menus equal,
and consistent if we have 0, 1, or N marks (and work even when a
mark is dragged in).
BUG= http://crbug.com/59174 http://crbug.com/55203 http://crbug.com/55476
Review URL: http://codereview.chromium.org/3410001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is so it can be statically linked with untrusted NaCl code.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3366021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
s/ImportCertResult/ImportCertFailure/
BUG=19991
TEST=none
Review URL: http://codereview.chromium.org/3351002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59318 0039d316-1c4b-4281-b951-d872f2087c98
|