| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Commit after previous change to build-valgrind-for-chromium.sh is committed and run.
BUG=17484
TEST=sh tools/valgrind/chrome_tests.sh -t base --tool_flags="--nocleanup_on_exit"; grep PossiblyLost valgrind.tmp/* should find no matches.
Review URL: http://codereview.chromium.org/159252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/159260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=https://crbug.com/17509
Review URL: http://codereview.chromium.org/159259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
but we have to turn the tree green.
Can you please take a look?
Review URL: http://codereview.chromium.org/155981
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Broke in r21342)
<jamesr> agl: chromium XP release builder builds chrome.sln and then tries to
run ipc_tests.exe. nothing in chrome.gyp depends on ipc_tests now so the
executable doesn't exist on that builder
<jamesr> agl/jrg: adding a dependency on ../ipc/ipc.gyp:ipc_tests to the
'coverage' target would solve both issues
<jrg> jamesr: agl's change will only impact the coverage bots. Sounds like
that't not what you want, right?
<jamesr> jrg: i think it's correct but won't resolve the chromium XP issue.
coverage should run for those tests either way
<agl> jamesr: how about I tie it to unit_tests?
<agl> jamesr: there's a long term solution and then there's getting the builder
green.
<jamesr> agl: yeah. trying to check super fast if getting that builder to not
run ipc_tests.exe is easy
http://codereview.chromium.org/155977
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify test_shell so that it will handle checking system dependencies on
Vista and XP. Clean up a bunch of error messages so that we provide
better diagnostics about what is and isn't configured correctly.
BUG=none
TEST=none
R=ojan@chromium.org
Review URL: http://codereview.chromium.org/159111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
python 2.4's implementation of sys.popen() keeps a list of subprocesses
around to handle cleanup, but the list isn't safe against concurrent access,
leading it to sometimes through a ValueError exception. The list is kind
of pointless, and the exception can be ignored (which it is in 2.5).
BUG=none
R=maruel
TEST=none
Review URL: http://codereview.chromium.org/155782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 21252 seems to have had some svn brokenness (not sure why). I've recreated
it and resubmitted it. The changes are to move image_diff from
chrome/tools/test to tools/, and to make test_shell depend on image_diff
and npapi_layout_test_plugin (and test_worker, where applicable)
R=nsylvain@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to speed up log processing.
BUG=17484
TEST=run to install new valgrind; sh tools/valgrind/chrome_tests.sh -t base --tool_flags="--nocleanup_on_exit --show-possible=no"; grep PossiblyLost valgrind.tmp/* should find no matches.
Review URL: http://codereview.chromium.org/159251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a 1920x1200 screen.
Also, tweak the default size of new windows slightly. In case we decide
to use side by side windows size the window in such a way that 2
windows fit on the screen and have the kWindowTilePixels spacing
between each other and the screen edges.
BUG=None
TEST=Show two windows side. On a 1920x1200 screen they should both be
showing the thumbnails in normal size.
Review URL: http://codereview.chromium.org/155930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17441
TEST=sh tools/valgrind/chrome_test.sh -t ui on mac, watch it not time out when running dsymutil
Review URL: http://codereview.chromium.org/159196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when doing evictions or enumerations.
This cl fixes an issue with dirty entries being deleted
twice from disk, and improves the whole thing so that
different flavors or corrupt entries are removed
gracefully. We started deleting things twice when we
created the map of currently-open entries, because
we don't want to have dirty entries on that map, so it is
possible to have multiple EntryImpl objects that refer
to the same entry (for corrupt entries).
BUG=17474
TEST=Unittests, stress_cache.exe
Review URL: http://codereview.chromium.org/155951
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests (if-modified-since).
This test does not pass, and is currently disabled -- it will be enabled once 16199 is fixed.
BUG=http://crbug.com/16199
Review URL: http://codereview.chromium.org/159220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17300
TEST=none
Review URL: http://codereview.chromium.org/159232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16023
TEST=play a multichannel audio video and it should play with audio muted
Review URL: http://codereview.chromium.org/155937
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/155968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
theIO thread be the second thread. The change is needed for plugins on mac.
Review URL: http://codereview.chromium.org/155944
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockWebClipboardImpl is only used in layout test mode and it
contains some member variables. Since the destructors weren't
virtual, it was leaking these member variables.
BUG=17184
Review URL: http://codereview.chromium.org/159238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mouse hovering on every web page
Should check tooltip text against empty before adding Unicode Marks for directionality.
BUG=http://crbug.com/17468
BUG=http://crbug.com/17176
BUG=http://crbug.com/5996
TEST= open a webpage, mouse over plain text area, empty square should not show up as tooltip.
Review URL: http://codereview.chromium.org/159222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with typical collada files found on the net.
Often someone will export a collada file with absolute paths
like "z:\someplace\somewhere\texture.tga" and
"k:\shared\stuff\othertexture.tga"
The converter needed a way to handle these without requiring
an artist to manually edit XML files.
I also refactored the original_data_ stuff to make sure
we don't get 2 datas for the same path. I'm doing that
in prepartion for shortening the paths where possible
using base-path or some mechanism.
Review URL: http://codereview.chromium.org/159118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17392
TEST=Less console spew on test bots.
Review URL: http://codereview.chromium.org/155881
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension's name.
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/155957
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Crash/kill a plugin process on the Mac; sad tab should draw in the right place.
Review URL: http://codereview.chromium.org/155958
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
out of the browser. We must wrap the tab renderer widget in a GtkFixed in order to maintain the size we request for the widget; otherwise, the widget will fill the entire window.
BUG=none
TEST=Drag a tab out of the window. This should not crash.
Review URL: http://codereview.chromium.org/155965
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Running with --enable-plugins on, go to a page with a plugin and kill the plugin process. The info bar should list the name of the plugin rather than its path.
Review URL: http://codereview.chromium.org/155952
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add browser-process IPC code + tweak the WebKit Thread. Note that this code can't possibly be called/run yet.
WebKitThread now has a PostIOThreadTask methods that can safely post back to the IO thread. This should be used for all WebKit thread -> the rest of the world communication.
There are many TODOs in this code that should be resolved before this is shipped without a --enable-local-storage flag.
BUG=4360
TEST=none
Review URL: http://codereview.chromium.org/155845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't get called back in our signal handlers and access freed memory.
BUG=17188
TEST=sh tools/valgrind/valgrind_webkit_tests.sh LayoutTests/editing/pasteboard works
Review URL: http://codereview.chromium.org/155893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the mouse down occurs over an unselected row, let the default handler run before we show the context menu (so that row will be selected when we show the menu). If the mouse down occurs over a selected row, don't let the default handler run (because if multiple rows are selected the rest of the selection would get clobbered).
BUG=http://crbug.com/17388
TEST=see bug
Review URL: http://codereview.chromium.org/159179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=4773
BUG=17081
TEST=Compile, run, and browse google.com with Chromium.
Review URL: http://codereview.chromium.org/159227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This splits the ipc code from the common project. The 'common' project pulls in
all of webkit, the v8 bindings, skia, googleurl, and a number of other projects
which makes it very difficult to deal with especially for external projects
wanting just to use some of Chromium's infrastructure. This puts the ipc code
into its top-level ipc/ directory with a dependency only on base. The common
project depends on the new ipc/ipc.gyp:ipc target so that all projects currently
pulling common in to get the IPC code still have it available. This mostly
follows agl's pre-gyp attempt to do this which was r13062.
Known issues:
- Currently a number of projects depend on chrome/chrome.gyp:common in order to
use the IPC infrastructure. Rather than fixing all of these dependencies I have
made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules
section of DEPS so that checkdeps.py doesn't complain. Over time projects that
need IPC should depend on the IPC project themselves and dependencies on common
removed, although I don't think many projects that need IPC will be able to get
away without common currently.
- ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a
ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve
this since it's really an IDE bug
- the named pipe name (windows+linux) and the logging event name (all) + env
variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion
of ipc/ being an independent library. I think this should be examined in a
subsequent, much smaller patch.
- I've eliminated the IPC.SendMsgCount counter since it was implemented in a way
to create a dependency from ipc/ to chrome/common/chrome_counters. This is the
same approach that r13062 took.
http://codereview.chromium.org/155905
(Patch from James Robinson)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: aa
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser_tests are not happy.
TBR=aa
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/159243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=estade
Review URL: http://codereview.chromium.org/159240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/159233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
failing on the buildbot.
TBR=aa
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/159235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FileDataSource broke the linux valgrind build because the callback
for read was not deleted.
TBR=scherkus
Review URL: http://codereview.chromium.org/159234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
<http://build.chromium.org/buildbot/waterfall/waterfall?builder=Vista%20Tests>
tbr=rafaelw
Review URL: http://codereview.chromium.org/155955
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit r21332.
REVERT=21332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awong
Review URL: http://codereview.chromium.org/155949
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I've updated revelant bugs to indicate new test status.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/155948
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is mostly accomplished by decoupling autocomplete (and the
auto-select-all when first clicking in the omnibox to focus it) from GTK's
clipboard code. Before we update the selection marks, I unregister the
clipboard and block the signal from reaching my handler. Afterwards, I
restore things.
This creates the possibly-odd effect that text can be highlighted both in
the omnibox and in Webkit, assuming that the omnibox text isn't actually
the primary selection. I think that this is reasonable, but let me know if
you can think of a better way that it should be handled.
To test, I confirmed that all of the cases listed in
http://codereview.chromium.org/151006's description still work, along with
the following new ones:
1. Highlight text in an xterm to make it the primary selection. Start
typing an autocomplete-able URL into Chrome's omnibox. Middle-click in
the xterm and check that the xterm's text, rather than the autocompleted
text from the omnibox, is pasted.
2. Now switch to a different tab and middle-click in the xterm again. The
xterm's text should still be pasted.
3. Switch to the original tab and check that the xterm's text is still the
primary selection.
4. Highlight text in an xterm. Click in Webkit to make sure
that the omnibox doesn't have the focus. Left-click in the omnibox.
Its text should be highlighted but not made the primary selection
(middle-clicking in the xterm should still paste the xterm's text).
EDIT: I've changed this behavior -- clicking in the omnibox to focus it
now sets its text as the primary selection.
5. Now triple-left-click in the omnibox to highlight all of its text. This
time, the URL should become the primary selection.
EDIT: This is no longer relevant.
I noticed the following annoying behavior, but it's also present in the
official build without this change, so I don't think it's a regression
(there's probably something going on in GTK that I don't understand):
Highlight some text in the omnibox to make it the primary selection.
Now double-left-click to highlight a word in an xterm. The word flashes in
the xterm, but Chrome automatically grabs the selection again.
Double-clicking in the xterm again lets it hang on to the selection.
Patch by Dan Erat <derat [at] google>
original review url: <http://codereview.chromium.org/159185>
Review URL: http://codereview.chromium.org/159230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(as opposed to grey text in unfocused panels)
Review URL: http://codereview.chromium.org/159176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expand complex types in reference pages.
Support $ref for types in docs.
Added Kathyw's template changes including leftNav and header.
Remove old api files.
R=aa
Review URL: http://codereview.chromium.org/155945
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. FFmpegGlue now taks a FFmpegProtocol instead of DataSource as input
2. FFmpegDemuxr implements FFmpegProtocol and does the blocking read and submit asynchronous read request to DataSource (with unit tests)
3. Changed SimpleDataSource to work with asynchronous read (with unit tests)
4. Reimplemented BufferedDataSource to work with asynchronous read (with unit tests)
5. Moved BufferedDataSource from chrome/renderer/media to webkit/glue/media (for faster build/debug and better coverage in automated testing)
TEST=BufferedDataSourceTest.*, SimpleDataSourceTest.*, FFmpegDemuxerTest.*
Review URL: http://codereview.chromium.org/149567
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
them from moving when running the selenium tests in order to get consistent snapshots.
Review URL: http://codereview.chromium.org/155928
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21325 0039d316-1c4b-4281-b951-d872f2087c98
|