| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tyoshino
Review URL: http://codereview.chromium.org/7384009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
File "/usr/local/google/chrome-commit/src/tools/valgrind/memcheck_analyze.py", line 501, in Report
self.ErrorHash())
AttributeError: MemcheckAnalyzer instance has no attribute 'ErrorHash'
TBR=timurrrr
Review URL: http://codereview.chromium.org/7387009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/7386004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Memcheck:/Heapcheck: suppression lines.
BUG=89305
TEST=Run presubmit check on a suppression without a Memcheck:/Heapcheck: line.
Review URL: http://codereview.chromium.org/7373001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileIOData is now always deleted on the IO thread. Replaces a use of ChromeURLRequestContextGetter with a ChromeURLDataManagerBackend getter callback. Also gets rid of ExtensionInfoMap from ChromeURLRequestContext by directly passing it into the places that need it. Gets rid of the HTML5 storage objects from ChromeURLRequestContext too.
Adds a workaround for TranslateManager's Profile::GetDefaultRequestContext() use, since after this refactoring (by not requiring ChromeURLRequestContextGetter for ChromeURLDataManagerBackend), it prevents having to initialize the ChromeURLRequestContextGetter in most tests since they don't actually use it. This means |default_request_context_| doesn't always get initialized in BrowserMain(), which causes TranslateManager to crash on startup since it requires |default_request_context_| to be initialized. So we forcibly initialize |default_request_context_| until TranslateManager stops depending on this.
BUG=89396
TEST=none
Review URL: http://codereview.chromium.org/7282054
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/7384008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's crashing consistently when it's on Linux Tests (Views dbg)(3) bot while
it's passing consistently when it's on other View dbg bots.
BUG=89392
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added C++ code send property name in OnNetworkDeviceChanged to make sure that we got results of scan instead of some other property change.
BUG=chrome-os-partner:4918,chromium-os:14422
TEST=manual
Review URL: http://codereview.chromium.org/7342041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileIOData is now always deleted on the IO thread. Replaces a use of ChromeURLRequestContextGetter with a ChromeURLDataManagerBackend getter callback. Also gets rid of ExtensionInfoMap from ChromeURLRequestContext by directly passing it into the places that need it. Gets rid of the HTML5 storage objects from ChromeURLRequestContext too.
Adds a workaround for TranslateManager's Profile::GetDefaultRequestContext() use, since after this refactoring (by not requiring ChromeURLRequestContextGetter for ChromeURLDataManagerBackend), it prevents having to initialize the ChromeURLRequestContextGetter in most tests since they don't actually use it. This means |default_request_context_| doesn't always get initialized in BrowserMain(), which causes TranslateManager to crash on startup since it requires |default_request_context_| to be initialized. So we forcibly initialize |default_request_context_| until TranslateManager stops depending on this.
BUG=89396
TEST=none
Review URL: http://codereview.chromium.org/7282054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's failing consistently when it's on Linux Tests (Views dbg)(3) bot while
it's passing consistently when it's on other View dbg bots.
BUG=89392
TEST=none
Review URL: http://codereview.chromium.org/7389006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it's DefaultProviders communicate through an observer interface.
BUG=63656
TEST=host_content_settings_map_unittest.cc,
content_settings_pref_provider_unittests.cc,
content_settings_policy_provider_unittests.cc
Review URL: http://codereview.chromium.org/7368004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PendingTask::post_births could sometimes be left unitialized
No way for user to know if Tracked::GetBirthPlace will hit tracked_births_ NULL pointer exception.
nit: MissingBirthplace has inconsistent capitalization
BUG=None
TEST=base_unittests
Review URL: http://codereview.chromium.org/7375006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=scheib@chromium.org
BUG=none
TEST=green
Review URL: http://codereview.chromium.org/7387004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87295,chromium-os:16138
TEST=launch downloads page (ctrl-j). Right click should bring up a context menu on the body and non-control links. For control links (Show in Finder, Remove From List, Pause, Resume, etc), right click should not bring up a context menu. Right click + Open in New Tab should work correctly on all platforms for files with unicode characters as well as uri special chars +/\@~!'"()#$&,:;=?%
Review URL: http://codereview.chromium.org/7308002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved the CanSetAsDefaultBrowser / ProtocolClient functions next to the
routines which do the setting of Chrome to be the default browser and
client.
BUG=88196
TEST=Manual testing performed
Review URL: http://codereview.chromium.org/7334003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Build on clang.
Review URL: http://codereview.chromium.org/7383005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used
A tiny cleanup.
BUG=none
TEST=green bots
Review URL: http://codereview.chromium.org/7372001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turning on CoreAnimationLayers in tabviews caused a serious performance
regression. We now use an NSAnimation to animate the close button.
xib change is to turn off layers in tabviews.
Roll GTM 440:446 - Gets us GTMKeyValueAnimation
BUG=89232, 89228
TEST=Test described in 89232. For 89228 verified that close button appears in tab, info bar and download bar.
Review URL: http://codereview.chromium.org/7375014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=87283
TEST=Run on a machine with NVIDIA GeForce 7300 GT on Mac 10.5 immediately after booting.
Review URL: http://codereview.chromium.org/7373018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=89274
TEST=base_unittests --gtest_filter=MD5Test.*
R=evan@chromium.org
Review URL: http://codereview.chromium.org/7363013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7358009
nacl_integration test is still failing. Reverting this to re-disable it.
BUG=89177
TBR=polina@google.com
Review URL: http://codereview.chromium.org/7387003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Download and save a file with uri special chars +/\@~!'"()#$&,:;=?%. The fileicon should display correctly.
Review URL: http://codereview.chromium.org/7377009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to JingleChannel class.
Added new CreateChannel() method in Session interface. The new method can be used to create arbitrary channels.
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7326024
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/7385002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added new CreateChannel() method in Session interface. The new method can be used to create arbitrary channels.
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7326024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1 - fix horizontal scroll for pagers in rtl
2 - fix page shower hidden logic (don't flash them during page startup)
3 - fix nav dots so you can click the whole vertical space to select them (use a spacer div instead of margin because margins can't be clicked)
4 - fix font color for nav dots (linux doesn't like transparency and we don't need it anyway)
5 - fix z-order of recently closed menu (show on top of footer)
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7373015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=krisr@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7373016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: This was a TODO for ben.
BUG=None
TEST=views_unittests, views_examples, views_desktop.
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7359006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Relanding r92585, which was reverted by r92591 after breaking
CapsLockMenuButtonTest.InitialIndicatorTest.)
This makes us hide status area icons instead of clearing
their bitmaps and tooltips. StatusAreaView is notified about
visibility changes and uses that as a signal to re-layout.
BUG=chromium-os:17429,chromium-os:17370
TEST=manual: checked that status area is updated as expected when toggling caps lock and switching/enabling/disabling input methods; also saw the previously-failing test pass on linux_view and linux_chromeos trybots
Review URL: http://codereview.chromium.org/7379006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=87995
TEST=None
Review URL: http://codereview.chromium.org/7346002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
testImportFirefoxHistoryFromPrefs, testImportFirefoxPasswordsFromPrefs, testImportFirefoxSearchEnginesFromPrefs
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7360007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the DEPS in content\browser\download is very permissive for now. The one exception is save_package.cc, where I had to split off the usage of SelectFileDialog because the code depended on grit which can't be used in content (circular dependencies in gyp).
TBR=rdsmith
BUG=82782
Review URL: http://codereview.chromium.org/7373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7374006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change tests away from racy code.
R=jhawkins@chromium.org,phajdan.jr@chromium.org
BUG=22951
TEST=BrowserNavigatorTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92289
Review URL: http://codereview.chromium.org/7233021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=89059
TEST=none
Review URL: http://codereview.chromium.org/7360003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to remove it from all, but it's needed for the save. The reason I'm
doing this is I'm changing the calling order so that the delegate
won't know it's widget at the time GetSavedXXX is invoked. Turns out
we really only need the widget during the save calls anyway, so this
all still works.
BUG=none
TEST=none
R=ben@chromium.org,mirandac@chromium.org
Review URL: http://codereview.chromium.org/7377004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
profile-specific.
This is accomplished by associating a randomly generated id with each profile,
and storing the profile id with the passwords. The ids are chosen such that they
are obviously not unique ids (there are more users than ids), yet within one
machine they should be unique with high probability.
Although profiles have names, it turns out that using these names as the
identifiers is not preferable for two reasons. First, the names are actually the
account email addresses, and not user-provided strings. The default profile, if
not using sync, has the empty string for its name. This means that we still have
to worry about migration in this case, and can't cleanly assume that existing
passwords "belong" to the default profile, because we can't always tell which
profile is the default. Second, the sync code seems to be rather non-robust and
fails frequently when passwords change underneath it. Using the profile name
would mean that the same account synced within different user data dirs would
share passwords, which the sync code won't really like. (Of course, this is the
current situation as well, with different user data dirs.)
Speaking of migration: this change leaves the original, shared passwords alone,
and they will be migrated (copied, really) into each profile the first time it
is used. After a while, we can add code to delete these shared passwords so they
don't persist forever without being visible in the UI. Eventually, we can remove
the migration and deletion code.
BUG=77022
Review URL: http://codereview.chromium.org/7212031
TBR=mdm@chromium.org
Review URL: http://codereview.chromium.org/7373014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=88531
R=mattm@chromium.org, noelutz@google.com
Review URL: http://codereview.chromium.org/7379010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is accomplished by associating a randomly generated id with each profile,
and storing the profile id with the passwords. The ids are chosen such that they
are obviously not unique ids (there are more users than ids), yet within one
machine they should be unique with high probability.
Although profiles have names, it turns out that using these names as the
identifiers is not preferable for two reasons. First, the names are actually the
account email addresses, and not user-provided strings. The default profile, if
not using sync, has the empty string for its name. This means that we still have
to worry about migration in this case, and can't cleanly assume that existing
passwords "belong" to the default profile, because we can't always tell which
profile is the default. Second, the sync code seems to be rather non-robust and
fails frequently when passwords change underneath it. Using the profile name
would mean that the same account synced within different user data dirs would
share passwords, which the sync code won't really like. (Of course, this is the
current situation as well, with different user data dirs.)
Speaking of migration: this change leaves the original, shared passwords alone,
and they will be migrated (copied, really) into each profile the first time it
is used. After a while, we can add code to delete these shared passwords so they
don't persist forever without being visible in the UI. Eventually, we can remove
the migration and deletion code.
BUG=77022
Review URL: http://codereview.chromium.org/7212031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=89297, 87500
TEST=
Review URL: http://codereview.chromium.org/7381006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=76301
TEST=20_register_epson.com.mx.html
Review URL: http://codereview.chromium.org/7354010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the test now results in a timeout, it fails. Before, it would erroneously
pass. Also, the test first checks if it can create a WebGL context, failing
immediately if it cannot (what's the point of a WebGL conformance test
without WebGL?).
When a test fails, it now prints informative, machine-specific WebGL data.
TEST=gpu_tests --gtest_filter=WebGLConformanceTests.*
Review URL: http://codereview.chromium.org/7359004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dennisjeffrey@chromium.org
BUG=85310
TEST=
Review URL: http://codereview.chromium.org/7373012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=89309
TEST=less redness
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/7365005
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/7373013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51461, 73631
TEST=Install an extension that adds context menu items - you should now see
them on pages with schemes like chrome://, file://, chrome-extension://, etc.
Review URL: http://codereview.chromium.org/7258009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for a leak.
BUG=87396, 87500
TEST=none
Review URL: http://codereview.chromium.org/7379011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92608 0039d316-1c4b-4281-b951-d872f2087c98
|