| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Not handling correctly caused a crash. Added unit tests to cover those cases.
BUG=71953
TEST=covered by installer util unit tests
Review URL: http://codereview.chromium.org/6485026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=NaCl:910
Review URL: http://codereview.chromium.org/6505002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TODO(willchan): Whack the other old suppressions that this supercedes.
BUG=72698
TEST=none
Review URL: http://codereview.chromium.org/6474048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
constructor.
R=cbentzel
CID=8793
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6492001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put the SSE2 block differ code back in.
TBR=dhollowa
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6501005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FormStructureBrowserTest.DataDrivenHeuristics.
BUG=72401
TEST=
Review URL: http://codereview.chromium.org/6486027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is accomplished with hashtags, which also make it possible to copy/paste a search URL.
I also removed the special hash handling in content settings exceptions, because it's enough to check the hash in didShowPage (to make that possible, I made it so the history/address bar updates before didShowPage is called).
TESTS:
1. if you type something in the search field, then click away (either on a link or nothing), that search page is persisted in history
2. go to browser page. Search for a. click on the right pane. Add more text to the search and click a subpage overlay. Clicking back should walk back through both searches all the way to the basics page.
3. search for something and click away from the search field. close the tab. re-open with ctrl-shift-t. You should get back to the search page you were on.
4. Clicking the same link in the navbar twice shouldn't add more than 1 entry to history.
note that 3 sometimes fails, but I think it's a problem of session restore not updating quickly enough (the wrong URL is populated for the restored tab).
BUG=71477
TEST=see above
Review URL: http://codereview.chromium.org/6420001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6487015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open input method drop-down, press alt-shift, observe selected input method changed in drop-down.
oshima landed for vsevik
Review URL: http://codereview.chromium.org/6246138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to get context menus working in Pepper.
MenuClosed is called on views+win and native gtk, so this seems like the right thing to do.
BUG=none
TEST=Ran Pepper Flash on a Chrome OS build, made sure context menus work
Review URL: http://codereview.chromium.org/6250098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
due to this.
BUG=chromium-os:10655
TEST=manual
Review URL: http://codereview.chromium.org/6476011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland V8 update since it didn't make media_unittests pass.
Trying to see if this is related to the media_unittests crash.
Review URL: http://codereview.chromium.org/6486026
TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/6504001
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/6500009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently just log them to console for now; I'll do something with them
in a future CL.
BUG=69500
Review URL: http://codereview.chromium.org/6480018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, restore non-editability to location and notifications exceptions.
BUG=72355
TEST=manual
Review URL: http://codereview.chromium.org/6486019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6485015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6485017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
selection border. This should fix it.
BUG=51181
TEST=Go to bookmarks manager and right click a folder and select 'Rename...'. The blue borders should not be covered by the input boxes. The text in the input boxes should align exactly with the text before and after editing.
Review URL: http://codereview.chromium.org/6468001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6487017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6489023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
After talking to jar, it seems impossible to reliably get a reasonable MSG from Windows given native nested message loops etc. So I am making this do what my prototype did and just generate a synthetic MSG from the information supplied to the WndProc. It turns out this is what ATL does too for its GetCurrentMessage implementation.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6500003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=compile with touch, press alt+d to select the omnibox, crash.
TEST=manually, see bug.
Review URL: http://codereview.chromium.org/6503006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently users can interact with the browser window while the Request Restart dialog is open. This can lead to some weird cases where things don't work.
There are two problems here. First, RequestRestart() calls -[NSAlert beginSheetModalForWindow:] even if the parent window is nil. This causes the dialog to be top most but not block input in the browser window. Fix is to use -[NSAlert runModal] instead.
Second, BrowserWindowCocoa::ShowUpdateChromeDialog() calls RequestRestart() with a nil parent window. I'm changing this to pass a parent window instead.
BUG=66532
TEST=Forced the restart dialog to show. Verified that the dialog was window modal and didn't allow any interaction with tabs.
Review URL: http://codereview.chromium.org/6503005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's 9% flaky on WIn XP (dbg).
BUG=72745
TEST=NONE
TBL=kkania
Review URL: http://codereview.chromium.org/6500006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
see what's going on without opening up page_transition_types.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6488015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove hacky code to increase timeout for specific tests.
Instead, allow to increase test termination timeout
via SLOW_ prefix (should be used as last resort).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6410059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we're communicating through the ALSA API, there's no more need to try to talk to the mixer through PulseAudio. If PulseAudio is running however, all should still work since PA will emulate the Alsa API.
Originally, we tried to connect through the PulseAudio API, and then if that failed, tried through ALSA. As a first step in removing PA altogether, this just skips trying to connect to PA first and goes right to connecting through Alsa. If Alsa is working fine for a while, we can then remove all other references to PulseAudio.
Currently browser tests are failing quite often with a pulseaudio error, probably still something to do with trying to stop the connection to pulse before trying to connect.
BUG=(none)
TEST=Manual, browser_tests should not fail with pa_context_get_state() errors.
Review URL: http://codereview.chromium.org/6476020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
protected by the use_third_party_translations flag
Review URL: http://codereview.chromium.org/6485012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow the conversion to take mirroring into account by converting from
the icon view instead of its parent.
BUG=72654
TEST=LANGUAGE=he_IL chrome and verify that arrow is pointing at location icon.
Review URL: http://codereview.chromium.org/6487018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no observable change
Review URL: http://codereview.chromium.org/6505001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6486016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Real bugs:
net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:310:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>' requested here
CaptureGroupNameHttpProxySocketPool::CaptureGroupNameSocketPool(
^
In file included from ./net/http/http_network_session_peer.h:10:
./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:316:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>' requested here
CaptureGroupNameSSLSocketPool::CaptureGroupNameSocketPool(
^
In file included from ./net/http/http_network_session_peer.h:12:
./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:5511:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>' requested here
new CaptureGroupNameTCPSocketPool(NULL, NULL);
^
In file included from ./net/socket/socket_test_util.h:34:
./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:5630:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>' requested here
new CaptureGroupNameSOCKSSocketPool(NULL, NULL);
^
In file included from ./net/http/http_network_session_peer.h:11:
./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
CXX(target) out/Debug/obj.target/net_unittests/net/http/http_response_body_drainer_unittest.o
4 errors generated.
net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:170:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>' requested here
CapturePreconnectsHttpProxySocketPool::CapturePreconnectsSocketPool(
^
In file included from ./net/http/http_network_session_peer.h:10:
./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:176:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>' requested here
CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool(
^
In file included from ./net/http/http_network_session_peer.h:12:
./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:188:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>' requested here
new CapturePreconnectsTCPSocketPool(
^
In file included from ./net/socket/socket_test_util.h:34:
./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:237:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>' requested here
new CapturePreconnectsSOCKSSocketPool(
^
In file included from net/http/http_stream_factory_unittest.cc:17:
In file included from ./net/http/http_network_session_peer.h:11:
./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
CXX(target) out/Debug/obj.target/net_unittests/net/http/http_vary_data_unittest.o
4 errors generated.
make: *** [out/Debug/obj.target/net_unittests/net/http/http_stream_factory_unittest.o] Error 1
media/audio/linux/alsa_output_unittest.cc:83:3:error: 'MockAudioManagerLinux::MakeAudioInputStream' hides overloaded virtual function [-Woverloaded-virtual]
MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*(
^
In file included from media/audio/linux/alsa_output_unittest.cc:12:
In file included from ./testing/gmock/include/gmock/gmock.h:61:
testing/gmock/include/gmock/gmock-generated-function-mockers.h:632:28: note: instantiated from:
^
media/audio/linux/alsa_output_unittest.cc:83:3: note: instantiated from:
MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*(
^
media/audio/linux/alsa_output_unittest.cc:83:16: note: instantiated from:
MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*(
^
In file included from media/audio/linux/alsa_output_unittest.cc:9:
./media/audio/linux/audio_manager_linux.h:30:29: note: hidden overloaded virtual function 'AudioManagerLinux::MakeAudioInputStream' declared here
virtual AudioInputStream* MakeAudioInputStream(AudioParameters params);
^
CXX(target) out/Debug/obj.target/media_unittests/media/base/data_buffer_unittest.o
CXX(target) out/Debug/obj.target/media_unittests/media/base/djb2_unittest.o
1 error generated.
No bug, just confusing:
In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5:
./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual]
void HandleEvent(int event_index);
^
In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5:
In file included from ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:9:
./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here
virtual int16 HandleEvent(void* event);
^
1 error generated.
make: *** [out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_schedule_timer_test.o] Error 1
CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_private_test.o
CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_test_factory.o
In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:17:
./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual]
void HandleEvent(int event_index);
^
In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:7:
In file included from ./webkit/plugins/npapi/test/plugin_arguments_test.h:8:
./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here
virtual int16 HandleEvent(void* event);
^
1 error generated.
BUG=72205
TEST=none
Review URL: http://codereview.chromium.org/6503001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6474020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
appropriate CSS/JS files.
BUG=72363
TEST=none
Review URL: http://codereview.chromium.org/6471014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6489035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Trying to see if this is related to the media_unittests crash.
Review URL: http://codereview.chromium.org/6486026
TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/6504001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
a header only.
Review URL: http://codereview.chromium.org/6410007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Clang gfx_unittest passes
Review URL: http://codereview.chromium.org/6502001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the pepper plugin is called into, it has the ability to remove itself from
the DOM, using the Var interface. To prevent the instance from going away while
it's still in the stack, we need to keep a reference to it, any time we call
into the plugin but need to access the interface afterwards.
BUG=chromium-os:11694
TEST=With pepper flash (needs separate fix), go to www.nick.com, let it play the video and check it doesn't crash
Review URL: http://codereview.chromium.org/6488017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Missed the const param part last time.
BUG=chromium:72576
TEST=Build should pass without warning.
Review URL: http://codereview.chromium.org/6499001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hamaji
Review URL: http://codereview.chromium.org/6474043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce OffTheRecordProfileIOData and ProfileImplIOData.
They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile.
All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal().
I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files.
TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData.
BUG=67237
TEST=none
Review URL: http://codereview.chromium.org/6500002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
A number of Windows bots have gone red in media_tests on the waterfall:
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%281%29
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%281%29/builds/501/steps/media_unittests/logs/stdio
This seems to be related to r74571. So am reverting to see.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/6502002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the place it was being registered in all cases, so I am moving the message tracking to use the existing widget message loop observer which is added post-window-create. Need to talk to jar/darin about exposing this functionality on MessageLoop.
BUG=none
TEST=views_unittests passes
TBR=sky
Review URL: http://codereview.chromium.org/6474042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=find those machines, verify
Review URL: http://codereview.chromium.org/6487025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This achieves the same goal as ScopedImage, namely encapsulating the memory
management of any image type. But ui::gfx::Image goes further by providing
conversion helpers between different image types.
BUG=carnitas
TEST=gfx_unittests and unit_tests
Review URL: http://codereview.chromium.org/6312159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71326
TEST=verify popup is correct with test page noted in bug writeup.
Review URL: http://codereview.chromium.org/6410125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/6474041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark safe_browsing_thread_ as safe for thread join on shutdown.
BUG=chromium:60211, chromium:72696
TEST=bots
Review URL: http://codereview.chromium.org/6476033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds logic in |select_control_handler.cc| to fill months that are not zero-padded. Also, addes unit tests for major functionality of the |autofill::FillSelectControl()| function.
BUG=64282
TEST=SelectControlHandlerTest.*
Review URL: http://codereview.chromium.org/6482012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74616 0039d316-1c4b-4281-b951-d872f2087c98
|