| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=28746
TEST=Ctrl+C = clean shutdown.
Review URL: http://codereview.chromium.org/432019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28765
Review URL: http://codereview.chromium.org/441010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(sync_ui_util), per style guide.
Changed static functions into anonymous-namespace functions.
Renamed files/namespaces from sync_status_ui_helper to sync_ui_util.
Moved sync_ui_util_mac.mm functions into sync_ui_util namespace.
Updated all callers.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/414065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
memory allocation implementations (tcmalloc, jemalloc, etc.) into a
base\allocator library.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/434067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28149
Review URL: http://codereview.chromium.org/434069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and into lineprimitives.js.
I refactored to code to share a lot of stuff
with primitive.js.
Review URL: http://codereview.chromium.org/435039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a separate transform graph and render graph from
the main scene's.
two more things
1) added a scale to one transform in the scene
to show an issue with manipulators that might
need to be fixed
2) changed the material used by the manipulators
to be constant. This is on the path to making
the manipulators be line primitives instead
of geometry.
Review URL: http://codereview.chromium.org/434060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=agl
Review URL: http://codereview.chromium.org/440015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default it to false. This should improve performance in
sites that use frames and elimiate confusion, since in most
cases developers *don't* expect content scripts to match
frames.
Review URL: http://codereview.chromium.org/412008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetCurrentRenderView() can actually return NULL, which means
that GetExtensionIdForCurrentContext() can also return empty
string. Hillarity ensues.
BUG=28487
Review URL: http://codereview.chromium.org/441005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=UserScriptMasterTest
Review URL: http://codereview.chromium.org/434034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
preserve checkin history. svn cp the added config*.h files into
the local patched branch.
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
r19 is the first revision that has passed security reviews.
BUG=27127
TEST=none
Review URL: http://codereview.chromium.org/437034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to avoid confusing them with other colors.
Review URL: http://codereview.chromium.org/440013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(One edited file: template/api_template.html.
Every other change is an automatically generated file.)
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/434058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28149
Review URL: http://codereview.chromium.org/440014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is almost a full revert of r31526, except that the two DCHECK(url_request_context_getter_) which I promoted to CHECK()s remain as CHECK()s (since they will be useful to catch similar problems in the future, and are cheap).
BUG=27074
Review URL: http://codereview.chromium.org/434050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http server. This should have moved in the previous patch
adding retry of unexpected failures. As it is here, if a websocket
test needs retrying, the an exception will be thrown because the
websocket server is already running from the original test run.
Review URL: http://codereview.chromium.org/435035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Invoking SetRootShown before the tree was created resulted in
updating internal structures with wrong info. This caused problems
if you later tried to delete. I've added a DCHECK to make sure we
don't hit this again.
. Adding a node to the root when the root wasn't shown silently
failed.
BUG=none
TEST=make sure bookmark manager doesn't have any problems when
adding/removing nodes.
Review URL: http://codereview.chromium.org/434053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
via redirect) in a web page displayed by Chrome Frame. The request should be handled by the host browser.BUG=23561
Review URL: http://codereview.chromium.org/385108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modified the FlipIOBuffer to use a DrainableIOBuffer instead
of a IOBufferWithSize. When a write completes, we drain the
bytes, and only fetch the next FlipFrame from the queue after
we have fully drained the buffer.
I will update the tests to be much more thorough in my next
CL.
BUG=none
TEST=FlipNetworkTransactionTest.PartialWrites
Review URL: http://codereview.chromium.org/436019
TBR=mbelshe@google.com
Review URL: http://codereview.chromium.org/440011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed Eos() to IsEndOfStream() to be consistent with other buffer implementations.
BUG=n/a
TEST=n/a
Review URL: http://codereview.chromium.org/440007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modified the FlipIOBuffer to use a DrainableIOBuffer instead
of a IOBufferWithSize. When a write completes, we drain the
bytes, and only fetch the next FlipFrame from the queue after
we have fully drained the buffer.
I will update the tests to be much more thorough in my next
CL.
BUG=none
TEST=FlipNetworkTransactionTest.PartialWrites
Review URL: http://codereview.chromium.org/436019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
as a basis for local changes.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/436037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
..\tcmalloc\jemalloc to preserve checkin history.
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You can switch to using -lOmxCore by setting the gyp variable use_system_openmax=1.
Also fixed type-punning warnings in omx_video_decoder.cc
BUG=28663
TEST=building omx_test should have no linker errors
Review URL: http://codereview.chromium.org/431041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change also reworks the tcmalloc dependency to be added only to chrome and test_shell, instead of base. This is necessary since otherwise tcmalloc will be double initialized (by both the main executable and dlopen'd shared objects like the npapitestplugin.so).
Add valgrind suppressions. This are invalid reads on static initialization in the VDSOSupport module. I haven't investigated it yet, but I suspect they're benign.
BUG=http://crbug.com/28149, http://crbug.com/28385
Review URL: http://codereview.chromium.org/399081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a revert of r31267.
BUG=22083
Review URL: http://codereview.chromium.org/434048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/436034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A X11 media player application that uses the video stack pipeline.
It uses XRender when possible, this will allow the XRender
extension to convert RGBA8888 to the target depth and bits per
pixel on the X Server.
Review URL: http://codereview.chromium.org/399113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
file with the necessary include rules.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=agl
Review URL: http://codereview.chromium.org/441003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dumi
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/437047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This goes along with webkit bug: https://bugs.webkit.org/show_bug.cgi?id=31841
BUG=17466
Review URL: http://codereview.chromium.org/431031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25028
TEST=Drag the window from both incognito view and regular window bar while it's in foreground and background
Review URL: http://codereview.chromium.org/434030
Patch from feldstein.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28577
TEST= Trigger notification (remove a thumbnail) with themed browser, note that text and link in notification (and in extension/bookmark sync promo) are legible and retain original colors.
Review URL: http://codereview.chromium.org/437045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(In particular, clip them to their rounded rectangle.)
BUG=28593
TEST=Drag bookmark bar buttons with a wide variety of themes; make sure edges/corners are correctly clipped from drag images.
Review URL: http://codereview.chromium.org/435028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/431040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/436033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
You can switch to using -lOmxCore by setting the gyp variable use_system_openmax=1.
BUG=28663
TEST=building omx_test should have no linker errors
Review URL: http://codereview.chromium.org/436021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't remove the underlying support from
UserScriptMaster; that is a riskier change.
BUG=27520
Review URL: http://codereview.chromium.org/418043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allowing unwanted popups from a notification with script that sets window.location=foo.
Instead override some RVHDelegate::View methods to allow popups to be blocked, and new-tab links to open in new tabs; now regular links will navigate the toast. The view methods are implemented using the standard helper.
BUG=28015
TEST=none
Review URL: http://codereview.chromium.org/434041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux Release builds on my machine, all the chrome://theme/ image
requests block for 300-400ms during browser startup (it's faster
after startup). Something is blocking the UI thread so move
image requests that aren't themed off the UI thread. This is
safe to do because ResourceBundle is thread safe.
I still see chrome://theme/theme_ntp_attribution and
chrome://theme/theme_ntp_background blocking so I will look
into those next (I think with the default theme, they shouldn't
be loaded at all).
Review URL: http://codereview.chromium.org/440009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a section that points to the various doc URLs (e.g. trunk) and explains
each one.
The only files I edited are static/docs.html and template/api_template.html.
(The remaining files just reflect the template changes.)
BUG=none
TEST=none
TBR=nickbaum
Review URL: http://codereview.chromium.org/431035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28670
TEST=DevToolsSanityTest
Review URL: http://codereview.chromium.org/435015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flicker is caused by setting window title icon while a loading
animation is in progress. Fix the problem by skipping window icon update
when loading animation is running.
BUG=15782
TEST=Verify no flicker while web app loads per Ben's comments.
Review URL: http://codereview.chromium.org/436028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Here's the recent report
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(tsan)/builds/1084/steps/valgrind%20test:%20unit/logs/stdio
BUG=25913
TBR=dank
TEST=unit should become green under TSAN
Review URL: http://codereview.chromium.org/440010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for tab-specific browser action buttons.
o If a tooltip is not present on a browser action button, clear the tooltip of the button.
BUG=28719
TEST=Load chrome/test/data/extensions/api_test/browser_tab_specific_state, play around with it in different tabs and make sure that the state remains the same per tab.
Review URL: http://codereview.chromium.org/434047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32980 0039d316-1c4b-4281-b951-d872f2087c98
|