| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few functions need this and the expected compile-speed impact is low. We should be careful when raising this number higher. If you're binding a function that has more parameters than this supports, consider refactoring your API to use a parameter struct or something.
Template equation: (n^2 + 26n) / 2
Template growth: 96 -> 116 types.
BUG=98542
TEST=try bots
Review URL: http://codereview.chromium.org/8728010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/resources/chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8687012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/8727008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:22020
TEST=Manual.
Review URL: http://codereview.chromium.org/8702001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breakpad r883. Along with that, a partial backout of Chrome r110931 is needed
to account for an API change.
Breakpad log:
------------------------------------------------------------------------
r891 | mark@chromium.org | 2011-11-28 14:17:41 -0500 (Mon, 28 Nov 2011) | 2 lines
Speculative back-out of r883, which may have broken Windows crash reporting.
------------------------------------------------------------------------
r890 | jimblandy | 2011-11-23 18:03:30 -0500 (Wed, 23 Nov 2011) | 5 lines
Fix some comments and parameter names.
Trivial changes; committing for post-facto review.
------------------------------------------------------------------------
r889 | qsr@chromium.org | 2011-11-23 11:14:35 -0500 (Wed, 23 Nov 2011) | 4 lines
Create a static library to use Breakpad on iOS.
This obliged me to move BreakpadDefines.h to src/client/apple/Framework/BreakpadDefines.h
Review URL: http://breakpad.appspot.com/329001
------------------------------------------------------------------------
Review URL: http://codereview.chromium.org/8664008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL includes callback_forward.h and a number of files that depend on it. Other CLs have been sent to other reviewers, according to OWNERS files. This search shows the other CLs: http://goo.gl/vzQoJ
See this chromium-dev thread for the rationale behind the change: http://goo.gl/I3kob
BUG=None
TEST=Compiles
Review URL: http://codereview.chromium.org/8702019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browsertest
BUG=90443
TEST=none
Review URL: http://codereview.chromium.org/8659013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=CID 102461
TEST=no
Review URL: http://codereview.chromium.org/8681004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104582
TEST=WebKitBrowserTest.XsltBadImport
Review URL: http://codereview.chromium.org/8664002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chromeos-chrome ebuild strips Chrome tests after the build, but it
can run significantly faster if we strip them during the build. This
changelist reduces the time it takes to build Chrome by allowing
developers to remove unnecessary debug symbols.
Performance comparison on z600 LOCAL_SOURCE build:
Before: 24m31s (257m04s user, 23m19s sys)
After: 20m55s (236m12s user, 22m10s sys)
Companion CL for updating Chrome OS to use strip_tests by default is here:
https://gerrit.chromium.org/gerrit/11517
BUG=chromium-os:22844
TEST=Build with and without debug symbols. Confirm speed difference.
Review URL: http://codereview.chromium.org/8526022
TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/8659015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8631014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable in this roll is that it adds support for mandatory
OVERRIDEs on overridden functions in chromium code to the chromium
style plugin. The warning is currently behind a flag.
BUG=none
TEST=none
TBR=hans
Review URL: http://codereview.chromium.org/8718015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=LoginUserTest.UserPassed, LoginProfileTest.UserNotPassed will pass on aura
Review URL: http://codereview.chromium.org/8682016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and PeerConnection functionality. "
Original review: http://codereview.chromium.org/8060055/
TBR=darin, scherkus
Review URL: http://codereview.chromium.org/8691003
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/8706002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
functionality. "
Original review: http://codereview.chromium.org/8060055/
TBR=darin, scherkus
Review URL: http://codereview.chromium.org/8691003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90443
TEST=SiteInstanceTest.* still works
Review URL: http://codereview.chromium.org/8719002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Histogram logging for custom selection of sync datatypes is currently
done using booleans. It's better to use an enumeration, since the
datatypes are related, and it makes sense to have a unified view of all
sync datatypes.
This patch adds a new enum called UserSelectableSyncTypes, and changes
the UMA histogram logging from booleans to an enumeration.
BUG=96507
TEST=Customize sync in different ways and examine about:histograms.
Review URL: http://codereview.chromium.org/8680022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
As mentioned in http://msdn.microsoft.com/en-us/library/9a89h429.aspx /SAFESEH is only valid for x86 targets as x64 targets have exception handlers noted in their PDATA section.
BUG=104188
Review URL: http://codereview.chromium.org/8687005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/8727005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Inspired by r111713.
BUG=none
TEST=none
R=gbillock@chromium.org
Review URL: http://codereview.chromium.org/8687002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8726006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90443
TEST=content_unittests
Review URL: http://codereview.chromium.org/8718009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- separate initialization from ctor
- track restored size instead of height as width will soon be changing
This is step one in the PanelManager refactor to componentize PanelManager internals as we add more ways to layout and display panels.
BUG=None
TEST=Panel*Test.*
Review URL: http://codereview.chromium.org/8681018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
item.
Also, fix some style violations.
BUG=70425
TEST=See bug.
Review URL: http://codereview.chromium.org/8693007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionProcessManager. This was causing obscure shutdown crashes. See bug for description of crashes.
Also add a DCHECK to help enforce that all RenderProcessHost instances must have been shutdown before ProfileImplIOData->ShutdownOnUIThread() is called.
BUG=91398
TEST=Chrome does not crash when extensions with background pages make resource requests during shutdown.
Review URL: http://codereview.chromium.org/8591024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=105579
Review URL: http://codereview.chromium.org/8659008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the glibc toolchain to chromebots.
BUG=None
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/8676030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=erg@chromium.org,rsesek@chromium.org
Review URL: http://codereview.chromium.org/8682020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8679015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8678021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moved some static constants and functions into the anonymous namespaces, and marked a couple of static locals as const (because they are, and non-const static locals make me nervous).
NativeThemeWin is kind of a mess. I kept the public overload of PaintTextField next to the private overload because I think it probably should be private. The file length decreased by one line because I removed a blank line.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8679010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=101781
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/8687007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The many client sync integration tests use 10 clients and perform basic
sync operations that are synced across all clients. Unfortunately, they
have never worked as designed due to various issues with testserver,
browserlists, etc. that stem from running too many instances on a single
machine.
This patch deletes all the many client tests.
BUG=69604
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/8669003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also add a comment with the synopsis of the results.
Review URL: http://codereview.chromium.org/8588056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interested in r891):
------------------------------------------------------------------------
r891 | mark@chromium.org | 2011-11-28 14:17:41 -0500 (Mon, 28 Nov 2011) | 2 lines
Speculative back-out of r883, which may have broken Windows crash reporting.
------------------------------------------------------------------------
r890 | jimblandy | 2011-11-23 18:03:30 -0500 (Wed, 23 Nov 2011) | 5 lines
Fix some comments and parameter names.
Trivial changes; committing for post-facto review.
------------------------------------------------------------------------
r889 | qsr@chromium.org | 2011-11-23 11:14:35 -0500 (Wed, 23 Nov 2011) | 4 lines
Create a static library to use Breakpad on iOS.
This obliged me to move BreakpadDefines.h to src/client/apple/Framework/BreakpadDefines.h
Review URL: http://breakpad.appspot.com/329001
------------------------------------------------------------------------
Review URL: http://codereview.chromium.org/8729003
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/8687006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105580
TBR=ericu@chromium.org,mark@chromium.org
Review URL: http://codereview.chromium.org/8687004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In the IPC dispatcher code (both renderer and browser), handle failed IDB object lookups, which can occur when the document is being torn down or closed.
BUG=104492
TEST=
Review URL: http://codereview.chromium.org/8486023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------------------------------------------------------------------
r891 | mark@chromium.org | 2011-11-28 14:17:41 -0500 (Mon, 28 Nov 2011) | 2 lines
Speculative back-out of r883, which may have broken Windows crash reporting.
------------------------------------------------------------------------
r890 | jimblandy | 2011-11-23 18:03:30 -0500 (Wed, 23 Nov 2011) | 5 lines
Fix some comments and parameter names.
Trivial changes; committing for post-facto review.
------------------------------------------------------------------------
r889 | qsr@chromium.org | 2011-11-23 11:14:35 -0500 (Wed, 23 Nov 2011) | 4 lines
Create a static library to use Breakpad on iOS.
This obliged me to move BreakpadDefines.h to src/client/apple/Framework/BreakpadDefines.h
Review URL: http://breakpad.appspot.com/329001
------------------------------------------------------------------------
Review URL: http://codereview.chromium.org/8729003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8676022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Pulling in pymox (now with corrected headers, mirroring coming soon).
- Pulling in glibc toolchains.
- Pulling in sdk build binaries.
BUG=http://code.google.com/p/chromium/issues/detail?id=105568
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/8659005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8714002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
change their behavior based on its setting.
This will help keep buildbots green during a transition period (see bug).
BUG=101731
Review URL: http://codereview.chromium.org/8716011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86483
TBR=atwilson@chromium.org
Review URL: http://codereview.chromium.org/8726003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=edit files locally, add random references to the old callback system, and run presubmit.
Review URL: http://codereview.chromium.org/8714008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=groby@chromium.org
Review URL: http://codereview.chromium.org/8718003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8698023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111727 0039d316-1c4b-4281-b951-d872f2087c98
|