| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Sandbox is currently having a problem with this so it is disabled.
Fixed a few stray items.
Review URL: http://codereview.chromium.org/9259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=paulg
Review URL: http://codereview.chromium.org/9290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(while leaving the HTTP authentication dialog support) and add a new type of constrained window which owns all blocked popups. Rip out dead unit tests.
Review URL: http://codereview.chromium.org/8782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CredHandles instead of per-socket CredHandles.
R=darin,maruel
BUG=3560
Review URL: http://codereview.chromium.org/8950
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- the numbers were out of sync with result_codes.h
- can't use result_codes.h in base project so I extracted
the generic part of it.
Rahul: I hope I don't break installer assumptions here.
Dan: don't feel obligated to review.
Review URL: http://codereview.chromium.org/9012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was a crash in the browser in the IPC handler codepath which handles scrolling.
The crash occured because of a failure to find the backing store for the RenderWidgetHost instance. We would end up dereferencing a NULL backing store pointer and crash.
The fix for this is to check for a NULL backing store and return.
R=darin
Bug=3907
Review URL: http://codereview.chromium.org/9056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://code.google.com/p/chromium/issues/detail?id=3661
Also change LaunchApp to check PATH,
and fixed a useful gcc-4.3 warning re operator precedence.
Review URL: http://codereview.chromium.org/7968
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds a menu button on the bookmark manager. If I finish up import
I'll add a second one for importing.
. Creating new page/folder from menu items selects new item in table.
. I changed around the FolderBookmarkTableModel to copy the contents
into a vector (now extends VectorBackedTabledModel). This is
necessitated by TableView not providing a moved notification. The
problem with previous approach is that I sent out ModelChanged on
any change, which loses selection and causes things to snap around.
I considered adding a moved method to TableView, but it's too much
work at this time.
. Added persisting of divider location in bookmark manager.
. When focus is on table pressing enter on a folder descends into the
folder, and pressing backspace goes back up a folder.
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/8967
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prompting the user.
BUG=1445145
Review URL: http://codereview.chromium.org/8943
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
my earlier experiment.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fix linux build
tbr=aa
Review URL: http://codereview.chromium.org/9278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and adding sqlite to the test_shell dependencies
TBR=aa
Review URL: http://codereview.chromium.org/9275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR mmentovai@chromium.org
Review URL: http://codereview.chromium.org/9274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
needed files in third_party/WebKit/WebCore/platform/sql and
third_party/WebKit/WebCore/storage to webkit.xcodeproj. Makes
TestShell.xcodeproj depend on libsqlite.
Review URL: http://codereview.chromium.org/9055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8792
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move params to "distribution" group
- Add "import_search_engine", "show_welcome_page" params
- Now the welcome page and the bubble actually work
- Some cleanup
BUG=1394863
Review URL: http://codereview.chromium.org/9207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bindings, this doesn't actually expose the DB code to web pages.
Review URL: http://codereview.chromium.org/7982
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3961
Review URL: http://codereview.chromium.org/8983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Now running 60 tests on Linux.
Patch from Paweł Hajdan jr and from:
http://codereview.chromium.org/8677/show
Review URL: http://codereview.chromium.org/9268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also add a comment to explain the strange tls gyrations in
SlotReturnFunction.
Review URL: http://codereview.chromium.org/8972
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
WebFrame::ExecuteJavaScript() instead.
Review URL: http://codereview.chromium.org/8826
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Provide indication that inline even handlers are indeed inline.
Review URL: http://codereview.chromium.org/9037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
times later than the UNIX epoch 32 bit rollover in 2038 (such as
cookie expirations). time_t is only 32 bits in MacOS X, so
we can't just use time_posix.cc
Review URL: http://codereview.chromium.org/9249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
time, as much as 3.5ms. Altough the lock is not contended in this case, be more precise about when we need to hold the lock. Also clean up a static initialization to use LazyInstance.
Review URL: http://codereview.chromium.org/9246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should increase reliability issues seen on
the bbots.
Review URL: http://codereview.chromium.org/9261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Disabled two flaky unittests.
Review URL: http://codereview.chromium.org/9258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Rename chrome/common/SConscript to chrome/common/common.scons.
* Use the new using_*.scons files for settings.
* Split build of ipc_tests.exe into chrome/common/ipc_tests.scons.
Review URL: http://codereview.chromium.org/9253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
system level install case.
BUG=1455516.
Review URL: http://codereview.chromium.org/8974
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove unnecessary calls to dispatchWindowObjectReady. FrameLoader calls the function.
Review URL: http://codereview.chromium.org/9247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests, but failed when all tests were run because
some tests run without a message loop. The
observer_list_threadsafe allowed AddObserver to run
with null message loops. But, if you call Notify
after doing so, then the notify call would attempt
to use the registered "null" ptr to a message loop.
This crashed, of course.
Review URL: http://codereview.chromium.org/9045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/9252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Not sure how I missed this!
Review URL: http://codereview.chromium.org/9250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move chrome/browser/SConscript => chrome/browser/browser.scons.
* Use using_*.scons files instead of by-hand settings.
* Add new using_*.scons files:
breakpad/using_breakpad.scons
chrome/third_party/hunspell/using_hunspell.scons
chrome/third_party/wtl/using_wtl.scons
google_update/using_google_update.scons
third_party/npapi/using_npapi.scons
* Delete some unused CPPPATH directories.
Review URL: http://codereview.chromium.org/9243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sgk
Review URL: http://codereview.chromium.org/9043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Moved net/disk_cache/os_file to base/platform_file.
Review URL: http://codereview.chromium.org/8843
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
refer to the *.res files we need directly by name, instead of trying
to get them from the (no longer shared) the construction environment.
Review URL: http://codereview.chromium.org/9242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4453 0039d316-1c4b-4281-b951-d872f2087c98
|