summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add -fno-threadsafe-statics to the Linux build.deanm@chromium.org2009-07-141-0/+6
| | | | | | | | | | | We already depend on our static initializers being thread safe, since MSVC does not implement locking around static initialization. This avoids extra locking (__cxa_guard_acquire / __cxa_guard_release). Review URL: http://codereview.chromium.org/149607 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20616 0039d316-1c4b-4281-b951-d872f2087c98
* Remove fixed issue 16276 from known crashes list.kasperl@google.com2009-07-141-4/+1
| | | | | | | | BUG=16276 TEST=none Review URL: http://codereview.chromium.org/155492 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20615 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Focus docked DevTools window on breakpoint.pfeldman@chromium.org2009-07-149-2/+26
| | | | | | Review URL: http://codereview.chromium.org/155423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20614 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: mitigate WebKit console API changes.pfeldman@chromium.org2009-07-143-18/+2
| | | | | | Review URL: http://codereview.chromium.org/155490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20613 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 16597.hbono@chromium.org2009-07-141-1/+1
| | | | | | | | | | Our autofill code handles keyboard events by itself and it prevents dispatch a return key to WebKit when the key is comsumed by the autofill. Unfortunately, this code is enclosed with "#if defined(OS_WIN)" and "#endif". This change just activates this code on Linux. BUG=16597 "Prevents submitting a form when pressing a return key in an auto-fill popup" TEST=Type a return key on an auto-fill popup and verify this is not submitted. Review URL: http://codereview.chromium.org/149517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20612 0039d316-1c4b-4281-b951-d872f2087c98
* A blind fix for Issue 13443.hbono@chromium.org2009-07-141-0/+1
| | | | | | | | | | | | | | GTK may sends a GdkKeyEvent whose |keyval| is GDK_KP_Tab in pressing shift+tab keys on an X terminal running on Windows. This change just adds GDK_KP_Tab to HandleCustomAccelerator() to handle this event. (This is a blind fix since I don't have any environment that can reproduce this issue.) (*1) http://mail.gnome.org/archives/gtk-list/1999-September/msg00354.html BUG=13443 "Shift+Ctrl+Tab should cycle tabs backwards" TEST=none Review URL: http://codereview.chromium.org/149519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20611 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ConsoleLog test and enable it. It was previously disabled because ↵dimich@google.com2009-07-142-11/+11
| | | | | | | | | | | | WebKit change http://trac.webkit.org/changeset/45786 had split the 'type' and 'level' parameters of the ConsoleMessage into 2 separate parameters, which changed the way CSS styles are formatted for messages in Inspector front-end. Updated test expectations. BUG=16684 TEST=the test DevToolsSanityTest.TestConsoleLog is enabled by this CL Review URL: http://codereview.chromium.org/155482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20609 0039d316-1c4b-4281-b951-d872f2087c98
* more svn:ignoresgman@google.com2009-07-140-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20608 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable layout test which does not fail on build bots.dimich@google.com2009-07-141-2/+1
| | | | | | | | | BUG=16690 TEST=none TBR=levin@chromium.org Review URL: http://codereview.chromium.org/155486 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20607 0039d316-1c4b-4281-b951-d872f2087c98
* Add baseline for new test khmer-selection.html. Enable it on WIN.dimich@google.com2009-07-144-2/+54
| | | | | | | | | BUG=16690 TEST=none, the CL is a test TBR=agl@chromium.org Review URL: http://codereview.chromium.org/155485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20606 0039d316-1c4b-4281-b951-d872f2087c98
* Whenever proxy configurations contain socks and http/https/ftp proxies, ↵arindam@chromium.org2009-07-1413-55/+211
| | | | | | | | | | | | socks configuration over rid the other proxies. Fixes the issue. Attached test cases. BUG=15738 TEST=unittest (ProxyConfigTest.ParseProxyRules, ProxyServiceTest.DefaultProxyFallbackToSOCKS) Review URL: http://codereview.chromium.org/149191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20605 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: workaround a fontconfig bug.agl@chromium.org2009-07-142-12/+48
| | | | | | | | | | Fontconfig cannot filter out non-scalable fonts on Hardy. http://codereview.chromium.org/149482 BUG=16411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20604 0039d316-1c4b-4281-b951-d872f2087c98
* Add new selenium failures from webkit merge 45738:45840.nsylvain@chromium.org2009-07-141-0/+1
| | | | | | | BUG=16691 Review URL: http://codereview.chromium.org/149602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20603 0039d316-1c4b-4281-b951-d872f2087c98
* SKIP the audio-data-url.html. It's a new test, added in ↵dimich@google.com2009-07-141-2/+5
| | | | | | | | | | | | http://trac.webkit.org/changeset/45783 It uses 'audio/3gpp' mime type, does not play in Chromium yet. Also, SKIP the new khmer-selection.html, temporarily, until I can get new snapshot. BUG=13907,16678 TBR=victorw Review URL: http://codereview.chromium.org/149601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20602 0039d316-1c4b-4281-b951-d872f2087c98
* Allow TabContentsDelegates to process unhandled keyboard messages coming ↵ananta@chromium.org2009-07-147-100/+47
| | | | | | | | | | | | | | | | | | | back from the renderer. This is required for ExternalTabContainer to be able to pass unhandled keyboard accelerator messages back to the external host. This worked before as the focus manager would hand off these messages to keystroke listeners like the ExternalTabContainer. However with the ExternalTabContainer no longer using the focus manager this does not work anymore. Removed the keystroke listener code from the focus manager as the ExternalTabContainer was the only consumer and it does not use it anymore. This fixes bug http://b/issue?id=1975749 Bug=1975749 Review URL: http://codereview.chromium.org/149520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20600 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in newer version of nacl.bradnelson@chromium.org2009-07-141-1/+1
| | | | | | | | | | | | | This drops scons out of the part pulled into the chromium tree. This also switches to chrome's copy of gtest. BUG=None TEST=None TBR=gregoryd Review URL: http://codereview.chromium.org/149599 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20599 0039d316-1c4b-4281-b951-d872f2087c98
* Fix run webkit tests empty path issue with new LayoutTests directoryvictorw@chromium.org2009-07-143-10/+17
| | | | | | | | | | | Search LayoutTests first in third_party/WebKit and fallback to webkit/data if it does not exist. TEST=buildbot should work BUG=12881 Review URL: http://codereview.chromium.org/155474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20598 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20592. Causing a bunch of valgrind MAC redness.mhm@chromium.org2009-07-142-7/+17
| | | | | | | TBR: dkegel Review URL: http://codereview.chromium.org/155483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20597 0039d316-1c4b-4281-b951-d872f2087c98
* Copy codec Mac build stage (branded and unbranded)jrg@chromium.org2009-07-141-0/+16
| | | | | | Review URL: http://codereview.chromium.org/149593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20596 0039d316-1c4b-4281-b951-d872f2087c98
* Hookup Print HTML page to the DOM UI for Print Preview and Settingsmhm@chromium.org2009-07-147-8/+101
| | | | | | | | | | | | | | Depends on initial foundation: http://src.chromium.org/viewvc/chrome?view=rev&revision=19906 And html mockup: http://src.chromium.org/viewvc/chrome?view=rev&revision=19918 BUG=173, 947 TEST=The user will see the print html page as a html test webpage. Review URL: http://codereview.chromium.org/155067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20595 0039d316-1c4b-4281-b951-d872f2087c98
* Update gitignoreevan@chromium.org2009-07-141-0/+5
| | | | | | | | Ignore directories that have recently been added to the gclient checkout. Review URL: http://codereview.chromium.org/149592 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20594 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable TestConsoleLog in interactive_tests. dimich@google.com2009-07-141-1/+1
| | | | | | | | | BUG=16684 TEST=none TBR=mhm@chromium.org Review URL: http://codereview.chromium.org/155472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20593 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 15762 happens on Linux, too, so move suppression to generic file.dkegel@google.com2009-07-142-17/+7
| | | | | | | | | | Also trim unneeded end of stack. BUG=15762 TEST=watch valgrind test_shell_tests go greener on linux Review URL: http://codereview.chromium.org/155465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20592 0039d316-1c4b-4281-b951-d872f2087c98
* More bookmark bar changes.jrg@chromium.org2009-07-1421-142/+1285
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Applied memory cleanliness fix in unit test; follow-up from http://codereview.chromium.org/149308. * Move bookmark bar into it's own nib; minor code refactor to accomodate. * The toolbar STAR button somehow lost it's action; added it back in. * Implemented delete bookmark notification callback so we behave (remove button from the screen) when a bookmark is deleted. * Added context menus for the bookmark bar and bookmark buttons. * Hooked up a handful of these menu items. E.g. - open in new tab, window, incog window - delete bookmark (finally) - bookmark manager (which then hits a NOTIMPLEMENTED()) - always show bookmark bar * Truncate bookmark button text on end, not on middle. Experimental to look more like Windows. It looks cleaner but is less Mac-like. * Add "draws border when mouse goes over" for bookmark buttons. Need to do it by hand since we have a custom button drawing method. BUG=crbug.com/8381 TEST=Here's a list: - Make sure the bookmark buttons don't have a border unless the mouse is over them - Toolbar "STAR" should now add bookmarks when clicked - Test context menus on bookmark buttons, and the bar itself - Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g. Right click on bookmark --> delete menu item should delete button Review URL: http://codereview.chromium.org/155358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20591 0039d316-1c4b-4281-b951-d872f2087c98
* This provides a simpler js template engine than JsTemplate. It has beenarv@google.com2009-07-1431-236/+436
| | | | | | | | | | | | | | | | | | optimized for the way we do internationalization with JST before and is about 4 times faster (average 4.8ms vs 22.8ms) for the history page. The syntax for this is very similar to JsTemplates. It uses the attributes i18n-values and i18n-content which worls like jsvalues and jscontent except that it does not allow arbitrary expressions. BUG=None TEST=All UI pages should work as before Review URL: http://codereview.chromium.org/149420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS from 45738 to 45840.dimich@google.com2009-07-1418-13/+129
| | | | | | Review URL: http://codereview.chromium.org/149575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20589 0039d316-1c4b-4281-b951-d872f2087c98
* Mac test regressions 20529:20532mhm@chromium.org2009-07-141-1/+10
| | | | | | | | | BUG=16675 TEST=None Review URL: http://codereview.chromium.org/149586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20588 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unittest; we changed the name of the PDF file that the test was using. ↵avi@chromium.org2009-07-142-5/+6
| | | | | | | | | | | | | (Plus a quick part of the original patch missed on checkin.) BUG=none TEST=none TBR Review URL: http://codereview.chromium.org/149587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20586 0039d316-1c4b-4281-b951-d872f2087c98
* Add autofill dropdown support for password forms.tim@chromium.org2009-07-148-218/+93
| | | | | | | | BUG=5406 Review URL: http://codereview.chromium.org/155399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20585 0039d316-1c4b-4281-b951-d872f2087c98
* Add "learn more" link to privacy settings.mattm@chromium.org2009-07-141-1/+23
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/149581 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20584 0039d316-1c4b-4281-b951-d872f2087c98
* Adding Ogg/Theora/Vorbis-only FFmpeg binaries to Chromium nightly builds.scherkus@chromium.org2009-07-143-4/+14
| | | | | | | | | BUG=16657 TEST=nightly builds of Chromium should include avutil-50.dll, avformat-52.dll, avcodec-52.dll and pthreadGC2.dll Review URL: http://codereview.chromium.org/149571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20583 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more docs.gman@google.com2009-07-143-11/+27
| | | | | | | | | | | | Changed to put them in a folder called "reference" since that is what Josie needs to publish without renaming. Also fixed a few path issues. Review URL: http://codereview.chromium.org/155467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20582 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.sky@chromium.org2009-07-1313-23/+27
| | | | | | | | | BUG=16634 TEST=none Review URL: http://codereview.chromium.org/155441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20581 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromium build.estade@chromium.org2009-07-131-2/+2
| | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/155466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20580 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the wrapper uses our included ffmpeg libs.mmoss@chromium.org2009-07-131-0/+3
| | | | | | | Review URL: http://codereview.chromium.org/155455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20579 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 194.0 to 195.0jon@chromium.org2009-07-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20578 0039d316-1c4b-4281-b951-d872f2087c98
* Bring RPM packaging scripts into the build.mmoss@chromium.org2009-07-131-0/+7
| | | | | | | Review URL: http://codereview.chromium.org/155460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20576 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable previously flaky download ui tests. I can't reproduce the ↵estade@chromium.org2009-07-131-21/+5
| | | | | | | | | | failures. Will watch tree after commit. TBR=evan Review URL: http://codereview.chromium.org/155449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20575 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: For the render view, count keyboard grab shadows the same as focus events.estade@chromium.org2009-07-131-0/+18
| | | | | | | | | | | | | This fixes an age old bug that dropdown menus still looked depressed after you select something from them and they collapse. It also fixes the more recent bug that you could have focus in the render view without any indication drawn by the renderer. I suspect there was a change to webkit that exacerbated this bug, because it seems like something we would have noticed earlier. Verified in a debugger that showing/hiding a dropdown menu doesn't emit focus signals, but does emit grab notify signals. Also verified that the bug is no longer reproducible in a simple page with <select> and <input> elements. BUG=16313 TEST=see desc. Review URL: http://codereview.chromium.org/149506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20574 0039d316-1c4b-4281-b951-d872f2087c98
* Support individual Keychain item deletion in PasswordStoreMac.stuartmorgan@google.com2009-07-138-58/+180
| | | | | | | | | | | | Rename AddLogin to AddPassword for consistency with other method names. Remove a confusing out param from the form merge check function. BUG=16486 TEST=Once the UI exists, deleting individual passwords should work on the Mac. Review URL: http://codereview.chromium.org/155451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20573 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Force a size on download items and elide the dangerous download filename.estade@chromium.org2009-07-131-3/+8
| | | | | | | | | | | | | This is a temporary hack that might not work in all locales and definitely won't work if we ever let users change font sizes. GtkLabels are just plain broken. Pango is also broken because you can get height-for-width for a layout but not width-for-height. Thus we should switch to using skia to draw download items fonts, but this solution will work for now. BUG=16389 TEST=download the Dansk version of open office for windows Review URL: http://codereview.chromium.org/155395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20572 0039d316-1c4b-4281-b951-d872f2087c98
* Don't clobber the previous session when showing about-linux splash page.estade@chromium.org2009-07-132-13/+21
| | | | | | | | | BUG=16599 TEST=previous session should restore + linux splash page Review URL: http://codereview.chromium.org/149555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20571 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome version legible in about:chrome dialog for dark themes.estade@chromium.org2009-07-131-15/+43
| | | | | | | | | | | Add Terms of Service link for google chrome (not chromium). BUG=16544 TEST=use dark theme, look at version in about:chrome Review URL: http://codereview.chromium.org/155454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20570 0039d316-1c4b-4281-b951-d872f2087c98
* Set infobar height on a different widget.estade@chromium.org2009-07-131-1/+2
| | | | | | | | | | | Honestly I'm not completely sure why this is happening, all I know is the internal widget isn't getting sized as large as we want it, so I changed it to take a more direct action to set the size. BUG=16412 TEST=go to c, see infobar, switch tabs and go back and re-look at infobar. Should look same, with no 4 pixel strip of plainness. Review URL: http://codereview.chromium.org/149579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20569 0039d316-1c4b-4281-b951-d872f2087c98
* Restore RTL icons to CustomDrawButtonBase.tc@google.com2009-07-135-13/+38
| | | | | | | | | | Since moving from ResourceBundle to ThemeProvider, we needed to plumb through GetRTLEnabledPixbufNamed in ThemeProvider. Review URL: http://codereview.chromium.org/149483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20568 0039d316-1c4b-4281-b951-d872f2087c98
* posix: show "plugin crashed" info bar when appropriateevan@chromium.org2009-07-132-3/+6
| | | | | | | | Note I fixed a bug in AlertInfoBar while I was at it. Review URL: http://codereview.chromium.org/155462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20567 0039d316-1c4b-4281-b951-d872f2087c98
* Fix KillProcess so it doesn't report everything as a failure.stuartmorgan@chromium.org2009-07-131-4/+11
| | | | | | | | BUG=none TEST=UI tests on Mac should no longer all log that kills are failing. Review URL: http://codereview.chromium.org/155297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20566 0039d316-1c4b-4281-b951-d872f2087c98
* Try the original CL "Always persist bookmark IDs" again with the fix tomunjal@chromium.org2009-07-1320-195/+195
| | | | | | | | | | | | | | Valgrind issue. The fix is in bookmark_storage.h - initialized the newly added member ids_reassigned_ of LoadDetails class. See http://codereview.chromium.org/149310 for the original CL. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/155456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20565 0039d316-1c4b-4281-b951-d872f2087c98
* Add cookie behavior combobox.mattm@chromium.org2009-07-131-2/+50
| | | | | | | | | BUG=11507 TEST=Disable cookie saving and try to login to iGoogle. Reenable and try again. Review URL: http://codereview.chromium.org/149574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20564 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land the patch to elide the status bubble to 1/3 the width of thetc@google.com2009-07-131-3/+10
| | | | | | | | | window. Review URL: http://codereview.chromium.org/155432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20563 0039d316-1c4b-4281-b951-d872f2087c98