| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename SConscript files to {module}.scons or {moduel}_lib.scons,
depending on the primary target involved.
* Separate targets into individual *.scons files, with one
construction environment (named "env") per *.scons file.
* Add using_{module}.scons files (like .vsprops) that will be used
by other modules to add CPPDEFINES, CPPPATH, LIBS and LIBPATH values.
* Update other modules' *.scons files to use the new using_{module}.scons
files (using a temporary one-liner idiom until we have the
ApplySConscript() method from the Hammer modules).
* Use the idiom of removing to-be-ported files from the master list,
so they can be simply deleted from the to-be-ported list as they
get ported in the future, instead of having to shuffle entries
between lists.
* Use $OBJ_ROOT instead of hard-coded '#/$BUILD_TYPE/' for the $*_DIR
variables.
* Add a addRepository() call mapping build/ to $TARGET_ROOT/googleurl,
so its $OBJ_ROOT value can look like the others'.
* Formatting changes, primarily modifying indentation to conform to
style guidelines.
* Fix copyright headers in some third_party/* modules
previously overlooked.
* Add rudimentary __doc__ strings, setting up for a future
ability to generate meaningful documentation.
Review URL: http://codereview.chromium.org/7807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7825
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7817
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mbelshe
Review URL: http://codereview.chromium.org/8021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in test shell is not compatible with the webkit event generation mechanism.
This is to help in pushing this layout test upstream.
R=pam
Review URL: http://codereview.chromium.org/8012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The visible flag was getting set twice from two different sources, one of which
was wrong.
Review URL: http://codereview.chromium.org/7820
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
After the change to PlatformScrollbar.h, this just works (tm).
Review URL: http://codereview.chromium.org/7821
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ERR_SSL_RENEGOTIATION_REQUESTED error code for when we
received a renegotiation request from a server.
Support the completion of an SSL handshake after we write
something. (This happens in a session resumption
handshake.)
Use the SSL configuration settings to turn on or turn off
various versions of the SSL protocol and server certificate
revocation checking.
Report all the errors of a certificate and whether revocation
checking was done in in the server_cert_status_ bitmask.
Create a new scoped_cert_chain_context.h header for the
ScopedCertChainContext class that used to be in
x509_certificate_win.cc, and use it to fix a leak of
chain_context on error paths in
SSLClientSocketWin::VerifyServerCert.
R=rvargas
BUG=3002,3003,3004
Review URL: http://codereview.chromium.org/7505
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7819
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the scrollbar tick rects to IntRect.
Review URL: http://codereview.chromium.org/7802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
patch from WildFox (TorchMobile, Inc) in
http://codereview.chromium.org/7295
Review URL: http://codereview.chromium.org/8013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Issue=3039
Review URL: http://codereview.chromium.org/7528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is too large for changes in warm timings to show up well.
BUG=3597
TEST=warm-test results show up better on startup-test plot
Review URL: http://codereview.chromium.org/7531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
msimg32.dll. The wrapper does a few additional santity checks, which I presume GdiAlphaBlend will have to handle anyway. This means we don't depend on msimg32.dll anymore.
Review URL: http://codereview.chromium.org/7813
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
all view specific. Rename find in page controller to be "FindBarWin", and
find in page view to be "findBarView" (since this is not Windows specific, but
"Views" specific).
I did lots of simplification and moving around of the find in page API. I
coalesced several of the show functions into one master function on the view.
I removed some other sizing and window updating code from WebContents and moved
it to the view.
Review URL: http://codereview.chromium.org/7667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mbelshe
Review URL: http://codereview.chromium.org/8007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
includes a fix for bug 1439135.
Review URL: http://codereview.chromium.org/8006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains mbelshe's patch to JavaScriptCore.vcproj to pick up the various missing .cpp files there. It also includes his fix to copy_files.bat to make Profiler.h appear as though it lives within a JavaScriptCore directory. See http://codereview.chromium.org/7804 for reference.
In addition, this CL adds a number of KJS-specific files from WebCore to the KJSBindings project. This included files under the bridge, bridge/c, and page directories.
I resurrected a portion of the old KJSBridge.cpp to fix the numerous NPN_ link errors. There is probably a better way to deal with this issue, but doing what we used to do seems like a reasonable stop-gap.
Finally, I loaded up TemporaryLinkStubs.cpp with the remaining link errors. These all had to do with SQL related features that we had mostly disabled. Unfortunatley, DerivedSources.make doesn't honor those ENABLE flags, and since it now spits out a large single DerivedSources.cpp file, it was easier to just define the undefined symbols rather than trying to hack DerivedSources.make to honor the ENABLE flags.
TBR=mbelshe
Review URL: http://codereview.chromium.org/7811
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
HASH/$BUILD_TYPE -> $OBJ_ROOT
Review URL: http://codereview.chromium.org/7801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the console.
Review URL: http://codereview.chromium.org/7533
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a bunch of symbols for POSIX systems dealing with filesystem calls and sound.
Review URL: http://codereview.chromium.org/7526
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=erg
Review URL: http://codereview.chromium.org/7535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7681
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
defined in the WebCore namespace (it isn't in any of the other ports).
Review URL: http://codereview.chromium.org/7680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and identify revisions where the tests started failing.
Review URL: http://codereview.chromium.org/7527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
JavaScriptCore/wtf.
R=dglazkov
Review URL: http://codereview.chromium.org/7677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an issue with a windowed flash instance not rendering content at times.The bug occurs as a result of the following:-1. The flash plugin executes a script via GetURLNotify. This script calls window.open with the target as self, which shows up as a new tab in the browser. This causes a new RenderView object to be instantiated (See RenderView::CreateWebView).2. RenderView::CreateWebView sends over the ViewHostMsg_CreateWindow IPC message to the browser. The handler in the browser sends over an ack for this message with the window handle. This is used as the parent window for any plugins instantiated in the page.3. At times, the newly created view starts receiving data which is processed before the ViewMsg_CreatingNew_ACK message is received and processed by the view. This causes the plugin to be instantiated without a parent window thus ending up as a top level window.The fix is to queue up resource messages and process them after we receive the ack for the ViewHostMsg_CreateWindow IPC.
Tests :- Covered by UI tests.
R=jam
Review URL: http://codereview.chromium.org/7514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the style.
Review URL: http://codereview.chromium.org/7624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
correctly.
TBR=sky
Review URL: http://codereview.chromium.org/7333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Implement BindToWindowObject for JSC.
Review URL: http://codereview.chromium.org/7673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rollback was not needed to correct distributed test regression.
This reverts changes in 3608, which were done to try to repair the
regression.
r=huanr
Review URL: http://codereview.chromium.org/7522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Construct the $THIRD_PARTY_DIR and $WEBKIT_DIR variables consistently
with other $*_DIR variables.
Don't execute test scripts from the VariantDir by default; everything
isn't installed in the proper place yet.
Use the 'build_component' variable from the submodule SConstruct
files to restrict how much we build by default (e.g. don't try to
build all of webkit if you're only working in base or net).
Review URL: http://codereview.chromium.org/7524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
too timing-sensitive.
Review URL: http://codereview.chromium.org/7671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(V8Bindings, libport and WebCore being the most significant example.) Since the
GNU linker does only a single pass over the archives we need some extra
trickery to deal with these unavoidable cycles. That trickey is --start-group
and --end-group (aka -( and -) ). That causes ld to loop over the group until
no more undefined symbols are found. In an ideal world we would only make
groups from those libraries which we knew to be in cycles. However, that's
tough with SCons, so we bodge it by making all the archives a group by
redefining the linking command here.
Review URL: http://codereview.chromium.org/7523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was just an artifact of how I changed my mind a number of times during the AutocompleteEdit model/view split and failed to ultimately do the right thing here.
BUG=2901
Review URL: http://codereview.chromium.org/7672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think I've finally fixed this. Knock on wood. Turns out that these two
additional places do non-client rendering:
- DefWindowProc for WM_NCLBUTTONDOWN
- the function EnableMenuItem (called from CustomFrameWindow::OnInitMenu)
For the first case, we also need to unlock updating when we begin to receive
mouse move events during modal size/move loops, otherwise the feedback won't be
visually continuous.
http://crbug.com/3264
Review URL: http://codereview.chromium.org/7662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebFrameImpl::CreateChildFrame is based on third_party/WebKit/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp, which is based on WebKit/mac/WebView/WebFrame.mm:_loadURL. WebKit change 31264
(http://trac.webkit.org/changeset/31264/trunk/WebKit/mac/WebView/WebFrame.mm), fixed this bug on Mac, but was never ported to Windows, so webframe_impl.cc didn't get that fix. (FYI, WebFrame.mm:_loadURL has since moved to WebCore/loader/FrameLoader.cpp, with the appropriate changes.)
Note that these layout tests also fail for WebKit on Windows (disabled in LayoutTests/platform/win/Skipped). This same change still needs to be made upstream to WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp.
Review URL: http://codereview.chromium.org/7503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3617 0039d316-1c4b-4281-b951-d872f2087c98
|