| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
through several iterations.
R=abarth
BUG=7338,8473
Review URL: http://codereview.chromium.org/42148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/42146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If chrome tab is hosted in an external tab and 'inspect
element' is invoked via GUI (as opposed to sending an
automation request for AutomationMsg_InspectElement),
we get a crash in AutomationProvider::ReceivedInspectElementResponse
BUG=1694650
Review URL: http://codereview.chromium.org/43102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
get their own linebox. The change that caused this was http://trac.webkit.org/changeset/41569/trunk and you can see that they re-baselined all tests that had trailing whitespaces there. For this test, regular webkit does not select a trailing whitespace (they only select "foo" on double click, we select "foo "), so this wasn't rebased by them.
Review URL: http://codereview.chromium.org/46005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4391
TEST=covered by layout tests
Review URL: http://codereview.chromium.org/42097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
mac build will actually stay green.
Review URL: http://codereview.chromium.org/42151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ChildThread so that the same code is used by the plugin process (and soon, workers).
Review URL: http://codereview.chromium.org/42108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
merge, but not image files.
Review URL: http://codereview.chromium.org/42149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image.
Review URL: http://codereview.chromium.org/43144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is admitedly a little hacky, but I don't care as much since it's single-process mode and I don't think there's another way to solve it. The problem is that SiteInstance::GetProcess should always reuse an existing renderer "process", but GetExistingProcessHost() won't return the in-process renderer until RenderProcessHost::Init is called, which is after the second GetProcess call. So since we generate the in-process 'pid', I do it in the constructor instead of in Init.
Review URL: http://codereview.chromium.org/42144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
worker process.
Review URL: http://codereview.chromium.org/44003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Changed InProcessBrowserTest to restore the original CommandLine after it
tears down.
Review URL: http://codereview.chromium.org/42084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whether we should turn on the reporting of upload progress updates.
This CL adds plumbing in the SimpleResourceLoader for reporting upload progress updates, as is already done in ResourceDispatcherHost.
This makes 3 layout tests (XMLHttpRequest related) pass.
BUG=None
TEST=Run the layout tests.
Review URL: http://codereview.chromium.org/28341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Mac failures seem to be flaky, and not caused by 11548
tbr=davemoore
Review URL: http://codereview.chromium.org/42141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that isn't tied to the bookmark bar. Removes some dead code from the
bookmark bar, and fixes a UMR in chrome_menu that I found when running
under purify. There isn't any behavior change in this patch.
BUG=none
TEST=this is a large refactoring of how bookmark menus are
shown. Please thoroughly test menus on the bookmark bar to make sure I
didn't screw anything up.
Review URL: http://codereview.chromium.org/42128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/42125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
There are situations in which the machine can return a time slightly earlier (up to a few ms) than it previously returned. Therefore, I paused for 50ms in between timer checks in order to compensate for this. This should hopefully fix the test.
Review URL: http://codereview.chromium.org/42001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
means of various crazy hacks.
Review URL: http://codereview.chromium.org/42106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(in favor of letting the gyp generator pass us $DESTINATION_ROOT,
which gives us the right absolute path name to the output directory).
Review URL: http://codereview.chromium.org/43108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=davemoore
Review URL: http://codereview.chromium.org/42134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/42135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add some more suppressions to the suppressions file. I don't have any errors when running Chromium on my workstation.
Review URL: http://codereview.chromium.org/43129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DISALLOW_COPY_AND_ASSIGN
TBR=finnur
Review URL: http://codereview.chromium.org/43140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we can share code across platforms.
See http://code.google.com/p/chromium/wiki/FindBarRefactoring for
more information about the design.
Review URL: http://codereview.chromium.org/42057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rewrite strip controller to create and manage TabControllers instead of NSButtons.
Review URL: http://codereview.chromium.org/43137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/svg/dom/animated-tearoff-equality.xhtml
LayoutTests/svg/dom/animated-tearoff-lifespan.xhtml
in Release only.
The cause was the use of an invalid hash function.
Review URL: http://codereview.chromium.org/42094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
trying to autoupdate, it looks like this was not the
cause of the failure.
Review URL: http://codereview.chromium.org/42126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
expectated behavior on both Windows and Linux.
Review URL: http://codereview.chromium.org/42120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Net agent.
Dom agent provides API for querying for DOM nodes and receiving notifications
on
Dom updates. It has some logic in and this logic is covered with the unit
tests.
Net agent pushes an initial set of request/response-related events to the
client. It is to be filled with more data later on. It currently caches loaders
for all the requests which is Ok for the case when this agent is turned ON (at
least for now).
Note that this code is not yet wired to the dev tools agent (this is by design).
The plan is to start enrolling the dev tools agent glue that connects these
sub-agents with the IPC transport once this CL is in.
Original CL: http://codereview.chromium.org/41008/show
Review URL: http://codereview.chromium.org/43128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We previously left the widget floating, the reference would be sunk by the first container it was added to, if removed from this container it would be destroyed. This was happening in WebContentsViewGtk, and then we were double-destroying the widget in RenderWidgetHostViewGtk::Destroy().
BUG=8707
Review URL: http://codereview.chromium.org/42119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows).
BUG=8236
Review URL: http://codereview.chromium.org/42074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Grab enter key events before they get to GtkTextView.
We need to do this, otherwise enter when text is selected
will replace the text, and we won't get a chance to catch
that happening. This might have problems with IME, but it
should be straightforward to fix anything IME related.
- Don't deselect when we lose focus. This sometimes looks a
bit strange, but it's the GTK thing to do. This also unbreaks
copy and paste via the context menu, since popping up the
context menu makes the GtkTextView lose focus.
- Rewrite the inefficent newline eater. This should now only be
needed for newlines that didn't come from the keyboard (like when
you paste text). Use the builtin iter support for finding line
boundaries, hopefully more efficient than checking the characters
one by one. Still might have some bad behavior when pasting a ton
of newline characters, but that can be improved later.
This fixes inline autocomplete, you can now hit the enter key on an
inline autocompleted suggestion, and you will get the intented navigation,
instead of the navigation with the selected completion removed.
This also adds support for alt-enter in Omnibox to navigate in a new tab.
BUG=8236
Review URL: http://codereview.chromium.org/43072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11527 0039d316-1c4b-4281-b951-d872f2087c98
|