summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add FilePathTest.StripTrailingSeparators to base_unittests to testmark@chromium.org2009-10-131-1/+64
| | | | | | | | | | FilePath::StripTrailingSeparators. BUG=24692 TEST=this Review URL: http://codereview.chromium.org/272039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28832 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the number of expectations we'll hold on to to 750. There is at leastojan@chromium.org2009-10-131-1/+1
| | | | | | | | | | one test that appears to be flaky that inconsistently: LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html As we have fewer and fewer failing tests, I think we can keep increasing this number. Review URL: http://codereview.chromium.org/272035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28831 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the layout test formatter to not require an extra scrape of the ↵gwilson@google.com2009-10-131-2/+2
| | | | | | | | | | | | builders if a local zip file is specified. R=ojan BUG=none TEST=run test_output_formatter.bat/.sh with a local zip file, it should not scrape for zip output directory. Review URL: http://codereview.chromium.org/267079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28830 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors freaky TaskManager::Resource self-updatingjamesr@chromium.org2009-10-135-3/+46
| | | | | | | | | | | Currently, TaskManagerTabContentsResource supports getting WebCore cache information. This information has to be fetched from the renderer process via an IPC round-trip. Currently, the Resource updates itself whenever a query is made from the View via the TaskManagerModel::GetResourceWebCore*() methods, which seems very wrong from a design POV and is tricky to test. This patch cleans up the picture a bit by routing the TaskManagerModel::Refresh() call to interested TaskManager::Resource objects. TEST=try bots, open task manager + right click to enable cache columns, browse around, observe updated values BUG=none Review URL: http://codereview.chromium.org/267062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28829 0039d316-1c4b-4281-b951-d872f2087c98
* Re-adding vim/emacs stuff to Chrome Frame's rename_me_to_supplement.gypi. ↵robertshield@chromium.org2009-10-131-0/+5
| | | | | | | | This was apparently needed. Review URL: http://codereview.chromium.org/262030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28828 0039d316-1c4b-4281-b951-d872f2087c98
* A few other miscellaneous bits of cleanup to BrowserThemeProvider:pkasting@chromium.org2009-10-132-23/+21
| | | | | | | | | | | | | * Put "&" ref-qualifier on type, not variable (style guide) * Use "foo.count(bar)" instead of "foo.find(bar) != foo.end()" where possible (shorter) * Better iterator name in one spot (missed it last time) * Some tiny indentation/whitespace/line-wrapping changes BUG=none TEST=none Review URL: http://codereview.chromium.org/275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28827 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix bookmark bar buttons not being layed out correctly on startup.erg@chromium.org2009-10-133-16/+41
| | | | | | | | BUG=17625 Review URL: http://codereview.chromium.org/271058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28826 0039d316-1c4b-4281-b951-d872f2087c98
* Disable broken tests until I can get a fix in.dmaclach@chromium.org2009-10-131-2/+2
| | | | | | | | TEST=None BUG=None Review URL: http://codereview.chromium.org/275003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28825 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to note a test crash.darin@chromium.org2009-10-131-1/+2
| | | | | | | | | | | | | This test is now routinely crashing on the Mac debug build. LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html TBR=finnur BUG=24720 TEST=none Review URL: http://codereview.chromium.org/267078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28824 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes up drawing so that we don't have any transparent holes, and adds admaclach@chromium.org2009-10-134-40/+60
| | | | | | | | | | | | bit more of a guard around some private API calling. Also moves the widgets up one pixel, and fixes drawing the widgets in windows without tabstrips. BUG=24539, 24693 TEST=Assign a window the Mark Ecko theme (https://tools.google.com/chrome/intl/en/themes/theme_at_mecko.html) and look for holes in the top of the window graphics. Click on this link (http://www.htmlcodetutorial.com/linking/popup_test_a.html) and make sure the popup windows widgets are in the right place. Review URL: http://codereview.chromium.org/273031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28823 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebAccessibility object, a wrapper for WebCore::AccessibilityObject.dglazkov@chromium.org2009-10-1318-21/+237
| | | | | | | | | | | | | | | | | | | R=darin BUG=24596 TEST=none Implement getter/setter-based bound properties for CppBoundClass. This is necessary for AccessibilityController, which has non-trivial property accessors. R=darin BUG=10322 TEST=CppBoundClassTest.SetAndGetPropertiesWithCallbacks Review URL: http://codereview.chromium.org/272029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28821 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix buttons not tinting to theme.avi@chromium.org2009-10-131-5/+27
| | | | | | | | | BUG=http://crbug.com/24429 TEST=buttons should tint Review URL: http://codereview.chromium.org/273037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28819 0039d316-1c4b-4281-b951-d872f2087c98
* This CL is for the needs of ChromeFrame.stoyan@google.com2009-10-139-1/+43
| | | | | | | | | | | | TabContentsDelegate implementation may override navigations caused by JsvaScript history object. Yet not perfect since webkit view of navigation stack differs from the view of external-non-Chrome-host-browser. We have to provide the full stack from host-browser (+visited links alongside) in the same way as Chrome-browser provides it to renderer. BUG=24004 Review URL: http://codereview.chromium.org/261046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28818 0039d316-1c4b-4281-b951-d872f2087c98
* MOve user agent regisration to HKLMstoyan@google.com2009-10-131-1/+1
| | | | | | | BUG=23549 Review URL: http://codereview.chromium.org/268039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28817 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make the nsimage_cache behave more like +[NSImage imageNamed:]avi@chromium.org2009-10-133-2/+17
| | | | | | | | | BUG=none TEST=no visible change Review URL: http://codereview.chromium.org/272032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28815 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the about window to create a new window to handle loading web pages if ↵pinkerton@chromium.org2009-10-134-7/+19
| | | | | | | | | | there is none currently available. BUG=24234 TEST=clicking links in about window with and without browsers open. Review URL: http://codereview.chromium.org/272013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28814 0039d316-1c4b-4281-b951-d872f2087c98
* Use the real bundle identifier instead of the framework's identifier for ↵pinkerton@chromium.org2009-10-131-4/+5
| | | | | | | | | | detecting default browser identifier. BUG=24401 TEST=set default to chromium from safari, verify chromium thinks it's default. set default to safari in safari, verify chromium thinks it's not default. Then set it to default and verify Safari thinks Chromium is default. Review URL: http://codereview.chromium.org/261039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28813 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: prepare for a change in WebKit introducing profile types.mnaganov@chromium.org2009-10-131-0/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/270084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28812 0039d316-1c4b-4281-b951-d872f2087c98
* When a nested run loop is driven directly by Run/DoRun as opposed to being amark@chromium.org2009-10-132-18/+30
| | | | | | | | | | | | | nested native loop run by code outside of our control, and the nested run loop stops, don't schedule nesting-deferred work until returning fron Run/DoRun. BUG=24337, 24383 TEST=With r28745 backed out or an equivalent change recommitted: 1. Test case from bug 24337: the window should close 2. Test case from bug 24383: no Chromium processes should use 100% CPU Review URL: http://codereview.chromium.org/264042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28811 0039d316-1c4b-4281-b951-d872f2087c98
* Turn NULL used as int to 0.phajdan.jr@chromium.org2009-10-1319-39/+47
| | | | | | | | | | | | | (Excluding chrome/browser/...) Landing patch for Jacob Mandelson. Original review: http://codereview.chromium.org/195067 BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/267076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28810 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add breakpad info for crashes in the target/action dispatcher.shess@chromium.org2009-10-132-0/+48
| | | | | | | | | | | | | | | -[NSApplication sendAction:to:from:] is a central dispatcher for target-action messages sent by controls. Backtraces from here often contain only Cocoa messages, making it hard to tell where things are at when a freed target gets messaged. Add additional info like the action being requested and the tag of the sender. http://crbug.com/24460 TEST=Browser continues to work. Review URL: http://codereview.chromium.org/269039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28809 0039d316-1c4b-4281-b951-d872f2087c98
* LTTF: rebaseline fast/css/pseudo-cache-stale .hamaji@chromium.org2009-10-133-2/+1
| | | | | | | | | BUG=17398 TEST=none Review URL: http://codereview.chromium.org/267073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28808 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.5 to 222.6laforge@chromium.org2009-10-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28807 0039d316-1c4b-4281-b951-d872f2087c98
* Fix parsing of the first race report for ThreadSanitizertimurrrr@chromium.org2009-10-131-6/+7
| | | | | | | | | We've introduced a mistake recently which results in hiding the first race report. The reason was the "main thread" line which doesn't contain "{{{" and doesn't have context printed. Please note that after submitting of this CL ThreadSanitizer bots can become red for a while. Review URL: http://codereview.chromium.org/272026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28806 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressed test-only race on bool, improved existing suppressions.timurrrr@chromium.org2009-10-131-3/+19
| | | | | | | | Fixed indentations and added comments for some old suppressions. TBR=dank,stuartmorgan Review URL: http://codereview.chromium.org/269053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28805 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add methods to our InspectorController stub to prepare for a ↵mnaganov@chromium.org2009-10-131-0/+16
| | | | | | | | | | | change in WebKit. BUG=none TEST=none Review URL: http://codereview.chromium.org/273034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28804 0039d316-1c4b-4281-b951-d872f2087c98
* Do not run FlipNetworkTransactionTest.Connect under ThreadSanitizer on Mac OStimurrrr@chromium.org2009-10-131-0/+1
| | | | | | | | | | | | | | The pre-3.5 version of ThreadSanitizer reports "aspacem" warnings on this test, the latest Tsan hangs silently. This test case was enabled in http://src.chromium.org/viewvc/chrome?view=rev&revision=28793, so we haven't seen the complaints before. This patch was prepared by Alexander Potapenko (cc'ed) TBR=dank Review URL: http://codereview.chromium.org/270083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28803 0039d316-1c4b-4281-b951-d872f2087c98
* 64 bit linux yuvfbarchard@chromium.org2009-10-132-40/+120
| | | | | | | | BUG=23263 TEST=media_unittest should pass and run much faster: faster than 32 bit even. Review URL: http://codereview.chromium.org/268029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28802 0039d316-1c4b-4281-b951-d872f2087c98
* This is a second attempt at submitting this changelist. The original one wasmarkus@chromium.org2009-10-138-17/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/196053 It turns out, since none of our tests abstract time correctly, unittests are very sensitive to subtle changes in timing. This made some of the valgrind tests on Linux fail, and unfortunately, neither my desktop nor the trybots could reproduce the problem reliably. As far as I can tell, all the (design) bugs are in the unittests. The browser is actually fine. Tweaked the code a little more. Will resubmit and carefully monitor the buildbots. Original change description follows: When converting between units of time or data types of different precision, we have to be careful to consistently round in the same direction. Timeout checks usually check if Now() is less or equal to a deadline in order to determine if a timeout has occurred. This correctly handles the case where actual sleep times are equal or longer than requested sleep times. But if we round down when setting the sleep delay, this can result in unnecessary and expensive looping. Make sure, we always round up when converting to a format with less precision. BUG=none TEST=none Review URL: http://codereview.chromium.org/257044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28801 0039d316-1c4b-4281-b951-d872f2087c98
* Importing dromaeo performance tests to src/chrome/test/data.asargent@chromium.org2009-10-13104-0/+109376
| | | | | | | | | | | | | Committing this for Anton Muhin (antonm@chromium.org). BUG=none TEST=none Review URL: http://codereview.chromium.org/269054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28800 0039d316-1c4b-4281-b951-d872f2087c98
* Mix mismatched new[] with delete. (should be delete[]).mbelshe@google.com2009-10-132-8/+8
| | | | | | | | | | BUG=none TEST=none TBR=jar@chromium.org Review URL: http://codereview.chromium.org/267071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28799 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 28607.darin@chromium.org2009-10-135-113/+98
| | | | | | Review URL: http://codereview.chromium.org/275001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28798 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28796 - This is a simple integration test that loads a simple nexe ↵gregoryd@google.com2009-10-134-73/+1
| | | | | | | | | | | | and verifies that Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree. Review URL: http://codereview.chromium.org/272005 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/270080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28797 0039d316-1c4b-4281-b951-d872f2087c98
* This is a simple integration test that loads a simple nexe and verifies that ↵gregoryd@google.com2009-10-136-1/+210
| | | | | | | | Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree. Review URL: http://codereview.chromium.org/272005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28796 0039d316-1c4b-4281-b951-d872f2087c98
* Adding native-client-reviews to watch nacl changesgregoryd@google.com2009-10-131-134/+139
| | | | | | Review URL: http://codereview.chromium.org/264039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28795 0039d316-1c4b-4281-b951-d872f2087c98
* Make SSLClientSocketNSS full-duplexukai@chromium.org2009-10-132-99/+238
| | | | | | | | | BUG=13289,12497 TEST=visit https site and works as before. Review URL: http://codereview.chromium.org/255074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28794 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line switch to enable flip sockets.mbelshe@google.com2009-10-136-1/+42
| | | | | | | | | | | | With this change, flip code is now compiled and the limited unit tests actually run. BUG=none TEST=none Review URL: http://codereview.chromium.org/259064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28793 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for https://bugs.webkit.org/show_bug.cgi?id=30262darin@chromium.org2009-10-131-0/+10
| | | | | | | | | | R=eseidel BUG=none TEST=none Review URL: http://codereview.chromium.org/261058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28792 0039d316-1c4b-4281-b951-d872f2087c98
* More build a-fixin for GCF related to base/test move.slightlyoff@chromium.org2009-10-131-2/+2
| | | | | | | | | | BUG=None TEST=None TBR=joshia@chromium.org,ananta@chromium.org Review URL: http://codereview.chromium.org/270079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28791 0039d316-1c4b-4281-b951-d872f2087c98
* Add scripts to start/stop PyWebSocket server that is used for testing Web ↵yuzo@chromium.org2009-10-135-3/+172
| | | | | | | | | | | Socket. BUG=none TEST=none Review URL: http://codereview.chromium.org/267002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flashing issue when hitting escape while find bar is active.mhm@chromium.org2009-10-132-0/+15
| | | | | | | | | | | When the View try's to focus to the last focused component, it can't, because ToolBarView is not Focusable, hence overriding IsFocusable will fix the flashing, but will create a focusable ring around the whole toolbar. BUG=15228 TEST=ALT+SHIFT+T press left arrow until page menu, and select find in page. Press ESC numerous times, no more flashing issues for the find bar. Review URL: http://codereview.chromium.org/265056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28789 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up bookmark all tabs on linux.sky@chromium.org2009-10-137-37/+77
| | | | | | | | | | | | BUG=2935 TEST=Create two tabs, press control-shift-d. You should be presented with a dialog that lets you give a name to a folder. Change the name, press enter and make sure you get a bookmark folder populated with the urls of any open tabs. Review URL: http://codereview.chromium.org/268038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28788 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code to reset cursor on leave. We need to do this or cursor cansky@chromium.org2009-10-132-0/+9
| | | | | | | | | | | get stuck. BUG=none TEST=none Review URL: http://codereview.chromium.org/274008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28787 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetLinuxDistro thread-safe.thestig@chromium.org2009-10-131-8/+61
| | | | | | | | BUG=24659 TEST=none Review URL: http://codereview.chromium.org/273026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28785 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete source excludes in base/gfx. The files have been moved to ↵thestig@chromium.org2009-10-131-6/+0
| | | | | | | | | | app/gfx/ BUG=none TEST=none Review URL: http://codereview.chromium.org/273030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28784 0039d316-1c4b-4281-b951-d872f2087c98
* Remove typos for gtk_native_view_id_manager in app.gyp. Make complains: ↵thestig@chromium.org2009-10-131-2/+0
| | | | | | | | | | Circular out/Debug/obj/app/gfx/gtk_native_view_id_manager.o <- out/Debug/obj/app/libapp_base.a dependency dropped. BUG=none TEST=Make no longer complains about circular dependencies in app/gfx. Review URL: http://codereview.chromium.org/267068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28783 0039d316-1c4b-4281-b951-d872f2087c98
* Spawn the pepper WebPluginDelegateImpl when a MIME type begins with "pepper-".brettw@chromium.org2009-10-131-0/+9
| | | | | | | | | | | This is a temporary hack for testing. I wrapped it in USE_PEPPER_PLUGINS ifdef, what ifdef are you using in real life? BUG=none TEST=none Review URL: http://codereview.chromium.org/271047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28782 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS build.evan@chromium.org2009-10-131-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28781 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the IcognitoDownload as flaky because it keepsnsylvain@chromium.org2009-10-131-1/+2
| | | | | | | | | failing on mac. BUG:24684 Review URL: http://codereview.chromium.org/266059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28780 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASCII strings for switch names.evan@chromium.org2009-10-1369-652/+679
| | | | | | Review URL: http://codereview.chromium.org/270062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 08:36:23 +0000