| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=sgk
Review URL: http://codereview.chromium.org/11309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
process windows messages broke FTP. This fixes it to work using PostTask.
R=rvargas
Review URL: http://codereview.chromium.org/11502
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies code as we don't need to listen for events on input elements, the editor client API is only triggered when the text changes.
The only quirk we have to work around is that when the editor client API notifies us that the text has changed, the selection is not set properly, preventing us from reliably finding out if the caret is at the end of the text.
To work around that issue, we post a task that does the autofill after the text change callback.
BUG=None
TEST=Trigger the autofill behavior with form and passwords.
Review URL: http://codereview.chromium.org/11479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build\*.scons structure (mirroring build\*.vsprops files):
* Use env.ApplySConscript() instead of env.SConscript with a
hand-crafted dictionary defining 'env'.
* Move various CPPPATH, CCFLAGS, CPPDEFINES, LIBS and LIBPATH
definitions from build/SConscript.main and target-specific
*.scons files into the build\*.scons files that mirror the
existing build\*.vsprops hierarchy.
* Use the new build\{debug,release}.scons files to update the
windows_dbg and windows_opt construction environments.
* Mirror current support for CHROME_BUILD_TYPE and CHROMIUM_BUILD
external environment variables.
* Remove hard-coded /TP options.
* Massage $CXXFLAGS to remove $CCFLAGS, avoiding duplication of options
on command lines. Handle the ripple effect in $PCHCOM by adding
$CCFLAGS back to that command line.
* Delete hammer's default settings of {CC,LINK}FLAGS_{DEBUG,OPTIMIZED}
so they don't pollute our construction environments.
* Update chrome config to link against v8 for opt, v8_g for dbg.
* Get rid of fragile by-hand order of using_net.scons before other
using_*.scons files. We're now using --start-group and --end-group
on Linux to deal with dependency cycles in libraries.
Review URL: http://codereview.chromium.org/11478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around.
Review URL: http://codereview.chromium.org/11506
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that state would create a crasher.
It is ok to have -1 as the selection index, which means no selection.
BUG=4573
TEST=In a form text field enter some text so the autofill popup shows up, press enter. The popup should disappear with no crasher.
Review URL: http://codereview.chromium.org/11297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
developers can use the .coverage files inside their Visual Studio Team Tools. Also misc bug fixes.
Review URL: http://codereview.chromium.org/11497
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
std::string. This means we can point directly into the resource in the
binary, instead of copying. This makes sense for the TLD data, which doesn't
need to be copied around."
This reverts commit r5735.
TBR=deanm
Review URL: http://codereview.chromium.org/11298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around.
Review URL: http://codereview.chromium.org/11296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test_shell_win.cc.
The sln change is to make test_shell_tests depend on breakpad.
Review URL: http://codereview.chromium.org/11288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab strip contains the tab but the model is closing all. Normally the
end of the animation removes the tab, but if we're closing all tabs
the animation isn't run. I was hitting this when I have more than one
window open and drag a tab in a window with a single tab and release
it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/11294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/12002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fix of issue 11437.
Review URL: http://codereview.chromium.org/11293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
resource provider system to return direct pointers into the resources instead of copying.
Review URL: http://codereview.chromium.org/11501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in accessibility tests.
Review URL: http://codereview.chromium.org/11292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
nice and not create these keys on every Chrome start just in case user wants a customized open with list. So now we only create these keys at installation or when user choses to make Chrome default browser. Also we clean them up on uninstall.
BUG=1190855
Review URL: http://codereview.chromium.org/11491
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11437
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sequence ContainerWin remains on the stack while the modal dialog is
showing. Prior to this fix we would delete the ContainerWin, so that
when the modal dialog closed control would return to a deleted
object. The fix is to effectively delay deleting of the ConatinerWins
used by menus.
BUG=4580
TEST=This is the sequence that triggered the crash: open a folder on
the bookmark bar, right child on a child folder that has more than 15
descendant URLs, click open all, a dialog should appear asking if you
really want to open all, click cancel and make sure it doesn't crash.
This is a subtle change to bookmark menus though, would be good to
thoroughly exercise the menus in as many permutations as you can
think of.
Review URL: http://codereview.chromium.org/11289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Now with two improvements:
- no longer create WebContentsViews as WS_VISIBLE, to prevent them from showing up in the taskbar
- make sure overridden CreateView in NativeUIContents and StatusView have the correct signature.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensive so I decided to just check it in.
Changes:
- Use Return() instead of Export() from SConscript.inputs to pass 'env' back.
- Move some of the build vars around to fix builders that aren't in
SConscript.browser.
- Refactor SConscript.installers so that we now have DirBuilder, a generic
builder that creates a directory tree (used to be FF-specific). This will be
used for OSX bundles.
Review URL: http://codereview.chromium.org/11261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This means we can stop debugging failed tests that also fail on Windows.
Review URL: http://codereview.chromium.org/11500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the sort_sln.py script.
TBR=brettw
Review URL: http://codereview.chromium.org/11291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11498
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Linux (and mac?).
Review URL: http://codereview.chromium.org/11287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This was lost by Brett's move this morning.
Review URL: http://codereview.chromium.org/11605
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Append doesn't mutate so take the result of it.
TBR=evan
Review URL: http://codereview.chromium.org/11493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes the Layout Tests instructions work on Linux:
http://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-tests
Review URL: http://codereview.chromium.org/11490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a threading issue in PluginInstance.
PluginThreadAsyncCall is supposed to provide a thread safe way of
enqueing a callback onto the plugin thread. Currently, it unsafely
adds a reference to the PluginInstance when the callback is enqueued.
This patch converts PluginInstance from RefCounted to
RefCountedThreadSafe.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
detect address space collisions where chrome.dll is needing to be rebased, and it will help us choose a better base address.
Review URL: http://codereview.chromium.org/6540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, many layout tests involving text match render trees
exactly. By turning off anti-aliasing we also almost match pixel
exact. There are a couple of single-pixel differences between Win32 font
rendering and FreeType however (see the bottom left pixel of an 'a'
glyph for example), so we aren't quite pixel-for-pixel yet.
Mike Reed expects to redo much of the font configuration code in Skia to
cope with complex text and subpixel text so, for now, I'm not going to
have anti-aliasing be a command line flag etc.
Review URL: http://codereview.chromium.org/11284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Otherwise we fall back to Mac results, which aren't what we are going to
be aiming for.
Review URL: http://codereview.chromium.org/11254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We need to trim whitespace off the URL and handle the
tricky html case by using rfind.
Review URL: http://codereview.chromium.org/11465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
javascript from setting a new httponly cookie, and more importantly from overwriting httponly cookies.
Patch from Marius Schilder.
Review URL: http://codereview.chromium.org/11275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add the bitmap platform device file to the scons and revert a reversion
introduced in the move.
Review URL: http://codereview.chromium.org/11484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5697 0039d316-1c4b-4281-b951-d872f2087c98
|