summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Coverity: Initialize profile_ and process_images_ in the constructor.jhawkins@chromium.org2009-09-282-3/+4
| | | | | | | | | CID=3971 BUG=none TEST=none Review URL: http://codereview.chromium.org/219014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27396 0039d316-1c4b-4281-b951-d872f2087c98
* Move cairo font handling from printing to skia to avoid circular dependency.mmoss@chromium.org2009-09-284-146/+150
| | | | | | | | | http://crbug.com/22792 Review URL: http://codereview.chromium.org/245027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27395 0039d316-1c4b-4281-b951-d872f2087c98
* Add columns to gtk task manager.thakis@chromium.org2009-09-281-1/+51
| | | | | | | | | BUG=16221 TEST=Open task man, right-click dialog, enable new columns (image size, script size, css size), surf around. Review URL: http://codereview.chromium.org/245018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27394 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing chrome.i18n.getMessage call, that loads message from the ↵cira@chromium.org2009-09-2824-32/+515
| | | | | | | | | | | | | | | | | | | extension catalog, and if necessary replaces placeholders (up to 9). I have 3 forms of getMessage call: getMessage("name") for simple messages without placeholders. getMessage("name", "one param") for messages with only one placeholder. getMessage("name", ["one", "two"]) for messages with only one or more placeholders. getMessage returns string. BUG=12131 TEST=Load samples/i18n extension (switch Chrome to sr locale) and observe ext. name, description and toolstrip texts should be in Serbian. Review URL: http://codereview.chromium.org/225009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27393 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize message_loop_ in the constructor.jhawkins@chromium.org2009-09-281-1/+2
| | | | | | | | | CID=1505 BUG=none TEST=none Review URL: http://codereview.chromium.org/219036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27392 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in drop arrow. Specifically window properties weresky@chromium.org2009-09-281-3/+3
| | | | | | | | | | | being set after Init, which does no good. BUG=23180 TEST=see bug Review URL: http://codereview.chromium.org/251019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27391 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize message_response_timeout_ in the constructor.jhawkins@chromium.org2009-09-281-0/+1
| | | | | | | | | CID=1504 BUG=none TEST=none Review URL: http://codereview.chromium.org/223028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27390 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27379, in hopes of fixing browser_tests.senorblanco@chromium.org2009-09-2827-106/+122
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add note to about:memoy re missing renderers.agl@chromium.org2009-09-281-1/+1
| | | | | | | | | | | | | | | | | | On Linux, we cannot gets at the 'maps' nor 'smaps' files for our renderers when they are sandboxed (because they are non-dumpable). One could imaging plumbing IPC calls to the renderers for this information, but it would be a lot of code for little gain. In the mean time we should at least explain why all the renderers might be missing. (This is an issue with the SUID sandbox. The seccomp sandbox would be ok.) BUG=23258 http://codereview.chromium.org/235008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27388 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix take 2.agl@chromium.org2009-09-281-0/+2
| | | | | | | (We don't have try servers for ChromeOS yet.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27385 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "gtk implemenation of Scrollbar."agl@chromium.org2009-09-286-472/+49
| | | | | | | This reverts commit 27381 (build break). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27384 0039d316-1c4b-4281-b951-d872f2087c98
* Make the invisible items in the system menu of a few Indian language ↵jshin@chromium.org2009-09-281-1/+2
| | | | | | | | | | | | | | | | versions of Chrome. |owner_drawn| is currently set if the UI font family or the UI font size is overriden. However, this leads menu items to be invisible in the system menu. This was not the case in Chrome 2.0, but somehow the way 'owner_drawn' menu is drawn has changed and we have this regression. As a work around for the branch (3.0 train left, but we can merge this to 3.0.1), this CL sets |owner_drawn| to false for the system menu even if the UI font or the UI font size is overriden. BUG=18042 (http://crbug.com/18042 ) TEST=Run Chrome with '--lang=hi' command line flag on Windows. Make sure that the translated menu items in the system menu are visible (e.g. 'New Tab', 'Task Manager') although a bit too small to read while the font size in the page/wrench menu is reasonably large. Review URL: http://codereview.chromium.org/200123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27382 0039d316-1c4b-4281-b951-d872f2087c98
* gtk implemenation of Scrollbar.oshima@chromium.org2009-09-286-49/+472
| | | | | | | | | | | enabled ScrollView on linux. BUG=none TEST=none Review URL: http://codereview.chromium.org/222030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27381 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: ChromeOS is using a more recent compiler.agl@chromium.org2009-09-281-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27380 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that thread-safe reference counting is used withdarin@chromium.org2009-09-2827-122/+106
| | | | | | | | | | | | | | | | | | | | | | | | cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits<T> to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted<T> and RefCountedThreadSafe<T>. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Sheets should be positioned between the content and everything above it.erg@chromium.org2009-09-281-2/+5
| | | | | | | | BUG=17615 Review URL: http://codereview.chromium.org/219032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27378 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: create the directory for the desktop file in the wrapper script if it ↵mdm@chromium.org2009-09-281-0/+1
| | | | | | | | | | | does not exist. BUG=none TEST=none Review URL: http://codereview.chromium.org/244018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27377 0039d316-1c4b-4281-b951-d872f2087c98
* Remove failing expectations for tests, fixed in ↵dglazkov@chromium.org2009-09-281-4/+0
| | | | | | | | | | | | http://trac.webkit.org/changeset/48759. TBR=abarth TEST=none BUG=17523 Review URL: http://codereview.chromium.org/249019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27376 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove --google-internal-crash-reporting.agl@chromium.org2009-09-287-269/+3
| | | | | | | | | It's time to kill this. It's been marginally useful, but only marginally. http://codereview.chromium.org/222021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27375 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out the condition (b == vmax), since it will always be true at this ↵jhawkins@chromium.org2009-09-281-1/+3
| | | | | | | | | | point in the code. BUG=none TEST=none Review URL: http://codereview.chromium.org/243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27374 0039d316-1c4b-4281-b951-d872f2087c98
* A couple fixes to layout test scripts:jianli@chromium.org2009-09-283-4/+8
| | | | | | | | | | | | | | | | 1) Fix division by zero if running only 1 WONTFIX test. 2) Do not add to the missing list if a test missing the result is marked as WONTFIX. Also update the test_expectation list: 1) Remove SKIP for one test so that we can rebaseline it later. 2) Remove a qt test that was skipped previously because its missing result. BUG=none TEST=non Review URL: http://codereview.chromium.org/246013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27373 0039d316-1c4b-4281-b951-d872f2087c98
* Be defensive against 0-sized custom cursors. This may fix a moderately commoncevans@chromium.org2009-09-282-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | browser crash that triggers ~100 times a day: `anonymous namespace'::PureCall() _invalid_parameter_noinfo std::vector<unsigned char,std::allocator<unsigned char> >::operator[](unsigned int) WebCursor::GetCursor(HINSTANCE__ *) RenderWidgetHostViewWin::UpdateCursorIfOverSelf() RenderWidgetHostViewWin::UpdateCursor(WebCursor const &) I was unable to reproduce myself, so I don't know if the bad cursor came from the web or from the Windows "external cursor" concept. Accordingly: - Do not accept 0-sized cursors from the renderer. - Do not access array[0] on an empty array as per other call sites in the cursor code. Thanks to The Mighty Hoppy for triggering this via means unknown! BUG=NONE TEST=NONE (unable to reproduce) Review URL: http://codereview.chromium.org/251008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27372 0039d316-1c4b-4281-b951-d872f2087c98
* Added an accelerator to the HtmlDialogView class so that hitting the ESC key ↵tim@chromium.org2009-09-283-0/+14
| | | | | | | | | | | | | closes the dialog. BUG=19786 TEST=Open Sync Bookmaeks Login dialog. Enter credentials, TAB between fields, etc. to ensure nothing is broken. Hit the ESC key to dismiss the dialog. Patch by Randy Posynick (http://codereview.chromium.org/199069) Review URL: http://codereview.chromium.org/246020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27371 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS.erg@google.com2009-09-282-12/+34
| | | | | | | | | | GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors. BUG=23031 Review URL: http://codereview.chromium.org/248006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27368 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up after the initial Chrome Frame commit.robertshield@chromium.org2009-09-288-28/+153
| | | | | | Review URL: http://codereview.chromium.org/242025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27367 0039d316-1c4b-4281-b951-d872f2087c98
* Don't instrument NSS for ThreadSanitizertimurrrr@chromium.org2009-09-281-0/+5
| | | | | | | | Currently, RSAPrivateKeyUnitTest.InitRandomTest takes too long to pass. We ignore istrumentation of NSS to speed up the tests that use it. Review URL: http://codereview.chromium.org/242032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27366 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds the facility of providing Linux- andtimurrrr@chromium.org2009-09-282-3/+23
| | | | | | | | | | | | | | | Darwin-specific ignore files to ThreadSanitizer. This is necessary because ThreadSanitizer cannot handle the dSYM files properly and the "src:*" ignore rules don't work on Mac. The ignores_mac file contains the rules that make ThreadSanitizer ignore the false positives reported on base::subtle::{NoBarrier_Load, Release_Store} This patch was prepared by Alexander Potapenko (cc'ed) Review URL: http://codereview.chromium.org/251017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27365 0039d316-1c4b-4281-b951-d872f2087c98
* When the results.json file is not locally available, grab itojan@chromium.org2009-09-282-41/+75
| | | | | | | | | | | off the appropriate archive directory. This allows us to not lose the layout tests results history one one of the bots is clobbered. A small change is needed to the buildbots to pass in the --build-name flag before we'll be able to actually grab the results of archive location. Review URL: http://codereview.chromium.org/246014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27364 0039d316-1c4b-4281-b951-d872f2087c98
* Make dumpBackForwardList() print file and data URL results that match upstream.dglazkov@chromium.org2009-09-282-7/+27
| | | | | | | | | | R=darin TEST=LayoutTests/fast/loader/* BUG=8407 Review URL: http://codereview.chromium.org/243011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27363 0039d316-1c4b-4281-b951-d872f2087c98
* Add two more transition-end-event flaky layout testsnsylvain@chromium.org2009-09-281-0/+2
| | | | | | | | | | to the list. BUG:9798 Review URL: http://codereview.chromium.org/248018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27360 0039d316-1c4b-4281-b951-d872f2087c98
* Update the context menus to support title case.thomasvl@chromium.org2009-09-281-162/+340
| | | | | | | | | | | Fix one "fullscreen" to be "full screen" to match all other uses (not yet used, so no translation issue for windows) Fix two new strings that were in Title Case instead of Sentence case. BUG=22257 TEST=the context menus on different types of web content should be title case on mac/linux but sentence case on windows. These are new strings, so they won't exist in other languages yet. Review URL: http://codereview.chromium.org/244004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27359 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind keeps complaining about:nsylvain@chromium.org2009-09-281-14/+1
| | | | | | | | | | | | | ==25902== </valgrindoutput> ==25902== FATAL: in suppressions file "/b/slave/chromium-rel-linux-valgrind-tests-1/build/src/tools/valgrind/memcheck/suppressions.txt" near line 1081: ==25902== too many callers in stack trace ==25902== exiting now. So, i'm making the stack trace smaller. Review URL: http://codereview.chromium.org/244020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27358 0039d316-1c4b-4281-b951-d872f2087c98
* getting example_views to compile is too much work for now. I'm disabling itnsylvain@chromium.org2009-09-281-36/+40
| | | | | | | | | | for windows. Please don't commit code that does not compile. Review URL: http://codereview.chromium.org/244019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27357 0039d316-1c4b-4281-b951-d872f2087c98
* views_example depends on views.nsylvain@chromium.org2009-09-271-0/+1
| | | | | | Review URL: http://codereview.chromium.org/242030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27356 0039d316-1c4b-4281-b951-d872f2087c98
* more missing dependencies (caused by bad dependencies somewhere else)nsylvain@chromium.org2009-09-271-0/+7
| | | | | | Review URL: http://codereview.chromium.org/242029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27355 0039d316-1c4b-4281-b951-d872f2087c98
* Another case where we need to allow "this" in the constructor.nsylvain@chromium.org2009-09-271-4/+9
| | | | | | Review URL: http://codereview.chromium.org/248016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27354 0039d316-1c4b-4281-b951-d872f2087c98
* Don't assume that we build from the src/chrome folder.nsylvain@chromium.org2009-09-271-1/+1
| | | | | | | | | This is still not perfect, but all least it should work for all the use cases we currently have. Review URL: http://codereview.chromium.org/254001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27353 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakage by disabling a warning.nsylvain@chromium.org2009-09-272-4/+10
| | | | | | | | tbr:oshima@chromium.org Review URL: http://codereview.chromium.org/242028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27352 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing dependencies.nsylvain@chromium.org2009-09-271-0/+3
| | | | | | Review URL: http://codereview.chromium.org/235037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27351 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my last change to the known leaks to see ifnsylvain@chromium.org2009-09-271-60/+0
| | | | | | | | Tim's fix works. Review URL: http://codereview.chromium.org/246018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27346 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some purify leaks while Tim tries to fix them. (All from syncapi)nsylvain@chromium.org2009-09-271-0/+60
| | | | | | Review URL: http://codereview.chromium.org/245023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27345 0039d316-1c4b-4281-b951-d872f2087c98
* Balance call to CommandLine::Init in syncapi with call to ↵tim@chromium.org2009-09-271-0/+2
| | | | | | | | | | | | | CommandLine::Terminate. This should relieve the purify redness. TBR=nick TEST=ProfileSyncServiceTest, sync_unit_tests Review URL: http://codereview.chromium.org/243023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27344 0039d316-1c4b-4281-b951-d872f2087c98
* Disable LayoutTests/transitions/transition-end-event-window.html becausensylvain@chromium.org2009-09-271-0/+2
| | | | | | | | | | | | | | it fails too often on linux. Also disable LayoutTests/transitions/transition-end-event-left.htmt It looks like all the transition-end-event-* are flaky. BUG:9798 Review URL: http://codereview.chromium.org/248015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27343 0039d316-1c4b-4281-b951-d872f2087c98
* The comment above the ExtensionApiTest.Toolstrip says that it'snsylvain@chromium.org2009-09-271-1/+1
| | | | | | | | | | | disabled because of flakyness, but it's not disabled, and it's really flaky, so i'm disabling it for real. BUG:22668 Review URL: http://codereview.chromium.org/242027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27342 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AutocompleteEditViewTest.AltEnter and ↵nsylvain@chromium.org2009-09-271-2/+4
| | | | | | | | | | | | | AutocompleteEditViewTest.BrowserAccelerators because they started failing all the time. TBR:pkasting BUG:23213 Review URL: http://codereview.chromium.org/246017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27341 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.3 to 219.4laforge@chromium.org2009-09-271-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27340 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for new memory leak that appeared during the WebKit deps roll.levin@chromium.org2009-09-271-0/+31
| | | | | | | | | | TBR=senorblanco@chromium.org BUG=23197 TEST=None Review URL: http://codereview.chromium.org/243020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27338 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 48766:48796levin@chromium.org2009-09-272-1/+4
| | | | | | | | | | | | | Add failure for newly added test for me to investigate. TBR=senorblanco@chromium.org TEST=None BUG=None Review URL: http://codereview.chromium.org/242023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27337 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 48747:48766levin@chromium.org2009-09-273-2/+7
| | | | | | | | | | | | | | Rolling right up to the next breakage. Adding new breakages that I need to investigate. TBR=senorblanco@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/251006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27336 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded main.maruel@chromium.org2009-09-271-1/+0
| | | | | | | | TEST=none BUG=22926 Review URL: http://codereview.chromium.org/235033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27335 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-05 16:14:59 +0000