| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland Disallow chrome.tabs.executeScript from injecting code into gallery
TBR=aa
BUG=30146
TEST=browertest is pending: http://codereview.chromium.org/506066
Original review: http://codereview.chromium.org/501098/
Review URL: http://codereview.chromium.org/518005
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/515025
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check permissions for chrome.tabs.executeScript() in the renderer
Original Review: http://codereview.chromium.org/509032
TBR=aa
Review URL: http://codereview.chromium.org/515023
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=29538
TEST=Extensions with utf8 encoded names should appear correctly named in the context menu.
Review URL: http://codereview.chromium.org/520001
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/515020
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patched from 401007(see http://codereview.chromium.org/401007/) to commit. Reviewed by aa and darin.
R=aa,darin
Review URL: http://codereview.chromium.org/421005
TBR=tangjie@chromium.org
Review URL: http://codereview.chromium.org/518013
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't inject content scripts into incognito browsers
BUG=21392
original review: http://codereview.chromium.org/502079
Review URL: http://codereview.chromium.org/517007
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
truncated entries on the viewcache details page.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/502021
TBR=laforge@chromium.org
Review URL: http://codereview.chromium.org/508024
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a minor rendering issue on IE7. IE seemed to choking on (probably invalid) html where a <div> was a child of a <ul>
Review URL: http://codereview.chromium.org/506068
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/503073
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r34203 | evan@chromium.org | 2009-12-09 15:53:18 -0800 (Wed, 09 Dec 2009) | 5 lines
extensions: Properly use string16 for Unicode text.
BUG=29850
Review URL: http://codereview.chromium.org/477011
TBR=evan
Review URL: http://codereview.chromium.org/504076
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In ResolveProxy(), it expects requesting url is valid. If not, it will die
with DECHK, or freeze the browser.
Check the url before calling ResolveProxy and close the connection immediately.
Use url_ instead of proxy_url_, because proxy_url_ is not in 249 branch.
BUG=29932
TEST=open html with <script>ws = new WebSocket('ws://javascript:a');</script> and don't die nor freeze.
Review URL: http://codereview.chromium.org/505032
TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/505058
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Actions.
BUG=29538
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
TBR=laforge@chromium.org
Review URL: http://codereview.chromium.org/501136
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adapt Chrome to use KeystoneRegistration 1.0.7.1306. Use "tag path" and "tag
key" to direct Keystone to use a tag stored in the application as opposed to
in its ticket.
BUG=30730
TEST= - ksadmin --print-ticket --productid com.google.Chrome should show
tagPath pointing to GC.app/Contents/Info.plist, and
tagKey of KSChannelID;
- ksadmin --print-tag --productid com.google.Chrome should show the
value of the KSChannelID key in GC.app/Contents/Info.plist;
this should be the tag that is used for autoupdates
The above steps should be validated after the following operations:
- launching Chrome when on a user ticket,
- promoting Chrome from a user ticket to a system ticket, and
- when a Chrome update is applied (using this version of
keystone_install.sh) when on either a user or a system ticket.
The tagPath and tagKey will NOT be set when launching Chrome on a
system (promoted) ticket, but they WILL be set when the ticket is
initially promoted and also when an update is applied using this version
of keystone_install.sh.
Review URL: http://codereview.chromium.org/506061
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/505055
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actions and Page Actions.
BUG=29538
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
Review URL: http://codereview.chromium.org/486022
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/501085
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/501130
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
simple_menu_model.h was moved after we branched. It looks fixing the include should do the trick.
TBR=laforge
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501119
TBR=arv@chromium.org
Review URL: http://codereview.chromium.org/502082
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=laforge
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501121
TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/501129
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW has nonASCII characters.
BUG=30736
TEST=Open chrome with lang=sr and try to pack extension. It shouldn't crash, and files with be generated.
Review URL: http://codereview.chromium.org/503051
TBR=cira@chromium.org
Review URL: http://codereview.chromium.org/503061
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch exempts nontheme extensions (extensions not downloaded from theme minigallery) from showing the arrow download animation.
BUG=29632
TEST=Install extension from the gallery. No download arrow should be shown. Install theme from https://tools.google.com/chrome/intl/en/themes/index.html. Download arrow should be shown. Download random other stuff > download arrow should be shown.
Review URL: http://codereview.chromium.org/504031
TBR=rafaelw@chromium.org, aa@chromium.org
Review URL: http://codereview.chromium.org/504062
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=cira
Review URL: http://codereview.chromium.org/504061
TBR=kathyw@google.com
Review URL: http://codereview.chromium.org/502080
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@35000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly links, but a few embedded videos.
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/504054
TBR=kathyw@google.com
Review URL: http://codereview.chromium.org/506080
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=laforge
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501121
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
simple_menu_model.h was moved after we branched. It looks fixing the include should do the trick.
TBR=laforge
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/501119
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In ResolveProxy(), it expects requesting url is valid. If not, it will die with
DCHECK, or freeze the browser.
Check the url before calling ResolveProxy and close the connection immediately.
BUG=29932
TEST=open html with <script>ws = new WebSocket('ws://javascript:a');</script>
and don't die nor freeze.
Review URL: http://codereview.chromium.org/505032
TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/500087
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/502076
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r34925 | estade@chromium.org | 2009-12-17 18:39:47 -0800 (Thu, 17 Dec 2009) | 10 lines
gtk: Browser action dragging fixes
1) fix crasher triggered any time a drag from a different source hovers over the browser action bar.
2) fix graphical issue where changes to the ordering could possibly take a few seconds to propagate to other browser windows.
BUG=30639
TEST=a) drag a bookmark over the browser action toolbar, don't crash
b) open two windows. drag a browser action around, keep holding left mouse button and drag to a distant part of the screen, then rele
ase. The positional change should instantly take effect in the second browser window.
Review URL: http://codereview.chromium.org/506065
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/501117
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=29920
TEST=LayoutTests/http/tests/ssl
Review URL: http://codereview.chromium.org/502038
TBR=japhet@chromium.org
Review URL: http://codereview.chromium.org/501109
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
leak referrer information.
BUG=29920
TEST=URLRequestTestHTTP.HTTPSToHTTPRedirectNoRefererTest
Review URL: http://codereview.chromium.org/486015
TBR=japhet@chromium.org
Review URL: http://codereview.chromium.org/500129
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add link to Message Passing page.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/505044
TBR=kathyw@google.com
Review URL: http://codereview.chromium.org/500128
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/503014
TBR=kathyw@google.com
Review URL: http://codereview.chromium.org/507049
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/501062
TBR=kathyw@google.com
Review URL: http://codereview.chromium.org/503054
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally at http://codereview.chromium.org/485012.
This sample extension demonstrates using OAuth to connect to
Google's contacts service.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/505009
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/501105
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix sync dialog stop syncing dialog cutting off on XP in lang: ml.
BUG=27770, 29767, 29788, 29782, 29647, 29767
TEST=Automated run through sync dialog and stop dialog.
Review URL: http://codereview.chromium.org/500108
TBR=chron@google.com
Review URL: http://codereview.chromium.org/500122
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
downstream vendor name, etc.).
Also reformat the Mac/Win version strings as per comments in
http://codereview.chromium.org/506007.
Review URL: http://codereview.chromium.org/506016
TBR=mmoss@google.com
Review URL: http://codereview.chromium.org/502062
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
location.
Add channel info to about:version.
Linux about box work not done.
Linux channel determination code still a stub.
BUG=30444
How to verify:
on both Mac and Win, with a branded build:
confirm the About Box and about:version have channel info after the version number.
Channel for PC comes from the registry so it'll be the channel of your official install, not this build.
Channel for Mac comes from the Info.plist so it WILL be from the current version; stable if undefined.
Review URL: http://codereview.chromium.org/506007
TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/501095
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I guess I used the wrong diff.
TBR=eblake
Review URL: http://codereview.chromium.org/507041
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch changes the behavior of the LOADING dialog such that it is only shown for extension downloads from the minigallery (theme) url. Note that this means that themes from the chrome extensions gallery will also NOT have the dialog shown.
BUG=29628
TEST=Install an theme from https://tools.google.com/chrome/intl/pt/themes/index.html. The gray LOADING dialog should appear. Install extension or theme from chrome.google.com/extensions. No LOADING dialog should appear
Review URL: http://codereview.chromium.org/507016
TBR=rafaelw@chromium.org,aa@chromium.org
Review URL: http://codereview.chromium.org/505037
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Actions.
BUG=29538
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
Review URL: http://codereview.chromium.org/486022
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/501085
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In ResolveProxy(), it expects requesting url is valid. If not, it will die with
DCHECK, or freeze the browser.
Check the url before calling ResolveProxy and close the connection immediately.
BUG=29932
TEST=open html with <script>ws = new WebSocket('ws://javascript:a');</script>
and don't die nor freeze.
Review URL: http://codereview.chromium.org/505032
TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/500087
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default it to false. This should improve performance in
sites that use frames and elimiate confusion, since in most
cases developers *don't* expect content scripts to match
frames.
Review URL: http://codereview.chromium.org/412008
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------------------------------------------------------------------
r34513 | estade@chromium.org | 2009-12-14 15:34:45 -0800 (Mon, 14 Dec 2009) | 8 lines
Fix badge center-alignment logic.
This was initially fixed in r29152. It regressed in r30994.
BUG=27648
TEST=see bug
Review URL: http://codereview.chromium.org/506003
TBR=aa
Review URL: http://codereview.chromium.org/500080
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If javascript code puts custom toJSON functions on Array.prototype, our
extension API code detects malformed requests and kills the offending renderer.
Also, the browser can crash if a browser action popup process dies (for various
reasons, including this json serialization problem).
BUG=29283
TEST=Create an extension with a browser action popup that loads prototype.js, and then calls chrome.tabs.update().
Before this change, the popup bubble will crash, and when you click away, crash the browser too.
Review URL: http://codereview.chromium.org/466065
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/506044
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split extension renderer crashes out of the existing UMA renderer crash metric
into its own metric.
Add a new metric for the sum of all ChildProcessHost crashes.
Add histograms for each crash type.
BUG=28022
TEST=We should start getting more crash reports in UMA and histograms.
Review URL: http://codereview.chromium.org/468005
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/501064
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=select REGEXP('abc') from sqlite_master
BUG=30510
Review URL: http://codereview.chromium.org/501038
TBR=dumi@chromium.org
Review URL: http://codereview.chromium.org/502041
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enable multipage testing.
add totals.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/506021
TBR=mbelshe@google.com
Review URL: http://codereview.chromium.org/500064
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out that the extension API changed such that scripts don't run in pages
which are hosted in the extension process (like this one).
Switch from window.open to the chrome.tab.create() API.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/501036
TBR=mbelshe@google.com
Review URL: http://codereview.chromium.org/506036
git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34715 0039d316-1c4b-4281-b951-d872f2087c98
|