| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The combined IPC means that scrolling only requires one transport DIB instead
of two. Previously, we'd use one in the ScrollRect IPC to pass up the pixels
for the exposed region, and then we'd use a second one in the PaintRect IPC to
pass up the pixels for the updated scroll bar rendering. Now all paints are
done using a single transport DIB.
Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions.
This means calling GetUpdateRgn and GetRegionData to enumerate the list of
damage rects. Then only those rects are copied from the backing store.
The same optimization is not done for Linux or Mac yet.
R=brettw
BUG=29591
TEST=none
Originally reviewed at http://codereview.chromium.org/506013
Review URL: http://codereview.chromium.org/509005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The image view shows NSUser and is at y=72, so it's not visible. Looks like this was here since this file was first checked in. I can't imagine it serves an actual purpose.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/509004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It failed out of the blue here:
<http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP/builds/21055/steps/net_unittests/logs/stdio>
I'm tempted to pre-emptively mark the rest of URLRequestTestFTP flaky.
BUG=25045
TEST=more green, less red
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/509003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/509002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and corresponding strings from "Import Bookmarks & Settings" dialog since we none of the importers support importing cookies and likely won't in the future.
* Removed IDS_IMPORT_COOKIES string since it isn't used by any other part of the change.
* Modified nib to remove relevant checkbox and move the rest of the UI up to fill the space.
BUG=29125
Test=Open dialog in question, make sure "Import Cookies" option is no longer displayed and that profile import still works correctly.
Review URL: http://codereview.chromium.org/500066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
probably just too-smart zlib.
BUG=30667
TEST=green (Linux) valgrind
TBR=hamaji@chromium.org
Review URL: http://codereview.chromium.org/503069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See, e.g., failure here:
<http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(valgrind)(3)/builds/2168/steps/valgrind%20test%3A%20ui/logs/stdio>
BUG=30870
TEST=green (Linux) valgrind
TBR=slightlyoff@chromium.org, viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/501145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FlipFramer::DecompressFrame.
Probably it's just that zlib is smarter than us though.
BUG=30667
TEST=Linux valgrind test: net
TBR=hamaji@chromium.org
Review URL: http://codereview.chromium.org/505059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces code to properly enable DnD to the Omnibox without adding a
trivial |-updateDragTypeRegistration| to |AutocompleteTextFieldEditor| (so that
it falls through to the text field), but rather letting the field editor accept
DnD directly.
We'll see whether or not it turns Mac Perf(2) red (by regressing startup times).
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/500157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an experiment. I expect the startup times to regress and Mac Perf(2) to
turn red, at which point I'll revert this. If not, the TEST below applies.
[Yes, indeed, it turned red. Crazy!]
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
Review URL: http://codereview.chromium.org/500155
TBR=viettrungluu@chromium.org, shess@chromium.org
Review URL: http://codereview.chromium.org/502086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an experiment. I expect the startup times to regress and Mac Perf(2) to
turn red, at which point I'll revert this. If not, the TEST below applies.
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/500155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 481012 was: Mac: implement DnD of URLs onto Omnibox.
It was reverted due to a startup (perf) regression. The first half was re-committed at r35044. (Committing this at r35053, reverting at r35054, showed that this CL really does cause a regression.)
I don't know what causes this, so I'm committing it with the functionality turned off. So all that's changed is that some methods have been added and some protocols conformed to. If startup test times regress, something really weird is going on.
BUG=24631
TEST=Mac perf(2) doesn't turn red.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/508001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move the one existing test to final location
- Test more critical paths to be accessilbe and writable
- Test the OS version
- Test user or systemwide install type
BUG=27885
TEST=unit test updated
Review URL: http://codereview.chromium.org/504028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mac perf turns red.
Well, it turned red.
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/502084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
red.
CL 481012 was: Mac: implement DnD of URLs onto Omnibox.
It was reverted due to a startup (perf) regression. The first half was re-committed at r35044. I can't for the life of me reproduce the regression locally, so I'm re-committing and watching the bots.
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/500153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 481012 was: Mac: implement DnD of URLs onto Omnibox.
This is the half consisting of mild refactoring and no new functionality.
BUG=none
TEST=Dragging and dropping URLs onto the tab strip should still work as before. More important is whether this regresses the startup tests.
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/505057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
measurements on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/505056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implement DnD of URLs onto Omnibox.
(DnD of text coming in another patch.)
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
Review URL: http://codereview.chromium.org/481012
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/501135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by their upstream equivalents and I don't see any reason to keep them around.
BUG=9161
BUG=11251
TEST=chrome/fast/forms/basic-textareas.html
TEST=chrome/fast/forms/textarea-metrics.html
R=ojan@chromium.org
Review URL: http://codereview.chromium.org/500151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jparent
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/501134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mbelshe
BUG=None
TeST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=chrome/fast/encoding/Invalid-multi-byte-over-consumption.html
R=ojan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=mbelshe
TEST=None
Review URL: http://codereview.chromium.org/504069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
key" to direct Keystone to use a tag stored in the application as opposed to
in its ticket.
BUG=30730
TEST= - ksadmin --print-ticket --productid com.google.Chrome should show
tagPath pointing to GC.app/Contents/Info.plist, and
tagKey of KSChannelID;
- ksadmin --print-tag --productid com.google.Chrome should show the
value of the KSChannelID key in GC.app/Contents/Info.plist;
this should be the tag that is used for auto-updates
The above steps should be validated after the following operations:
- launching Chrome when on a user ticket,
- promoting Chrome from a user ticket to a system ticket, and
- when a Chrome update is applied (using this version of
keystone_install.sh) when on either a user or a system ticket.
The tagPath and tagKey will NOT be set when launching Chrome on a
system (promoted) ticket, but they WILL be set when the ticket is
initially promoted and also when an update is applied using this version
of keystone_install.sh.
Review URL: http://codereview.chromium.org/506061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=htp://crbug.com/30173
Review URL: http://codereview.chromium.org/504065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST= run the toast experiment and cancel it. Then look at the dr key on
HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463C-AFF1-A69D9E530F96}
should be "0"
BUG=30799
Review URL: http://codereview.chromium.org/502077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dank
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/505054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
On deletion, the model goes away before the actual table,
causing the table to access a deleted object.
This CL fixes it.
BUG=30791
TEST=Bring up the password dialog (in the options dialog, 'Personal Stuff', 'Show saved passwords').
Review URL: http://codereview.chromium.org/503063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jparent
BUG=30825
TEST=none
Review URL: http://codereview.chromium.org/500142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29710
TEST=none
Review URL: http://codereview.chromium.org/506069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
intermittently / are not reproducible locally.
TBR=dank
BUG=none
TEST=net_unittests goes green!
Review URL: http://codereview.chromium.org/504066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
instead of having it change to a tabbed browser. Original patch by David Garcia (see http://codereview.chromium.org/505013 ), r=me, tweaked.
BUG=20529
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
better support for x64 on Windows
TEST=none
BUG=29467
Review URL: http://codereview.chromium.org/501127
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/500149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run sync_unit_tests in a release build.
Review URL: http://codereview.chromium.org/500147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The intent is to allow unit-tests that use render view
to override ChildThread::CreateBridge() to provide their
own resource loading.
This is used by the upcoming translate unit-test.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/503032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30749
TEST=this patch
Review URL: http://codereview.chromium.org/507054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for x64 on Windows
TEST=none
BUG=29467
Review URL: http://codereview.chromium.org/501127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/501092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test that changed upstream.
TEST=try servers
BUG=30816,29737
Review URL: http://codereview.chromium.org/500145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Check that connecting again after having disconnected works.
* Check that trying to connect with a very large hostname fails.
Also removes some unused code from socks_client_socket.cc.
BUG=NONE
Review URL: http://codereview.chromium.org/501112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- No longer create 2 infobars.
- No longer leak infobars. This fixes a crash.
- Update the disabled list before sending the notification, so that the
extension management page updates properly.
BUG=30407
Review URL: http://codereview.chromium.org/501104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't have a limit on the number of console messages we hold in memory.
Until we can get this bug fixed in WebKit, I'm removing the console.log
statements.
BUG=29919
Review URL: http://codereview.chromium.org/502081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(DnD of text coming in another patch.)
BUG=24631
TEST=Select a URL/link/file from somewhere (a link in a browser, a URL in text, a file from the desktop, etc.) and drag it to the Omnibox in a Chromium browser window; the contents of the Omnibox should be selected to indicate that a drop would replace its contents; dropping should navigate to the appropriate location.
Review URL: http://codereview.chromium.org/481012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=cira
Review URL: http://codereview.chromium.org/501123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
way the automation
launch parameters are propagated to the ChromeFrameAutomationClient object.
I also fixed the ChromeFrame automation mock tests which don't use gmock and instead relied
on an incorrect behavior in ChromeFrame where we would deny the navigation from the automation
client and still navigate in Chrome when the external tab is created.
Will work on changing these tests to gmock in a subsequent CL.
TBR=stoyan and thanks to him for helping debug the gmock failures.
Review URL: http://codereview.chromium.org/500143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=cira
Review URL: http://codereview.chromium.org/504061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run sync_unit_tests
Review URL: http://codereview.chromium.org/500114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34993 0039d316-1c4b-4281-b951-d872f2087c98
|