summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Change URLRequest to use a ref-counted buffer for actual IO.The ref-counting ↵rvargas@google.com2009-01-2470-231/+408
| | | | | | | | will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325 Review URL: http://codereview.chromium.org/18390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8603 0039d316-1c4b-4281-b951-d872f2087c98
* update list after mergetc@google.com2009-01-241-0/+20
| | | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/18573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8602 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of webkit merge to r40164.tc@google.com2009-01-247-17/+66
| | | | | | | | One file added between r40124 and r40164, however, all the worker files didn't seem to be in the xcode project so I added all of them. Review URL: http://codereview.chromium.org/18733 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8601 0039d316-1c4b-4281-b951-d872f2087c98
* Load plugin metadata (mime types, etc.) on Linux.evan@chromium.org2009-01-243-32/+64
| | | | | | | | | Verified to work with at least Flash 10. Review URL: http://codereview.chromium.org/18571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8600 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of CertStore on shutdown.sky@google.com2009-01-233-22/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18568 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8599 0039d316-1c4b-4281-b951-d872f2087c98
* Pull toolbar importer from trunk.brg@chromium.com2009-01-236-1251/+0
| | | | | | | This change was requested by personalization. Review URL: http://codereview.chromium.org/18550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8598 0039d316-1c4b-4281-b951-d872f2087c98
* Update the tests_fixable list for more tests passing on Linux.jhawkins@chromium.org2009-01-231-4/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8596 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing file from last checkin.brettw@chromium.org2009-01-231-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8595 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out the backing store from the RenderWidgetHost into its own file tobrettw@chromium.org2009-01-238-366/+505
| | | | | | | | | | | | | make porting easier. I also did some cleanup in the scrolling and painting areas, collapsing the confusing ScrollRect call inside OnMsgScrollRect to just be inside the function and call a new function on the backing store to scroll it. Same for painting. This also moves plugin window moving to the view. Review URL: http://codereview.chromium.org/18702 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8594 0039d316-1c4b-4281-b951-d872f2087c98
* ===================================================xji@chromium.org2009-01-2314-37/+173
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change list fixes the following 2 chrome bugs: 2821 RTL: Ellipsis appeared at right for RTL locales on "Task Manager - Google Chrome" dialog (http://crbug.com/2821) 6132: Strings in tables are displayed LTR when they should be RTL (http://crbug.com/6132) =================================================== Background: The above 2 bugs are related to Chrome task manager. Task manager is a TableView, which is a subclass of NativeControl. Currently, TableView window is created by using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, which is wrong. WS_EX_LAYOUTRTL | WS_EX_RTLREADING renders a RTL alignment but LTR reading order. Please see the following blog for detail: http://blogs.msdn.com/michkap/archive/2007/03/11/1857043.aspx We need to replace the above flag with WS_EX_LAYOUTRTL only. Consequently, we need to make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. For example, if the text in an URL, then the returned text should be explicitly marked as LTR text. Please note: there are several other places where we create RTL window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, such as AutoCompleteEditView (omnibox), MenuHostWindow, TextField (for example, text in bookmark dialog), and other NativeControl (including checkbox, combobox, native_button, radio_button, separator, tabbed_pane, and tree view). They all need to be fixed. And the following bug is filed for tracking. http://crbug.com/6573 =================================================== The fix is based on Idan's comments on bug 6132 1.create the table view with WS_EX_LAYOUTRTL (rather than WS_EX_LAYOUTRTL | WS_EX_RTLREADING) 2 Make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. If the text in an URL, then the returned text is explicitly marked as LTR text. Otherwise, the returned text is marked with LTR if it is RTL environment and there is no strong RTL character in the text. This is to avoid the wrong placement of (or wrong mirrored) ending-punctuation. =================================================== Since we have quite a few places creating window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING style. We decided to migrate to the right style step to step. This is the first step, and there is unnecessary function introduced by this change list. 1. I am using l10n_util::GetExtendedTooltipStyles() for the right style for now. And I marked a TODO there to obsolete this function name, replace with GetExtendedStyles eventually. (the l10n_util.h is no longer in the change list since I've checked it in with another CL). 2. I introduced native_control::GetAdditionalRTLStyle() which should replace GetAdditionalExStyle() eventually. =================================================== When wrapping text with LTR format in GetText(), ideally, we should parse the text to check whether this is a n URL or not (for example, a webpage title could be an URL, or user could add URL as search engine's name or keyword). I did not do that and only added a TODO there because I think that might be rare case and parsing the text might cause performance degradation. Review URL: http://codereview.chromium.org/18076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8593 0039d316-1c4b-4281-b951-d872f2087c98
* Six more layout tests in 'fast' folder.finnur@google.com2009-01-2317-33/+326
| | | | | | Review URL: http://codereview.chromium.org/18723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8591 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists to cleanup some rollbacks that happened by mistake in r8532.kuchhal@chromium.org2009-01-232-23/+9
| | | | | | Review URL: http://codereview.chromium.org/18730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8590 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Adjust the current experiment so that the cachervargas@google.com2009-01-231-15/+18
| | | | | | | | | | size is not limited by 1% of the disk space. Also, group four was limited by the mask so it was effectively the same as group 3. Review URL: http://codereview.chromium.org/18727 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8589 0039d316-1c4b-4281-b951-d872f2087c98
* Remove now-passing Linux layout tests from tests_fixable.jhawkins@chromium.org2009-01-231-32/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8588 0039d316-1c4b-4281-b951-d872f2087c98
* I'm relanding the UserDataManager leak fix. I didn't realize we hadsky@google.com2009-01-235-6/+9
| | | | | | | | | | | | | stubs for mac which needed to be updated too. This time I'll wait for the bots to finish compiling before committing. BUG=none TEST=none TBR=munjal Review URL: http://codereview.chromium.org/18566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8587 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome part of the Webkit related CL.jcampan@chromium.org2009-01-231-0/+1
| | | | | | Review URL: http://codereview.chromium.org/16815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8585 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts my user data manager change as it breaks the mac buildbot.sky@google.com2009-01-233-6/+4
| | | | | | | | | | BUG=none TEST=none TBR=munjal Review URL: http://codereview.chromium.org/18564 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8584 0039d316-1c4b-4281-b951-d872f2087c98
* Build image_diff tool on the Mac. Fix up a few other things that had becomemark@chromium.org2009-01-231-86/+269
| | | | | | | strange in chrome.xcodeproj. Review URL: http://codereview.chromium.org/18562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8583 0039d316-1c4b-4281-b951-d872f2087c98
* Install the npapi_test_plugin in the same way we did the layout_test one.evan@chromium.org2009-01-232-1/+7
| | | | | | | Review URL: http://codereview.chromium.org/18563 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8582 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of UserDataManager on shutdown.sky@google.com2009-01-233-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8581 0039d316-1c4b-4281-b951-d872f2087c98
* Adds switch to ui tests that enable dialogs in slave process. I'msky@google.com2009-01-231-3/+9
| | | | | | | | | | | adding this to make it easier to attach to a failing ui test. BUG=none TEST=none Review URL: http://codereview.chromium.org/18725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8580 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage by disabling testsben@chromium.org2009-01-231-12/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8579 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the safe browsing interstitial page support multiple unsafe ↵jcampan@chromium.org2009-01-2313-192/+662
| | | | | | | | | | | | | | | | | | | | | | | resources in one page. We had a bug when an interstitial was showing and another unsafe resource was detected. We would show another interstitial on top of the original one, causing the DontProceed method to be invoked several times. That would cause us to remove more than once an entry from the navigation controller and cause crashers. With this new CL, if an interstitial shows and a new resource is flagged as bad, the SafeBrowsingBlockingPage will queue that notification. If the user decides to proceed through the interstitial, we'll create another interstitial warning about all the unsafe resources we have received so far. This CL also contains a fix for a crasher that would happen when closing a tab with a safe browsing interstitial. BUG=5916,6207,6306 TEST=Test all actions in the interstitial you get when opening pages with the followin scenarios: - Main page is malware - Main page is fishing - Main page is OK contains resources (images,iframes...) which are malware - Main page is OK contains resources (images,iframes...) which are phishing - Main page is OK contains resources (images,iframes...) some of them phishing, some of then malware. Note that when there are more than one bad resource, it is normal to see a 1st interstitial, then another one listing all the other bad resources. (ex of malware site http://ianfette.org, phishing site http://cvisit.tripod.com) Review URL: http://codereview.chromium.org/18346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8578 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for generated .vcproj files:sgk@google.com2009-01-2314-59/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix minor stylistic inconsistencies in some .vcproj files: * /> tag termination: net\net_resources.vcproj * Add empty <ToolFiles>, <References> and <Globals> sections: net\net_resources.vcproj third_party\zlib\zlib.vcproj third_party\libpng\libpng.vcproj chrome\tools\test\image_diff\image_diff.vcproj * Remove .\ on file names where its use is inconsistent with the rest of the file names in the .vcproj: net\build\net.vcproj net\build\net_unittests.vcproj chrome\installer\util\util.vcproj * Add explicit RootNamespace attribute: chrome\test\automation\automation.vcproj testing\gtest.vcproj * Fix file order in four locales that don't match other locale .vcproj files: chrome\app\locales\da.vcproj chrome\app\locales\he.vcproj chrome\app\locales\zh-TW.vcproj chrome\app\locales\en-US.vcproj * Remove duplicate files from the list: chrome\browser\views\browser_views.vcproj (event_utils.[ch]) Review URL: http://codereview.chromium.org/18555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8577 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r8486, which updates the manifestaa@chromium.org2009-01-2314-227/+449
| | | | | | | | | | | | | | | | | | | | | | | parsing in the Extension class to also parse out user script details. The problem was that extension_protocols.cc appears to link OK if you don't refer to anything in it, but as soon as you try to use something defined in it, a bunch of other symbols it refers to turn up undefined. To avoid this problem in the future, I stopped compiling extensions_protocol.cc so that we would realize if we tried to use it. Also in this change, I absolutified paths in ExtensionsService before creating Extension instances. On Linux, the path that PathService was giving us was not absolute. Review URL: http://codereview.chromium.org/18704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8576 0039d316-1c4b-4281-b951-d872f2087c98
* Update test list to remove tests that are passing now and rebaseline one test.kuchhal@chromium.org2009-01-234-46/+47
| | | | | | | | | BUG=945322 Review URL: http://codereview.chromium.org/18721 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8575 0039d316-1c4b-4281-b951-d872f2087c98
* Keystone auto-update support for TestShellmark@chromium.org2009-01-235-5/+201
| | | | | | Review URL: http://codereview.chromium.org/18521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8574 0039d316-1c4b-4281-b951-d872f2087c98
* Importing pkg-dmg for all of your dmg packaging needs.mark@chromium.org2009-01-232-0/+1525
| | | | | | | Review URL: http://codereview.chromium.org/18521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8573 0039d316-1c4b-4281-b951-d872f2087c98
* Don't expose the go and star button views directly through the BrowserWindow ↵ben@chromium.org2009-01-2313-114/+102
| | | | | | | | interface (for porting). Review URL: http://codereview.chromium.org/18540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8572 0039d316-1c4b-4281-b951-d872f2087c98
* ui refresh from cole. make it look chromey and get the basic framework for ↵pinkerton@google.com2009-01-2321-446/+8067
| | | | | | | | the views we'll need. Review URL: http://codereview.chromium.org/18720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8571 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r8560 due to broken interactive_ui_testsmark@chromium.org2009-01-2311-70/+56
| | | | | | Review URL: http://codereview.chromium.org/18722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8570 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug when saving web pages that have a period in their title.paulg@google.com2009-01-234-5/+19
| | | | | | | | | | | | | | | | | | | | | | The save dialog code attempts to generate a file extension based on the suggested name provided to it, which in the case of saving a web page is the title. If that title contains a '.' character, it treats anything that follows as the file extension and appends it to the name the user selects. For example, saving a page with the title "Google Inc. - A search engine" and the user choosing the save name as "Google" will result in the saved file being named "Google. - A search engine.htm" when it should be "Google.htm". In the case of saving a web page, we can ignore trying to figure out the file extension since we already know it will be ".htm". BUG=6105 (http://crbug.com/6105) Review URL: http://codereview.chromium.org/18699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8569 0039d316-1c4b-4281-b951-d872f2087c98
* Project changes (automatic reordering by UUID).avi@chromium.org2009-01-231-4/+4
| | | | | | Review URL: http://codereview.chromium.org/18629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8568 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn eol-style to LF for merge scripts.tc@google.com2009-01-231-109/+109
| | | | | | | TBR=pamg Review URL: http://codereview.chromium.org/18557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8567 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8565.brettw@chromium.org2009-01-232-59/+32
| | | | | | Review URL: http://codereview.chromium.org/18718 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8566 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of unnecessary region code from spellcheck language/locale codessidchat@google.com2009-01-232-32/+59
| | | | | | | Issue=6329 Review URL: http://codereview.chromium.org/18694 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8565 0039d316-1c4b-4281-b951-d872f2087c98
* Move security style into the tab_contents directory. This is the last part ofbrettw@chromium.org2009-01-236-18/+11
| | | | | | | the "Tab Contents (old)" group! Review URL: http://codereview.chromium.org/18686 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8564 0039d316-1c4b-4281-b951-d872f2087c98
* Adds missing include in scoped_ole_initializer. Without this includesky@google.com2009-01-231-0/+2
| | | | | | | | | | | someone can't just include scoped_ole_initializer and have it work. BUG=none TEST=none Review URL: http://codereview.chromium.org/18536 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8563 0039d316-1c4b-4281-b951-d872f2087c98
* Adds call to unload plugins on shutdown.sky@google.com2009-01-231-1/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18715 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8562 0039d316-1c4b-4281-b951-d872f2087c98
* Add a PNGEncoder helper function that takes an SkBitmap,nick@chromium.org2009-01-237-29/+28
| | | | | | | | | | | | which is how PNGEncode is used almost everywhere. This should be strictly no functional change, except for the ImageFilterPeer::DataReady case, where we now take an SkAutoLockPixels where previously we did not. Review URL: http://codereview.chromium.org/18347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8561 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2009-01-2311-56/+70
| | | | | | Review URL: http://codereview.chromium.org/18446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8560 0039d316-1c4b-4281-b951-d872f2087c98
* When the server says "nosniff" but then doesn't give us a Content-Type we ↵abarth@chromium.org2009-01-231-1/+10
| | | | | | | | | | now treat the response as "text/plain". Before, we treated the response as a download. This behavior is (a) safer and (b) matches what we expect in IE8. R=darin Review URL: http://codereview.chromium.org/18549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8559 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore googlemac.maruel@chromium.org2009-01-230-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8558 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of shutdown event in BrowserProcess.sky@google.com2009-01-232-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8555 0039d316-1c4b-4281-b951-d872f2087c98
* Decrements FieldTrialList::constructor_count_ in the destructor. I'msky@google.com2009-01-233-10/+1
| | | | | | | | | | | | | going to run ui tests in process and call BrowserMain multiple times. That means FieldTrialList's constructor is run multiple times. Without this decrement, the constructor isn't happy. BUG=none TEST=none Review URL: http://codereview.chromium.org/18535 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8554 0039d316-1c4b-4281-b951-d872f2087c98
* More Mac test updatesthomasvl@chromium.org2009-01-231-15/+12
| | | | | | | | - mark a few flaky tests. - update for more things passing (webkit fixes) Review URL: http://codereview.chromium.org/18713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8553 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:eol-style native on media_player.vcproj,sgk@google.com2009-01-230-0/+0
| | | | | | | so it matches the other *.vcproj files. Review URL: http://codereview.chromium.org/18553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8552 0039d316-1c4b-4281-b951-d872f2087c98
* Support domain=IPADDR if it matches the url ip address exactly.deanm@chromium.org2009-01-232-2/+12
| | | | | | | | | | | This doesn't do anything special to handle ipv6, dotless ip address, etc. BUG=3699 Review URL: http://codereview.chromium.org/18657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8551 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for "Issue 6252: Regression: IME candidate window showing far ↵hbono@chromium.org2009-01-231-5/+2
| | | | | | | | | | | | away from the input box". This issue is caused by a recent WebKit merge that changes the behavior of the ScrollView::contentsToWindow() function. To fix this issue, this change uses the SelectionController::absoluteCaretBounds() function instead of calling the ScrollView::contentsToWindow() function. BUG=6252 Review URL: http://codereview.chromium.org/17638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8550 0039d316-1c4b-4281-b951-d872f2087c98
* Update test list again as these tests sometimes fails and sometimes timeout.kuchhal@chromium.org2009-01-231-7/+9
| | | | | | Review URL: http://codereview.chromium.org/18547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8549 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 07:33:16 +0000