| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
having the pass a flag. This will be used on the try bots.
BUG=96753
Review URL: http://codereview.chromium.org/7719007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
drags landing on the page switcher were unintentionally ignored (although the switching between pages worked)
BUG=96229
TEST=drag app onto page swticher. await switch. drop. Should add to current page.
Review URL: http://codereview.chromium.org/7959001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7904034
TBR=sadrul@chromium.org
Review URL: http://codereview.chromium.org/7978007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan@chromium.org
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7979010
TBR=sadrul@chromium.org
Review URL: http://codereview.chromium.org/7983020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7906015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=27840
TEST=extended applicable unit test.
Review URL: http://codereview.chromium.org/7971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan@chromium.org
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7979010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ToplevelWindow and moves it into the examples namespace.Moves examples::ToplevelWindow creation to the launcher panel (and out of the DesktopBackgroundView).aura_shell should now only be production code, examples and test cases can live in the examples directory and built with aura_shell_exe test harness.http://crbug.com/97264TEST=none
Review URL: http://codereview.chromium.org/7981010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7941007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. add tests.
2. change SelectWord() to use BreakIterator, so it works for Chinese and Complex script.
3. DELETE/ReplaceChar delete/replace a whole grapheme. ReplaceTextInternal should only replace one grapheme when there is no selection.
4. pointing to position outside of text returns HOME/END position.
5. based on Chrome Linux omnibox and gedit, given
"abc| def", double click should select " " instead of "abc". Change test expectation.
BUG=90426
TEST=compile with touchui=1 test omnibox. run views_unittests.NativeTextfieldViewsTest/TextfieldViewsModelTest
Review URL: http://codereview.chromium.org/7841056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/7904034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
move handle enumerator into common.
BUG=96488
TEST=N/A
Review URL: http://codereview.chromium.org/7888024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TestWebKitPlatformSupport::audioHardwareBufferSize()
BUG=none
TEST=none
TBR=kbr@google.com
Review URL: http://codereview.chromium.org/7983017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for consistency with the other resource wrappers and to support certain
patterns of use.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/7945002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is to make way for the new PPB_Fullscreen interface which will hopefully replace the old one at some point. This maintains backwards binary compat.
I renamed two things related to the broker because the file wasn't being included in the proxy properly, and we never noticed they were wrong.
This also fixes a crash in the test harness generating the list of tests, since there is no current test case for the DidChangeView call.
Review URL: http://codereview.chromium.org/7917019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=96722
TEST=none
Review URL: http://codereview.chromium.org/7983009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to the NPAPI docs, the "type" field of this structure
should always be the value NP_SetWindow.
https://developer.mozilla.org/en/NPSetWindowCallbackStruct
It appears things worked without setting it, but valgrind complains
about using uninitialized memory, and it shouldn't hurt to match the
API more carefully.
BUG=71170
Review URL: http://codereview.chromium.org/7977007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't need to #include these headers in our header, we can move them to the .cc file.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/7973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserProcessImpl
BUG=none
TEST=about:discards still shows a page listing open tabs
Review URL: http://codereview.chromium.org/7973001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AtExitManager instance.
The AtExitManager instance is initialized by the NetTestSuite class constructor. The dchecks fire
because the NotificationService constructor uses the lazy instance class which relies on the AtExitManager
instance being initialized.
The fix is to initialize the NotificationService instance after the NetTestSuite constructor has done its job.
BUG=none
TEST=chrome frame net tests should pass in debug builds.
TBR=jam
Review URL: http://codereview.chromium.org/7981011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Side-pinning allows a site to pin to a public key that is both offline and not
a CA public key (without owning an intermediate CA themselves).
We do this by supporting a superfluous certificate in the chain which contains
a P256 public key and ECDSA signature over the leaf SPKI.
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/7951005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http_network_transaction_unittest.
There were a number of EXPECT's which should have been ASSERT's, and also moved *_FALSE's to *_TRUE's for more consistency.
Review URL: http://codereview.chromium.org/7838034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make double sure that this bug isn't the result of an encoding issue.
BUG=94758
TEST=None
Review URL: http://codereview.chromium.org/7982001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of callers wishing to refer to "a bitfield composed of these values" to use an explicit type instead of "int". I find the resulting code to be noticeably clearer, and a similar change for another type exposed a bug where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too.
The constants are still defined using an enum, because due to how macros like EXPECT_EQ are implemented, converting to use the typedef requires either separating the constant declarations and definitions (reducing readability) or converting EXPECT_EQ(b, a) -> EXPECT_TRUE (a == b) in various places.
BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7823006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Convert to UTF16 with ASCIIToUTF16 when calling set_name().
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7982010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: http://codereview.chromium.org/7976010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
TEST=views_unittests --gtest_filter=TabbedPaneTest.*
Review URL: http://codereview.chromium.org/7934010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7945014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
expand suppression for bug 69934 whose stack has changed slightly.
TBR=thestig@chromium.org
BUG=42958,69934
TEST=none
Review URL: http://codereview.chromium.org/7976008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7982008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual- drag windows in aura_demo under linux
Review URL: http://codereview.chromium.org/7971005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove is_synced check in CanShowPromo.
Add support for additional question param max_group_number.
Fix a bug where group was reset everytime the promo resource was fetched.
Breakup UnpackPromoSignal to a number of smaller helper functions
for clarity, and so they can be individually unit-tested.
Put all the logic of whether to display a promo into CanShowPromo.
Get rid of unnecessary namespace PromoResourceServiceUtil.
Make IsBuildTargeted private.
Make GetChannel a private function in anonymous scope
to consolidate duplicated comments/code.
Delete unused web_resource_cache_.
BUG=93201
TEST=Only relevant change is removal of is_synced check in CanShowPromo.
Review URL: http://codereview.chromium.org/7655008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=82278
TEST=test passes bots.
Review URL: http://codereview.chromium.org/7891022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/7983008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content/common
Note that these classes still depend on PluginChannel and PluginThread, which
live in content/plugin. This will be fixed in a later change.
BUG=96703
Review URL: http://codereview.chromium.org/7979002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
MediaStreamManager.
Review URL: http://codereview.chromium.org/7462012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Keeps toplevel windows constrained in z-index between the desktop background (bottom-most) and the launcher (topmost).
- Renames WindowManager to EventFilter, and moves it to the parent Window... i.e. when a window receives a mouse event its parent's event filter will get the opportunity to process it before that window's delegate does.
- WindowManager's content was mostly specific to toplevel window movement, so this content moved to an EventFilter subclass called ToplevelEventFilter.
- Adds a name property to aura::Windows useful for debugging.
- Prevent Windows with no delegate from taking part in event processing.
- Initialize the Aura_Shell in DesktopWindow, provide a single exported method - aura_shell::InitDesktopWindow() - to initialize it from the exe main.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7970001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=oshima@chromium.org,ben@chromium.org
TBR=oshima@chromium.org,ben@chromium.org
Review URL: http://codereview.chromium.org/7982006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f7bd952378555875dc321bb072ab03c32cdf8e34.
BUG=None (internal bug)
TEST=1) ran unit_tests with and without touchui=1 2) manually done with the device.
Review URL: http://codereview.chromium.org/7932016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This const was only used in a couple of places which have been migrated to cr.isMac.
BUG=none
TEST=Verify that cmd-delete still removes selected item from Most Visited page on NTP.
Review URL: http://codereview.chromium.org/7968002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/7934007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=thestig@chromium.org
BUG=42958
TEST=none
Review URL: http://codereview.chromium.org/7981003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20615
TEST=Manual: user images in Prefences->Personal Stuff->Change Picture and OOBE should have white background and a thin blue-gradient border.
Review URL: http://codereview.chromium.org/7980007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
after http://crrev.com/101826.
BUG=87335
TEST=chrome/tools/extract_actions.py works
Review URL: http://codereview.chromium.org/7971010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
threshold of text size.
BUG=none
TEST=none
R=cmp@chromium.org
TBR=cmp@chromium.org
Review URL: http://codereview.chromium.org/7980009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
plain lable text.
BUG=97047
TEST=adml_writer_unittests.py
Review URL: http://codereview.chromium.org/7935014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also cleans up the code a little bit.
BUG=28291
Review URL: http://codereview.chromium.org/7951009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=95066
TEST=None
Review URL: http://codereview.chromium.org/7825009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7937001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the EULA page look a bit closer to the mock and
converts the usage-stats-permission text into a clickable
label.
BUG=chromium-os:20166
TEST=manual: clicking the label toggles the checkbox
Review URL: http://codereview.chromium.org/7942009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101961 0039d316-1c4b-4281-b951-d872f2087c98
|